[fix][dev]Fingers of Frost, Aura 262

[gpadmin]

warrior still can use Charge in combat after talent reseting if Juggernaut was taken in previous talent build - it's a big exploit for dual spec patch users.

This is normal ?

2>Spell.cpp
2>..\\..\\src\\game\\Spell.cpp(4149) : warning C4806: '&' : unsafe operation: no value of type 'bool' promoted to type 'unsigned __int64' can equal the given constant

Have same error

[przemratajczak]

@ up

+    //Check Caster for combat
+ if(m_caster->isInCombat() && IsNonCombatSpell(m_spellInfo) && !m_caster->isIgnoreUnitState(m_spellInfo) 
+ && !m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_ROGUE_STEALTH && m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_ROGUE_VANISH) // Vanish hack
+        return SPELL_FAILED_AFFECTING_COMBAT;

there is typo probably, you cannot use !m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_ROGUE_STEALTHas bool. Pobably you meant

&& !(m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_ROGUE_STEALTH) && (m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_ROGUE_VANISH)  )

as to patch V6a Fingers of Frost is not procing from spells that has chilled effect as a proc spell (fo example Ice Armor) on MaNGOS 9088. I know it is kind of offtopic because aura262 effect is working fine ;-)

[bulek]

confirm but one problem with

 && !(m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_ROGUE_STEALTH) && (m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_ROGUE_VANISH)  )

[KAPATEJIb]

fingers of frost have a problem, it removes charges from non-mage spells, for example hand rocket from engineering

to fix it:

replace

if(!m_IsTriggeredSpell)

to

if(!m_IsTriggeredSpell && m_spellInfo->SpellFamilyName == SPELLFAMILY_MAGE)

[Oceanor]

warrior still can use Charge in combat after talent reseting if Juggernaut was taken in previous talent build - it's a big exploit for dual spec patch users.

try adding

SendInitialPacketsAfterAddToMap();

in void Player::ActivateSpec(uint8 spec) function, here:

//if (plrTalent != m_talents[m_activeSpec]->end())
           //    plrTalent->second->state = PLAYERSPELL_REMOVED;
       }
   }

   SendInitialPacketsAfterAddToMap();

   // set glyphs
   for (uint8 slot = 0; slot < MAX_GLYPH_SLOT_INDEX; ++slot)
   {
       // remove secondary glyph
       if(uint32 oldglyph = m_Glyphs[m_activeSpec][slot])
       {
           if(GlyphPropertiesEntry const *old_gp = sGlyphPropertiesStore.LookupEntry(oldglyph))
           {

this worked for me.

[bulek]

very good thank you :-)

[Morphau]

try adding

SendInitialPacketsAfterAddToMap();

in void Player::ActivateSpec(uint8 spec) function, here:

//if (plrTalent != m_talents[m_activeSpec]->end())
           //    plrTalent->second->state = PLAYERSPELL_REMOVED;
       }
   }

   SendInitialPacketsAfterAddToMap();

   // set glyphs
   for (uint8 slot = 0; slot < MAX_GLYPH_SLOT_INDEX; ++slot)
   {
       // remove secondary glyph
       if(uint32 oldglyph = m_Glyphs[m_activeSpec][slot])
       {
           if(GlyphPropertiesEntry const *old_gp = sGlyphPropertiesStore.LookupEntry(oldglyph))
           {

this worked for me.

Where you see this part of the code ?

[Morphau]

Bumps please

[fr00z]

This patch works only for 3.2.2a, do u have any clue what needs to be changed to work on 3.3.0.a ?

[dardennf]

This patch is awesome, but there are some problems.

First with Finger of Frost, when you cast a spell event if it's not a frost spell, like blink or fireblast it consumes one charge.

Then, Sudden death and Taste of blood are replaced each other.

[przemratajczak]

true, but this patch concern around implementing aura 262, should be cleand from other spell fixes/hacks and reviewed at last

[Raynar]

On my server with around 1200-1300 players online it works great! Congratulations.

[Nanihu]

Gives your Chill effects a 15% chance to grant you the Fingers of Frost effect, which treats your next 2 spells cast as if the target were Frozen. Lasts 15 sec.

Is bug

[Wojta]

Gives your Chill effects a 15% chance to grant you the Fingers of Frost effect, which treats your next 2 spells cast as if the target were Frozen. Lasts 15 sec.

Is bug

In spell tooltip? I dont see it.

[Raynar]

Yes, there is a bug. Fingers of frost must consume 2 charges...but now doesn't consume nothing.

[dardennf]

With the patch it consumes every spell ^^.

[xarly]

I have 3.2.2a, i'm testing this patch but when i talk with any innkeeper, server crash

My conf:

Mangos 9133 & SD2 1542

The last log line

2010-01-28 14:53:55 WORLD: Received CMSG_GOSSIP_HELLO

[Raynar]

With the patch it consumes every spell ^^.

What patch?

[dardennf]

Sorry I don't understand you, but the only problem with this patch is when you cast a spell, even if it's not a frost spell, like blink or fireblast it consumes one charge.

So it works but not properly.

[Ceris]

Sorry I don't understand you, but the only problem with this patch is when you cast a spell, even if it's not a frost spell, like blink or fireblast it consumes one charge.

So it works but not properly.

tooltip of spell:

Gives your Chill effects a 15% chance to grant you the Fingers of Frost effect, which treats your next 2 spells cast as if the target were Frozen. Lasts 15 sec.

tooltip of buff:

Your next 2 spells treat the target as if it were Frozen.

Where you have, that charges must be consumed only by frost spells?

Charges has been consumed only by frost spells on patch 2.4.3, not on patch 3.3.0.

[przemratajczak]

those should be only offensive spells. I was speaking with frien from offi so final target != caster. It could be general rule for this spell but AoE are breaking it (target = caster but results are impacting SPELL_AOE_TARGETS) so some unifying spell flag has to be found or DropCharge() has to be moved somwhere closer to DoAllEffectsOnTarget()

[xarly]

I have 3.2.2a, i'm testing this patch but when i talk with any innkeeper, server crash

My conf:

Mangos 9133 & SD2 1542

The last log line

2010-01-28 14:53:55 WORLD: Received CMSG_GOSSIP_HELLO

Is this patch compatible with my revision?

Thank you

[Raynar]

Yes it it, but you need apply manually.

[neorasAoT]

3.3.0

Fingers of Frost: This talent now triggers immediately on casting a spell rather than being delayed until the spell strikes the target.

duno if it was alrdy implemented (i play on 9433)

http://www.wowhead.com/?patchnotes=3.3.0

also charges should be consumed only by ofenside spells

[Toinan67]

Some news about this patch? I've patched my server with it on 9509, I have a core-stuck problem on Execute