[patch/dev] pet stats

[morderek]

the stamina seems to be ok but pet´s mana it´s not the correct.

The damage is also broken (hitting for 50-100)

[pasdVn]

Thx for feedback, but I need more details ;-)

• * which pet
  * level & stats
  * owner level + stats
  * dmg against what (or the pet menu values)?
  

[morderek]

OK, i only can test with warlock so i´ll only post information about warlock´s pets.

I´ll edit this post with the results

[plang]

........................

[morderek]

Warlock´s stats:

22500 hp

15564 mana

Pet's stats

Imp:

Hp: 13720

mana:2184

Damage:206

Voidwalker:

hp 15474

mana 3979

Damage: 64

Felhunter:

hp: 13695

mana: 4818

damage: 16

succubus:

hp 13220

mana: 3979

damage: 59 normal 239 with spell

felguard:

hp: 17500

mana 4800

damage 200-400

[reeshack]

Don't know if you checked wowwiki in the last weeks, but there has been some updates of the scaling coeficients for Wotlk (http://www.wowwiki.com/Hunter_pet#Pet_scaling, http://www.wowwiki.com/Minion#Minion_scaling, http://www.wowwiki.com/Risen_Ghoul#Stats_and_scaling, and maybe some other, I didn't search for them), hopefully it could help you .

To morderek: That was adressed mainly to the author of the thread (sorry for editing but I did not want to make a useless post about it)

[morderek]

i know, the worst problem is the pet damage.

[pasdVn]

Warlock´s stats:

22500 hp

15564 mana

Pet's stats

Imp:

Hp: 13720

mana:2184

Damage:206

Voidwalker:

hp 15474

mana 3979

Damage: 64

Felhunter:

hp: 13695

mana: 4818

damage: 16

succubus:

hp 13220

mana: 3979

damage: 59 normal 239 with spell

felguard:

hp: 17500

mana 4800

damage 200-400

Still to less Information :-/. I would need The owners stats that directly influence the pet stats (that are stamina, intellect, spellpower and armor if you like). Nevertheless I don't have any values to compare :-(. I don't have values from official servers about the pets base stats at any level (Warlock). I don't know if the scaling factors are corect (althoug I think they are) and I am unshure about hp/mana per stamina/intellect etc.

I only have representativ datas for hunter pets (see sql). If anyone can provide correct values of Warlock etc. pets you are welcome to PM me ;-)

Don't know if you checked wowwiki in the last weeks, but there has been some updates of the scaling coeficients for Wotlk (http://www.wowwiki.com/Hunter_pet#Pet_scaling, http://www.wowwiki.com/Minion#Minion_scaling, http://www.wowwiki.com/Risen_Ghoul#Stats_and_scaling, and maybe some other, I didn't search for them), hopefully it could help you .

In fact they only corrected their wrong old values^^ If I am honest, I trust my self gathered values more than wowwiki^^ (but anyway It shows, that mine seem to be correct). Resilence changed, but that is not a part of this patch anymore, as vladimir added an alternativ version in another commit already.

Maybe I shoul take a deeper look at the Ghuul scaling... Thanks anyway for your hint!

PS: Hmm, I just see that I linked a wrong patch in first post (with resilence)....

Edit: Fixed links and rebased/merged onto/with [9266]

[przemratajczak]

i havn't time to take a look at whole patch and test it in game but at the first briefly glance this part of code makes me confused:

SetModifierValue(UNIT_MOD_RESISTANCE_HOLY,   BASE_VALUE, float(cinfo->resistance1));
SetModifierValue(UNIT_MOD_RESISTANCE_FIRE,   BASE_VALUE, float(cinfo->resistance1));
SetModifierValue(UNIT_MOD_RESISTANCE_NATURE, BASE_VALUE, float(cinfo->resistance1));
SetModifierValue(UNIT_MOD_RESISTANCE_FROST,  BASE_VALUE, float(cinfo->resistance1));
SetModifierValue(UNIT_MOD_RESISTANCE_SHADOW, BASE_VALUE, float(cinfo->resistance1));
SetModifierValue(UNIT_MOD_RESISTANCE_ARCANE, BASE_VALUE, float(cinfo->resistance1));

Does it suppose to update each resistance field based on one, origin resistance1?

[pasdVn]

Yes, you are right, that's a typo. Thank you :-) I'm going to update patches and branch soon!

[przemratajczak]

thanks

pet spell branch will be also updated?

[pasdVn]

Ok, branche and single patches updated.

pet spell branch will be also updated?

I'll see. Will be a lot of work ^^

[Nykothino]

This patch supports the pet of the priest (Shadowfiend)?

http://www.wowhead.com/?spell=34433#comments

[morderek]

http://github.com/pasdVn/mangos/commit/7513249a12c25e5e0c18055cf8ddeb3b26174800

[pasdVn]

Ok, I rechecked the problem with the warlock pets. There was a typo... just a wrong bitoperation, so that they did not get ap and spellpower from owners fire or shadow spellpower. So thanks to morderek one more time! Everything that is now incorrect with wl pets stats should be db problem now (I hope), as I already mentioned.

Branch and patches updatet.

This patch supports the pet of the priest (Shadowfiend)?

http://www.wowhead.com/?spell=34433#comments

Depends on what you mean by "support". This patch makes the shadowfiend profit from the owner's spellpower. Maybe there are again some special hp per stamina (etc.) factors that we don't know about. And than we don't have correct DB values again here, I think...

[morderek]

Thanks pasdVn, really nice work.

I need to ask something , we´re having some issues with the patches/branch.

I think you´ll se better with the crash log.

http://paste2.org/p/644938

If anybody needs more information just ask

[przemratajczak]

       if ( Pet* pet = GetPet())
       {
           if (pet->IsWithinDistInMap(this, GetMap()->GetVisibilityDistance()) && (GetCharmGUID() && (pet->GetGUID() != GetCharmGUID())))
               RemovePet(pet, PET_SAVE_NOT_IN_SLOT, true);
           else if (m_petScalingUpdateTimer)
           {
               if (m_petScalingUpdateTimer <= p_time)
               {
                   pet->UpdateScalingAuras();
                   m_petScalingUpdateTimer = 0;
               }
               else
                   m_petScalingUpdateTimer -= p_time;
           }
       }

try something like that in Player.cpp in place where UpdateScalingAuras is called

[pasdVn]

Ouch... rookie mistake^^ Thank you guys.

Updated, as always...

[Ayane]

Thanks, i test it.

Actually i receive an crash due to maxHealth of "Bonechewer Riding Wolf" setted to zero.

My database has correct data (minhealth: 4000, maxhealth: 4100).

[przemratajczak]

can you paste BT?

[morderek]

i have noticed just one problem, the pet suddenly gets out of mana , i mean, you are doing nothing and the pet just gets out of mana without any reason.

Pd: If i have more crashes i´ll post the logs

Thanks for your work!

[pasdVn]

Ah... one more typo.. sry :-/ Update will follow..

Edit: Done.

[Ayane]

My crashdump don't show any relation with StatSystem, it appear in Pet::Update in Cell::Visit with arithmetic exception (division by maxHealth (zero)). It doesn't occur before this patch.

[pasdVn]

Can you post your crashdump (pastebin or whatever..)?

[Ayane]

Sorry, i don't preserve the crashdump, you will have my word.

But it can crash anywhere

here:

uint32 perc = (m_creature->getVictim()->GetHealth()*100) / m_creature->getVictim()->GetMaxHealth();

or here

i_percent = unit->GetHealth() * 100 / unit->GetMaxHealth();

or here

uint32 newHPValue = (m_target->GetMaxHealth() * curHPValue) / maxHPValue;

or here

if (target && (m_target->GetHealth() * 100 / m_target->GetMaxHealth() > target->GetHealth() * 100 / target->GetMaxHealth()))

or ...