Ruthlessness bug

[nikko]

Mangos Version: 8886

Custom Patches: 3.2.2a

SD2 Version: ScriptDev2 (for MaNGOS 8831+)

Database Name and Version: UDB 0.11.6 (385) for MaNGOS 8798 with SD2 SQL for rev. 1495

How it SHOULD work: Gives your melee finishing moves a 60% chance to add a combo point to your target. http://www.wowhead.com/?spell=14161

How it DOES work: Doesn't work

[bomba]

I use this hack:

in spell.cpp:

// Okay, everything is prepared. Now we need to distinguish between immediate and evented delayed spells
- if (m_spellInfo->speed > 0.0f)
+ if (m_spellInfo->speed > 0.0f || m_spellInfo->Id == 14157)                // hack for Ruthlessness

[nikko]

Works ok in 3.2.2a

[nikko]

I find only one bug, Ruthlessness doesn't work with Seal Fate http://www.wowhead.com/?spell=14195

Seal Fate description: Your critical strikes from abilities that add combo points have a 100% chance to add an additional combo point.

Ruthlessness description: Gives your melee finishing moves a 60% chance to add a combo point to your target.

If you do Eviscerate crit, only gives you 1combo point, and with seal fate should give 2combo point

[hershaw121]

Seal Fate description: Your critical strikes from abilities that add combo points have a 100% chance to add an additional combo point.

Eviscerate is a finishing move so it should not give 1 combopoint, in your case an Evis crit giving 1 combopoint should be correct.

[nikko]

Eviscerate is a finishing move so it should not give 1 combopoint, in your case an Evis crit giving 1 combopoint should be correct.

Hershaw, Please read bold and mayus words.

Ruthlessness description: Gives your MELEE FINISHING MOVES a 60% chance to ADD A COMBO POINT to your target.

Seal Fate description: Your critical strikes FROM ABILITIES THAT ADD COMBO POINTS have a 100% chance to ADD AN ADDITIONAL COMBO POINT

Please, read carefully these two talents

[dardennf]

No, doing a critical finishing move won't give you 2 CP.

[hershaw121]

Hershaw, Please read bold and mayus words.

Ruthlessness description: Gives your MELEE FINISHING MOVES a 60% chance to ADD A COMBO POINT to your target.

Seal Fate description: Your critical strikes FROM ABILITIES THAT ADD COMBO POINTS have a 100% chance to ADD AN ADDITIONAL COMBO POINT

Please, read carefully these two talents

Very funny how you bolded the text, but have no clue which abilities adds a combopoint. A Finishing move giving 1 combopoint from ruthlessness talent is not considered as an ability that add a combopoint. Finishing moves itself never awards 1 combopoints, that's the point.

The wording from Seal Fate might sounds a bit confusing, but it only covers the spells where it says "Awards 1 combopoint" like Ambush, Backstab, Sinister Strike, Mutilate, Hemorrhage, Shiv, Ghostly Strike or Riposte (maybe I misses some spells)

[nikko]

Everyone ever be confused and therefore no need to disrespect

[mrlocus]

i can confirm this bug for the 0.12 branch, latest rev 8569

[piroy1337]

the problem is,

it even will work without speccing into it... so you can call it "passive" talent lol

[alein]

Is this hack works in the last 91xx rev?

[nikko]

Is this hack works in the last 91xx rev?

Yes, it works

[Hundekuchen]

here the trinity hack, testet on mangos 0.12

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 5ca3033..14278f0 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -6221,6 +6256,9 @@ bool Unit::HandleProcTriggerSpell(Unit *pVictim, uint32 damage, Aura* triggeredB
        case 14189: // Seal Fate (Netherblade set)
        case 14157: // Ruthlessness
        {
+            if (!pVictim || pVictim == this)
+                return false;
+
            // Need add combopoint AFTER finish movie (or they dropped in finish phase)
            break;
        }
diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index bd4ca17..9ef1ad7 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -2434,7 +2443,7 @@ void Spell::cast(bool skipCheck)
    SendSpellGo();                                          // we must send smsg_spell_go packet before m_castItem delete in TakeCastItem()...

    // Okay, everything is prepared. Now we need to distinguish between immediate and evented delayed spells
-    if (m_spellInfo->speed > 0.0f)
+    if (m_spellInfo->speed > 0.0f && !IsChanneledSpell(m_spellInfo) ||  m_spellInfo->Id == 14189 || m_spellInfo->Id == 14157)
    {

        // Remove used for cast item if need (it can be already NULL after TakeReagents call