Snake Trap

[_VENOM_]

mangos rev: 9577

DB ytdb: 538

Snake Trap

http://www.wowhead.com/?spell=34600

summoned snakes attacking hunter. { not enemy } + there ar some diffrent snakes with diffrent HP. 5k hp

[_VENOM_]

http://www.wowhead.com/?spell=34600 summons http://www.wowhead.com/?npc=19833

but it also summons this snakes too http://www.wowhead.com/?npc=19921 and this guys have loot table

wrong.

[jluis859]

Any fix to this? this is an important trap to the hunter.

[laise]

looks like DB problem, since trap uses correct creature entries

[jluis859]

Any fix to this?

greetings

[darkstalker]

problem is that snakes are wild summons (aggresive to everyone)

[Krak]

These snakes don't die after 15 seconds. They are alive until killed and if you kill them, you get XPs They also don't proc poisons. Should proc crippling, mind-numbing and deadly poison

[jluis859]

is there any way to fix this?

[Milk13]

src/game/Pet.cpp
@@ -1219,6 +1219,17 @@ bool Pet::InitStatsForLevel(uint32 petlevel, Unit* owner)
        SetModifierValue(UnitMods(UNIT_MOD_RESISTANCE_START + i), BASE_VALUE, float(createResistance[i]));

    UpdateAllStats();
+    
+    if(getPetType() == GUARDIAN_PET)
+        switch (GetEntry())
+    {
+        case 19833: //Snake Trap - Venomous Snake
+            SetMaxHealth(94);
+            break;
+        case 19921: //Snake Trap - Viper
+            SetMaxHealth(96);
+            break;
+    }

    SetHealth(GetMaxHealth());
    SetPower(POWER_MANA, GetMaxPower(POWER_MANA));

The function UpdateAllStats() modify maxhealth with the different stats, you must define the maxhealth after that.

[jluis859]

src/game/Pet.cpp
@@ -1219,6 +1219,17 @@ bool Pet::InitStatsForLevel(uint32 petlevel, Unit* owner)
        SetModifierValue(UnitMods(UNIT_MOD_RESISTANCE_START + i), BASE_VALUE, float(createResistance[i]));

    UpdateAllStats();
+    
+    if(getPetType() == GUARDIAN_PET)
+        switch (GetEntry())
+    {
+        case 19833: //Snake Trap - Venomous Snake
+            SetMaxHealth(94);
+            break;
+        case 19921: //Snake Trap - Viper
+            SetMaxHealth(96);
+            break;
+    }

    SetHealth(GetMaxHealth());
    SetPower(POWER_MANA, GetMaxPower(POWER_MANA));

The function UpdateAllStats() modify maxhealth with the different stats, you must define the maxhealth after that.

But snakes are still attacking me, this only fixes the maxhealth.

[Sotun]

UPDATE creature_template SET faction_A=84, faction_H=83 WHERE entry IN (19921, 19833);

Hack, but almost corrects the problem - does not work in duels:)

[Milk13]

For the faction, I think you need SD2 patch, you can take the code from TC : http://code.google.com/p/trinitycore/source/browse/src/scripts/world/npcs_special.cpp

[jluis859]

For the faction, I think you need SD2 patch, you can take the code from TC : http://code.google.com/p/trinitycore/source/browse/src/scripts/world/npcs_special.cpp

and does it work on trinity?

[Milk13]

It's work on my serv with mangos-0.12

[przemratajczak]

on TC there is separate SummonAI for summonedWild NPCs (snakes, images, etc). they are updated like normal pets,companions etc

[jluis859]

It's work on my serv with mangos-0.12

is it work on my serv with mangos-0.12?

Can you put a picture of this?

thanks in advance for your answer.

[Milk13]

/*####
## npc_snake_trap_serpents - Summonned snake id are 19921 and 19833
####*/

#define SPELL_MIND_NUMBING_POISON    25810   //Viper
#define SPELL_CRIPPLING_POISON       30981    //Viper
#define SPELL_DEADLY_POISON          34655   //Venomous Snake

#define MOB_VIPER 19921

#define VENOMOUS_SNAKE_TIMER 1500
#define VIPER_TIMER 3000

struct MANGOS_DLL_DECL npc_snake_trap_serpentsAI : public ScriptedAI
{
   npc_snake_trap_serpentsAI(Creature *c) : ScriptedAI(c) {}

   uint32 SpellTimer;
   bool IsViper;

   void EnterCombat(Unit *who) {}

   void Reset()
   {
       SpellTimer = 0;

       Unit *Owner = m_creature->GetOwner();
       if (!m_creature->isPet() || !Owner) return;

       CreatureInfo const *Info = m_creature->GetCreatureInfo();

       if (Info->Entry == MOB_VIPER)
           IsViper = true;
       else
           IsViper = false;

   }

   //Redefined for random target selection:
   void MoveInLineOfSight(Unit *who)
   {
       if (!m_creature->getVictim() && who->isTargetableForAttack() && (m_creature->IsHostileTo(who)) && who->isInAccessablePlaceFor(m_creature))
       {
           if (m_creature->GetDistanceZ(who) > CREATURE_Z_ATTACK_RANGE)
               return;

           float attackRadius = m_creature->GetAttackDistance(who);
           if (m_creature->IsWithinDistInMap(who, attackRadius) && m_creature->IsWithinLOSInMap(who))
           {
               if (!(rand() % 5))
               {
                   m_creature->setAttackTimer(BASE_ATTACK, (rand() % 10) * 100);
                   SpellTimer = (rand() % 10) * 100;
                   AttackStart(who);
               }
           }
       }
   }

   void UpdateAI(const uint32 diff)
   {
       Unit *Owner = m_creature->GetOwner();

       if (!m_creature->isPet() || !Owner) return;

       if (!m_creature->getVictim())
       {
           if (m_creature->isInCombat())
               DoStopAttack();

           if (Owner->getAttackerForHelper())
               AttackStart(Owner->getAttackerForHelper());
           return;
       }

       if (SpellTimer <= diff)
       {
           if (IsViper) //Viper - 19921
           {
               if (urand(0,2) == 0) //33% chance to cast
               {
                   uint32 spell;
                   if (urand(0,1) == 0)
                       spell = SPELL_MIND_NUMBING_POISON;
                   else
                       spell = SPELL_CRIPPLING_POISON;

                   m_creature->CastSpell(m_creature->getVictim(), spell, true);
               }

               SpellTimer = VIPER_TIMER;
           }
           else //Venomous Snake - 19833
           {
               if (urand(0,2) == 0) //80% chance to cast
                   m_creature->CastSpell(m_creature->getVictim(), SPELL_DEADLY_POISON, true);
               SpellTimer = VENOMOUS_SNAKE_TIMER + (rand() %5)*100;
           }
       } else SpellTimer -= diff;
       DoMeleeAttackIfReady();
   }
};

CreatureAI* GetAI_npc_snake_trap_serpents(Creature* pCreature)
{
   return new npc_snake_trap_serpentsAI(pCreature);
}

[jluis859]

Is there a way to put this on a last revision of mangos?

thanks in advance for your answer

[ankso]

I have added the Milk13 script into my SD2, with the lastest revisions of MaNGOS. I have used this SQL:

UPDATE creature_template SET scriptname=npc_snake_trap_serpents WHERE entry IN (19921, 19833);

and also added this:

newscript = new Script;    
   newscript->Name = "npc_snake_trap_serpents";    
   newscript->GetAI = &GetAI_npc_snake_trap_serpents;
   newscript->RegisterSelf();

Now the snakes are green for the owner, but they do nothing, they appear, they don't attack mobs or enemy players, and they disappear. Could someone help me?

[Wowka321]

I modified and simplify script, and now work fine for me.

http://paste2.org/p/826610

[jluis859]

I modified and simplify script, and now work fine for me.

http://paste2.org/p/826610

What revision did you use?

where can I put this?

thanks in advance for your answer.

[Wowka321]

This is offtop anyway ))

It's for SD2, where you wanna, better place is npc_special.cpp )

[Jethrogibbs]

Or another solution that works very well without script:

UPDATE `creature_template` SET `faction_A` = 1802,`faction_H` = 1801, `family` = 35 WHERE `entry` = 19833;         
UPDATE `creature_template` SET `faction_A` = 1802,`faction_H` = 1801, `family` = 35 WHERE `entry` = 19921;

[jluis859]

Or another solution that works very well without script:

UPDATE `creature_template` SET `faction_A` = 1802,`faction_H` = 1801, `family` = 35 WHERE `entry` = 19833;         
UPDATE `creature_template` SET `faction_A` = 1802,`faction_H` = 1801, `family` = 35 WHERE `entry` = 19921;

does this work on arena system or pvp? or does it work only in pve?

[Shad00w]

Poisons of Viper can stack and Snake's do too much damage.