[patch][8064] "Rapture" Dummy Procs

[Auntie Mangos]

In [8064]. Thank you

Loading errors for outdated recored i will fix in next patch as suggested early in ( http://getmangos.eu/community/viewtopic.php?id=8481 )

[pasdVn]

This patch adds the dummy procs for "Rapture" (http://www.wowhead.com/?spell=47535).

The formula is based on http://forums.worldofwarcraft.com/thread.html;jsessionid=5DD29E14CB82EF5628B964471BAE6DB1.app25_02?topicId=11296623227&sid=1 and the comments on wowhead.

--

Because only Flash Heal, Great Heal, and the triggered missiles of Penance are abled to trigger the procs we have to change the procflags (currently wrong entries for Penance):

pasdVn

UPDATE for 3.1.3 (new spell mechanics):

http://github.com/pasdVn/mangos/commit/80d0367959b110cb3daa0c6dd65022f5ecf84ac5

(the diff looks quite huge, but thats only because I had to shift a whole code part a tabulator to the left)

[Maxxie]

Personally i would move the healing script from dummy to Override Class Scripts.

Something like this:

http://pastebin.com/m311c490

[pasdVn]

As you like it ;-)

Just did not want to take two times the same aura if there are two. Did this for a similar spell but a dev wanted me not take the same aura twice so I did not do it like that this time^^ Anyway its curious why both auras have different values...

But maybe we could swap them... use Dummy for shield proc in CalcAbsorbResist and OverrideCs for healing proc. We don't have to search auras twice in calcAbsorbResist then. Just some thoughts...

I'm going to change it if some more people misslike it

[Sephiroth1983]

Unknown post id, it may have expired or been deleted

Link expired, this patch is still needed, nice talent.

[pasdVn]

Reuploaded.

Anyway the spellmechanics for Rapture seem to change again in 3.1.0.

[Graftal]

Can anyone confirm this works properly please? Thank you

[Graftal]

Can you please upload it on another paste-like site? Everything posted on pastebin expires too soon And yes, it's expired again Thank you!

[Marin4o]

Can this please get reuploaded really needed for Disc. Priest

[pasdVn]

Done. ...maybe I should use github or anything in the future... :-/

[Marin4o]

Can someone please test this and the Borrowed Time fix before they get expired again.

[Marin4o]

Anyone tested this yet?

[Marin4o]

Can someone please test this and the Borrowed Time fix before they get expired again.

[Reve]

Using this patch for some time now and as author said casting healing flash, penance and greaters returns mana.

R.

[pasdVn]

When uploading this patch to github and rechecking it I noticed, that the mana, returning from absorb did not work (wrong conversion from float to int). I could swear that it worked before and I did not changed anything :mellow:

Anyway, here comes an updated working version (see first post)!

[NetSky]

i can remember this was already working without the patch

[pasdVn]

Not with a clean mangos core ;-)

[KAPATEJIb]

Only last rank of spell (5) works for me, other ranks return 1 mana. Tested on 7900 rev.

[Crunch]

Only last rank of spell (5) works for me, other ranks return 1 mana. Tested on 7900 rev.

tested on 7894 rev. + your patches - all ok, return 2,5% of max. mana for all ranks.

[pasdVn]

Thank you for feedback. I missed a type conversion. Maybe different compilers have/don't have problems with that (vc++ has).

Fixed that and should work for all ranks now :-)

[KAPATEJIb]

Fixed that...

where? patch and link isn't changed in first post

[pasdVn]

I changed the patch at the repo. Link and hash of the commit keeps the same. To reapply it, best would be to revert the old commit at your repo and than cherry-pick the new one (or however you are used to do it^^).

Edit: Hmm sry. The commit hash and link changed... very strange. In fact this linked commit should not exist anymore... just a second...

Edit2: Ok, link updated.

[KAPATEJIb]

patch needs in update for 3.1.3

[pasdVn]

Updated. But possible that it does not work. I don't have a 3.1.3 client here currently (and so no dbc's).

I don't like this big hardcoded part on removing PW:S, but I don't see any other possibility for now.

Don't forget to apply the sql part.

[Maxxie]

Shouldn't the target energize part proc at shield remove too?