Jump to content

VladimirMangos

Members
  • Posts

    2813
  • Joined

  • Last visited

    Never
  • Donations

    0.00 GBP 

Everything posted by VladimirMangos

  1. Hmm, i think it can be added also for any creature-owned case, not only for temp summon, if it will added. Maybe instead id send someting other, but i not sure what send... also note: patch in suggested form not applied clearly with in git... i see some lines or line parts lost at paste
  2. Yes, as Schmoozerd say. If we expect existence proper way with current sources, or after some rewrite ist then low chance adding hack way writed patchs. Hack can be sometime accepted when tottal unknown how implement this in proper way or expected that hack overwrite some wrong data in dbc for example. Last must really hard proved not just "not fit my code then this some wrong data"
  3. In short: hack fix is attempt fix specific single case in game working with ignore how related generic code work expected. proper fix: look how work similar case, attempt find generic sollution for all its, use same shared code and attempt look in future for avoid created by change problems in other code places. Proper fix in most cases not req. "fix"/overwrite data send by client or stored in DBC. It also often let see better how game must work in some other related case so improve code in cases not directly affected by fix. Ofc, exist cases when client/dbc provide wrong data by result original author typos for example. Or just unclear how some part must work in details. So fixes mostly something between hacl/proper fix in its extreme definitions. But we must attempt has been more near to proper side when write fixes how possible... ^^
  4. Just for note: at YTDB forum this confirmed as fixed DB bug in next release.
  5. You need google ACE at openSuse. Maybe you find suggestions how fix it. Or use system specific ACE port
  6. if all cases for aura must be avoid target coefs then check maybe make sense..
  7. Possible problem with review is hard for devs reproduce it locally... If someone write steps for reproduce...
  8. This also make sense because lighthouse tracker account disabled for mangos. Also forum have link to lighthouse tracker that need updated.
  9. You meaning repo under mangos account or totally independent repo?
  10. gm not have limitations for sent chat strings. this expected way work.
  11. This tables filled by DB projects. So report and look for sollution at used DB project forum.
  12. Thank you for test cases! Must be fixed in [11321] with ChatStrictLinkChecking.Severity = 3
  13. Can you send it to my PM for testing?
  14. i will look, thanks for pointing. In most cases not use warrior for test.
  15. Just lol, THIS is case not prove. Just look in this point up and you will see sky. this is OUTDOOR, in different gates paths. So please not refer to this case.
  16. Ok, all pointing to use in some cases deleted auras
  17. Yes, possible for offline player need ask DB for data. Maybe with adding wrapper and use new DB prepared statements way. ok, its not backported to One yet.
  18. 00000001400B0D44 000000000A5803B0 Unit::CalculateSpellDamage+284 d:\\51-[s0974]_2011\\src\\game\\unit.cpp line 1275 Line not fit to related revision sources so trace useless 00000001400C7A43 000000000A580340 Unit::SpellDamageBonusTaken+2F3 d:\\51-[s0974]_2011\\src\\game\\unit.cpp line 5789 Hmm, in addition to above notes in -2 my post crash possible if deleted aura not removed from auras list by type, BUT in like cases it must crash at any first removed aura and this not happens .... I understand that problem exist but unclear where. crash logs can't help in this for real problem search because crash happense later in code after real problem (maybe at prev tick and etc)
  19. switch((*i)->GetSpellProto()->SpellIconID) Aura expected always have valid spell proto pointer. If it broken then aura list iterator invalidated or unit object itself wrong Because loop by AuraList const& mDummyAuras = GetAurasByType(SPELL_AURA_DUMMY); not modify auras data but check values only so iterator can't be invalidated. So possible single case: unit object not existed/deleted/corrupted/etc Not related directly to aura work. But not all follow fixes for aura code after holders applied at this moment. So some new crashes possible ofc. This is same as before aura holders. As i remember i see same at master (at least in past for first part), if some some later not backported fix possible will fix this problem.
  20. Ok, problem clear, BUT is it correct prevent join to arena with offline members?
  21. Without description what cast this spells and how spells casted impossible say anything. So until will not described way reproduce in game with all pre-requirement i expect that just spell used wrongly. [11276] fix clean bug in code, and not direct fix for listed spells.
  22. In [s0977] mask 0x8008 restored.
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use