VladimirMangos

Agree, with index need but not agrre with strange remark: primary key is _pair_ of fields.[added] Not mangos bug. Possible some old DB porjects versions have wrong different from mangos realmd.sql keys for table and not add propertly expected primary key. So adding any mangos sql update is useless (mangos _has_ proper key). And must be fixed by users. Just for note: i also found in my long existed DB this table without key.

Rewrited patch added in to [8317] base at version listed in KAPATEJIb thread in Russian Mangos Forum. Anyway thanks for patch versions and comments. And include so not nice one more unrelated spell. I replace using spellmasks by category checks.

In [8316]. Thank you

base at fact that in normal chat you can't write message with \\n i not see problem with adding this to code. In [8311]. Thank you

Must be completed _cretera_ instead achievement and using proper call instead hacks like you attempt do... Player have Player::UpdateAchievementCriteria But in most case like kill boss with additional reqirement expected some another way... and this call will propertly ignored. Achievment criteria for kill special reqs check additinal requirements by achievment_criteria_data. In many kill boss cases not exist achievement creatria data types for descrive its. Possible need implement achievement creatria data type *_SCRIPT that will suggest achievement system ask instance data for additinal reqs for criteria... And in instance data virtual function you will can describe check like some boss killed at moment, anotyher boss alive, none death while phase, some objects not destroyed...

With some changes patch added in [8298]. Thank you

Maybe this is off. bug Other recial castable abilities added to actions...

Ok, i agree, that my commit has been too fast... and move thread also... sorry... I will partly revert referenced commit to allow some spells authocast out of combat. But this not related explicitly to not autocastable in generla spells mostly..

This case must be fixed in [8295]

You not provided proper data.. copy-paste error But fixed.I also not apply Not sure that this correct. This is racial ability and learned so strange if it not added... Added in [8294] with some fixes in suggested data and additinal fixes. Count of food fixed in code. Thanks

This is incorrect way, need fixed in code... i will look

I think problem must solved lot more simple way: autocast work only in combat. So not autocasted or not spells. Its just don;t must be autocasted non in combat. This alt. way change appliend in [8291]

When you will think that data ready to add to mangops.sql please send me PM...

This is changed version (not deep tested): http://paste2.org/p/348592 Why need this part? triggered effects as i look not have 47 category...

I add not fully related GetSpellSpecific part (without SPELL_WARRIOR_BLEED) in to [8279]. Thank you. After more deep review code i not agree that using spell specific is normal way for this. I think we must use std. switch(spellfaily) and classification by mailymask/spelid/category way.. (note: SPELL_WARRIOR_BLEED more easy and correct tested by mechannic 15 as i think) This let merge later part of Aura::HandleShapeshiftBoosts at least Possible i will rewrite this part by self...

I only worry about I see 2 problem: 1) hack like, what if we will case without aura apply in first effect 2) what if we have spell with 2 aura: it wil cast spell after dirst aura apply but before second aura with possible strange effects.

Must be fixed with recent TOM_RUS backport related code from 320.

In [8272]. Thank you

Fixed in [8266]

In fact base at fact that talent always have learned only single rank this only affect loop execute time.

In loop by ShapeShifterAuras you need break at success. Another case ofc put it in Unit::HandleDummyAuraProc as suggested in http://getmangos.ru/forum/showthread.php?t=19663&highlight=Master+Shapeshifter But i think in case: (1) not set proc flags in spell.dbc and expection add at apply and remove at !apply cleary show that it better proccess as you suggest in Aura::HandleShapeshiftBoosts... In [8263]. Thank you

Strange, i not have any problems with global broadcast. Command start work indeed. So i think chnage correct. In [8262]. Thank you

But with decrease. I not found cleary referenses to expected ppm for this spell It required special chance==100 case for 62124 in code. I think this can work.

You think that all spells with rank have this ppm dependence? Added spell have explicitly reference that it have increasing ppm with rank. I worry about over generalization.... Have 2 existed or found cases that required this not prove general case.

Windows part of changes is ok for x64. Not sure that this only need change from other side. Before this can be tested under winsows need create related projectes mode and resolve conflict settings for x32 Laos note that existed #include <linux/types.h> will not build at FreeBSD or any othoer not linux OSs