VladimirMangos

this is known 3.0.3 feature not implemented in mangos. Totally unrelated.

I fix in [7751] problem that exist before but will triggered activly by suggested change: unneeded pet spells saves ansd possible per spell save DB errors. Hmm, better ofc, if you provided infor about affected spell ids for simplify testing... [added]Ok, i find case for check. Patch with some changes (use enums as in other cases insteed hardcoded values) in [7752]. Thank you

In [7750]. Thank you

Are you sure? I think too later make recoloring attempts.

Ah, sorry, not look in existed patches at forum when reseach problem. Thank you any way

Patch in [7737]. Thank you, raven_coda and Trazom

Is this really need?Maybe spell always casted by player to creature, but spell have target mode "self" in case spell effect that expected to casted to player? I think this is must be moved to related spell cast aura apply code... instead special case...

I currently review, just notes: better set _after_ merge fishingnode to fishing. This make loot of fishing node expected fishing loot also. And will not req. specail check in achievement call. 2. Instead hardcoded values i will add using `achievement_criteria_data`

I agree with Wyk3d point as usual 1) I not fully agree with term "re-union": in fact all pointed ppl not has been formally mangos devs in past. And mangos team in fact not broken by parts (except small time period maybe when trinity created). And then i not see why take part in unfriedly fork make they good for _join_ to team. 2) If talk about team memebership important not only code skills but also trust. Work in trinity with known position to mangos project can't imrpove trust. I not have pre-made position that thay not trusted and period, or that they must do someting special to return trust. But i think exist normal way how devs join to mangos team: good patches, good discussion, help to project, show that adding push rights will not create problems for project. 3) We have hard times sometime or make wrong notes and comments, And this harm team climate in some level sometime. I worry specially about Paradox. He show often very unfriendly reactions at forums. In fact he always near to ban state. 4) I not look deeply at current megamage patches but remember that megamege always prefer fast hack solutions. And some patches that has been add aftre megameage move to trinity also req. rewriting to correct state before adding to mangos (ignore cheating possibilities for example). 5) Not have any info to say about Trullyone and Raczman code skills. I think they join to fork just show that they not so want cooperation when his patches not ready by some reason to repo. Anyway i not have anything personally against they just as result his trinity development. But i think need normal way proof that they want help to mangos. Help to mangos not required explicit access to mangos repo push rights. Also with GIT author have honor for commit in any case and this more explicit show honor in comparison any team membarship. Membership only speedup things when commiter can trusted. [added]I understand why they can want join to team. Other case will look like trinity team fail. But is this our problem? We (as team) not fork from trinity, we not attempt harm trinity, we just continue development mangos. This is trinity fork, attempt harm, amd has been something like mangos repack mostly. [added2]About git use for patches: At personal expirience vote by both hands for patches in git repo. Lot simple review.

5.1.24-rc-community, just has been first version that i find in time switch to vista that can be installed at vista x64 and started

In [7728] loottype values update to really used by client for specific loot types. I think this must simplify suggested patch and remove hacks

cmake not support precompiled headers as i read. we plan add its to mangos build.

I test grid unloading at clean mangos and it work as expected.

Last part with described changes in [7703]. Thank you

Second part of criteria list in [7702]. Thank you Note: i move ACHIEVEMENT_CRITERIA_TYPE_TOTAL_DAMAGE_RECEIVED under if (health <= damage) cases to avoid in death case accumulate overdamage Update not req. I will review last part. [added] ACHIEVEMENT_CRITERIA_TYPE_DAMAGE_DONE (and heal case also) called incorrectly. As i understand statistic case _must_ counted in any cases including for non-player damage/heal at BG In your version non-player damage/heal in BG ignored. Player/non-player must be checked in to criteria, not at call. I will update patch in described way.

no-no. This is fixed more easy by re-numbering loot types (enum LootType) and this part already ready in my local repo. So switch LOOT_SKINNING with LOOT_PICKPOCKETING and after LOOT_DISENCHANTING and LOOT_SKINNING, and update code to 5-8 custom values. Currently we send to client only 1-3 values and replace any server side values 4-8 by 2 for client. But base at achievement data possible 4 also now acceptable for client. So after this changes we apply fishing part replace we will have values compatibale with achievment values. _But_ possible our replace 5-8 by 2 not fully correct and client expect another values for specific loot types. This will not affect achivement side but i don;t want move enum value by associared numbers without confirmations. So achivment part can wait until in game loot type enums will updated to more correct state.

DealHeal function added in [7701]. Thank you Other code will be reviewed later. If you update patch this will be helpful.

In [7700]. Thank you

Before ACHIEVEMENT_CRITERIA_TYPE_LOOT_TYPE adding need resolve current loot types conflicting numbering with achievement, not as hack fix but proper way. I attempt currently find data for recently used loot types for different looting.

It's can be normal if you have disabled grid unload in configs.

Fix part of post #1 patch added in [7694]. Thank you

This is not true. If player relogin and without moves use .start command thne command will applied.

This is not threads for new commands, ignored.

Done in [7693]

.additem - in current format hard to implement in clear way: it accept as first arg item name so hard seelct what this: item name or player nick.