Wowka321

Confirm. Some days ago i tried to fix it, but my knowledge not enough. We must add check in aura requirements for interrupt channeling spells, and if effects of channeling spell is gone -> interrupt casting.I thing is the best place.

So fast to copy-paste

Not related topic directly, but can anyone tell me, does any spells with EffectImplicitTargetA1=87 that must be affected by caster exist? May be EffectImplicitTargetA1=87 - must to be exclude caster? I not clearly understand this yet ...

Tested. Now all fine. Thx. =)

Thx. BTW, can you post full Eye of Acherus mod ? ^^ Sorry about offtop...

No one part of opcodes don't affected by my modifications. BTW, i tested this issue on clear core. And after some reserch i fix it by sending full packet. I don't have sniffer for research this packet as must be http://paste2.org/p/616628 Only TOM_RUS can do it as expected

Something changed in SMSG_AUTH_RESPONSE packet after swith to 3.3.0. Queue is broken. Always showing position 0 in queue. And after you pass queue you can login with characters only preTBC. Other characters: .

Oops, It's my old stupid and crazy Crt+C & Ctrl+V. =/.. Solved. Sorry :rolleyes:

Master branch. When player login, core ignore CONFIG_MAX_HONOR_POINTS. This is the fix From de5b9c124e5cb2e6e3ef07dd25350acef6f810d7 Mon Sep 17 00:00:00 2001 From: Wowka321 <[email protected]> Date: Fri, 15 Jan 2010 19:18:25 +0200 Subject: [PATCH] Fixed max honor --- src/game/Player.cpp | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/game/Player.cpp b/src/game/Player.cpp index ce1120a..ce3aa4e 100644 --- a/src/game/Player.cpp +++ b/src/game/Player.cpp @@ -14966,6 +14966,12 @@ bool Player::LoadFromDB( uint32 guid, SqlQueryHolder *holder ) _LoadArenaTeamInfo(holder->GetResult(PLAYER_LOGIN_QUERY_LOADARENAINFO)); + uint32 honor_currency = GetUInt32Value(PLAYER_FIELD_HONOR_CURRENCY); + if (honor_currency > sWorld.getConfig(CONFIG_MAX_HONOR_POINTS)) + honor_currency = sWorld.getConfig(CONFIG_MAX_HONOR_POINTS); + + SetUInt32Value(PLAYER_FIELD_HONOR_CURRENCY, honor_currency); + uint32 arena_currency = GetUInt32Value(PLAYER_FIELD_ARENA_CURRENCY) + fields[40].GetUInt32(); if (arena_currency > sWorld.getConfig(CONFIG_MAX_ARENA_POINTS)) arena_currency = sWorld.getConfig(CONFIG_MAX_ARENA_POINTS); -- 1.6.0.2.1172.ga5ed0

Search in forum "Death bug". Somewhere i posted hackly fix.

copy from http://paste2.org/followup/610677

Ok. It's my fix. Not see any other way to fix now. http://paste2.org/p/609835

Conflagrate after master branch switch to support 3.3.0 don't work correctly. Damage must be now 60% of your Immolate or Shadowflame . Also have DoT . Now tick only 60

look into Common.h

Thx, friend, for repost patch in right subforum

This my fix

Work what? Bug? On clear core yes. My hack? -yes, it prevent stacking bonuses from meta. I also was try put IsBroken where it need, but i always get crash So, main problem in Player::_ApplyItemMods (all or part subfunctions). We shoul't make checks for unequip item case and always remove all bonuses when item unequip.

Finaly units can animate jumps

Change to uint32 spell_id = ((Player*)m_caster)->GetActionByActionButton(button); if(spell_id && !((Player*)m_caster)->HasSpellCooldown(spell_id)) m_caster->CastSpell(unitTarget,spell_id,true);

Confirm. damage from 100 to 8k per tick :eek:

http://paste2.org/p/573502 As possible solution i made exeption in Player::_ApplyItemMods to pass checks if(item->IsBroken() && proto->Socket[0].Color) //This need to remove bonuses from meta if item broken { CorrectMetaGemEnchants(slot, apply); return; }

No, crash again. :confused: Main problem here that bonus from meta not removed if EnchantmentFitsRequirements return false (if requirements with count of gems not true) when unequip item with metagem.

In Player::EnchantmentFitsRequirements there are very seriuos bug, that make possible do exploits with stacking metagems effects. Counting current equipped gem colors should't count gems from broken items. I was try to add check like if(pItem2->IsBroken()) continue; but i get crash when equip item with metagem Anybody can to help with this check?

So, why it should work? In code no one string about skin(hair) color for shape visual. So, hard-code it (or may be more research DBC)

This version not fully correct. My version http://paste2.org/p/565216