Auntie Mangos

I assume this requires some procc flags as of patch http://getmangos.eu/community/topic/15283/dev-removal-of-auras-by-procflags/

many thx to VladimirMangos I have made a post in "... under review" Plz close More in this thread http://getmangos.eu/community/post/135038/#p135038

How can be handled spell like 45477 Icy Touch (Rank 1) "Very high threat when in Frost Presence.", x7 damage according wowwiki? I'm not sure but with you patch healing and damage do the same threat while, for what I know, healing usually should generate half amount Since you are using both a mutiplier and flat values http://getmangos.eu/community/post/124975/#p124975 must be solved to find if 1 damage = 1 or 100 threat otherwise it's impossibile to fill the table properly In part realated to this, time ago I was working on threat from float to uint32 it's based on an old revision and I had no time to test it but maybe it can be usefull, the main idea was to move threat math to uint since that's how it must be send to client and because, IMHO, a unit's threat can be negative that's why now some spell or scripts bork the threat meter.

Core: 10610 but appear since 9000+ and i always need a hack to fix it. Only appear with high population 1000+ online http://getmangos.eu/community/viewtopic.php?pid=98052#p98052 Related with corrupted mover pointer at charmed creature... maybe: http://pastebin.com/8zR3cTDS With this fix http://pastebin.com/EVhHgrB0 by zergtmn crash less in low population 600 max online If i check with: http://pastebin.com/CM5eVNPJ crash again in same position If i remove this antiexploit check, crash later in: data.appendPackGUID(mover->GetGUID()); I can only use a really ugly hack checking if plMover is not null, but no relocation for charmed creatures. And no... i dont use vehicle patch and nothing related with movers Any ideas to finally fix it? Best regards

I prefer not to add new features unless its absolutely necessary for the patch functioning.. so maybe in a far away future and if aura holders will be in master -- updated for 10048 - messed with spell proc code - now will use spell family mask from spell if no school mask and no different spell family mask present on spell_proc_event. Some records left for family name only, possibly will drop in the future if they will work without the need to check it. Added possibility to define spell family mask based on effect index and not 1 for whole spell (no longer need to add checks for effect indexes in proc handle code). Note: currently most of the data is cloned from original spell_proc_event - means still all auras on all effect indexes will proc.. and I left isTriggerSpell array although it became unused, maybe will drop later

errors in unit.h do not work core:9842 Insider 1.core_9842\\src\\game\\Unit.h(1860) : error C2065: m_vehicleGUID: Not declared identifier 1.core_9842\\src\\game\\Unit.h(1861) : error C2065: m_vehicleGUID: Not declared identifier 1.core_9842\\src\\game\\Unit.h(1366) : error C2065: m_auraUpdateMask: Not declared identifier 1.core_9842\\src\\game\\Unit.h(1367) : error C2065: m_auraUpdateMask: Not declared identifier 1.core_9842\\src\\game\\Unit.h(1368) : error C2065: m_auraUpdateMask: Not declared identifier update Patch from here please in it there were no errors http://getmangos.eu/community/showthread.php?11759-dev-Vehicles&p=110595&viewfull=1#post110595

What bug does the patch fix? What features does the patch add? fixes offhand poison apply for Deadly Poison For which repository revision was the patch created? 9609 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/showthread.php?12829-[9286]Deadly-Poison-5-stacks-bugged-effect Who has been writing this patch? Please include either forum user names or email addresses. me diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 8990035..2a9a809 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -6173,6 +6173,49 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu break; } } + // Deadly Poison + if (dummySpell->SpellIconID == 513) + { + if (pVictim->GetTypeId() != TYPEID_PLAYER) + return false; + + if (triggeredByAura->GetStackAmount() < dummySpell->StackAmount) + return false; + + Player *pCaster = ((Player*)pVictim); + + Item* castItem = triggeredByAura->GetCastItemGUID() ? pCaster->GetItemByGuid(triggeredByAura->GetCastItemGUID()) : NULL; + + if (!castItem) + return false; + + Item *item = pCaster->GetWeaponForAttack(castItem->GetSlot() == EQUIPMENT_SLOT_MAINHAND ? OFF_ATTACK : BASE_ATTACK); + if (!item) + return false; + + // all poison enchantments is temporary + uint32 enchant_id = item->GetEnchantmentId(TEMP_ENCHANTMENT_SLOT); + if (!enchant_id) + return false; + + SpellItemEnchantmentEntry const *pEnchant = sSpellItemEnchantmentStore.LookupEntry(enchant_id); + if (!pEnchant) + return false; + + for (int s = 0; s < 3; ++s) + { + if (pEnchant->type[s]!=ITEM_ENCHANTMENT_TYPE_COMBAT_SPELL) + continue; + + SpellEntry const* combatEntry = sSpellStore.LookupEntry(pEnchant->spellid[s]); + if (!combatEntry || combatEntry->Dispel != DISPEL_POISON) + continue; + + pVictim->CastSpell(this, combatEntry, true, item); + } + + return true; + } // Cut to the Chase if (dummySpell->SpellIconID == 2909) { @@ -12939,6 +12982,7 @@ void Unit::ProcDamageAndSpellFor( bool isVictim, Unit * pTarget, uint32 procFlag } case SPELL_AURA_MOD_DAMAGE_PERCENT_TAKEN: case SPELL_AURA_MOD_DAMAGE_PERCENT_DONE: + case SPELL_AURA_MOD_ATTACKER_SPELL_AND_WEAPON_CRIT_CHANCE: case SPELL_AURA_MANA_SHIELD: case SPELL_AURA_OBS_MOD_MANA: case SPELL_AURA_MOD_STUN: @@ -13828,7 +13872,7 @@ bool Unit::IsTriggeredAtSpellProcEvent(Unit *pVictim, Aura* aura, SpellEntry con } // Aura added by spell can`t trogger from self (prevent drop charges/do triggers) // But except periodic triggers (can triggered from self) - if(procSpell && procSpell->Id == spellProto->Id && !(spellProto->procFlags & PROC_FLAG_ON_TAKE_PERIODIC)) + if(procSpell && procSpell->Id == spellProto->Id && !(spellProto->procFlags & PROC_FLAG_ON_TAKE_PERIODIC) && aura->GetModifier()->m_auraname != SPELL_AURA_MOD_ATTACKER_SPELL_AND_WEAPON_CRIT_CHANCE) return false; // Check if current equipment allows aura to proc mostly based on Shiv offhand poison apply DELETE FROM `spell_proc_event` WHERE `entry` IN (2818); INSERT INTO `spell_proc_event` VALUES (2818, 0x00, 8, 0x00010000, 0x00000000, 0x00000000, 0x00020000, 0x00000000, 0.000000, 0.000000, 0); INSERT INTO `spell_chain` VALUES (2818, 0, 2818, 1, 0), (2819, 2818, 2818, 2, 0), (11353, 2819, 2818, 3, 0), (11354, 11353, 2818, 4, 0), (25349, 11354, 2818, 5, 0), (26968, 25349, 2818, 6, 0), (27187, 26968, 2818, 7, 0), (57969, 27187, 2818, 8, 0), (57970, 57969, 2818, 9, 0);

Found it - it was SpellEffects after all as I thought. Very sneaky little change. Anyhow: patch in review at http://getmangos.eu/community/showthread.php?12884-[Fiix]-Battleground-Object-buffs

Hi a have 1 problem with mtmaps using rev 8573. I currently using derek's mtmaps (ACE), because i'm unable to use this http://getmangos.eu/community/showpost.php?p=90117&postcount=49, if I use that openmp mtmaps, all threads starts in 7X% of cpu ussage and raising...and infinity's (raczman, etc.). I currently have gcc 4.4.0. Any ideas to do with this crash or somebody with my openmp problems? [Core was generated by `./mangos-worldd'. Program terminated with signal 11, Segmentation fault. [New process 1355] [New process 1357] [New process 1365] [New process 1361] [New process 1362] [New process 1342] [New process 1367] [New process 1352] [New process 1350] [New process 1364] [New process 1366] [New process 1349] [New process 1358] [New process 1359] [New process 1354] [New process 1356] #0 0x00000000006a3630 in Spell::DoAllEffectOnTarget (this=0x7f59e6dacdb0, target=0x10) at ../../../src/game/Spell.cpp:922 922 if(target->processed) // Check target #0 0x00000000006a3630 in Spell::DoAllEffectOnTarget (this=0x7f59e6dacdb0, target=0x10) at ../../../src/game/Spell.cpp:922 mask = <value optimized out> unit = <value optimized out> caster = <value optimized out> missInfo = <value optimized out> procVictim = <value optimized out> procAttacker = 16384 procEx = <value optimized out> #1 0x00000000006b1b44 in Spell::handle_immediate (this=0x7f59e6dacdb0) at ../../../src/game/Spell.cpp:2667 No locals. #2 0x00000000006b0fb8 in Spell::cast (this=0x7f59e6dacdb0, skipCheck=true) at ../../../src/game/Spell.cpp:2641 castResult = <value optimized out> #3 0x00000000006f576a in Unit::CastCustomSpell (this=<value optimized out>, Victim=<value optimized out>, spellInfo=<value optimized out>, bp0=0x430e4a38, bp1=0x0, bp2=0x0, triggered=<value optimized out>, castItem=0x0, triggeredByAura=0x7f5a3d410760, originalCaster=144773) at ../../../src/game/Unit.cpp:977 targets = {m_srcX = 0, m_srcY = 0, m_srcZ = 0, m_destX = 1024.65173, m_destY = 860.800659, m_destZ = -62.5263367, m_strTarget = { static npos = 18446744073709551615, _M_dataplus = {<std::allocator<char>> = {<__gnu_cxx::new_allocator<char>> = {<No data fields>}, <No data fields>}, _M_p = 0xaebbb8 ""}}, m_targetMask = 2, m_unitTarget = 0x7f5a2cafba40, m_GOTarget = 0x0, m_itemTarget = 0x0, m_unitTargetGUID = 140061, m_GOTargetGUID = 0, m_CorpseTargetGUID = 0, m_itemTargetGUID = 0, m_itemTargetEntry = 0} #4 0x00000000007092af in Unit::HandleDummyAuraProc (this=0x7f5a5acbf420, pVictim=<value optimized out>, damage=568, triggeredByAura=0x7f5a3d410760, procSpell=<value optimized out>, procFlag=<value optimized out>, procEx=1, cooldown=0) at ../../../src/game/Unit.cpp:6395 dummySpell = (const SpellEntry *) 0x7f5a554f2fe0 castItem = (class Item *) 0x0 triggered_spell_id = <value optimized out> effIndex = 1 triggerAmount = <value optimized out> target = (Unit *) 0x7f5a2cafba40 basepoints0 = 227 #5 0x000000000070c69e in Unit::ProcDamageAndSpellFor (this=0x7f5a5acbf420, isVictim=<value optimized out>, pTarget=<value optimized out>, procFlag=<value optimized out>, procExtra=<value optimized out>, attType=<value optimized out>, procSpell=0x7f5a53c6cd40, damage=568) at ../../../src/game/Unit.cpp:11369 triggeredByAura = (class Aura *) 0x7f5a3d410760 spellProcEvent = <value optimized out> spellInfo = <value optimized out> cooldown = 0 removedSpells = {<std::_List_base<unsigned int, std::allocator<unsigned int> >> = { _M_impl = {<std::allocator<std::_List_node<unsigned int> >> = {<__gnu_cxx::new_allocator<std::_List_node<unsigned int> >> = {<No data fields>}, <No data fields>}, _M_node = {_M_next = 0x430e4b40, _M_prev = 0x430e4b40}}}, <No data fields>} procTriggered = {<std::_List_base<ProcTriggeredData, std::allocator<ProcTriggeredData> >> = { _M_impl = {<std::allocator<std::_List_node<ProcTriggeredData> >> = {<__gnu_cxx::new_allocator<std::_List_node<ProcTriggeredData> >> = {<No data fields>}, <No data fields>}, _M_node = {_M_next = 0x7f59e76870e0, _M_prev = 0x7f59cc710bd0}}}, <No data fields>} #6 0x000000000070cdc4 in Unit::ProcDamageAndSpell (this=0x7f5a5acbf420, pVictim=0x7f5a2cafba40, procAttacker=<value optimized out>, procVictim=1572864, procExtra=1, amount=568, attType=BASE_ATTACK, procSpell=0x7f5a53c6cd40) at ../../../src/game/Unit.cpp:4411 No locals. #7 0x0000000000698711 in Aura::PeriodicTick (this=0x7f5a33b3b7f0) at ../../../src/game/SpellAuras.cpp:6452 resist = 0 amount = <value optimized out> pdamage = 0 isCrit = false procVictim = 0 pCaster = <value optimized out> absorb = 0 cleanDamage = {damage = 0, attackType = BASE_ATTACK, hitOutCome = MELEE_HIT_NORMAL} pInfo = {aura = 0x7f5a33b3b7f0, damage = 568, overDamage = 0, absorb = 0, resist = 0, multiplier = 0, critical = false} #8 0x0000000000699ace in Aura::Update (this=0x7f5a33b3b7f0, diff=152) at ../../../src/game/SpellAuras.cpp:650 No locals. #9 0x00000000006f8cef in Unit::_UpdateSpells (this=0x7f5a2cafba40, time=152) at ../../../src/game/SpellAuras.h:311 i_aura = (class Aura *) 0x7f5a33b3b7f0 #10 0x00000000006fbe46 in Unit::Update (this=0x7f5a2cafba40, p_time=152) at ../../../src/game/Unit.cpp:195 No locals. #11 0x0000000000671311 in Player::Update (this=0x7f5a2cafba40, p_time=152) at ../../../src/game/Player.cpp:1060 now = <value optimized out> pet = <value optimized out> #12 0x00000000005b82d0 in Map::Update (this=0x7f59fd409410, t_diff=@0x7f5a1f9b9a60) at ../../../src/game/Map.cpp:591 plr = (class Player *) 0x7f59e6dacdb0 updater = {i_timeDiff = 152} __PRETTY_FUNCTION__ = "virtual void Map::Update(const uint32&)" #13 0x000000000077cba9 in MapInstanced::Update (this=0x7f5a27b73860, t=@0x7f5a1f9b9a60) at ../../../src/game/MapInstanced.cpp:63 i = {<std::tr1::__detail::_Hashtable_iterator_base<std::Pair<const unsigned int, Map*>, false>> = {_M_cur_node = 0x7f5a1ca33470, _M_cur_bucket = 0x7f5a27b72708}, <No data fields>} #14 0x0000000000730b82 in MapUpdateRequest::call (this=0x7f5a1f9b9a40) at ../../../src/game/MapUpdater.cpp:65 No locals. #15 0x00000000007bbfe1 in DelayExecutor::svc (this=0x2b9ee88) at ../../../src/shared/DelayExecutor.cpp:61 rq = (class ACE_Method_Request *) 0x7f5a1f9b9a40 #16 0x00007f5a5f233067 in ACE_Task_Base::svc_run (args=<value optimized out>) at ../../../../dep/ACE_wrappers/ace/Task.cpp:275 t = (ACE_Task_Base *) 0x2b9ee88 svc_status = <value optimized out> #17 0x00007f5a5f234421 in ACE_Thread_Adapter::invoke (this=0x7f5a58c01e60) at ../../../../dep/ACE_wrappers/ace/Thread_Adapter.cpp:98 exit_hook_instance = <value optimized out> exit_hook_maybe = {instance_ = 0x0} exit_hook_ptr = <value optimized out> #18 0x00007f5a5d3503f7 in start_thread () from /lib64/libpthread.so.0 No symbol table info available. #19 0x00007f5a5cc2d1dd in clone () from /lib64/libc.so.6 No symbol table info available.

Hi 5 , I dont know what are my problem, my friend have a server version 3.1.3 (its arcemu server but the dbc files is the same for mangos i think) running OK and his upload yours dbc files running on your server but its does not work for me and i have the same error i reported. Here is the error. Initialize data stores... [***************************************** ] 82% Some required *.dbc files (14 from 79) not found or not compatible: ./dbc/AreaTable.dbc (exist, but have 0 fields instead 36) Wrong client version DBC file? ./dbc/Achievement.dbc (exist, but have 0 fields instead 62) Wrong client version DBC file? ./dbc/CreatureDisplayInfo.dbc (exist, but have 0 fields instead 16) Wrong client version DBC file? ./dbc/GameObjectDisplayInfo.dbc (exist, but have 0 fields instead 19) Wrong client version DBC file? ./dbc/Holidays.dbc (exist, but have 54 fields instead 55) Wrong client version DBC file? ./dbc/Item.dbc (exist, but have 0 fields instead 8) Wrong client version DBC file? ./dbc/ItemExtendedCost.dbc (exist, but have 0 fields instead 15) Wrong client version DBC file? ./dbc/MailTemplate.dbc (exist, but have 0 fields instead 35) Wrong client version DBC file? ./dbc/SoundEntries.dbc (exist, but have 0 fields instead 30) Wrong client version DBC file? ./dbc/Spell.dbc (exist, but have 0 fields instead 232) Wrong client version DBC file? ./dbc/TaxiPathNode.dbc (exist, but have 0 fields instead 11) Wrong client version DBC file? ./dbc/Vehicle.dbc (exist, but have 0 fields instead 40) Wrong client version DBC file? ./dbc/VehicleSeat.dbc (exist, but have 0 fields instead 58) Wrong client version DBC file? ./dbc/WorldMapOverlay.dbc (exist, but have 0 fields instead 17) Wrong client version DBC file? I tested 3 dbc files diferent but any work for me. I use the repair tool with my client wow but its dont see any error on my client. I reset my client and take the updates from wow 1.x to 3.1.3 and extract the dbc files and its have the same error. I dont know what i do now... Can one help me with this?

Dear Mangos Community, I use the Arena Patch which has been posted in November here ( http://getmangos.eu/community/showpost.php?p=50236&postcount=2683 ). It might be a bit old but its the only compatible one I found so far, no I don't want to use a newer Git revision of Mangos due to stability reasons. Can anyone give me the SQL Patches which I need for this patch? (All Pastbin links which I found here are outdated) Thanks a lot in advance, Crashuncle

MadJack have you tested this on linux, because I think it wont work. You need to compile the scripts as loadable module.

Of course, I forgot Heroic Strike does not activate the global cooldown (and this can be cast anytime, simultaneously, etc...). You are correct. As for code boxes, I assume you're referring to this? It's odd it's been broken so long, since it seems all it's missing is replacing '\\n' with " ", but then I'm lazing myself as far as mangos goes so I totally get that

http://getmangos.eu/community/topic/15618/win32debug-wrong-libeay32dll-version/

This fixes so that AH addons in the client start to work and i have done some more resurge on the problem and i started a thread so that i might get into mangos. Its a simple fix with the problem that searches don't get any hits. http://getmangos.eu/community/viewtopic.php?pid=128387#p128387

Stickied to this section is this: http://getmangos.eu/community/viewtopic.php?id=8517

[Fix][8693] Glyph of Life Tap , but I did not notice its action

Just saying, but ... here's the vellums thread Basically, the 9280 patch is incomplete without the rest of the vellum functionnality, which was pointed by Moandor

What bug does the patch fix? What features does the patch add? Fixed for spell http://www.wowhead.com/?spell=58875 For which repository revision was the patch created? 9071 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.php?id=10539 Who has been writing this patch? Please include either forum user names or email addresses. Me diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 5498286..6a32c6c 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -4216,13 +4216,16 @@ void Aura::HandleModTaunt(bool apply, bool Real) /*********************************************************/ /*** MODIFY SPEED ***/ /*********************************************************/ -void Aura::HandleAuraModIncreaseSpeed(bool /*apply*/, bool Real) +void Aura::HandleAuraModIncreaseSpeed(bool apply, bool Real) { // all applied/removed only at real aura add/remove if(!Real) return; m_target->UpdateSpeed(MOVE_RUN, true); + + if (apply && GetSpellProto()->Id == 58875) + m_target->CastSpell(m_target, 58876, true); } void Aura::HandleAuraModIncreaseMountedSpeed(bool apply, bool Real)

What about this and this bugs?

Again: this quest doest not need vehicles, its mind-control spell on eye!

Hi, Sorry it's my fault. When you asked me about 'path-finding' and 'mmap' I thought you meant 'minimaps' on the client :blink: Yes I know, I should try to follow other relevant projects, but I don't have enough time. Since you and UnkleNuke mentioned mmap, I found faramir118's github and I can now see what all the buzz is about, particularly with the various utube video demos. The improvements in the way NPCs navigate will be a definite advantage. It's visually annoying to see NPCs walking through walls and floor boards of buildings. I'm sure when they have perfected it, playerbot will also benefit. I tried to extract a set of 'mmaps', but the extractor hangs and complains that my map files are the wrong version. Does 'mmap' work with the latest maps/vmaps ? I am sure everyone will be interested to see the changes you have made B) Cheers

UPDATED on 01-Dec-2010 Revision of MaNGOS: 10759 with some custom changes, so the diff file may be "tainted" by them ;P Fix for talent Honored Among Thieves. When anyone in the Rogue's group deals critical damage/heal, also periodic - the rogue gains a combo point for his current victim. Works with >1 rogue in the group with this talent. Cooldown is 1s per rogue with the talent. Talent rank 1: http://www.wowhead.com/spell=51698 Proc spell: http://www.wowhead.com/spell=52916 Spell adding combo point: http://www.wowhead.com/spell=51699 Patch: http://pastebin.com/Gr6LgKpN SQL proc event: -- Honor Among Thieves DELETE FROM `spell_chain` WHERE `spell_id` IN (51698, 51700, 51701); INSERT INTO `spell_chain` VALUES (51698, 0, 51698, 1, 0), (51700, 51698, 51698, 2, 0), (51701, 51700, 51698, 3, 0); DELETE FROM `spell_proc_event` WHERE `entry` IN (51698); INSERT INTO `spell_proc_event` VALUES (51698, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x0054110, 0x0040002, 0, 0, 1); Tested in a group of 2 rogues and a druid, works with melee/spell/healing criticals, also DoT crits and it worked all time, so hunter's ranged crits shouldnt be an exception ;p Also 1sec. cooldown works, when there's a lot of spamming crits rogue gains only 1 cb point per second as intended. thanks to przemratajczak for help

Please continue the discussion at http://getmangos.eu/community/showthread.php?10618-Auto-Announcer-with-NextID-and-MangChat-support

Yes they do, and I think the same flag as here is used to determine which spells they use (all spells with that flag won't be cast by a controlled player).