Auntie Mangos

* What bug does the patch fix? What features does the patch add? It fixes the coefficients of spells wich were using wrong coefficients. * For which repository revision was the patch created? 7242+ * Who has been writing this patch? cccyril , with the help of Sephiroth1983 who wrote a part of the fix (http://getmangos.eu/community/viewtopic.php?id=6289) -- Updating coefficients for some spells DELETE FROM `spell_bonus_data` WHERE `entry` IN ('689', '18790', '172', '42223', '42224', '42225', '42226', '42218', '47817', '47818', '1949', '5857', '11681', '11682', '27214', '47822', '27243', '30108', '17962', '6789', '48181', '29722', '5676', '686', '17877', '30283', '1120', '30294', '44425', '42208', '42209', '42210', '42211', '42212', '42213', '42198', '42937', '42938', '11113', '31661', '120', '19750', '635', '25914', '25913', '25903', '27175', '33074', '48820', '48821', '58597', '31935', '31803', '53742', '31893', '32221', '53719', '53718', '20167', '20424', '31804', '53733', '31898', '32220', '53726', '53725', '20267', '20187', '20467', '53600', '596', '2944', '8092', '27813', '27817', '27818', '33619', '60089'); INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES ('689', '0', '0.143', '0', 'Warlock - Drain Life'), ('18790', '0', '0', '0','Warlock - Fel Stamina'), ('172', '0', '0.2', '0', 'Warlock - Corruption'), ('42223', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 1'), ('42224', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 2'), ('42225', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 3'), ('42226', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 4'), ('42218', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 5'), ('47817', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 6'), ('47818', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 7'), ('1949', '0', '0.0949', '0', 'Warlock - Hellfire'), ('5857', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy Rank 1'), ('11681', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy Rank 2'), ('11682', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy Rank 3'), ('27214', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy Rank 4'), ('47822', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy Rank 5'), ('27243', '0.2129', '0.25', '0', 'Warlock - Seed of Corruption'), ('30108', '0', '0.2', '0', 'Warlock - Unstable Affliction'), ('17962', '0.4293', '0', '0', 'Warlock - Conflagrate'), ('6789', '0.214', '0', '0', 'Warlock - Death Coil'), ('48181', '0.4793', '0', '0', 'Warlock - Haunt'), ('29722', '0.7139', '0', '0', 'Warlock - Incinerate'), ('5676', '0.4293', '0', '0', 'Warlock - Searing Pain'), ('686', '0.8569', '0', '0', 'Warlock - Shadow Bolt'), ('17877', '0.4293', '0', '0', 'Warlock - Shadowburn'), ('30283', '0.1932', '0', '0', 'Warlock - Shadowfury'), ('1120', '0', '0.429', '0', 'Warlock - Drain Soul'), ('30294', '0', '0', '0', 'Warlock - Soul Leech'), ('44425', '0.7143', '0', '0', 'Mage - Arcane Barrage'), ('42208', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 1'), ('42209', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 2'), ('42210', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 3'), ('42211', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 4'), ('42212', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 5'), ('42213', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 6'), ('42198', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 7'), ('42937', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 8'), ('42938', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 9'), ('11113', '0.1936', '0', '0', 'Mage - Blast Wave Rank'), ('31661', '0.1936', '0', '0', 'Mage - Dragons Breath'), ('120', '0.214', '0', '0', 'Mage - Cone of Cold'), ('19750', '1', '0', '0', 'Paladin - Flash of Light'), ('635', '1.66', '0', '0', 'Paladin - Holy Light'), ('25914', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 1'), ('25913', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 2'), ('25903', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 3'), ('27175', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 4'), ('33074', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 5'), ('48820', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 6'), ('48821', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 7'), ('58597', '0.75', '0', '0', 'Paladin - Sacred Shield'), ('31935', '0.07', '0', '0.07', 'Paladin - Avenger Shield'), ('31803', '0', '0.018', '0.03', 'Paladin - Holy Vengeance'), ('53742', '0', '0.018', '0.03', 'Paladin - Blood Corruption'), ('31893', '0', '0', '0', 'Paladin - Seal of Blood Enemy Proc'), ('32221', '0', '0', '0', 'Paladin - Seal of Blood Self Proc'), ('53719', '0', '0', '0', 'Paladin - Seal of The Martyr Enemy Proc'), ('53718', '0', '0', '0', 'Paladin - Seal of The Martyr Self Proc'), ('20167', '0.15', '0', '0.15', 'Paladin - Seal of Light Proc'), ('20424', '0.1035', '0', '0', 'Paladin - Seal of Command Proc'), ('31804', '0.22', '0', '0.14', 'Paladin - Judgement of Vengeance'), ('53733', '0.22', '0', '0.14', 'Paladin - Judgement of Corruption'), ('31898', '0.25', '0', '0.16', 'Paladin - Judgement of Blood Enemy'), ('32220', '0', '0', '0', 'Paladin - Judgement of Blood Self'), ('53726', '0.25', '0', '0.16', 'Paladin - Judgement of the Martyr Enemy'), ('53725', '0', '0', '0', 'Paladin - Judgement of the Martyr Self'), ('20267', '0.1', '0', '0.1', 'Paladin - Judgement of Light Proc'), ('20187', '0.4', '0', '0.25', 'Paladin - Judgement of Righteousness'), ('20467', '0.25', '0', '0.16', 'Paladin - Judgement of Command'), ('53600', '0', '0', '0', 'Paladin - Shield of Righteousness'), ('596', '0.8068', '0', '0', 'Priest - Prayer of Healing'), ('2944', '0', '0.1849', '0', 'Priest - Devouring Plague'), ('8092', '0.428', '0', '0', 'Priest - Mind Blast'), ('27813', '0', '0', '0', 'Priest - Blessed Recovery Rank 1'), ('27817', '0', '0', '0', 'Priest - Blessed Recovery Rank 2'), ('27818', '0', '0', '0', 'Priest - Blessed Recovery Rank 3'), ('33619', '0', '0', '0', 'Priest - Reflective Shield'), ('60089', '0', '0', '0.05', 'Druid - Faerie Fire (Bear Form)'); Nevertheless, I have some doubts about Seal of Command and Seal of Blood / Martyr coefficients. Moreover, I am not sure about spells used by Soul Leech, Blessed Recovery and Reflective Shield. Remove old coded Judgement of Righteousness coefficients, thanks to rechapa79 2009-03-08 12:19 diff -rul a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp Page 1 --- a/src/game/SpellEffects.cpp 2009-03-08 12:15:02.000000000 -0200 +++ b/src/game/SpellEffects.cpp 2009-03-08 12:16:27.000000000 -0200 @@ -1559,14 +1559,7 @@ switch(m_spellInfo->Id) { - // Judgement of Righteousness (0.2*$AP+0.32*$SPH) holy added in spellDamagBonus - case 20187: - { - if (!unitTarget) - return; - m_damage+=int32(0.2f*m_caster->GetTotalAttackPowerValue(BASE_ATTACK)); - return; - } + case 31789: // Righteous Defense (step 1) { // 31989 -> dummy effect (step 1) + dummy effect (step 2) -> 31709 (taunt like spell for each target)

Following up the ideas suggested in Playerbot thread I thought of a more generic system to enable ingame bug reports. For userside I think some "all-you-can-drink" command(s) like .report <type> [hidden] <status> [guid or target or Shiftlink] <comment> .reportTo <Whom> <type> <status> <comment> with possible versions like: <type> quest: <status> = 0 undefined (cannot be used) 1 not-completable 2 bugged completable 3 looking good 4 blizzlike // Possible more, similar to project tracker Shiftlink = Quest Shiftlink npc: <status> = 0 missing spawn 1 wrong position 2 double spawn 3 bad stats 4 bad candy (ie equip) guid or target (for status > 0) the npc of whom we are talking go: <status> = 0 missing spawn 1 wrong position 2 double spawn 3 bad stats guid or target (for status > 0) the go of which we are talking [hidden] Mark report as hidden The reportTo command should behave the same, only that this report is for automatic report to the project-sites (ie something like the udb quest tracker) Now about the internally mechanism: The reports should be stored in a database table, with this format: (id, whom, process-state, type, status, entryOrGuid, comment, reporter, pos(map, x, y, z), version(core, db, scripting)) Where whom = To Whom it should be reported (0 for .report command) process-state: 0 = normal, 1= hidden, 2=to-sent, 3=validated, 4=sent // Maybe some additonal states like fixed, etc.. type, status, entryOrGuid, comment from above reporter = user that reported (I think char-guid is fine pos = position where the user was For the reportTo command, I some additional special configs are required (for each used WHOM): - WHOM_NAME (ie "udb" for the udb quest tracker) - WHOM_USER (some random string identifying the user on udb-tracker - iE a hash value of AdminsUsername+RandomSeed ) - WHOM_BEHAVIOUR (validate before submitting / direct submit) So what is to discuss: * types - status combinations * ReportTo - must agree on some sort of way to send datas (format) (Actually I have no idea how this could be handled when down to coding ) * Possible GM/Admin addon to work with these things? * Role based command rights might come in handy for reportTo command - so that only knowing users are able to use it * Interaction to Bugtracker/ Website - I don't know how to handle such things * Feedback from our site hosters, if there would be possibilities to create wrappers to ie forward to github issues or other trackers

many thx to VladimirMangos I have made a post in "... under review" Plz close More in this thread http://getmangos.eu/community/post/135038/#p135038

http://getmangos.eu/community/viewtopic.php?id=14555 alternate version, including idea (by zergtmn) how to really make is a generic function

first you must download and apply the vehicle patch, which you apparently does, so second thing is to go through vehicle patch topic and learn from this topic how to implement more vehicles. Also look at vehicle patch sql queries, which could help you better understand what you must do to get the vehicles working http://getmangos.eu/community/showthread.php?11759-dev-Vehicles

Mangos fail copiling on Ubuntu 9.4 Latest upgraded Ubuntu Latest Version OpenSSL Similar Topics: http://getmangos.eu/community/showthread.php?12456-[9311]-Crash-client http://getmangos.eu/community/showthread.php?12272-Compile-in-linux-fail-again&highlight=void+Group%3A%3ASetTargetIcon(uint8%2C+uint64%2C+uint64) http://getmangos.eu/community/showthread.php?12473-CentOS-5-3-compiling-MaNGOS-9310&highlight=openssl

What bug does the patch fix? What features does the patch add? Patch will remove a bugged facing limitation from http://www.wowhead.com/?spell=2764 ability For which repository revision was the patch created? 8754+ Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.php?id=10650 Who has been writing this patch? Please include either forum user names or email addresses. Me diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp index 4be1945..0915316 100644 --- a/src/game/Spell.cpp +++ b/src/game/Spell.cpp @@ -4070,8 +4070,10 @@ SpellCastResult Spell::CheckCast(bool strict) { //Exclusion for Pounce: Facing Limitation was removed in 2.0.1, but it still uses the same, old Ex-Flags //Exclusion for Mutilate:Facing Limitation was removed in 2.0.1 and 3.0.3, but they still use the same, old Ex-Flags + //Exclusion for Throw: Facing limitation was added in 3.2.x, but that shouldn't be if ((m_spellInfo->SpellFamilyName != SPELLFAMILY_DRUID || (m_spellInfo->SpellFamilyFlags != UI64LIT(0x0000000000020000))) && - (m_spellInfo->SpellFamilyName != SPELLFAMILY_ROGUE || (m_spellInfo->SpellFamilyFlags != UI64LIT(0x0020000000000000)))) + (m_spellInfo->SpellFamilyName != SPELLFAMILY_ROGUE || (m_spellInfo->SpellFamilyFlags != UI64LIT(0x0020000000000000))) && + m_spellInfo->Id != 2764) { SendInterrupted(2); return SPELL_FAILED_NOT_BEHIND;

@xzbbzx - if you want to read why thats a proper patch read the old thread here @Shin Darth - im not trying to hijack your thread and i see your point about just replacing the group.cpp being "easy"...but easier is not always better. the proper patch is working great and still works on current mangos version! also, this one is just as easy to update your core too. after reading the original thread i think you are just not applying the patch correctly. put the group.diff posted above in your mangos folder and use this command patch -d . -p1 < group.diff enjoy

Search->Mirror Image http://getmangos.eu/community/topic/12917/mirror-image/ http://getmangos.eu/community/topic/14146/mirror-image-dont-work/ ... ... ... Even you can find some patches if you search a little bit. It's no so difficult.

Could we have an option added on the forums under "My Settings" for selecting which Rank/Title to be displayed. I enjoyed having my "Is it an apple?" rank and working up towards new ranks, but now that i've donated I just get a plain never changing rank of "Donator" Like Toinan67 and I stated in the We need your help thread, community members should donate because they want to help not to get special recognition or a reward. I'd rather be known for my donations of code and helping with users' problems, not for donating money Edit: We could have all the "Achievements" a member has obtained listed on their profile for users who want to see all the Titles/Ranks and member has, that way the member could display whatever Title/Rank they want on the forums but their other Titles/Ranks would still be publicly visible by other users

Using the forum search you could have answered that question yourself: http://getmangos.eu/community/showthread.php?13397-MaNGOS-switch-to-support-3-3-3a-%2811723%29

Hi Runsttren Please look at this thread ^^ http://getmangos.eu/community/viewtopic.php?id=2661 Can i somehow persuade you to help us in this Bot System ? An we use this to get the spell. This is in the bot.cpp RETRIBUTION_AURA = ai->getSpellId("retribution aura"); And this in the playerbotai.cpp uint32 PlayerbotAI::getSpellId(const char* args) const { if(!*args) return 0; std::string namepart = args; std::wstring wnamepart; if(!Utf8toWStr(namepart,wnamepart)) return 0; // converting string that we try to find to lower case wstrToLower(wnamepart); int loc = m_master->GetSession()->GetSessionDbcLocale(); uint32 foundSpellId = 0; bool foundExactMatch = false; bool foundMatchUsesNoReagents = false; for(PlayerSpellMap::iterator itr = m_bot->GetSpellMap().begin(); itr != m_bot->GetSpellMap().end(); ++itr) { uint32 spellId = itr->first; if(itr->second->state == PLAYERSPELL_REMOVED || itr->second->disabled || IsPassiveSpell(spellId)) continue; const SpellEntry* pSpellInfo = sSpellStore.LookupEntry(spellId); if (! pSpellInfo) continue; const std::string name = pSpellInfo->SpellName[loc]; if(name.empty() || !Utf8FitTo(name, wnamepart)) continue; bool isExactMatch = (name.length() == wnamepart.length()) ? true : false; bool usesNoReagents = (pSpellInfo->Reagent[0] <= 0) ? true : false; // if we already found a spell bool useThisSpell = true; if (foundSpellId > 0) { if (isExactMatch && ! foundExactMatch) {} else if (usesNoReagents && ! foundMatchUsesNoReagents) {} else if (spellId > foundSpellId) {} else useThisSpell = false; } if (useThisSpell) { foundSpellId = spellId; foundExactMatch = isExactMatch; foundMatchUsesNoReagents = usesNoReagents; } } return foundSpellId; } I hope you take into consideration to help us.

I would say it is http://getmangos.eu/community/viewtopic.php?id=6135 related

When the target dies due to the spell the damage shouldn't be done on the player. Someone suggested a fix here http://getmangos.eu/community/topic/16136/mangos-onepatch-fix-shadow-word-death/ and for some reason it works. Altho Vladimir was right that it's the same procflag as in the .dbc file, and you get a console error stating that, seems the fix is actually working. Maybe there's something wrong in the spell's code and doesnt handle the procflag correctly?

please follow the Bug Reporting Guidelines

If I could have one wish, it would be for people to search before posting. http://getmangos.eu/community/viewtopic.php?id=836

The problem is that atm I can code only in the weekends. If I have free time this weekend I may try to port it ... but I deffinitely won't have time to stress-test it.

cyberium's work for Auction House Bot has been submitted for review to include it in the standard core. You may find the new topic in the under review section here: http://getmangos.eu/community/topic/15522/patchauction-house-bot/ Continued development, updates, and discussions are posted there.

I had problems compiling with Visual Studio Express 2010 so I ditched it and uninstalled and used 2008 instead. I'm running the win32 version of the latest 3.3.3a and it works flawlessly on a win x64 box (Mangos, ScriptDev2, ACID) I suggest if it is your first attempt to scrap everything and start again its actually faster than fixing problems. The whole process takes about 2 hours from start to finish (even faster if you automate it). Rename your old mangos folder and forget about it. Follow this guide by Temporary http://getmangos.eu/community/showthread.php?13121-World-of-Warcraft-Server-for-Windows-Installation-Guide The only thing I would suggest differently obviously is to compile the latest version. And copy the binaries in a simple folder such as C:\\Mangos and drop in the data folders. When you launch realmd and mangosd do it from the actual folder. You should end up with something like this. C:\\Mangos C:\\Mangos\\buildings C:\\Mangos\\dbc C:\\Mangos\\maps C:\\Mangos\\vmaps So if it works fine with a 2008 recompile your all happy. If exactly the same problem then I would delete your databases and do them again. If you like you can back up the old databases by exporting them as SQL dumps so you can import them again if you need or for troubleshooting. Just make sure you always import into a fresh database. I moved my server and restored it this way - copied the mangos folder, installed mysql, made empty databases, imported the sql dumps, launched it. I might try compiling the win64 version but really theres no need as its running so well.

if someone has a working patch, than it can be found in "under review" section for example daggers are corrected here http://getmangos.eu/community/showthread.php?13522-[fix]-Hemorrhage-Ghostly-Strike

I tried this patch last night before posting but it was so late and I was very tired and forgot to remove this : diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index 168cf44..adb562c 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -1764,7 +1764,23 @@ void Spell::EffectDummy(uint32 i) } return; } [b][color="Red"]- break;[/color][/b] + //Death Grip temp fix + if(m_spellInfo->Id==49576) + { + if (!unitTarget||!m_caster) + return; + uint32 mapid = m_caster->GetMapId(); + float x = m_caster->GetPositionX(); + float y = m_caster->GetPositionY(); + float z = m_caster->GetPositionZ()+1; + float orientation = unitTarget->GetOrientation(); + m_caster->CastSpell(unitTarget,49560,true,NULL);//get taunt debuff as well + unitTarget->SendMonsterMove(x,y,z,0,MOVEMENTFLAG_JUMPING,1); + if (unitTarget->GetTypeId()==TYPEID_PLAYER) + unitTarget->NearTeleportTo(x,y,z,orientation,false); + return; + } + break; } // pet auras This morning i found out and it works I hope the Mangos source will be updated so will not need to apply a patch for the death grip to work Thank you , Have a nice day

cause i didnt managed to work purify on linux, i did some logs with valgrind (i am still looking for some DEV witch can join to mine server and install purify, PM pls) NEW Vlagrind logs, mangos rev 7158 + sd2 857(modified some c++ scripts sorry) mangos is almost clean, without derex mtmaps, only some minor changes at player plevel accounts+ player titles:) here are two valgrind logs, one is only mangos startup with full debug mode, without optimization, second is debug, with optimization, and cca 2hours gameplay, i also reproduced crash described here: http://getmangos.eu/community/showthread.php?p=56944#post56944 here are the valgrind logs: http://filebeam.com/fda307e4b30ba4d967f1891398456bee here are bt from core dumps generated by gdb/valgrind http://pastebin.com/m73b92b7e crash http://pastebin.com/m145027f5 ctrl+c ? (i am not sure ) hope it helps : )

http://getmangos.eu/community/viewtopic.php?id=4242

this patch doesn't work at the actual rev. i'm not soo good in such things... i try but I'm not so good as I want... sorry..

http://getmangos.eu/community/viewtopic.php?id=5351 Search next time.