Auntie Mangos

i rewrited it once that it worked but still affect only Night Elf druids. Something is wrong with sending update packets to Tauren players since 3.1.3 introduced . Posted bug report. http://getmangos.eu/community/showthread.php?11824-Barber-Shop-%28Horde%29&highlight=

* What bug does the patch fix? What features does the patch add? Fix handling of SPELL_AURA_ADD_TARGET_TRIGGER auras. e.g. fix Shadow Weaving proccing from Mind Flay. Periodic trigger from Mind Flay in casted by target with original caster guid. * For which repository revision was the patch created? 11956 * Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. don't know http://getmangos.eu/community/topic/13391/2x-bug-mind-sear-priest/ * Who has been writing this patch? Please include either forum user names or email addresses. me http://paste2.org/p/1978871 src/game/Spell.cpp | 54 ++++++++++++++++++++++++++++----------------------- 1 files changed, 30 insertions(+), 24 deletions(-) diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp index ab9f141..099c1dd 100644 --- a/src/game/Spell.cpp +++ b/src/game/Spell.cpp @@ -3547,30 +3547,36 @@ void Spell::finish(bool ok) if (!ok) return; - // handle SPELL_AURA_ADD_TARGET_TRIGGER auras - Unit::AuraList const& targetTriggers = m_caster->GetAurasByType(SPELL_AURA_ADD_TARGET_TRIGGER); - for(Unit::AuraList::const_iterator i = targetTriggers.begin(); i != targetTriggers.end(); ++i) - { - if (!(*i)->isAffectedOnSpell(m_spellInfo)) - continue; - for(TargetList::const_iterator ihit = m_UniqueTargetInfo.begin(); ihit != m_UniqueTargetInfo.end(); ++ihit) - { - if (ihit->missCondition == SPELL_MISS_NONE) - { - // check m_caster->GetGUID() let load auras at login and speedup most often case - Unit *unit = m_caster->GetObjectGuid() == ihit->targetGUID ? m_caster : ObjectAccessor::GetUnit(*m_caster, ihit->targetGUID); - if (unit && unit->isAlive()) - { - SpellEntry const *auraSpellInfo = (*i)->GetSpellProto(); - SpellEffectIndex auraSpellIdx = (*i)->GetEffIndex(); - // Calculate chance at that moment (can be depend for example from combo points) - int32 auraBasePoints = (*i)->GetBasePoints(); - int32 chance = m_caster->CalculateSpellDamage(unit, auraSpellInfo, auraSpellIdx, &auraBasePoints); - if(roll_chance_i(chance)) - m_caster->CastSpell(unit, auraSpellInfo->EffectTriggerSpell[auraSpellIdx], true, NULL, (*i)); - } - } - } + if (Unit* caster = GetAffectiveCaster()) + { + Unit::AuraList const& targetTriggers = caster->GetAurasByType(SPELL_AURA_ADD_TARGET_TRIGGER); + for (Unit::AuraList::const_iterator i = targetTriggers.begin(); i != targetTriggers.end(); ++i) + { + if (!(*i)->isAffectedOnSpell(m_spellInfo)) + continue; + + for (TargetList::const_iterator ihit = m_UniqueTargetInfo.begin(); ihit != m_UniqueTargetInfo.end(); ++ihit) + { + if (ihit->deleted) + continue; + + if (ihit->missCondition == SPELL_MISS_NONE) + { + // check caster->GetGUID() let load auras at login and speedup most often case + Unit* unit = caster->GetObjectGuid() == ihit->targetGUID ? caster : ObjectAccessor::GetUnit(*caster, ihit->targetGUID); + if (unit && unit->isAlive()) + { + SpellEntry const * auraSpellInfo = (*i)->GetSpellProto(); + SpellEffectIndex auraSpellIdx = (*i)->GetEffIndex(); + // Calculate chance at that moment (can be depend for example from combo points) + int32 auraBasePoints = (*i)->GetBasePoints(); + int32 chance = caster->CalculateSpellDamage(unit, auraSpellInfo, auraSpellIdx, &auraBasePoints); + if (roll_chance_i(chance)) + caster->CastSpell(unit, auraSpellInfo->EffectTriggerSpell[auraSpellIdx], true, NULL, (*i)); + } + } + } + } } // Heal caster for all health leech from all targets

DummyEffect was implemented wrong (http://getmangos.eu/community/topic/15814/targeteffectselect-in-effectteleportunits-ikiss-blink-effectdummy/). Spell has SPELLFAMILY_MAGE and not GENERIC. diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index b974967..b2d60d0 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -1166,14 +1166,6 @@ void Spell::EffectDummy(SpellEffectIndex eff_idx) m_caster->CastCustomSpell(unitTarget, spell_id, NULL, NULL, NULL, true); return; } - case 38194: // Blink - { - // Blink - if (unitTarget) - m_caster->CastSpell(unitTarget, 38203, true); - - return; - } case 39189: // Sha'tari Torch { if (!unitTarget || unitTarget->GetTypeId() != TYPEID_UNIT || m_caster->GetTypeId() != TYPEID_PLAYER) @@ -1443,6 +1435,14 @@ void Spell::EffectDummy(SpellEffectIndex eff_idx) } return; } + case 38194: // Blink + { + // Blink + if (unitTarget) + m_caster->CastSpell(unitTarget, 38203, true); + + return; + } } break; } greetings, DaC

http://getmangos.eu/community/viewtopic.php?id=14789&p=120701&viewfull=1#post120701

The changes in CheckCast() don't make much sense to me .. anyway, patches here http://getmangos.eu/community/showthread.php?5936-blink-patch-2009 should still work with master branch ...

vBulletin's ignore system is a joke, and does very little. I reported the post and PM, so hopefully its dealt with.

What bug does the patch fix? What features does the patch add? - fixes cooldown removing of Intercept For which repository revision was the patch created? - should work on latest Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. - http://getmangos.eu/community/viewtopic.php?id=1043 Who has been writing this patch? Please include either forum user names or email addresses. - me diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 2de02d2..a473fa0 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -4257,6 +4257,9 @@ void Aura::HandleModMechanicImmunity(bool apply, bool /*Real*/) } } } + // Heroic Fury (Intercept cooldown remove) + if (apply && GetSpellProto()->Id == 60970 && m_target->GetTypeId() == TYPEID_PLAYER) + ((Player*)m_target)->RemoveSpellCooldown(20252, true); } void Aura::HandleModMechanicImmunityMask(bool apply, bool /*Real*/) regarding immobilization removing part, I think it works as it should (for more info on immobilization effect see : http://www.wowwiki.com/Root , http://www.allakhazam.com/wiki/root_%28wow%29)

Just posted So now post any feedback in This post please.

Changes applied as suggested by provided URL.

I won't work, it's like for mage arcane missiles, it's fine if you are alone and only with one mob around but when you're in raid or surrounded by many mobs you'll get an odd behaviour while casting: wrong target message o cast on another target or cast to caster itself too. The problem is well described here: -spell-target-type-77"]spell target type 77 the only way I found to make penance and arcane missile usable was using the channelling target: obviously this is another hack since the real problem is the current (bad) implementation of target type 77.

blueboy: http://getmangos.eu/community/showthread.php?12148-%5B9219%5D%5Bpatch%5D-Allow-configure-to-find-OpenSSL-if-pkg-config-fails

http://getmangos.eu/community/viewtopic.php?id=8695

I don't see why this values that are calculated every login shouldn't receive their own field... it would consume some space as a trade for cpu consuming. I'm wondering with the retail armory needs to calculate anything... :mellow: I know that this isn't MaNGOS problem directly... but... in some sort of way it is... I would like to see the blob expanded for the simplicity of reading the database... not to remove anything. Also hunuza made 3 important points! To learn do not need necessarily to be difficult!

It's related to this dagguh: http://getmangos.eu/community/viewtopic.php?id=5157

Further _discussion_ about development of mmaps please in a new thread, or with normal bug/patch reports Thank you all very much, mmaps are implemented in Revs 11901 up to 11919 About problems with the very implementation, see http://getmangos.eu/community/topic/17015/movemaps/

What bug does the patch fix? What features does the patch add? prevents crashes while the arenateam loading in Player::_LoadArenaTeamInfo we had ~30 crashes today with 600-700 players online tonight (in the morning maybe 100-200). INFO: i couldn't test this patch on my own server because i have no arenateams on it (only testserver, just me who's on it... from time to time 1 or 2 testers). and our serveradmin isn't here yet, so he couldn't test it too... For which SubVersion revision was the patch created? a5a0702376c222572e7b6c8c48b2cae975398ae3 (last 2.4.3 version, but should be the same in 3.0.3) Who has been writing this patch? Please include either forum user names or email addresses. DasBlub here is the commit in my git repo: http://github.com/DasBlub/mangos/commit/9f908e877d054ff9ab973082d631bb7199f292f6 here are the crashlogs: http://www.2shared.com/file/4503952/1778b8f/crashlogs_2008_12_22.html EDITH says that here is the bugreport: http://getmangos.eu/community/showthread.php?p=53233#post53233

I promise this will be the last time. I've explained how to build a MaNGOS server that many times to those who refuse to read through the threads. http://getmangos.eu/community/topic/8238/playerbot-archive/ or http://getmangos.eu/community/topic/16235/playerbot/ I will shortly update the first post as kennumen suggested and I hope no one will ask again. But once more for you These instructions will build a MaNGOS zero server, with playerbot code only (i.e no scripdev code). If your'e having issues, it's best to keep the build simple. Build again with scripdev code once your happy. First you need to create a portal_zero standalone patch. Use this bash script Now get a clean download of the MaNGOS zero core. copy the playerbot_zero.patch to the server folder. Then apply Then create the project by running this bash script Then build the server and then You will need to copy playerbot.conf.dist.in and mods.conf.dist.in to the -DSYSCONFDIR folder. Rename all files in this folder, removing the '.dist.in' part. Then configure the files to access the dbc/vmap/map data, the database data and the playerbot data. If these are configured correctly then both daemons (realmd & mangosd) should load & run without issue. botguy provides an alternative way to summon and dismiss your bots (apply the sql file to your mangos database and configure the option in playerbot.conf) Then you will find that many of the NPC (trainers etc...) will include an interactive menu for you to summon and dismiss your bots. EDIT: @ensiferum can you edit post #234 and remove your server.log Cheers Hope this helps

What features does the patch add? Auction house bot has 2 functionnality: - Automatically sell random items on auction house of the 3 factions. - Automatically buy item selled by real player. (under some condition) For which repository revision was the patch created? 11191 Is there a thread in the bug report section or at lighthouse? http://getmangos.eu/community/viewtopic.php?id=13676 Who has been writing this patch? Please include either forum user names or email addresses. Originally Created by ChrisK & Paradox Buyer functionality was added by Kerbe and Paradox After this the AHBot was maintained by Naicisum Xeross155 took over the maintenance/development until Naicisum returns and continues development (has he said) Me Here is the complete patch -> http://www.mediafire.com/file/tpyvyrq3aht43at/ahbot_11191.patch Here is the branch if you prefer -> http://github.com/cyberium/mangos/tree/new_ahbot Details Seller part: In a small server, see auction house completely empty can be a bit frustrating. This bot resolves this problem by randomly filling the auction house with items for sale. I think the administrator of the server keeps a lot of freedom with items type and quantity he wants to see in auction house. All options are detailed in the file ahbot.conf. Buyer part: Still in a small server, it is olso frustrating not being able to sell its objects. This bot gives this possibility. Of course we tried to make a minimum intelligence to simulate theses operation as close as possible to a real auction house. I am waiting any of your remark and still here to adapt some part of the code if needed. Stuff must be done to be MaNGOS compliant : - Code style doesn't meet MaNGOS standards (spaces, naming, braces) Work in progress... - Don't use public class variables. Done - Use typedefs for things like std::vector<std::vector<std::vector<uint32> > > Done - Use inheritance or singleton instead of AHB_Base* m_BaseConfig; Done - Use 'const' specifier where possible. Done Update - Patch updated with recent change (only code reorganised and cleaned no new function) - Just modified file reference to ahbot in some helping strings - Patch uodated for rev 11191

What bug does the patch fix? restores Savage Roar, being broken after switch to 3.0.8 For which repository revision was the patch created? master @ 1bf2e68b1b2aecc79eb84cfebc90543c5d9d0303 rev. 8312 Is there a thread in the bug report section or at lighthouse? http://getmangos.eu/community/viewtopic.php?id=7818 http://getmangos.eu/community/viewtopic.php?id=7030 http://getmangos.eu/community/viewtopic.php?id=6105 Who has been writing this patch? Sarjuuk Patch [Download] Notes You may also be interested in this addition, that limits Survival Instincts to Bear- and Cat-Form respectively. I refrain from posting it as a separate patch, because the remove is a bit ... ugly..? Like always, i did a rough test on both changes, with results as expected. Naturally, that does not guarantee anything Before someone asks.. Dash is not repairable in the same way, as it has no dummy triggering the real effect.

several threads about this already. http://getmangos.eu/community/search.php

What bug does the patch fix? What features does the patch add? allows stacking of dot parts of these spells For which repository revision was the patch created? 7940 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.php?id=2305 Who has been writing this patch? Please include either forum user names or email addresses. me - laise diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp index f06073e..d42b7c9 100644 --- a/src/game/SpellMgr.cpp +++ b/src/game/SpellMgr.cpp @@ -1256,6 +1256,17 @@ bool SpellMgr::IsNoStackSpellDueToSpell(uint32 spellId_1, uint32 spellId_2) cons if( (spellInfo_1->SpellFamilyFlags & UI64LIT(0x0000000000010000)) && (spellInfo_2->SpellVisual[0] == 72 && spellInfo_2->SpellIconID == 1499) || (spellInfo_2->SpellFamilyFlags & UI64LIT(0x0000000000010000)) && (spellInfo_1->SpellVisual[0] == 72 && spellInfo_1->SpellIconID == 1499) ) return false; + + // Living Bomb & Ignite (Dots) + if( (spellInfo_1->SpellFamilyFlags & UI64LIT(0x2000000000000)) && (spellInfo_2->SpellFamilyFlags & UI64LIT(0x8000000)) || + (spellInfo_2->SpellFamilyFlags & UI64LIT(0x2000000000000)) && (spellInfo_1->SpellFamilyFlags & UI64LIT(0x8000000)) ) + return false; + + // Fireball & Pyroblast (Dots) + if( (spellInfo_1->SpellFamilyFlags & UI64LIT(0x1)) && (spellInfo_2->SpellFamilyFlags & UI64LIT(0x400000)) || + (spellInfo_2->SpellFamilyFlags & UI64LIT(0x1)) && (spellInfo_1->SpellFamilyFlags & UI64LIT(0x400000)) ) + return false; + } // Detect Invisibility and Mana Shield (multi-family check) if( spellInfo_2->Id == 132 && spellInfo_1->SpellIconID == 209 && spellInfo_1->SpellVisual[0] == 968 )

MaNGOS/0.13.0 (* * Revision 7614 - *) Several crashes like this: Using host libthread_db library "/lib64/libthread_db.so.1". Core was generated by `/home/mangos/server/bin/mangos-worldd'. Program terminated with signal 11, Segmentation fault. #0 Unit::InterruptNonMeleeSpells (this=0x38c9f910, withDelayed=false, spell_id=0) at ../../../src/game/Spell.h:417 in ../../../src/game/Spell.h #0 Unit::InterruptNonMeleeSpells (this=0x38c9f910, withDelayed=false, spell_id=0) at ../../../src/game/Spell.h:417 No locals. #1 0x0000000000748380 in Unit::setDeathState (this=0x38c9f910, s=JUST_DIED) at ../../../src/game/Unit.cpp:9252 No locals. #2 0x00000000006b01c0 in Player::setDeathState (this=0x38c9f910, s=<value optimized out>) at ../../../src/game/Player.cpp:1384 ressSpellId = 0 cur = true #3 0x0000000000754d08 in Unit::DealDamage (this=0x2ee443b0, and one Using host libthread_db library "/lib64/libthread_db.so.1". Core was generated by `/home/mangos/server/bin/mangos-worldd'. Program terminated with signal 11, Segmentation fault. #0 Unit::InterruptSpell (this=0x2aab5ab61e00, spellType=3, withDelayed=true) at ../../../src/game/Spell.h:417 in ../../../src/game/Spell.h #0 Unit::InterruptSpell (this=0x2aab5ab61e00, spellType=3, withDelayed=true) at ../../../src/game/Spell.h:417 __PRETTY_FUNCTION__ = "void Unit::InterruptSpell(uint32, bool)" #1 0x00000000007382d2 in Unit::CastStop (this=0x2aab5ab61e00, except_spellid=0) at ../../../src/game/Unit.cpp:861 i = 605 #2 0x00000000006e51ec in Aura::HandleAuraModStun (this=0x393d21c0, apply=<value optimized out>, Real=<value optimized out>) at ../../../src/game/SpellAuras.cpp:3415 data = {<ByteBuffer> = {static DEFAULT_SIZE = 4096, _rpos = 48, _wpos = 46915449659496, _storage = {<std::_Vector_base<unsigned char,std::allocator<unsigned char> >> = { _M_impl = {<std::allocator<unsigned char>> = {<__gnu_cxx::new_allocator<unsigned char>> = {<No data fields>}, <No data fields>}, _M_start = 0x44725970 "2 ", _M_finish = 0x3e4174f9a0 "", _M_end_of_storage = 0x18 <Address 0x18 out of bounds>}}, <No data fields>}}, m_opcode = 12} spellType=3 is CURRENT_CHANNELED_SPELL So crash is the same in both cases if (m_currentSpells[CURRENT_CHANNELED_SPELL]->getState() != SPELL_STATE_FINISHED) m_currentSpells[CURRENT_CHANNELED_SPELL]->cancel(); [b] m_currentSpells[CURRENT_CHANNELED_SPELL]->SetReferencedFromCurrent(false);[/b] look like after m_currentSpells[CURRENT_CHANNELED_SPELL]->cancel(); pointer to Spell can be invalid and we able to get crash in m_currentSpells[CURRENT_CHANNELED_SPELL]->SetReferencedFromCurrent(false); Addition on Windows http://getmangos.eu/community/showpost.php?p=67976&postcount=42

I call code "from a bunch of authors" when I didn't yet care to investigate who the actual authorlist was. Especially for code I consider as bad. However a simple look into http://getmangos.eu/community/topic/9668 shows first patches from GriffonHeart, around end of 2009. Then a major change in this patch happened when Silverice implemented FarSight (which was at these times the major problem of the patch) So - without further investigation - I would assume original author of this patch was GriffonHeart, and most likely you (rsa) have been an author in the list of authors as well. Anyhow, please stop to claim every bit of code that you see here; It might be similar to code you published, this does not mean it was taken from you, and even it was taken from your repository it does not directly mean that you are to be considered author. At least don't assume hostility where there is none. In this very case here I can only tell that when I wrote "a bunch of authors" (and "author unknown" in the commit's message) I did not intend to discard anyone's work, but just to emphasize that I haven't investigated who did which work in which step of the patch or the problem. Also please relax more about these things - we all stand on the sholders of other people. Edit: To post at least on topic: When I looked into this problem, I didn't find a trace of a server-side spell, so I cannot conclude to this. (ofc maybe I forgot)

http://getmangos.eu/community/topic/10447/help-dalaran-cooking-daylies/ yeah this is a prob that exists long time ago, with auto-loot you get a semi-hack-fix ^^ but no real bugfix is there.

See more general bug fix for solution http://getmangos.eu/community/viewtopic.php?pid=127334#p127334