Auntie Mangos

Life Tap triggers this spell, which is spell effect energize, so it's not related to this patch. I think I've fixed it here, same with potions. Edit: There seems to be a bug with druids when they cast cat form. When you use it, energy "ticks" (in increments of 20) for a while before it begins to regen smoothly. I think it's because the "five second rule" is being applied after casting cat form, causing the server to remove the regenerate flag incorrectly.

2 As of patch 3.0.9 Mutilate damage against poisoned targets was reduced to 20% down from 50% Sources: wiki, patchnotes Who wrote it? me, Tequila 2 diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index 9f9505d..53a922d 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -4357,7 +4357,7 @@ void Spell::EffectWeaponDmg(uint32 i) } if(found) - totalDamagePercentMod *= 1.5f; // 150% if poisoned + totalDamagePercentMod *= 1.2f; // 120% if poisoned (3.0.9) } break; } Other infos: Other mutilate bug is that it still requires you to be behind the target. A fix was posted here.

Ok, added.

good idea! make a intance template, and relate to player, then make a custom item with sd2 script (transfer player or his friends in/out instance, do like a ticket). you can make a custom box with sd2 script (can put in something or take out something). now have two problem: 1) The map ID of the instance_template is relative to map.dbc. if instance_template's record befitted your room environment. if you add record in map.dbc, maybe raise client exception. 2) now wow client (2.4.1 8125) can not support custom item http://getmangos.eu/community/viewtopic.php?id=24021&st=0 i am troubling the second problem recently ! hope your success!

Water/Slime/Lava detection has been fixed as of vmap3 in mangos master and as of vmap3 backport + this patch in One/Zero. Breath timer refreshing while swimming (not underwater) has been fixed way before that.

You are right, Vladimir. Sorry for this, but it's still very intresting, since I'm trying to figure out how spell system and threat works. I will take a closer look on that later. Well then. I will try to improve the patch the next days, since this could be still useful for us. We could move discussion on topic back to http://getmangos.eu/community/topic/15271/bug-threat-calculation/page/2/ I think.

Of course it's possible.. you could do almost anything (use awesome spells and effects put on the latests armor sets and weapons.. and all that ).. but as Cyberfreak said it's a little hard at first to create a server and making it work. Have a look over the installation guides and find out for yourself http://getmangos.eu/community/viewforum.php?id=17

Use cyberium's patch from here.

My fault, didn't really search. Sorry for this. I see Schmoozerd version is way more complete 3 versions for this...at least it shows the community is active! *Trying to save myself* So please ignore my patch (http://getmangos.eu/community/viewtopic.php?id=14555 is more interesting)

try this: -Invisibility-remove-at-spell-cast"][patch] Invisibility remove at spell cast

think this could help gms which have to restore deleted characters: Don't delete chars finally git pull git://github.com/DasBlub/mangos.git no_char_delete Description Don't delete chars finally Author DasBlub Forum topic http://getmangos.eu/community/viewtopic.php?id=4394 is in developement, the min-level flag has no effect but i'll implement it today

this is proper place for bugreports. I know just when i was reporting that i thought its just me with this issue.

I assume this requires some procc flags as of patch http://getmangos.eu/community/topic/15283/dev-removal-of-auras-by-procflags/

On offy rabbits run away if attacked with dots, lol.

good screenshots, i dont know how create right documentation and screenshots on me project please say do you think about alterate on php ? http://getmangos.eu/community/viewtopic.php?id=10308&highlight=dbscript

Today compiled this patch with 10280. Normal... I recommend use patch from 74 post of this topic: http://getmangos.eu/community/viewtopic.php?id=7910&p=117127&viewfull=1#post117127 If it's don't help you I can post my patch (that I compiled today) again later... For 10283: diff --git a/src/game/Group.cpp b/src/game/Group.cpp index aa3cc94..393692e 100644 --- a/src/game/Group.cpp +++ b/src/game/Group.cpp @@ -346,6 +346,10 @@ bool Group::AddMember(const uint64 &guid, const char* name) uint32 Group::RemoveMember(const uint64 &guid, const uint8 &method) { + // Frozen Mod + BroadcastGroupUpdate(); + // Frozen Mod + // remove member and change leader (if need) only if strong more 2 members _before_ member remove if(GetMembersCount() > uint32(isBGGroup() ? 1 : 2)) // in BG group case allow 1 members group { @@ -1810,6 +1814,36 @@ void Group::_homebindIfInstance(Player *player) } } } +//Frozen Mod +void Group::BroadcastGroupUpdate(void) +{ + for(member_citerator citr = m_memberSlots.begin(); citr != m_memberSlots.end(); ++citr) + { + Player *pp = sObjectMgr.GetPlayer(citr->guid); + if(pp && pp->IsInWorld()) + { + pp->ForceValuesUpdateAtIndex(UNIT_FIELD_BYTES_2); + pp->ForceValuesUpdateAtIndex(UNIT_FIELD_FACTIONTEMPLATE); + DEBUG_LOG("-- Forced group value update for '%s'", pp->GetName()); + if(pp->GetPet()) + { + pp->GetPet()->ForceValuesUpdateAtIndex(UNIT_FIELD_BYTES_2); + pp->GetPet()->ForceValuesUpdateAtIndex(UNIT_FIELD_FACTIONTEMPLATE); + DEBUG_LOG("-- Forced group value update for '%s' pet '%s'", pp->GetName(), pp->GetPet()->GetName()); + } + for(uint32 i = 0; i < MAX_TOTEM_SLOT; ++i) + { + if(Unit *totem = Unit::GetUnit(*pp, pp->m_TotemSlot[i])) + { + totem->ForceValuesUpdateAtIndex(UNIT_FIELD_BYTES_2); + totem->ForceValuesUpdateAtIndex(UNIT_FIELD_FACTIONTEMPLATE); + DEBUG_LOG("-- Forced group value update for '%s' totem #%u", pp->GetName(), i); + } + } + } + } +} +// Frozen Mod static void RewardGroupAtKill_helper(Player* pGroupGuy, Unit* pVictim, uint32 count, bool PvP, float group_rate, uint32 sum_level, bool is_dungeon, Player* not_gray_member_with_max_level, Player* member_with_max_level, uint32 xp ) { diff --git a/src/game/Group.h b/src/game/Group.h index 85efa1c..2f436a3 100644 --- a/src/game/Group.h +++ b/src/game/Group.h @@ -375,6 +375,10 @@ class MANGOS_DLL_SPEC Group InstanceGroupBind* GetBoundInstance(uint32 mapId, Player* player); InstanceGroupBind* GetBoundInstance(Map* aMap, Difficulty difficulty); BoundInstancesMap& GetBoundInstances(Difficulty difficulty) { return m_boundInstances[difficulty]; } + + // Frozen Mod + void BroadcastGroupUpdate(void); + // Frozen Mod protected: bool _addMember(const uint64 &guid, const char* name, bool isAssistant=false); diff --git a/src/game/GroupHandler.cpp b/src/game/GroupHandler.cpp index c432d4a..2f6df07 100644 --- a/src/game/GroupHandler.cpp +++ b/src/game/GroupHandler.cpp @@ -207,6 +207,10 @@ void WorldSession::HandleGroupAcceptOpcode( WorldPacket & recv_data ) // everything is fine, do it, PLAYER'S GROUP IS SET IN ADDMEMBER!!! if(!group->AddMember(GetPlayer()->GetGUID(), GetPlayer()->GetName())) return; + + // Frozen Mod + group->BroadcastGroupUpdate(); + // Frozen Mod } void WorldSession::HandleGroupDeclineOpcode( WorldPacket & /*recv_data*/ ) diff --git a/src/game/Object.cpp b/src/game/Object.cpp index 9b25096..1e90052 100644 --- a/src/game/Object.cpp +++ b/src/game/Object.cpp @@ -662,6 +662,54 @@ void Object::BuildValuesUpdate(uint8 updatetype, ByteBuffer * data, UpdateMask * else *data << (m_uint32Values[ index ] & ~UNIT_DYNFLAG_TAPPED); } + + // Frozen Mod + else if(index == UNIT_FIELD_BYTES_2 || index == UNIT_FIELD_FACTIONTEMPLATE) + { + bool ch = false; + + if((GetTypeId() == TYPEID_PLAYER || GetTypeId() == TYPEID_UNIT) && target != this) + { + bool forcefriendly = false; // bool for pets/totems to offload more code from the big if below + + if(GetTypeId() == TYPEID_UNIT) + { + forcefriendly = (((Creature*)this)->isTotem() || ((Creature*)this)->isPet()) + && ((Creature*)this)->GetOwner()->GetTypeId() == TYPEID_PLAYER + && ((Creature*)this)->GetOwner()->IsFriendlyTo(target) // pet owner must be friendly to target + && ((Creature*)this)->GetOwner() != target // no need to send hackfix to pet owner + && (target->IsInSameGroupWith((Player*)((Creature*)this)->GetOwner()) || target->IsInSameRaidWith((Player*)((Creature*)this)->GetOwner())); + } + + if(((Unit*)this)->IsSpoofSamePlayerFaction() || forcefriendly || (target->GetTypeId() == TYPEID_PLAYER && GetTypeId() == TYPEID_PLAYER && (target->IsInSameGroupWith((Player*)this) || target->IsInSameRaidWith((Player*)this)))) + { + if(index == UNIT_FIELD_BYTES_2) + { + DEBUG_LOG("-- VALUES_UPDATE: Sending '%s' the blue-group-fix from '%s' (flag)", target->GetName(), ((Unit*)this)->GetName()); + *data << ( m_uint32Values[ index ] & (UNIT_BYTE2_FLAG_SANCTUARY << 8) ); // this flag is at uint8 offset 1 !! + ch = true; + } + else if(index == UNIT_FIELD_FACTIONTEMPLATE) + { + FactionTemplateEntry const *ft1, *ft2; + ft1 = ((Unit*)this)->getFactionTemplateEntry(); + ft2 = ((Unit*)target)->getFactionTemplateEntry(); + + if(ft1 && ft2 && (!ft1->IsFriendlyTo(*ft2) || ((Unit*)this)->IsSpoofSamePlayerFaction())) + { + uint32 faction = ((Player*)target)->getFaction(); // pretend that all other HOSTILE players have own faction, to allow follow, heal, rezz (trade wont work) + DEBUG_LOG("-- VALUES_UPDATE: Sending '%s' the blue-group-fix from '%s' (faction %u)", target->GetName(), ((Unit*)this)->GetName(), faction); + *data << uint32(faction); + ch = true; + } + } + } + } + + if(!ch) + *data << m_uint32Values[ index ]; + } + // Frozen Mod else { // send in current format (float as float, uint32 as uint32) @@ -1664,6 +1712,21 @@ Creature* WorldObject::SummonCreature(uint32 id, float x, float y, float z, floa return pCreature; } +// Frozen Mod +void Object::ForceValuesUpdateAtIndex(uint32 i) +{ + m_uint32Values_mirror[i] = GetUInt32Value(i) + 1; // makes server think the field changed + if(m_inWorld) + { + if(!m_objectUpdated) + { + AddToClientUpdateList(); + m_objectUpdated = true; + } + } +} +// Frozen Mod + namespace MaNGOS { class NearUsedPosDo diff --git a/src/game/Object.h b/src/game/Object.h index c900e4d..4e8063a 100644 --- a/src/game/Object.h +++ b/src/game/Object.h @@ -288,6 +288,11 @@ class MANGOS_DLL_SPEC Object virtual bool hasQuest(uint32 /* quest_id */) const { return false; } virtual bool hasInvolvedQuest(uint32 /* quest_id */) const { return false; } + + // Frozen Mod + void ForceValuesUpdateAtIndex(uint32); + // Frozen Mod + protected: Object ( ); diff --git a/src/game/TradeHandler.cpp b/src/game/TradeHandler.cpp index 6abb061..8fb7f64 100644 --- a/src/game/TradeHandler.cpp +++ b/src/game/TradeHandler.cpp @@ -604,11 +604,13 @@ void WorldSession::HandleInitiateTradeOpcode(WorldPacket& recvPacket) return; } - if (pOther->GetTeam() !=_player->GetTeam() ) + // Frozen Mod + /* if (pOther->GetTeam() !=_player->GetTeam() ) { SendTradeStatus(TRADE_STATUS_WRONG_FACTION); return; - } + } */ + // Frozen Mod if (!pOther->IsWithinDistInMap(_player,10.0f,false)) { diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 1d38c35..309c474 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -242,6 +242,10 @@ Unit::Unit() // remove aurastates allowing special moves for(int i=0; i < MAX_REACTIVE; ++i) m_reactiveTimer[i] = 0; + + // Frozen Mod + m_spoofSamePlayerFaction = false; + // Frozen Mod } Unit::~Unit() diff --git a/src/game/Unit.h b/src/game/Unit.h index 37cb495..9508fb9 100644 --- a/src/game/Unit.h +++ b/src/game/Unit.h @@ -1885,6 +1885,11 @@ class MANGOS_DLL_SPEC Unit : public WorldObject PetAuraSet m_petAuras; void AddPetAura(PetAura const* petSpell); void RemovePetAura(PetAura const* petSpell); + + // Frozen Mod + inline void SetSpoofSamePlayerFaction(bool b) { m_spoofSamePlayerFaction = b; } + inline bool IsSpoofSamePlayerFaction(void) {return m_spoofSamePlayerFaction; } + // Frozen Mod // Movement info MovementInfo m_movementInfo; @@ -1937,8 +1942,12 @@ class MANGOS_DLL_SPEC Unit : public WorldObject uint32 m_reactiveTimer[MAX_REACTIVE]; uint32 m_regenTimer; uint32 m_lastManaUseTimer; + + // Frozen Mod + bool m_spoofSamePlayerFaction : 1; + // Frozen Mod - private: + public: void CleanupDeletedAuras(); // player or player's pet

Ok now I see this is related to the following post. http://getmangos.eu/community/showthread.php?13138-%5B9606%5D-Causes-client-freezes Sorry for this.

Medicated, I suggest taking a strong dose, take the day off, and go do some reading: http://getmangos.eu/community/forumdisplay.php?17-Installation-Configuration-Upgrades Everything you need to know can be found there, if not there is a handy search tool as well. :lol:

Mangos Version: 9110 Custom Patches: ahbot, playerbot, vehicle SD2 Version: 1532 Database Name and Version : UDB Rev. 386 How it SHOULD work: Trinket Lifestone (833). Equip: Restores 10 health every 5 sec. Should stop restoring HP, when dead. How it DOES work: Continues restoring HP, even when player dead. Player is immediately is visible alive with 10, 20, next 30 HP and so on, but cannot be resurrected anymore, cannot move and is really dead. Only to way to solve this, is relogin as ghost and go to corpse. Don`t know if there problems with other "gaining +hp" trinkets as well, because of thread http://getmangos.eu/community/showthread.php?6106-[sql-fix][9007]-Engineering-Trinkets-PPM. Regards warrior

What bug does the patch fix? What features does the patch add? This fixes the bug that potions and other such energize effects make the client display twice as much of a gain, sometimes resulting in "not enough mana/energy/rage/etc" because the client thinks it has more than it does. For which repository revision was the patch created? 7887 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. See posts #8 and 9 here. Who has been writing this patch? Please include either forum user names or email addresses Myself ModifyPower has a call to SetPower, which tells the client to set its mana value to the value the server has after the amount energized is added. When it calls SendEnergizeSpellLog afterward, the client adds the amount energized a second time. Switching calls to ModifyPower and SendEnergizeSpellLog around fixes this problem. Patch

Possibly related: http://getmangos.eu/community/topic/17058/fixed-in-11857bug-druid-trainers/ fix @ master: https://github.com/mangos/mangos/commit/9f52382558bace0a28fbacbaff17e9c5d2c61dba fix @ one: https://github.com/mangos-one/server/commit/e6f35a0c93130786dfddc5e77a83f2c845e5f3cd

You people should read more ... those forums are full of answers to "no! stay with SVN!", mine as well: http://getmangos.eu/community/viewtopic.php?id=4159

Hi Syenet, In order for me to troubleshoot this issue, I need some information from you? Can you describe your system more (i.e MaNGOS version, which repo are you getting playerbot from and any other mods installed). Can you describe your raid group (i.e 1 player and 9 bots or any other combination). I have briefly looked at your crash dump. This is what currently runs on my box; MaNGOS[11106], playerbot from https://github.com/blueboy/portal, ahbot[Naiscisum] from https://github.com/blueboy/ahbot, Move Maps [faramir118 & Team], vellums [Lynx3d] patch. I have searched my code for the keyword _Tset_traits and found nothing. I suspect something else is causing the crash. The 'Unknown' name issue is an annoyance that very occasionally occurs and is not caused by playerbot. I thought this issue had been resolved in the core as I have not seen it for a long time. A dirty fix for this is to logout, delete your client cache, and then login again. If it occurs regularly on your server, try building the server without playerbot to check this out (In the past, summoned creatures for Warlocks and Hunters have had 'Unknown' names).http://getmangos.eu/community/viewtopic.php?id=14049 Please get back to me

* waiting 24 hours for an answer might be acceptable if we talk about paid support, but these forums are no paid support. It's called user supported. * Your issue description lacks precision. Are we talking about two physcial machines here, or one machine with two worldserver instances? Both could result in different issues. The mangos community is probably one of the oldest and friendliest places to be, and take note that we have a code of conduct which you accepted by registering an account. Thus: nothing is wrong with us. We are just not sitting here 24 hours waiting for desperate help requests. We would probably if someone would pay us for

using this thread as a reference: http://getmangos.eu/community/viewtopic.php?id=7839 wget [url]https://unifieddb.svn.sourceforge.net/svnroot/unifieddb/trunk/Full_DB/UDB_0.11.6_Core_8734_SD2_1480.rar[/url] [url]https://sd2-acid.svn.sourceforge.net/svnroot/sd2-acid/trunk/wotlk/3.0.1/3.0.1_acid.sql[/url] --no-check-certificate;unrar e UDB*; is giving me 100%[======================================>] 2,208,991 251K/s in 8.3s 2010-09-19 19:01:43 (261 KB/s) - `3.0.1_acid.sql.2' saved [2208991/2208991] FINISHED --2010-09-19 19:01:43-- Downloaded: 1 files, 2.1M in 8.3s (261 KB/s) unrar: invalid archive 'e': Bad address Usage: unrar [OPTION...] ARCHIVE [FILE...] [DESTINATION] Try `unrar --help' or `unrar --usage' for more information. Help?