Auntie Mangos

This has already been discussed. One topic is sufficient.

I've coded two patches to fix both the issue in the title and the tauren changing their skin-tones at the barbershop. Important links I've come through: Druid Forms underdev List of Hair/Skin vs Model Texture My Tauren Barbershop fix thread It supports rev [10148] as of now. Tauren Barbershop fix: Paste2 Druid shapeshifts: Paste2 The second patch needs the first.

@nyko: That's what MaNGOS devs want, before they'll ever add ahbot to the git master branch. The way I understand it, the current ahbot uses the character as a kind of workaround. MaNGOS doesn't want workarounds in the master branch, for maintaining and/or stability reasons (mainly to have a clean solution, instead of a "hacky" one). The idea in this thread is, if this patch should be included it has to follow mangos coding standards, meaning get rid of characters dependency. Neo2003 #72 of this thread: click VladimirMangos #951 of old ahbot thread: click There is no reason in further discussing if it's needed to remove the character dependency or if MaNGOS guidelines are the "ultima ratio". The way it is right now, is the MaNGOS way. It's their software - that we are allowed to use - that's why they make the rules. Right now ahbot works with minimalload update and even w/o it (if I understand xeross155's commits correctly). Regards Skirnir

Is it related to this post? http://getmangos.eu/community/showthread.php?12148-[9219][patch]-Allow-configure-to-find-OpenSSL-if-pkg-config-fails

Hello all, I started a few weeks ago with some pet fixies. I know, it is too hacky Comments and ideas are welcome What bug does the patch fix? What features does the patch add? Problems what I tried fix: * Warlock pet doesn't has a corpse. * Pets, summons, guardians and totems doesn't have properly FFA flag in FFA areas. * Pets are temporary unsummoned while is owner mounted in arena. * Warlock pet health, mana calculation is outdated. (I took coef from tc2 :-/ thx to nesocip) * Dead pets are revived after mount and dismount. * Warlock pet doesn't stay on login screen and it credit soulshard after logout. * Out of range dismiss doesn't work. * Some problem with summon, unsummon pets while enter/leave arena. * Reset Pet spell cooldown if pet die Revision: 8518 Branch: http://github.com/corfen/mangos/tree/pets Patch: http://pastebin.com/f72706fed Some TODO: + Warlock pet should have a saved health and mana while warlock mouted (after dismount warlock pet has full hp & mana instead hp, mana before warlock mounted). + After hunter's pet dies call pet should not work, hunter has to use Revive Pet. - Correct pet spell damage calculation. ( thx pasdVn and ApoC http://getmangos.eu/community/viewtopic.php?id=7233 ) Corfen =)

I try it, but it doesnt't work... I get this error: read error: **** Is A Directory for casalla: You that work?

See more general bug fix for solution http://getmangos.eu/community/viewtopic.php?pid=127334#p127334

state is open now... "Rockbiter Weapon should not apply to both weapon" https://mangos.lighthouseapp.com/projects/18208/tickets/637-rockbiter-weapon-should-not-apply-to-both-weapon it's have been fixed by Rev. 10636, at here http://getmangos.eu/community/viewtopic.php?id=15517

Hello, i am trying to update this patch: http://getmangos.eu/community/viewtopic.php?id=2433&highlight=darkmoon Can anyone tell me where to start? Like if there's a tutorial for updating patch code, or an faq. Any tips appreciated! Thanks

Use this: http://getmangos.eu/community/showthread.php?10618-Auto-Announcer-with-NextID-and-MangChat-support or http://getmangos.eu/community/showthread.php?13438-Autoanouncer-autobroadcast

http://getmangos.eu/community/showthread.php?6434-XML-Output&highlight=wowstat links old but i'm forun xmlstat on my pc http://dl.dropbox.com/u/4367350/xmlstat.zip may be some one update it to latest rev

/ignore Jriske

What bug does the patch fix? What features does the patch add? - This patch would fix the bug that after being queued due to playerlimit addons are not loaded. For which repository revision was the patch created? - 7579 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. - http://getmangos.eu/community/viewtopic.php?id=7228 diff --git a/src/game/World.cpp b/src/game/World.cpp index 22ae03f..4392803 100644 --- a/src/game/World.cpp +++ b/src/game/World.cpp @@ -226,6 +226,8 @@ World::AddSession_ (WorldSession* s) if(decrease_session) --Sessions; + s->SendAddonsInfo(); + if (pLimit > 0 && Sessions >= pLimit && s->GetSecurity () == SEC_PLAYER ) { AddQueuedPlayer (s); @@ -242,7 +244,6 @@ World::AddSession_ (WorldSession* s) packet << uint8 (s->Expansion()); // 0 - normal, 1 - TBC, must be set in database manually for each account s->SendPacket (&packet); - s->SendAddonsInfo(); UpdateMaxSessionCounters (); // Updates the population Patchfile

What bug does the patch fix? What features does the patch add? Leader can reset instance while member is still on it but logged off. After members relog he keep their positions so that permit to bypass all trash. With this patch, no reset is possible if any members is on instance leader try to reset. For which repository revision was the patch created? latest Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. found this old http://getmangos.eu/community/topic/11614/exploit-to-reset-instance/ Who has been writing this patch? Please include either forum user names or email addresses. me Patch: Last one http://paste2.org/p/1889282 Old version only for ref http://paste2.org/p/1885673 diff --git a/src/game/Group.cpp b/src/game/Group.cpp index e0cd4a6..c6f1b36 100644 --- a/src/game/Group.cpp +++ b/src/game/Group.cpp @@ -1168,6 +1168,7 @@ bool Group::_addMember(ObjectGuid guid, const char* name, bool isAssistant, uint member.name = name; member.group = group; member.assistant = isAssistant; + member.lastMap = player->GetMapId(); m_memberSlots.push_back(member); SubGroupCounterIncrease(group); @@ -1667,6 +1668,18 @@ bool Group::InCombatToInstance(uint32 instanceId) return false; } +bool Group::SetPlayerMap(const ObjectGuid guid, uint32 mapid) +{ + member_witerator slot = _getMemberWSlot(guid); + if (slot != m_memberSlots.end()) + { + slot->lastMap = mapid; + DEBUG_LOG("Group::SetPlayerMap> map is updated"); + return true; + } + return false; +} + void Group::ResetInstances(InstanceResetMethod method, bool isRaid, Player* SendMsgTo) { if(isBGGroup()) @@ -1677,6 +1690,20 @@ void Group::ResetInstances(InstanceResetMethod method, bool isRaid, Player* Send // we assume that when the difficulty changes, all instances that can be reset will be Difficulty diff = GetDifficulty(isRaid); + OfflineMapList offlineMapList; // to store map of offline players + + if ((method == INSTANCE_RESET_ALL) || (method == INSTANCE_RESET_CHANGE_DIFFICULTY)) + { + // build offline members Map list. For instance reset check. + for(member_citerator itr = m_memberSlots.begin(); itr != m_memberSlots.end(); ++itr) + { + Player* plr = ObjectAccessor::FindPlayer(itr->guid); + // add map from offline player in the list. + if (!plr) + offlineMapList.push_back(itr->lastMap); // add map from that player + } + } + for(BoundInstancesMap::iterator itr = m_boundInstances[diff].begin(); itr != m_boundInstances[diff].end() { DungeonPersistentState *state = itr->second.state; @@ -1701,7 +1728,20 @@ void Group::ResetInstances(InstanceResetMethod method, bool isRaid, Player* Send // if the map is loaded, reset it if (Map *map = sMapMgr.FindMap(state->GetMapId(), state->GetInstanceId())) if (map->IsDungeon() && !(method == INSTANCE_RESET_GROUP_DISBAND && !state->CanReset())) - isEmpty = ((DungeonMap*)map)->Reset(method); + { + // check if there is offline members + if (!offlineMapList.empty()) + for (OfflineMapList::iterator mapItr=offlineMapList.begin(); mapItr!=offlineMapList.end();mapItr++) + if ((*mapItr)==map->GetId()) // check if mapId of one offline member is the same as one we want to reset + { + // if at least one of offline player is in map consider map not empty + isEmpty=false; + break; + } + // now check if online players are in map + if (isEmpty) + isEmpty = ((DungeonMap*)map)->Reset(method); + } if (SendMsgTo) { diff --git a/src/game/Group.h b/src/game/Group.h index b674389..1e0f219 100644 --- a/src/game/Group.h +++ b/src/game/Group.h @@ -195,6 +195,7 @@ class MANGOS_DLL_SPEC Group std::string name; uint8 group; bool assistant; + uint32 lastMap; }; typedef std::list<MemberSlot> MemberSlotList; typedef MemberSlotList::const_iterator member_citerator; @@ -203,7 +204,7 @@ class MANGOS_DLL_SPEC Group protected: typedef MemberSlotList::iterator member_witerator; typedef std::set<Player*> InvitesList; - + typedef std::list<uint32> OfflineMapList; typedef std::vector<Roll*> Rolls; public: @@ -339,6 +340,8 @@ class MANGOS_DLL_SPEC Group void RewardGroupAtKill(Unit* pVictim, Player* player_tap); + bool SetPlayerMap(const ObjectGuid guid, uint32 mapid); + /*********************************************************/ /*** LOOT SYSTEM ***/ /*********************************************************/ diff --git a/src/game/MiscHandler.cpp b/src/game/MiscHandler.cpp diff --git a/src/game/Player.cpp b/src/game/Player.cpp index bffcaad..f3ce03f 100644 --- a/src/game/Player.cpp +++ b/src/game/Player.cpp @@ -1659,6 +1659,8 @@ bool Player::TeleportTo(uint32 mapid, float x, float y, float z, float orientati DEBUG_LOG("Player %s is being teleported to map %u", GetName(), mapid); } + if (Group* grp = GetGroup()) + grp->SetPlayerMap(GetObjectGuid(), mapid); // if we were on a transport, leave if (!(options & TELE_TO_NOT_LEAVE_TRANSPORT) && m_transport) {

I found an old patch from theneromancer that might help you out: http://getmangos.eu/community/viewtopic.p...p;hl=buff+stack

hmm i think you can modify the Guild Housing Patch by SinnerG (Link) if i have time i will make (i need it too but im lazy). this shouldnt be hard!

Yes, I know... Use patch from 86 post...

Hello i use PvP and PvP announce system from Darkrulez - http://getmangos.eu/community/showthread.php?8952-PvPToken-System&p=115872&highlight=#post115872 I when compiling i have errors ... 2>..\\..\\src\\game\\Unit.cpp(692) : error C2065: 'player_tap' : undeclared identifier 2>..\\..\\src\\game\\Unit.cpp(692) : error C2227: left of '->getLevel' must point to class/struct/union/generic type 2> type is ''unknown-type'' 2>..\\..\\src\\game\\Unit.cpp(694) : error C2065: 'player_tap' : undeclared identifier 2>..\\..\\src\\game\\Unit.cpp(694) : error C2227: left of '->ReceiveToken' must point to class/struct/union/generic type 2> type is ''unknown-type'' 2>..\\..\\src\\game\\Unit.cpp(700) : error C2065: 'player_tap' : undeclared identifier 2>..\\..\\src\\game\\Player.cpp(21406) : error C2039: 'ReceiveToken' : is not a member of 'Player' 2> c:\\users\\glararan\\desktop\\new mangos\\9839\\src\\game\\Player.h(1022) : see declaration of 'Player' 2>..\\..\\src\\game\\Player.cpp(21413) : error C3861: 'InBattleGround': identifier not found 2>..\\..\\src\\game\\Player.cpp(21413) : error C3861: 'HasByteFlag': identifier not found 2>..\\..\\src\\game\\Player.cpp(21414) : error C3861: 'HasByteFlag': identifier not found 2>..\\..\\src\\game\\Player.cpp(21415) : error C3861: 'InBattleGround': identifier not found 2>..\\..\\src\\game\\Player.cpp(21422) : error C3861: 'CanStoreNewItem': identifier not found 2>..\\..\\src\\game\\Player.cpp(21425) : error C3861: 'SendEquipError': identifier not found 2>..\\..\\src\\game\\Player.cpp(21429) : error C3861: 'StoreNewItem': identifier not found 2>..\\..\\src\\game\\Player.cpp(21430) : error C3861: 'SendNewItem': identifier not found 2>..\\..\\src\\game\\Player.cpp(21432) : error C2673: 'ReceiveToken' : global functions do not have 'this' pointers 2>..\\..\\src\\game\\Player.cpp(21432) : error C2228: left of '.PSendSysMessage' must have class/struct/union i use 9839 rev Win 7 os -- Visual C++ 2008 all patches from his PvP and announce i use

check http://getmangos.eu/community/viewtopic.php?id=8927 and see if it helps

What bug does the patch fix? What features does the patch add? Fix to the Druid's Predatory Strikes Talent. It was only providing the lvl attack bonus (50/100/150%). Included weapon feral attack power % ( 7,14,20 ) bonus to it. For which repository revision was the patch created? 8440 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. I found this thread ( http://getmangos.eu/community/viewtopic.php?id=9062 ). There is a patch sugestion and it should work as well, but it seemed a little bit misplaced for, so I'd rather put alongside with the first parameter treatment. Who has been writing this patch? Please include either forum user names or email addresses. Me File: src/game/StatSystem.cpp @@ -292,38 +292,44 @@ void Player::UpdateAttackPowerAndDamage(bool ranged ) case CLASS_SHAMAN: val2 = level*2.0f + GetStat(STAT_STRENGTH) + GetStat(STAT_AGILITY) - 20.0f; break; case CLASS_DRUID: { //Check if Predatory Strikes is skilled float mLevelMult = 0.0; + uint16 mBonusWeaponAtt = 0.0; switch(m_form) { case FORM_CAT: case FORM_BEAR: case FORM_DIREBEAR: - case FORM_MOONKIN: +// case FORM_MOONKIN: { Unit::AuraList const& mDummy = GetAurasByType(SPELL_AURA_DUMMY); for(Unit::AuraList::const_iterator itr = mDummy.begin(); itr != mDummy.end(); ++itr) { // Predatory Strikes (effect 0) if ((*itr)->GetEffIndex()==0 && (*itr)->GetSpellProto()->SpellIconID == 1563) { mLevelMult = (*itr)->GetModifier()->m_amount / 100.0f; - break; } + // Predatory Strikes (effect 1) + else if ((*itr)->GetEffIndex()==1 && (*itr)->GetSpellProto()->SpellIconID == 1563) + { + mBonusWeaponAtt = (*itr)->GetModifier()->m_amount * m_baseFeralAP / 100.0f; + break; + } } break; } } switch(m_form) { case FORM_CAT: - val2 = getLevel()*(mLevelMult+2.0f) + GetStat(STAT_STRENGTH)*2.0f + GetStat(STAT_AGILITY) - 20.0f + m_baseFeralAP; break; + val2 = getLevel()*(mLevelMult+2.0f) + GetStat(STAT_STRENGTH)*2.0f + GetStat(STAT_AGILITY) - 20.0f + m_baseFeralAP + mBonusWeaponAtt; break; case FORM_BEAR: case FORM_DIREBEAR: - val2 = getLevel()*(mLevelMult+3.0f) + GetStat(STAT_STRENGTH)*2.0f - 20.0f + m_baseFeralAP; break; + val2 = getLevel()*(mLevelMult+3.0f) + GetStat(STAT_STRENGTH)*2.0f - 20.0f + m_baseFeralAP + mBonusWeaponAtt; break; case FORM_MOONKIN: val2 = getLevel()*(mLevelMult+1.5f) + GetStat(STAT_STRENGTH)*2.0f - 20.0f + m_baseFeralAP; break; default: val2 = GetStat(STAT_STRENGTH)*2.0f - 20.0f; break; }

http://getmangos.eu/community/viewtopic.php?id=7568

i think it can be useful\\ screen partially on english - http://cs4559.vkontakte.ru/u15551257/92678536/x_29d703a9.jpg programm - http://getmangos.eu/community/viewtopic.php?id=10308&highlight=dbscript

Similar patch in http://getmangos.eu/community/viewtopic.php?id=11315 without author. So possible author is you. In any case applied rewrited version.

you can also use my easy gdb debugging guide if you are too lazy debugging manually http://getmangos.eu/community/viewtopic.php?id=10606&highlight=easy

tested on 309 last bug mentioned in post 17 stell exist