Auntie Mangos

You can't find the post, while it's only about 5 below yours. http://getmangos.eu/community/showthread.php?13715-README-What-if-ERROR-Table-db_version-have-field-required_%28etc%29-but-expected...

What bug does the patch fix? What features does the patch add? fixes Quick Shots proc from Improved Aspect of the Hawk talent when using Aspect of Dragonhawk For which repository revision was the patch created? 9112 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/showthread.php?9810-[8429][bug]-Improved-aspect-of-the-hawk Who has been writing this patch? Please include either forum user names or email addresses. Me INSERT INTO spell_chain VALUES (61846, 0, 61846, 1, 0); INSERT INTO spell_chain VALUES (61847, 61846, 61846, 2, 0); delete from `spell_proc_event` where `entry` in (61846, 61847); insert into `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) values('61846','0','9','1','0','0','0','0','0','0','0');

What bug does the patch fix? What features does the patch add? fixes Combustion For which repository revision was the patch created? 9095 Is there a thread in the bug report section or at lighthouse? http://getmangos.eu/community/showthread.php?11559-[bUG]Combustion-9909 Who has been writing this patch? Please include either forum user names or email addresses. Me diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 1d3c734..656350a 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -12179,6 +12179,7 @@ void Unit::ProcDamageAndSpellFor( bool isVictim, Unit * pTarget, uint32 procFlag case SPELL_AURA_MANA_SHIELD: case SPELL_AURA_PERIODIC_DUMMY: case SPELL_AURA_OBS_MOD_MANA: + case SPELL_AURA_ADD_PCT_MODIFIER: case SPELL_AURA_DUMMY: { sLog.outDebug("ProcDamageAndSpell: casting spell id %u (triggered by %s dummy aura of spell %u)", spellInfo->Id,(isVictim?"a victim's":"an attacker's"), triggeredByAura->GetId());

What bug does the patch fix? What features does the patch add? implements harmful magic effects duration reduce For which repository revision was the patch created? 8912 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.php?id=7393 Who has been writing this patch? Please include either forum user names or email addresses. me diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 00ade17..ff2e4aa 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -295,7 +295,7 @@ pAuraHandler AuraHandler[TOTAL_AURAS]= &Aura::HandleUnused, //242 SPELL_AURA_MOD_SPELL_DAMAGE_FROM_HEALING (only 2 test spels in 3.2.2a) &Aura::HandleNULL, //243 faction reaction override spells &Aura::HandleComprehendLanguage, //244 SPELL_AURA_COMPREHEND_LANGUAGE - &Aura::HandleNULL, //245 SPELL_AURA_MOD_DURATION_OF_MAGIC_EFFECTS + &Aura::HandleNoImmediateEffect, //245 SPELL_AURA_MOD_DURATION_OF_MAGIC_EFFECTS implemented in Unit::CalculateSpellDuration &Aura::HandleNoImmediateEffect, //246 SPELL_AURA_MOD_DURATION_OF_EFFECTS_BY_DISPEL implemented in Unit::CalculateSpellDuration &Aura::HandleNULL, //247 target to become a clone of the caster &Aura::HandleNoImmediateEffect, //248 SPELL_AURA_MOD_COMBAT_RESULT_CHANCE implemented in Unit::RollMeleeOutcomeAgainst diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 7414823..1fc1391 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -10962,6 +10962,11 @@ int32 Unit::CalculateSpellDuration(SpellEntry const* spellProto, uint8 effect_in durationMod_always+=target->GetTotalAuraModifierByMiscValue(SPELL_AURA_MOD_DURATION_OF_EFFECTS_BY_DISPEL, spellProto->Dispel); // Find max mod (negative bonus) int32 durationMod_not_stack = target->GetMaxNegativeAuraModifierByMiscValue(SPELL_AURA_MECHANIC_DURATION_MOD_NOT_STACK, mechanic); + + if (!IsPositiveSpell(spellProto->Id)) + { + // only for harmful effects + Unit::AuraList const& modAuras = target->GetAurasByType(SPELL_AURA_MOD_DURATION_OF_MAGIC_EFFECTS); + for(Unit::AuraList::const_iterator itr = modAuras.begin(); itr != modAuras.end(); ++itr) + if(spellProto->DmgClass == (*itr)->GetMiscValue()) + durationMod_always += (*itr)->GetModifier()->m_amount; + } int32 durationMod = 0; // Select strongest negative mod or diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 00ade17..ff2e4aa 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -295,7 +295,7 @@ pAuraHandler AuraHandler[TOTAL_AURAS]= &Aura::HandleUnused, //242 SPELL_AURA_MOD_SPELL_DAMAGE_FROM_HEALING (only 2 test spels in 3.2.2a) &Aura::HandleNULL, //243 faction reaction override spells &Aura::HandleComprehendLanguage, //244 SPELL_AURA_COMPREHEND_LANGUAGE - &Aura::HandleNULL, //245 SPELL_AURA_MOD_DURATION_OF_MAGIC_EFFECTS + &Aura::HandleNoImmediateEffect, //245 SPELL_AURA_MOD_DURATION_OF_MAGIC_EFFECTS implemented in Unit::CalculateSpellDuration &Aura::HandleNoImmediateEffect, //246 SPELL_AURA_MOD_DURATION_OF_EFFECTS_BY_DISPEL implemented in Unit::CalculateSpellDuration &Aura::HandleNULL, //247 target to become a clone of the caster &Aura::HandleNoImmediateEffect, //248 SPELL_AURA_MOD_COMBAT_RESULT_CHANCE implemented in Unit::RollMeleeOutcomeAgainst diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 7414823..1fc1391 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -10962,6 +10962,11 @@ int32 Unit::CalculateSpellDuration(SpellEntry const* spellProto, uint8 effect_in durationMod_always+=target->GetTotalAuraModifierByMiscValue(SPELL_AURA_MOD_DURATION_OF_EFFECTS_BY_DISPEL, spellProto->Dispel); // Find max mod (negative bonus) int32 durationMod_not_stack = target->GetMaxNegativeAuraModifierByMiscValue(SPELL_AURA_MECHANIC_DURATION_MOD_NOT_STACK, mechanic); + + if (!IsPositiveSpell(spellProto->Id)) + durationMod_always += target->GetTotalAuraModifierByMiscValue(SPELL_AURA_MOD_DURATION_OF_MAGIC_EFFECTS, spellProto->DmgClass); int32 durationMod = 0; // Select strongest negative mod idk if it should reduce duration of auras that are already on player and if it should restore back original duration if it is removed before harmful effect is expired.(I will add this part if it does) also IsPositiveSpell can be replaced by IsPositiveEffect but i haven't tested it enough to say that it is ok

What bug does the patch fix? What features does the patch add? This fixes the bug that some hunter traps can proc on their owners when a second trap is summoned. For which repository revision was the patch created? 8183 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.php?id=8961 Who has been writing this patch? Please include either forum user names or email addresses. Myself Using an obj->Delete causes the object to lose its OwnerGUID too early (prior to 8102, the Delete wasn't calling CleanupsBeforeDelete). So instead, the obsolete trap should just be set to GO_JUST_DEACTIVATED and be cleaned up after it finishes the next update procedure call. diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index d0843e6..151968b 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -5677,7 +5677,7 @@ void Spell::EffectSummonObject(uint32 i) if( m_caster ) obj = m_caster->GetMap()->GetGameObject(guid); - if(obj) obj->Delete(); + if(obj) obj->SetLootState(GO_JUST_DEACTIVATED); m_caster->m_ObjectSlot[slot] = 0; }

That is for reading in-game email which is something microManager already does IIRC there have been updates to that query as well. Always best to check SQLCode.vb for the latest. I don't remember specifically. Something about the way mangos inserts new mails. I know there was a proposed patch some time ago that would fix this issue, but it never made it in (since it would only be valuable to external projects and not mangos itself). EDIT: Here is the previous patch - http://getmangos.eu/community/viewtopic.php?id=1312&highlight=ingame+mail

Hi, I have some small problems compiling mangos on my root-server (debian etch amd64). First of all, running "autoreconf --install --force" gives me several messages. But as they are only warnings, it should not matter, or?Okay, following the guide at the first post in this thread, I got an error while running "make": It seems, that the libtool script file in /opt/mangos-src/objdir/dep/ACE_wrappers is somehow "wrong". I had a look at the mentioned codelines and found out, that the problem is here:/opt/mangos-src/objdir/dep/ACE_wrappers/libtool at line 812 The arguments are processed like commands (which also the error message states), but I have no idea how to overcome this. On my home machine (and small mini-itx x86) with debian etch, it runs without the warnings at autoreconf, and compiles without errors. Setup is almost the same. I also setup an virtual installation with help of VirtualBox. VBox runs on a 64bit quadcore system. There I configured an 64bit environment, again with Debian Etch, and also there there is no warning at autoreconf and nor error during compile-time. Maybe someone can give me a hint why it's not compiling on my root-server (amd dual core, 64bit, debian etch). best regards, Alex P.S. (sorry for the post in http://getmangos.eu/community/showthread.php?p=57583. I saw too late that this is an "old" thread). I found out, that the libtool file created in VirtualBox is different from the one created on my root-server. I copied the file to the root-server and replaced the "wrong" one. Now make runs.. seems to run without errors. Can someone explain me why the file is different from machine A to machine B? Both are running the same OS, and both are 64bit ... The working one has 213kbyte, the wrong one 212kbyte.

You guys should try http://getmangos.eu/community/viewtopic.php?id=23805 .. It replaces a lot of code that appeared in some of the freeze/crash logs so it might help..

Hi Guys, A few weeks ago I mentioned that I was working on a revision to help complete 'source item' type quests. http://getmangos.eu/community/post/134150/#p134150 These are quest where you are provided with an item (e.g empty bottle), with the quest objective to fill it. I have just pushed the patch to portal master Example of use [Three] whispers: my incomplete quests are: [Zenn's Bidding] use [Jade Phial] on [Crown of the Earth] Then travel to the objectives location with [Three] and [Three] should then have a [Filled Jade Phial] in it's inventory and a completed quest. Hope this helps

You can edit Network.Threads in mangosd.conf Also, if you would like, you can test my async network sockets, from this thread. There are expected to be performance benefits (also no connection limits under windows)

I have also made a SQL updater in Python which will actually check for the last update and then apply any after that. http://getmangos.eu/community/topic/15590/python-yet-another-script-for-sql-updates/ So Windows batch scripts can run on Linux and bash scripts can run on Windows? And before saying "install bash" why not "install Python"? Python is still a better cross-platform solution. It has a standard language that runs on every platform Python supports (pretty much all of them.) Shell scripts have many different languages for many different platforms.

Are you moking me ? ... users get an error message at login saying ... No, users are not in my network (Facebook, Twiter etc... joke!). They are users that have an account in realm.account table. In some unidentify case, SOME users ( not all ) get an error message at login saying : Login server down Only when Jupiter is in house 7 and Mars is in house 9 ( see astrology for detail ). Seriously, i dont think that "the time of the day" make a differents. Upgrading the client from 2.4.3 to 3.3.3 ( 11723 ), in some case(why i dont know) you have to remove all the 2.4.3 accounts from the "wtf/Accounts/" folder. anywayz... my guess is that it's a client side issue. My bad for posting here. I must apaulagize for sounding rude, I was pretty sure my question was clear enough for a reply and not a "please hold the line". I also get this naked player error too. one last thing, sorry again ! V0.16-* is not supported yet, until it's finished. will hush my self now Keep up the good work peps !

This patch does what you want: http://getmangos.eu/community/showthread.php?1710-[patch]new-Announce-System

Veretos Question #2 Answer: http://getmangos.eu/community/viewtopic.php?id=4579 Tested, working simple apt-get install gdb create a file restart.sh in the /opt/mangos directory or where you have the bin, etc, directories of mangos compilated, give execute permission #!/bin/bash ############### # About: Auto restart mangos-worldd on crash & generate crash log ############### # 1. Compile MaNGOS with parameter: --with-debug-info # 2. Put auto_restarter.sh into compiled mangos directory (where folders: bin/, lib/, etc/) # 3. (Only once): chmod +x auto_restarter.sh # 4. Usage: ./auto_restarter.sh -c etc/mangosd.conf # p.s. Make sure you have "gdb" installed. ############### # config: # path to mangos-worldd binary daemon=./bin/mangos-worldd # system export LD_LIBRARY_PATH=.:lib:$LD_LIBRARY_PATH if [ "`ulimit -c`" -eq 0 ]; then ulimit -c unlimited fi while true do MANGOS=`ps -el | grep mangos-worldd` $daemon $* if [ -z "$MANGOS" ]; then gdb $daemon core.* --batch --eval-command="bt ful" > crash.log dte=`date +%F_%H-%M-%S` mkdir crash_$dte mv crash.log crash_$dte/ mv log/Server.log crash_$dte/ mv core.* crash_$dte/ fi sleep 2 done you can run the file by ./restart.sh or "screen -A -m -d -S mangosd /opt/mangos/restart.sh" if chose screen method you can view or terminate the mangos by "screen -r mangosd" then CTRL C or if you only want watch you can exit with CTRL A + D and mangos is still runing in the screen named mangosd Hope this will help you as help me

I think we should handle the evading and similar stuff in SelectHostileTarget. We can do: * Skip not-reachable enemies as tanks * control an evade timer * add a param to not evade by default (ie for a boss like gothik where the encounter starts the first few minutes without any enemy in accessible place an idea about something that is handled similar: (also would be easy to extend to the above points) http://getmangos.eu/community/viewtopic.php?id=15188

There is a database listed in this thread that may suit your needs. Hope it helps: http://getmangos.eu/community/viewtopic.php?id=84 edit: it looks like udb forums are down. here's the TBCDB on github. http://github.com/DasBlub/TBCDB

Thank you. Maybe should someone correct the tutorial : http://getmangos.eu/community/showthread.php?4011-How-to-compile-MaNGOS-on-Linux-%28-Using-GIT-%29

I've created a branch on github, which contains very simple warden implementation for mangos (unrelated to Neo2003 implementation) developed by zhenya and me in March, 2010. It uses only one module and can run on any platform.

Look here: http://getmangos.eu/community/viewtopic.php?id=11400&p=104250&viewfull=1#post104250 This is a lot better solution then mine - which can be rejected now. This way it can be handled like: http://pastebin.com/10uTzK6b thx to KAPATEJIb

yes, i saw it. this is an original icon and i just need it in a scalable format, without reinvention of bicycles) i don't think that horde or alliance flags are good choice for server. Anyone can use it under cc-by-sa license please, host it permanently anywhere, i haven't found any hosting for svg.

http://www.wowhead.com/spell=53042 What does mixology do? * doubles (*2) duration off all flasks and elixirs * increase effect of any flask/elixir * all above happens only if you are able to make this flask/elixir 1. fix of double duration is in topic (not my work!)http://getmangos.eu/community/showthread.php?11752 diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index 0b6737a..1503512 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -2568,6 +2568,20 @@ void Spell::EffectApplyAura(uint32 i) return; } + if(caster->GetTypeId() == TYPEID_PLAYER && Aur->GetSpellProto()->SpellFamilyName == SPELLFAMILY_POTION + && caster->HasAura(53042)) + { + SpellSpecific spellSpec = GetSpellSpecific(Aur->GetSpellProto()->Id); + if(spellSpec == SPELL_BATTLE_ELIXIR || spellSpec == SPELL_GUARDIAN_ELIXIR || spellSpec == SPELL_FLASK_ELIXIR) + { + if(caster->HasSpell(Aur->GetSpellProto()->EffectTriggerSpell[0])) + { + duration *= 2.0f; + } + } + } + if(duration != Aur->GetAuraMaxDuration()) { Aur->SetAuraMaxDuration(duration); (i dont know if it is hacky, but it works) 2. In topic http://getmangos.eu/community/showthread.php?11752 was proved, that bonuses needs to be hardcoded somewhere and client has nothing to do with them. Because they show only in stats tab of character window. Ideal place for this is "spell_elixir" table in UDB. Why? Becouse there are only two columns used (ID of elixir/flask spell, and type (battle/guardian/flask). I have nearly accurate data for all flasks/elixirs from retail servers. So its no problem for me to create "value_1", "type_1","value_2", "type_2" (few flasks/elixir have more than one bonus) columns with accurate values. But working with mangos core and understanding its principles is realy hard for me. So im looking to somebody who has better mangos experience and understanding and can implement this to the core. I dont know how to make mangos understand what is in table, and how to add it to the player. 3. I realy dont know how to implement this, needs some love from experienced developer

If you use patch which cause the crash - please, post in topic of that patch... Dual Spec patch was updated... http://getmangos.eu/community/showthread.php?8580-Dual-Talent-Specializations&p=101346#post101346

Problem with those Talents below is, that alle pet spells have the same SpellFamilyMask (and SpellFamilyName Hunter), so that we need to check the procSpell in addition. Don't know why blizz didn't gave them extra flags if they even introduced pet's own SpellFamilyName :-/ Improved Cower (http://www.wowhead.com/?spell=53180): No Problem at all with this hardcoded Check. Guard Dog (http://www.wowhead.com/?spell=53178): The Proc isn't a problem neighter but the increased aggro, as we can't add a spellmod to the owner because of the already mentioned spellfamilyflags. A more easy sollution is just to add additional threat to the target in HandleDummyAurasProc() but the more mangos like way is my suggested sollution, as I think. Silverback (http://www.wowhead.com/?spell=62764): Also no problem with additionally check. Patch: http://github.com/pasdVn/mangos/commit/bc222160313c2f8decb21f616d3dd4e439b235e2 SQL part is needed, because all those dummy auras don't have any procflags. Quite strange, as normally, dummy auras used for procing other spells, have them. Maybe this is also a hint to implement them in another way (e.g. just hardcode in the spelleffects of the triggering spells) but I liked the idea more, to handle them with the trigger system: /*Improved Cower*/ DELETE FROM `spell_proc_event` WHERE entry IN (53180, 53181); INSERT INTO `spell_proc_event` (`entry` ,`SchoolMask` ,`SpellFamilyName` ,`SpellFamilyMask0` ,`SpellFamilyMask1` ,`SpellFamilyMask2` ,`procFlags` ,`procEx` ,`ppmRate` ,`CustomChance` ,`Cooldown`) VALUES ('53180', '0', '9', '0', '268435456', '0', '16', '0', '0', '0', '0'), ('53181', '0', '9', '0', '268435456', '0', '16', '0', '0', '0', '0'); /*Guard Dog*/ DELETE FROM `spell_proc_event` WHERE entry IN (53178, 53179); INSERT INTO `spell_proc_event` (`entry` ,`SchoolMask` ,`SpellFamilyName` ,`SpellFamilyMask0` ,`SpellFamilyMask1` ,`SpellFamilyMask2` ,`procFlags` ,`procEx` ,`ppmRate` ,`CustomChance` ,`Cooldown`)VALUES ('53178', '0', '9', '0', '268435456', '0', '65536', '0', '0', '0', '0'), ('53179', '0', '9', '0', '268435456', '0', '65536', '0', '0', '0', '0'); /*Silverback*/ DELETE FROM `spell_proc_event` WHERE entry IN (62764, 62765); INSERT INTO `spell_proc_event` (`entry` ,`SchoolMask` ,`SpellFamilyName` ,`SpellFamilyMask0` ,`SpellFamilyMask1` ,`SpellFamilyMask2` ,`procFlags` ,`procEx` ,`ppmRate` ,`CustomChance` ,`Cooldown`)VALUES ('62764', '0', '9', '0', '268435456', '0', '65536', '0', '0', '0', '0'), ('62765', '0', '9', '0', '268435456', '0', '65536', '0', '0', '0', '0'); Note: Proc of "Guard Dog" will only work with : http://getmangos.eu/community/viewtopic.php?id=6469

Did anything ever happen with bugreportaddon: index.php/topic,16068.0.html/?

Can you restore http://getmangos.eu/community/viewtopic.php?id=2433 also?