Auntie Mangos

sry wrong part or forum. i am posted my problem at: http://getmangos.eu/community/viewtopic.php?id=14599 Thanks for help !!!

http://getmangos.eu/community/showthread.php?9033-%5B8044%5D-Fishing-in-Dalaran&p=80206&viewfull=1#post80206 and updated to rev 9558 patch from this thread http://paste2.org/p/709210 I hope it will help you

What bug does the patch fix? What features does the patch add? fixes proc for 67356 For which repository revision was the patch created? 9619 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/showthread.php?12818-[bUG]-Idol-of-Flaring-Growth Who has been writing this patch? Please include either forum user names or email addresses. me delete from `spell_proc_event` where `entry`=67356; insert into `spell_proc_event` values (67356, 0x00, 7, 0x00000010, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0.000000, 0.000000, 0);

Exactly the same problem.. Install TBB libs ... Here is a howto: http://getmangos.eu/community/showthread.php?12771-How-to-use-custom-ACE-and-TBB-libs-without-screwing-the-one-already-installed-on-your

in fact, I have post a patch in under review to fix that. http://getmangos.eu/community/viewtopic.php?id=7545

As soon as we announce it. As usual the Announcements & News will contain an announcement for client support changes.

Yeah, I just submitted a support ticket now, I am going to see what their response is, I am also going to link this thread in the ticket and wait for a reply Edit: BTW, can someone recommend me another VPS provider if this one doesn't work? Will keep the thread updated with their reply

There is now an announcement topic which will contain the current status.

Or just clone my branch and pull mangos master on top of it. Continue discussion here(And use the version from this thread) here: http://getmangos.eu/community/viewtopic.php?id=10618

http://getmangos.eu/community/viewtopic.php?id=8580

10 seconds of searching would have answerewd this, THE most asked question in the history of most asked questions. You missed some SQL updates Read one of the MANY excellent GiT guides posted on the forum (written by Freghar).

What bug does the patch fix? What features does the patch add? This patch implements the dummy effect of Pandemic, warlock talent http://www.wowhead.com/?spell=58437 For which repository revision was the patch created? 7454 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.php?id=6119 Who has been writing this patch? Please include either forum user names or email addresses. Me (Corfen) patch: diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index e933d29..8e1135c 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -5045,6 +5045,21 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu triggered_spell_id = 37378; break; } + //Pandemic proc + case 58435: + case 58436: + case 58437: + { + float chance = 0.0f; // I don't know how to get spell crit rating better o_O + chance += ((Player*)this)->GetSpellCritFromIntellect(); + chance += ((Player*)this)->GetTotalAuraModifier(SPELL_AURA_MOD_SPELL_CRIT_CHANCE); + chance += ((Player*)this)->GetRatingBonusValue(CR_CRIT_SPELL); + if (!roll_chance_f(chance)) + return false; + basepoints0 = int32(damage*triggerAmount/100); + triggered_spell_id = 58691; + break; + } } break; } I don't know how to get spell crit chance in better way =/

this patch produces smaller vmaps (even if it's not the main goal). I still use it with a 2.4.3 branch.

no problem, nothing personally, btw this guy http://getmangos.eu/community/member.php?u=3717 has those patches on his signature

i was looking somewhere to find where speed increasement are handled to fix crusader aura ( http://getmangos.eu/community/viewtopic.php?id=23821 ) with flying mount, and i found this in unit.cpp line 8280: switch(mtype) { case MOVE_WALK: data.Initialize(MSG_MOVE_SET_WALK_SPEED, 8+4+1+4+4+4+4+4+4+4); break; case MOVE_MOUNTED: case MOVE_RUN: data.Initialize(MSG_MOVE_SET_RUN_SPEED, 8+4+1+4+4+4+4+4+4+4); break; case MOVE_WALKBACK: data.Initialize(MSG_MOVE_SET_RUN_BACK_SPEED, 8+4+1+4+4+4+4+4+4+4); break; case MOVE_SWIM: data.Initialize(MSG_MOVE_SET_SWIM_SPEED, 8+4+1+4+4+4+4+4+4+4); break; case MOVE_SWIMBACK: data.Initialize(MSG_MOVE_SET_SWIM_BACK_SPEED, 8+4+1+4+4+4+4+4+4+4); break; case MOVE_TURN: data.Initialize(MSG_MOVE_SET_TURN_RATE, 8+4+1+4+4+4+4+4+4+4); break; case MOVE_FLY: data.Initialize(MSG_MOVE_SET_FLY_SPEED, 8+4+1+4+4+4+4+4+4+4); break; case MOVE_FLYBACK: data.Initialize(MSG_MOVE_SET_FLY_BACK_SPEED, 8+4+1+4+4+4+4+4+4+4); break; default: sLog.outError("Unit::SetSpeed: Unsupported move type (%d), data not sent to client.",mtype); return; } i saw that we're missing case MOVE_MOUNTED and so i searched in opcodes.h line 236 and we can see that we're missing a MSG_MOVE_SET_ something with mount. why?

after recent replace build system, you need use cmake for mangos build instead autoconf/etc. at Unix. http://getmangos.eu/community/post/131751/#p131751

Nothing Special, something like this. http://getmangos.eu/community/viewtopic.php?id=14551 Fixe some Gylphen with 3 line of Code or maybe more.

In reference to http://getmangos.eu/community/showthread.php?p=49627#post49627 Ads the following subcommands to .pinfo: .pinfo account [account name] looks up account info & characters .pinfo character [character name] looks up character info .pinfo ip [ip address] looks up account(s) belonging to ip-address Code probably need lots of cleaning up, don't blame me lol, i started with c++ yesterday written for revision 8078 Patch: diff --git a/src/game/Chat.cpp b/src/game/Chat.cpp index 3444776..af4f749 100644 --- a/src/game/Chat.cpp +++ b/src/game/Chat.cpp @@ -363,6 +363,15 @@ ChatCommand * ChatHandler::getCommandTable() { NULL, 0, false, NULL, "", NULL } }; + static ChatCommand pinfoCommandTable[] = + { + { "account", SEC_GAMEMASTER, true, &ChatHandler::HandlePInfoAccountCommand, "", NULL }, + { "character", SEC_GAMEMASTER, true, &ChatHandler::HandlePInfoCharacterCommand, "", NULL }, + { "ip", SEC_GAMEMASTER, true, &ChatHandler::HandlePInfoIpCommand, "", NULL }, + { "", SEC_GAMEMASTER, true, &ChatHandler::HandlePInfoCommand, "", NULL }, + { NULL, 0, false, NULL, "", NULL } + }; + static ChatCommand questCommandTable[] = { { "add", SEC_ADMINISTRATOR, false, &ChatHandler::HandleQuestAdd, "", NULL }, @@ -628,7 +637,7 @@ ChatCommand * ChatHandler::getCommandTable() { "maxskill", SEC_ADMINISTRATOR, false, &ChatHandler::HandleMaxSkillCommand, "", NULL }, { "setskill", SEC_ADMINISTRATOR, false, &ChatHandler::HandleSetSkillCommand, "", NULL }, { "whispers", SEC_MODERATOR, false, &ChatHandler::HandleWhispersCommand, "", NULL }, - { "pinfo", SEC_GAMEMASTER, true, &ChatHandler::HandlePInfoCommand, "", NULL }, + { "pinfo", SEC_GAMEMASTER, true, NULL, "", pinfoCommandTable }, { "respawn", SEC_ADMINISTRATOR, false, &ChatHandler::HandleRespawnCommand, "", NULL }, { "send", SEC_MODERATOR, true, NULL, "", sendCommandTable }, { "loadscripts", SEC_ADMINISTRATOR, true, &ChatHandler::HandleLoadScriptsCommand, "", NULL }, diff --git a/src/game/Chat.h b/src/game/Chat.h index 18ef9cc..80bb19f 100644 --- a/src/game/Chat.h +++ b/src/game/Chat.h @@ -295,6 +295,11 @@ class ChatHandler bool HandlePDumpLoadCommand(const char *args); bool HandlePDumpWriteCommand(const char *args); + bool HandlePInfoAccountCommand(const char* args); + bool HandlePInfoCharacterCommand(const char* args); + bool HandlePInfoIpCommand(const char* args); + bool HandlePInfoCommand(const char* args); + bool HandleQuestAdd(const char * args); bool HandleQuestRemove(const char * args); bool HandleQuestComplete(const char * args); @@ -445,7 +450,6 @@ class ChatHandler bool HandleGUIDCommand(const char* args); bool HandleItemMoveCommand(const char* args); bool HandleDeMorphCommand(const char* args); - bool HandlePInfoCommand(const char* args); bool HandleMuteCommand(const char* args); bool HandleUnmuteCommand(const char* args); bool HandleMovegensCommand(const char* args); diff --git a/src/game/Language.h b/src/game/Language.h index e1c15fb..e2fa4d2 100644 --- a/src/game/Language.h +++ b/src/game/Language.h @@ -777,6 +777,11 @@ enum MangosStrings // 10000-10999 // Use for custom patches 11000-11999 + LANG_PINFO_CHARS = 11000, + LANG_PINFO_ACCOUNT_ACCOUNT = 11001, + LANG_PINFO_CHARACTER = 11002, + LANG_PINFO_IP = 11003, + LANG_ACCOUNT_NOT_FOUND = 11004, // NOT RESERVED IDS 12000-1999999999 // `db_script_string` table index 2000000000-2000009999 (MIN_DB_SCRIPT_STRING_ID-MAX_DB_SCRIPT_STRING_ID) diff --git a/src/game/Level2.cpp b/src/game/Level2.cpp index 7489cc8..fd123bd 100644 --- a/src/game/Level2.cpp +++ b/src/game/Level2.cpp @@ -2098,6 +2098,282 @@ bool ChatHandler::HandleModifyPhaseCommand(const char* args) return true; } +//show info of account +bool ChatHandler::HandlePInfoAccountCommand(const char* args) +{ + if(!*args) + return false; + + uint32 accId = 0; + std::string username = (char*)args; + std::string last_ip = GetMangosString(LANG_ERROR); + uint32 security = 0; + std::string last_login = GetMangosString(LANG_ERROR); + std::string email = GetMangosString(LANG_ERROR); + std::string joindate = GetMangosString(LANG_ERROR); + uint32 banned = 0; + std::string isbanned = GetMangosString(LANG_ERROR); + + QueryResult* result = loginDatabase.PQuery("SELECT username,gmlevel,last_ip,last_login,account.id,email,joindate,account_banned.id as bannedid,account_banned.active as banactive FROM account LEFT JOIN account_banned ON account.id = account_banned.id WHERE username = '%s'",username.c_str()); + if(result) + { + Field* fields = result->Fetch(); + username = fields[0].GetCppString(); + security = fields[1].GetUInt32(); + + if(!m_session || m_session->GetSecurity() >= security) + { + last_ip = fields[2].GetCppString(); + last_login = fields[3].GetCppString(); + } + else + { + last_ip = "-"; + last_login = "-"; + } + + accId = fields[4].GetUInt32(); + email = fields[5].GetCppString(); + joindate = fields[6].GetCppString(); + banned = fields[8].GetUInt32(); + if(banned > 0) + { + isbanned = "Yes"; + } + else + { + isbanned = "No"; + } + + delete result; + } + else + { + SendSysMessage(LANG_ACCOUNT_NOT_FOUND); + SetSentErrorMessage(true); + return false; + } + + //Characters + std::string playerChars; + uint32 count = 0; + result = CharacterDatabase.PQuery("SELECT name, account, guid, level FROM characters WHERE account = '%u'",accId); + if(result) + { + count = result->GetRowCount(); // Number of chars + for(int i = 0; i < count ; i++) + { + Field *fields = result->Fetch(); + + //Convert id to string + std::string cId; + std::stringstream ss; + ss << fields[2].GetUInt32(); + cId = ss.str(); + //Convert level to string + std::string pLevel; + std::stringstream ss2; + ss2 << fields[3].GetUInt32(); + pLevel = ss2.str(); + + //Make character line: Charname[level] (id: guid) - + std::string charLink = playerLink(fields[0].GetCppString()); + playerChars += charLink; + playerChars += '['; + playerChars += pLevel.c_str(); + playerChars += "] "; + playerChars += "(id: "; + playerChars += cId.c_str(); + playerChars += ')'; + playerChars += " - ";//Break apart different chars + + result->NextRow(); + } + + delete result; + } + else + { + playerChars = "No characters found"; + } + + + PSendSysMessage(LANG_PINFO_ACCOUNT_ACCOUNT, username.c_str(), accId, security, last_ip.c_str(), last_login.c_str(), email.c_str(), joindate.c_str(), isbanned.c_str()); + PSendSysMessage(LANG_PINFO_CHARS, count, playerChars.c_str()); + + return true; +} + +//show info of character +bool ChatHandler::HandlePInfoCharacterCommand(const char* args) +{ + if(!*args) + return false; + + uint32 total_player_time = 0; + uint32 level = 0; + uint32 money = 0; + uint32 accId = 0; + uint32 leveltime = 0; + uint32 guid = 0; + std::string name = (char*)args; + uint32 race = 0; + uint32 pclass = 0; + uint32 online = 0; + std::string isonline = "(Offline)"; + + QueryResult *result = CharacterDatabase.PQuery("SELECT totaltime, level, money, account, leveltime, guid, name, race, class, online FROM characters WHERE name = '%s'", name.c_str()); + if (result) + { + Field *fields = result->Fetch(); + total_player_time = fields[0].GetUInt32(); + level = fields[1].GetUInt32(); + money = fields[2].GetUInt32(); + accId = fields[3].GetUInt32(); + leveltime = fields[4].GetUInt32(); + guid = fields[5].GetUInt32(); + name = fields[6].GetCppString(); + race = fields[7].GetUInt32(); + pclass = fields[8].GetUInt32(); + online = fields[9].GetUInt32(); + if(online > 0) + isonline = "(Online)"; + + delete result; + } + else + { + SendSysMessage(LANG_PLAYER_NOT_FOUND); + SetSentErrorMessage(true); + return false; + } + + std::string username = GetMangosString(LANG_ERROR); + std::string last_ip = GetMangosString(LANG_ERROR); + uint32 security = 0; + std::string last_login = GetMangosString(LANG_ERROR); + std::string joindate = GetMangosString(LANG_ERROR); + + result = loginDatabase.PQuery("SELECT username,gmlevel,last_ip,last_login,id,joindate FROM account WHERE id = '%u'",accId); + if(result) + { + Field* fields = result->Fetch(); + username = fields[0].GetCppString(); + security = fields[1].GetUInt32(); + + if(!m_session || m_session->GetSecurity() >= security) + { + last_ip = fields[2].GetCppString(); + last_login = fields[3].GetCppString(); + } + else + { + last_ip = "-"; + last_login = "-"; + } + + accId = fields[4].GetUInt32(); + joindate = fields[5].GetCppString(); + + delete result; + } + else + { + SendSysMessage(LANG_ACCOUNT_NOT_FOUND);//Char has no account? + SetSentErrorMessage(true); + return false; + } + + uint32 gold = money /GOLD; + uint32 silv = (money % GOLD) / SILVER; + uint32 copp = (money % GOLD) % SILVER; + std::string timeStr = secsToTimeString(total_player_time,true,true); + std::string timeStr2 = secsToTimeString(leveltime,true,true); + + std::string charLink = playerLink(name.c_str()); + + PSendSysMessage(LANG_PINFO_CHARACTER, charLink.c_str(), isonline.c_str(), guid, race, pclass, gold, silv, copp, username.c_str(), accId, security, joindate.c_str(), last_ip.c_str(), last_login.c_str(), timeStr.c_str(), timeStr2.c_str() ); + + return true; +} + +//show info of IP +bool ChatHandler::HandlePInfoIpCommand(const char* args) +{ + if(!*args) + return false; + + std::string last_ip = (char*)args; + std::string ipAccounts; + uint32 count = 0; + std::string last_login = GetMangosString(LANG_ERROR); + + QueryResult* result = loginDatabase.PQuery("SELECT username,last_ip,last_login,account.id,online,account_banned.id as bannedid,account_banned.active as banactive FROM account LEFT JOIN account_banned ON account.id = account_banned.id WHERE last_ip = '%s' ORDER BY last_login ASC",last_ip.c_str()); + if(result) + { + count = result->GetRowCount(); // Number of accounts + for(int i = 0; i < count ; i++) + { + uint32 banned = 0; + std::string isBanned; + uint32 online = 0; + std::string isOnline; + Field *fields = result->Fetch(); + + //Checking for a online account + online = fields[4].GetUInt32(); + if(online > 0) + { + isOnline = "(ONLINE) "; + } + else + { + isOnline = ""; + } + + //Checking for a banned account + banned = fields[6].GetUInt32(); + if(banned > 0) + { + isBanned = "(BANNED) "; + } + else + { + isBanned = ""; + } + + //Convert id to string + std::string cId; + std::stringstream ss; + ss << fields[3].GetUInt32(); + cId = ss.str(); + + //Make account line: Account (id: id) *(banned) - + ipAccounts += fields[0].GetCppString(); + ipAccounts += " (id: "; + ipAccounts += cId.c_str(); + ipAccounts += ") "; + ipAccounts += isOnline; + ipAccounts += isBanned; + ipAccounts += "- ";//Break apart different accounts + last_login = fields[2].GetCppString();//Replace with last data ( latest last online ) + result->NextRow(); + } + + delete result; + } + else + { + SendSysMessage(LANG_ACCOUNT_NOT_FOUND); + SetSentErrorMessage(true); + return false; + } + + PSendSysMessage(LANG_PINFO_IP, last_ip.c_str(), last_login.c_str(), ipAccounts.c_str()); + + return true; +} + //show info of player bool ChatHandler::HandlePInfoCommand(const char* args) { @@ -2129,6 +2405,10 @@ bool ChatHandler::HandlePInfoCommand(const char* args) // get additional information from DB else { + //check for valid args + if(!*args) + return false; + // check offline security if (HasLowerSecurity(NULL, target_guid)) return false; @@ -2172,6 +2452,49 @@ bool ChatHandler::HandlePInfoCommand(const char* args) delete result; } + //Characters + std::string playerChars; + uint32 count = 0; + result = CharacterDatabase.PQuery("SELECT name, account, guid, level FROM characters WHERE account = '%u'",accId); + if(result) + { + count = result->GetRowCount(); // Number of chars + for(int i = 0; i < count ; i++) + { + Field *fields = result->Fetch(); + + //Convert id to string + std::string cId; + std::stringstream ss; + ss << fields[2].GetUInt32(); + cId = ss.str(); + //Convert level to string + std::string pLevel; + std::stringstream ss2; + ss2 << fields[3].GetUInt32(); + pLevel = ss2.str(); + + //Make character line: Charname[level] (id: guid) - + std::string charLink = playerLink(fields[0].GetCppString()); + playerChars += charLink; + playerChars += '['; + playerChars += pLevel.c_str(); + playerChars += "] "; + playerChars += "(id: "; + playerChars += cId.c_str(); + playerChars += ')'; + playerChars += " - ";//Breakup Chars + + result->NextRow(); + } + + delete result; + } + else + { + playerChars = "No characters found"; + } + std::string nameLink = playerLink(target_name); PSendSysMessage(LANG_PINFO_ACCOUNT, (target?"":GetMangosString(LANG_OFFLINE)), nameLink.c_str(), GUID_LOPART(target_guid), username.c_str(), accId, security, last_ip.c_str(), last_login.c_str(), latency); @@ -2181,10 +2504,10 @@ bool ChatHandler::HandlePInfoCommand(const char* args) uint32 silv = (money % GOLD) / SILVER; uint32 copp = (money % GOLD) % SILVER; PSendSysMessage(LANG_PINFO_LEVEL, timeStr.c_str(), level, gold,silv,copp ); + PSendSysMessage(LANG_PINFO_CHARS, count, playerChars.c_str());//Account characters return true; } - //show tickets void ChatHandler::ShowTicket(uint64 guid, char const* text, char const* time) { SQL: INSERT INTO `mangos_string` (`entry`, `content_default`, `content_loc1`, `content_loc2`, `content_loc3`, `content_loc4`, `content_loc5`, `content_loc6`, `content_loc7`, `content_loc8`) VALUES (11004, 'Account not found!', NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL), (11003, 'IP: %s Last login: %s\\r\\nAccount(s): %s', NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL), (11002, 'Player: %s %s (id: %u) Race: %u Class: %u Money: %ug%us Account: %s (id: %u) GMLevel: %u Join date: %s Last IP: %s Last login: %s Total time: %s Time this level: %s', NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL), (11001, 'Account: %s (id: %u) GMLevel: %u Last IP: %s Last login: %s Email: %s Join date: %s Banned: %s', NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL), (11000, 'Accounts characters (%u):\\r\\n%s', NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL); http://www.rvdev.net/pinfo2.patch http://www.rvdev.net/mangos_mangos_string.sql *right click, save as duhh

I tried 1400 users without any vmaps. Slightly less spelllag but still noticeable. I'd really like to know where that stuff is coming from... With mtmaps the mainthread mostly ranks around 70% cpu usage, so not really overloaded. @throneinc Those patches above are Derex mtmaps patch. I adapted the version from that trinity patch collection and it's working fine. Anticheat: http://getmangos.eu/community/viewtopic.php?id=4404 @Poe What's your playercount?

What bug does the patch fix: Missing proc for spell 38139 For which SubVersion revision was the patch created? 6528 Thread in the bug report section: http://getmangos.eu/community/viewtopic.php?id=28159 Who has been writing this patch?: Malah INSERT INTO `spell_proc_event` VALUES (38319,0,0,0,0,0x0000000000000000,0x00020000,0,0);

its true i think this isnt implemented because of that, SOTA and IOTC doesnt work, and before to get them work vehicle need to be implemented. or at least Random BG could be implemented with and option in the mangos.cfg where you can turn off/on the bgs available for the Random BG

hello,everyone! this forum is really a good place and many nice people are here! recently, chinese players would have their WOW version from TBC 3.1.3 update to WLK 3.2.2-12484. i followed this great guy's guide here: http://getmangos.eu/community/viewtopic.php?id=7318 ,luckly, everything goes fine ,and it worked well on my WOW 3.3.5a-12340 version (though the post recommended 3.3.3a, but my 3.3.5a also did well,due to my data update?) but when i used my China's WOW version 3.2.2-12484, it came to this error "can't validate game version", i almost know this error would happen , though ,it is said that someone can modify the MaNGOS file to make the newer version MaNGOS support lower version WOW . i used the search function of this forum, but due to my bad english ,i can only find the the "sharedefine" file contain some statment about version problems, but i really messed up, can some of you nice guys help me with this problem? or give me a link about this? that will be a great favor for me ! thank you everyone reading this post!

What bug does the patch fix? What features does the patch add? fixes Moonfire & Lacerate Debuff stack For which repository revision was the patch created? [9814] Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/showthread.php?7656-%5BBug%5D-Moonfire-Lacerate-Debuff-overwrite&highlight=lacerate Who has been writing this patch? Please include either forum user names or email addresses. Me Code diff: @@ -1590,6 +1609,11 @@ bool SpellMgr::IsNoStackSpellDueToSpell(uint32 spellId_1, uint32 spellId_2) cons case SPELLFAMILY_DRUID: if( spellInfo_2->SpellFamilyName == SPELLFAMILY_DRUID ) { + //Lacerate and Moonfire + if (spellInfo_1->SpellIconID == 225 && spellInfo_2->SpellIconID == 2246 || + spellInfo_2->SpellIconID == 225 && spellInfo_1->SpellIconID == 2246 ) + return false; + //Omen of Clarity and Blood Frenzy if( (spellInfo_1->SpellFamilyFlags == UI64LIT(0x0) && spellInfo_1->SpellIconID == 108) && (spellInfo_2->SpellFamilyFlags & UI64LIT(0x20000000000000)) || (spellInfo_2->SpellFamilyFlags == UI64LIT(0x0) && spellInfo_2->SpellIconID == 108) && (spellInfo_1->SpellFamilyFlags & UI64LIT(0x20000000000000)) )

the solution is here

What bug does the patch fix? resolves stacking issues between the following Spells: Spellist For which repository revision was the patch created? master @ 57cf96c19416dc63cf444d71d5deaeaa68bab143 Is there a thread in the bug report section or at lighthouse? http://getmangos.eu/community/showpost.php?p=94873&postcount=3 Who has been writing this patch? Me commit a2f7c25996105054cf4c3671878f6121a0c7f064 Author: unknown <Spezies 0815@.(none)> Date: Thu Dec 3 17:24:17 2009 +0100 IconID:240 Issues diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp index bdb1b66..cba3c96 100644 --- a/src/game/SpellMgr.cpp +++ b/src/game/SpellMgr.cpp @@ -1329,10 +1329,8 @@ bool SpellMgr::IsNoStackSpellDueToSpell(uint32 spellId_1, uint32 spellId_2) cons spellInfo_2->SpellVisual[0] == 99 && spellInfo_1->SpellVisual[0] == 0 ) ) return false; - // Heart of the Wild and (Primal Instinct (Idol of Terror) triggering spell or Agility) - if( spellInfo_1->SpellIconID == 240 && spellInfo_2->SpellIconID == 240 && ( - spellInfo_1->SpellVisual[0] == 0 && spellInfo_2->SpellVisual[0] == 78 || - spellInfo_2->SpellVisual[0] == 0 && spellInfo_1->SpellVisual[0] == 78 ) ) + // Heart of the Wild, Agility and various Idol Triggers + if(spellInfo_1->SpellIconID == 240 && spellInfo_2->SpellIconID == 240) return false; // Personalized Weather (thunder effect should overwrite rainy aura)