Auctionhouse bot

@madmax - can you flesh out exactly how this occurs

I have a ticket on the bot being broken already. Exactly as Max says. Starts fine, but nothing is shown in-game and nothing is ever bought from players.

The last part of AuctionBotSeller::LoadItemsQuantity (in src/game/AuctionHouseBot/AuctionHouseBot.cpp) calculates a divisor inside a loop by summing all the item amount config values.

For me, the values CONFIG_UINT32_AHBOT_CLASS_GEM_AMOUNT and CONFIG_UINT32_AHBOT_CLASS_GENERIC_AMOUNT are not present and therefore uninitialised and have large garbage values. This makes the divisor VERY LARGE and results in zero items being added per class.

I patched mine locally by removing them from the sum; and also added a check to print out an error if the item amount becomes zero as a result of the divisor (to help find item classes that would never be generated even with valid config values).

Do you think you could post the correction ?

That may be true, but just today while I was troubleshooting the SQL connection issue I increased MySQL's connection count from the default 100 to 1024 and the bot began working. It also fixed the SQL errors completely until the server had been running for an hour. I am still researching it, but for the past year AHBot has been dead. Increasing the connection limit appeared to have fixed it. I will continue this along with the SQL connection research.

Using Rev 21 on Debian machine and changing max connections to 1024 fixed the problem for me too.

Can you PR this change at all ?

That is not the issue. Even at 1024 it blanks out at times. The issue is a coding issue inside the bot somewhere.

Fixed by [url]https://github.com/mangoszero/server/pull/98[/url] The issue can be closed.