[fix] Vellums

[cyrex]

Is it 100% working since somebody said that in 9280 is was still not working with some vellums.

[Ceris]

Is it 100% working since somebody said that in 9280 is was still not working with some vellums.

in [9280] is implemented using scrolls of enchants on items, not creating scrolls of enchants from reagents.

[cyrex]

Is there any work on the Vellum part so they can be enchanted. Since i do not see how you will use a vellum to enchant an item if you can not enchant the vellum in the first part hehe.

[kyle1]

I use Lynx3D's patch for two weeks and it works fine. Was there any reason to commit 9280 without possibility to create enchant scrolls ?

[Cobra101]

I use Lynx3D's patch for two weeks and it works fine. Was there any reason to commit 9280 without possibility to create enchant scrolls ?

Yes, they got something working, and they released it like good developers lol. Sure, it's not perfect, but it's (especially in this case) way better than nothing.

Btw, Last time I checked there were conflicts in the spell.cpp with Lynx3d's stuff. Not sure if it's working or not. Still happy to have what we do. B)

[Moandor]

Maybe somebody post patch in new thread?

[Lynx3d]

Well since the scroll part is in master now (with somewhat different code), you have to remove that on merging obviously...

Kungfu-merged current master branch right into it, though i wonder if i should've just redone the branch...but seems it has worked.

http://github.com/Lynx3d/mangos/tree/vellums

Resulting patch shrunk down about 50 lines (against [9291])

http://paste2.org/p/647052

And i have to emphasize that code is still based on what Lightguard posted and others like timmons contributed.

[wolftang32000]

awesome, but seriously, why isnt this even accepted or reviewed yet? >_> i never had trouble with it!

[VladimirMangos]

because before patch has been not clear correct or not for me, and working remark not make patch 100% acceptable. Not it more short and more clear.

But i still not sure is this most clean way do this...

[kyle1]

Updated Lynx3D's patch to work with 9390 http://paste2.org/p/670036

[Lynx3d]

Just updated repository, fixed merge conflicts and did some small changes.

Still can't really find anything substantial to improve, but i need to re-test everything to make sure it still works as intended...

And maybe someone knows if error messages are correct (when trying to enchant vellum in trade slot, or vellum with scroll etc).

Repository still as in my last post.

Diff to master (for reviewing purpose): http://paste2.org/p/691125

[Forusim]

don´t let this go down...

[Moandor]

any news on this patch?

Since Vladimir posted that he will look into it no commit on master has been made.

By the way patch working with 9856.

[Forusim]

Puuuuuuuuuuuuuuuuush

[przemratajczak]

i am using this from a loooooooooooong time, tested by 600-700 testers and could't find any issue.

[kyle1]

This patch had a good testing period without any complaints. Lynx3d, you are a dev now, push it please.

[Moandor]

Working like charm for long time

BUMP

[Mordaunt]

Is this patch still needed? Does it still work?

[Wowka321]

Yes, still work, still needed =)

Bump! ))

[stk]

works like a charm, big thx

[kyle1]

Bump once again!

This code works for almost a year. Please merge it upstream.

[kyle1]

I've updated Lynx3d's patch to revision 10667. Link: http://paste2.org/p/1070438

[Forusim]

What´s wrong with this patch, that devs won´t review?

Thank you!

[Unkle Nuke]

I'll second that.

If there are still issues with the code style or just plain wrong functions, what can be done to make the Vellums patch comply?

[Lynx3d]

Added in [11203]...finally

Still might not win the most-beautiful-code-of-the-year award, but who know what the code at "Heavy Snowfall" looks like...

I'm fairly sure by now that no bad things are happening with this implementation