mtmaps (OpenMP)

[kero99]

For ACE or OpenMP MTMaps

[Ambal]

Finally crash in concurrent access to DB functions with MTMaps is solved with this pach: http://pastebin.com/RqU2ELVW

We'll review these changes and if appropriate to current core - will apply them Thanks.

[Unik2psc]

New patch (by Kero):

https://gist.github.com/725939

You've lost these lines:

ACE_Based::Thread::Sleep(loopSleepms);

- SqlOperation* s = NULL;

- while (m_sqlQueue.next(s))

+ ACE_Based::Thread::Sleep(loopSleepms);

+ SqlAsyncTask * s = dynamic_cast<SqlAsyncTask*> (m_sqlQueue.dequeue(/*&_time*/));

+ if(s)

Regards

[forbiddenn]

Is it really useful?

What draws you one performance between normal and mangos with this patch?

Sorry for my English.

[Unik2psc]

forbiddenn, mtmaps or kero patch ?

[selector]

crashes related to SqlDelayThread::run stopped (thx to GODs, author of patch and kero99)

But got newone type, something is wrong with Player::SaveToDB

http://pastebin.com/3Nm0Rjxw I've deleted other core_dumps but there where _SaveBGData(); _SaveSpellCooldowns(); and others...

P.S. Core is not clean. Bot there where no custom changes with SatveToDB

[forbiddenn]

forbiddenn, mtmaps or kero patch ?

Mtmaps and kero patch ^^

Just to know what it can bring to my core, I is not well understood.

Sorry for my English.

[forbiddenn]

Would you have a patch directly? Limit was put in hand to update my core with mtmaps - multithreaded packet processing and then I put the patch Kero ?

Sorry for my English.

Edit :

I perform the following command:

git pull git: / / github.com / Ambal / mangos.git

on my working branch

I must put the patch kero and is good?

[Ambal]

New patch (by Kero):

https://gist.github.com/725939

With modifications applied in [10865]. Cheers

[xarly]

I'm not really sure, but after apply tbb concurrent vector and sql sync patches, when a player open chests, this sometimes doesn't show loot and get bugged remaining opened, and cannot open it again, the player has to desconect and log again to try to view loot.

As I say, this didn't happened before apply these patches :rolleyes:

Any one can confirm this?

Thank you

[Ambal]

after apply tbb concurrent vector and sql sync patches

You might try and figure out what patches might cause such behavior:

1) run mtmaps w/o any additional patches;

2) run mtmaps with concurrent vector patch;

3) if you have revision below [10865] - apply SQL sync patch.

[xarly]

I have done some test, and definitely current vector patch is the cause of this little bug with loot

[blackthunder]

I have done some test, and definitely current vector patch is the cause of this little bug with loot

Confirm.

[mns]

Need updating after [11139]

[kero99]

Updated versions of patches needed for a MT environment (for rev 1297+)

MTMaps: http://pastebin.com/shkUMvnZ

TBB Concurrent Vector and some safe checks: http://pastebin.com/XSFzAaGB

Spell Update lock (Very hack... but needed): http://pastebin.com/VNdLvLks

Best regards

[sidsukana]

Can you put the last mtmaps patch? Link in the post above no longer exist

[kero99]

Link ready again =)

[Infinity_return]

I'm not really sure, but after apply tbb concurrent vector and sql sync patches, when a player open chests, this sometimes doesn't show loot and get bugged remaining opened, and cannot open it again, the player has to desconect and log again to try to view loot.

As I say, this didn't happened before apply these patches :rolleyes:

Any one can confirm this?

Thank you

Possbile fix:

Add "target.deleted = false;" to void Spell::AddGOTarget too

...

// This is new target calculate data for him

GOTargetInfo target;

target.targetGUID = targetGUID;

target.effectMask = (1 << effIndex);

target.processed = false; // Effects not apply on target

target.deleted = false;

...

Need to update patch?

[Thyros]

yes

[Drevan]

Simple maintain of diffs. Builds fine MaNGOS rev: 11734, not tested running server with it. Will update other 2 patches as I have time.

Mtmaps: http://pastebin.com/UDPe1hDp