[sql fix][9007] Engineering Trinkets' PPM

[nos4r2zod]

Huh? Seems to work fine for me; the 2 you highlighted refers to "PROC_EX_CRITICAL_HIT = 0x0000002." The proc flag is retrieved from dbc.

EDIT: Note there is a mistake in the description of the item though. If you read the comments here, it does proc off of ranged critical hits from a ranged weapon. The flag is correct in the dbc; it's marked as 0x00000154, meaning PROC_FLAG_SUCCESSFUL_RANGED_SPELL_HIT, PROC_FLAG_SUCCESSFUL_RANGED_HIT, PROC_FLAG_SUCCESSFUL_MELEE_SPELL_HIT, PROC_FLAG_SUCCESSFUL_MILEE_HIT. Same problem with Mirror of Truth

[Sephiroth1983]

Huh? Seems to work fine for me; the 2 you highlighted refers to "PROC_EX_CRITICAL_HIT = 0x0000002." The proc flag is retrieved from dbc.

So you added proc ex for criticals, and DBC gives proc flag for melee only? Ok.

[gonzalezbr]

hummmm

hey people! First post here, I'm just starting to get into MaNGOS developing, and actually mainly reading some posts and starting figure out how some stuff work....

Just one question here: From the first post, I think you are editing trinket's internal cooldown, not ppm, right?

Because both have different concepts...

[jorooo]

Well guys, I would update first post but, why are there some comented lines in the query?

And one more thing, is there any difference in using Hex and Dec. Let's unify the quiries a bit ;]

[nos4r2zod]

I commented out lines rather than deleting them because I wasn't sure about them, so I wanted to see what other people could come up with. Also, I wanted to keep the list complete; right now, it contains every proc spell added in WoTLK that comes from items, except for the ones that explicitly say "on every hit," such as the Brunnhildar weapons.

Changed the hex/floats to dec ints.

[jorooo]

Okay 10x for explanation.

First post updated. I did not add any of the commented spell procs.

[dardennf]

Hello everybody,

Does this item have a internal cooldown ?

And, about this one ?

[nos4r2zod]

I only created entries for proc spells from items that were added in WoTLK.

But in UDB 369, Band of the Eternal Champion has a 60 minute cd, Blackened Naaru Sliver has no entry in spell_proc_event (no internal CD).

IMO, you shouldn't be worrying about individual procs when there are faster ways to make entries for groups of them at a time.

[dardennf]

You mean 60 seconds, for Band of the Eternal Champion ?

Ok, but according to wowhead there is an internal CD for the Naaru trinket.

[dardennf]

Hello everybody, I would ask you to give me some details about, procFlags and procEx : what is the difference ?

Wich numbers can I inscribe in procFlags and in procEx, with wich effect ?

I have also a problem with this trinket : Noise Machine it proc with a internal cooldown but when it's not equiped, and just in my bag it can proc...

I don't understand.

Thank you, and sorry for my english.

PS : wiki udb is so outdated ^^, that's why I ask you this.

[jorooo]

First posted updated and unified a bit ;]

I have also a problem with this trinket : Noise Machine it proc with a internal cooldown but when it's not equiped, and just in my bag it can proc...

I don't understand.

Thank you, and sorry for my english.

Strange bug indeed. Never happend to me. Will test ;]

[Marin4o]

i got them in me all the time.Never happened.

[dardennf]

I wonder ... why with the trinket, it doesn't take procFlag or procEx into account of this : "Melee attacks against you have a chance to invoke a Sonic Shield, absorbing 1100 damage. This effect can only occur once a minute."

It should have a proc from Melee damage received, parried, blocked or dodged... but ProcFlags : 0 and also Proc Ex : 0

Moreover there is a Custom chance : " Apply Aura : [Proc Trigger Spell] Chance : 50%"

So that's why I ask you any information about ProcFlags and ProcEx, because wiki udb is outdated .

Thank you, and sorry for my english .

[jorooo]

Chance is loaded from dbc ;]

[dardennf]

Ok thank you .. but for Noise Machine, this trinket needs a ProcFlags or a ProcEx, doesn't it ?

And, somebody have some informations about ProcFlags and ProcEx ?

Thank you.

[jorooo]

Here nos4r2zod have explained:

Check the enums in SpellMgr.h:

PROC_FLAG_SUCCESSFUL_MILEE_HIT          = 0x00000004
...
PROC_EX_CRITICAL_HIT        = 0x0000002

I think that's what you're looking for.

[dardennf]

This is not the explanation I expected, I would like to know how it works in every case.

[s1lverghost]

This item also needs a fix, pls some1 takes a look at it.

After 5 minutes using it u'll have an army of knight summoned from this blade.

I'm using the lastest mangos and Udb btw

[Alez]

Meta gem http://www.wowhead.com/?spell=61356

INSERT INTO spell_proc_event VALUES
(61356,0,0,0,0,0,680,2,0,0,90);

[jorooo]

Use delete before insert

1st post updated, tnx Alez.

[heyy]

So are These Official Data?Blizzlike?Can some Dev Confirm this? and how come they do not have ppm set nor customchances?only the goddamn cooldown, none of the items say's anything about a cooldown, it say's a chance on hit/struck etc, so to me, this does not seem very blizzlike, unless you guys have another explanation?

[cyrex]

So crit chance is it db oriented or dbc oriented. Where should the crit chance go?

[jorooo]

Hm, Im not sure.

I think most of the procs capable of critical hits are using player melee/spell crit chance :?

[imblizzspy]

If we are at trinkets, could some1 look at these:

Quagmirran's Eye - Disabled spell haste rating buff (proccing from dots)

Linken's Boomerang - Too big proc rate

Talisman of the Alliance - Gaining +heal

Talisman of the Horde - Gaining +heal

Shattered Sun Pendant of Acumen - Scryer proc overpowered

Lifestone - Gaining +heal

Devilsaur Tooth - All pet attacks have 100% crit chance.

[jorooo]

The +heal bugs need spell_bonus_data set to 0. Others need procflags and cooldowns probably.

Even if I look into those, mangos devs are not interested in SQL updates, it won't get any attention anyway.