[SQL][8488] Spells coefficients

[Tassader2]

I have a question about this spell Rain of fire.

Currently, there is 69.32% from Direct_bonus, but I wonder if it should normally be (or not) 69.32% dot_bonus.

Yes, that seems to be quite too much

According to DrDamage addon, RoF should get 114.58 % for whole spell (about the same as mage's Blizzard), that's 28.645 % per tick.

[Tassader2]

i dont understand it either. but the fact is hammer of wrath isnt taking twice the coefficients as others spells do. if you remove the db entry, the spell deals base damage. if you remove the code, it deals base damage.

beats me

Nope, setting db entry to zero AP&SP contribution makes HoW doing the right amount of damage (15% AP & SP is already addec in code). (Note that damage displayed in tooltip changes accordingly to your gear!)

[Sephiroth1983]

Spell coefficient of Mind Flay of Shadow priest is wrong.

In Shadow form, they deal around 2k/s non-crit....

Here come the fix :

DELETE FROM `spell_bonus_data` WHERE `entry` IN ('15407','17311','17312','17313','17314','18807','25387','48155','48156');
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('15407', '0.257', '0', '0', 'Priest - Mind Flay rank 1'),
('17311', '0.257', '0', '0', 'Priest - Mind Flay rank 2'),
('17312', '0.257', '0', '0', 'Priest - Mind Flay rank 3'),
('17313', '0.257', '0', '0', 'Priest - Mind Flay rank 4'),
('17314', '0.257', '0', '0', 'Priest - Mind Flay rank 5'),
('18807', '0.257', '0', '0', 'Priest - Mind Flay rank 6'),
('25387', '0.257', '0', '0', 'Priest - Mind Flay rank 7'),
('48155', '0.257', '0', '0', 'Priest - Mind Flay rank 8'),
('48156', '0.257', '0', '0', 'Priest - Mind Flay rank 9');

Source :

http://www.wowwiki.com/Spell_power_coefficient

Can't you use Mind Flay trigger spell so you cover all ranks?

DELETE FROM `spell_bonus_data` WHERE `entry` = '58381';
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('58381', '0.257', '0', '0', 'Priest - Mind Flay - Trigger - all ranks');

I would like this topic to don't be forgotten, post your updates and fixes to the current version.

[Litaken]

Didnt really get if this one actually gives coeffs 2 Devouring plague, but presently it doesnt have any bonus damage from spellpower, i'd appriciate implementing coeffs to that one.

[Sephiroth1983]

Didnt really get if this one actually gives coeffs 2 Devouring plague, but presently it doesnt have any bonus damage from spellpower, i'd appriciate implementing coeffs to that one.

('2944', '0', '0.1849', '0', 'Priest - Devouring Plague'),

I would like to receive comments from guys who can actually add something

about Gauge, I don't know if we should add the coefficient with this table, maybe the attackpower is added depending on combo points and then its done within code calculation? I never played rogue.

[Sephiroth1983]

Nice, except that I don't think spell_chain is needed, in the end is the same quantity of code we have to make if we use the spell_chain or directly the spell_bonus_data entries.

Also I would like to discuss the following suggestions and corrections, Living Bomb is just obvious:

-- Living bomb correction, before DD and DoT coefficient in one spell, but explosion is separate
DELETE FROM `spell_bonus_data` WHERE `entry` IN ('44457', '44461', '55361', '55362');
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('44457', '0', '0.2', '0', 'Mage - Living Bomb DoT'),
('44461', '0.4', '0', '0', 'Mage - Living Bomb Explosion Rank 1'),
('55361', '0.4', '0', '0', 'Mage - Living Bomb Explosion Rank 2'),
('55362', '0.4', '0', '0', 'Mage - Living Bomb Explosion Rank 3');
-- Some coefficients added
DELETE FROM `spell_bonus_data` WHERE `entry` IN ('5570', '61391', '33745',  '49821', '53022');
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('5570', '0', '0.2', '0', 'Druid - Insect Swarm'),
('61391', '0.193', '0', '0', 'Druid - Typhoon'),
('33745', '0', '0', '0.01', 'Druid - Lacerate'),
('49821', '0.2861', '0', '0', 'Priest - Mind Sear Trigger Rank 1'),
('53022', '0.2861', '0', '0', 'Priest - Mind Sear Trigger Rank 2');

About the druid ones, I'm not sure about Lacerate, it can be it is hardcoded in damage calculation per combo point and needs to be updated there?

[nos4r2zod]

Nice, except that I don't think spell_chain is needed, in the end is the same quantity of code we have to make if we use the spell_chain or directly the spell_bonus_data entries.

Yes, it's the same amount of code right now, but it'll be a lot less in comparison the next time one of these spell's coefficients changes, and it'll be a lot easier to verify those changes when you only have to check one rank of the spell. Case in point: the data you have for typhoon would only work for rank 1 right now

- I don't think damage shields like thorns and fire shield are affected by spell_bonus_data, so I didn't add the data. If someone out there has written a patch that needs this data, I'll happily add it.

- Pounce bleed is correctly affected by AP without data.

- Swipe isn't affected by spell_bonus_data

- Only the dot of lacerate is affected by spell_bonus_data.

- Also note that the coefficients of insect swarm and mind sear are from post 3.0.9.

spell_bonus_data:

-- Updating coefficients for some spells
DELETE FROM `spell_bonus_data` WHERE `entry` IN ('689', '18790', '172', '42223', '42224', '42225', '42226', '42218', '47817', '47818', '1949', '5857', '11681', '11682', '27214', '47822', '27243', '30108', '17962', '6789', '48181', '29722', '5676', '686', '17877', '30283', '1120', '30294', '44425', '42208', '42209', '42210', '42211', '42212', '42213', '42198', '42937', '42938', '11113', '31661', '120', '19750', '635', '25914', '25913', '25903', '27175', '33074', '48820', '48821', '58597', '31935', '31803', '53742', '31893', '32221', '53719', '53718', '20167', '20424', '31804', '53733', '31898', '32220', '53726', '53725', '20267', '20187', '20467', '53600', '596', '2944', '8092', '27813', '27817', '27818', '33619', [b]'58381'[/b], '60089', [b]55039[/b], [b]'44457', '44461', '55361', '55362', '5570', '49821', '53022', '61391', '33745'[/b]);
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('689', '0', '0.143', '0', 'Warlock - Drain Life'),
('18790', '0', '0', '0','Warlock - Fel Stamina'),
('172', '0', '0.2', '0', 'Warlock - Corruption'),
[b]('42223', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered'),[/b]
('1949', '0', '0.0949', '0', 'Warlock - Hellfire'),
[b]('5857', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy'),[/b]
('27243', '0.2129', '0.25', '0', 'Warlock - Seed of Corruption'),
('30108', '0', '0.2', '0', 'Warlock - Unstable Affliction'),
('17962', '0.4293', '0', '0', 'Warlock - Conflagrate'),
('6789', '0.214', '0', '0', 'Warlock - Death Coil'),
('48181', '0.4793', '0', '0', 'Warlock - Haunt'),
('29722', '0.7139', '0', '0', 'Warlock - Incinerate'),
('5676', '0.4293', '0', '0', 'Warlock - Searing Pain'),
('686', '0.8569', '0', '0', 'Warlock - Shadow Bolt'),
('17877', '0.4293', '0', '0', 'Warlock - Shadowburn'),
('30283', '0.1932', '0', '0', 'Warlock - Shadowfury'),
('1120', '0', '0.429', '0', 'Warlock - Drain Soul'),
('30294', '0', '0', '0', 'Warlock - Soul Leech'),
('44425', '0.7143', '0', '0', 'Mage - Arcane Barrage'),
[b]('42208', '0.1437', '0', '0', 'Mage - Blizzard Triggered'),[/b]
('11113', '0.1936', '0', '0', 'Mage - Blast Wave Rank'),
('31661', '0.1936', '0', '0', 'Mage - Dragons Breath'),
('120', '0.214', '0', '0', 'Mage - Cone of Cold'),
('19750', '1', '0', '0', 'Paladin - Flash of Light'),
('635', '1.66', '0', '0', 'Paladin - Holy Light'),
[b]('25914', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal'),[/b]
('58597', '0.75', '0', '0', 'Paladin - Sacred Shield'),
('31935', '0.07', '0', '0.07', 'Paladin - Avenger Shield'),
('31803', '0', '[b]0.0176[/b]', '0.03', 'Paladin - Holy Vengeance'),
('53742', '0', '[b]0.0176[/b]', '0.03', 'Paladin - Blood Corruption'),
('31893', '0', '0', '0', 'Paladin - Seal of Blood Enemy Proc'),
('32221', '0', '0', '0', 'Paladin - Seal of Blood Self Proc'),
('53719', '0', '0', '0', 'Paladin - Seal of The Martyr Enemy Proc'),
('53718', '0', '0', '0', 'Paladin - Seal of The Martyr Self Proc'),
('20167', '0.15', '0', '0.15', 'Paladin - Seal of Light Proc'),
('20424', '[b]0[/b]', '0', '0', 'Paladin - Seal of Command Proc'),
('31804', '[b]0[/b]', '0', '[b]0[/b]', 'Paladin - Judgement of Vengeance'),
('53733', '[b]0[/b]', '0', '[b]0[/b]', 'Paladin - Judgement of Corruption'),
('31898', '0.25', '0', '0.16', 'Paladin - Judgement of Blood Enemy'),
('32220', '[b]0.0833[/b]', '0', '[b]0.0533[/b]', 'Paladin - Judgement of Blood Self'),
('53726', '0.25', '0', '0.16', 'Paladin - Judgement of the Martyr Enemy'),
('53725', '[b]0.0833[/b]', '0', '[b]0.0533[/b]', 'Paladin - Judgement of the Martyr Self'),
('20267', '0.1', '0', '0.1', 'Paladin - Judgement of Light Proc'),
('20187', '[b]0.32[/b]', '0', [b]'0[/b]', 'Paladin - Judgement of Righteousness'),
('20467', '0.25', '0', '0.16', 'Paladin - Judgement of Command'),
('53600', '0', '0', '0', 'Paladin - Shield of Righteousness'),
('596', '0.8068', '0', '0', 'Priest - Prayer of Healing'),
('2944', '0', '0.1849', '0', 'Priest - Devouring Plague'),
('8092', '0.428', '0', '0', 'Priest - Mind Blast'),
[b]('27813', '0', '0', '0', 'Priest - Blessed Recovery'),[/b]
('33619', '0', '0', '0', 'Priest - Reflective Shield'),
[b]('58381', '0.257', '0', '0', 'Priest - Mind Flay Triggered'),[/b]
('60089', '0', '0', '0.05', 'Druid - Faerie Fire (Bear Form)'),
('55039', '0', '0', '0', 'Engineering - Gnomish Lightning Generator'),
[b]('44457', '0', '0.2', '0', 'Mage - Living Bomb DoT'),
('44461', '0.4', '0', '0', 'Mage - Living Bomb Explosion'),
('5570', '0', '0.2', '0', 'Druid - Insect Swarm'),
('49821', '0.2861', '0', '0', 'Priest - Mind Sear Trigger'),
('61391', '0.193', '0', '0', 'Druid - Typhoon'),
('33745', '0', '0', '0.01', 'Druid - Lacerate');[/b]

spell_chain:

DELETE FROM spell_chain WHERE spell_id in ('42223', '42224', '42225', '42226', '42218', '47817', '47818', '5857', '11681', '11682', '27214', '47822', '42208', '42209', '42210', '42211', '42212', '42213', '42198', '42937', '42938', '25914', '25913', '25903', '27175', '33074', '48820', '48821', '27813', '27817', '27818', [b]'44461', '55361', '55362', '61391', '61390', '61388', '61387', '53227', '49821', '53022'[/b]);
INSERT INTO spell_chain (`spell_id`, `prev_spell`, `first_spell`, `rank`, `req_spell`) VALUES 
('42223', '0', '42223', '1', '0'),
('42224', '42223', '42223', '2', '0'),
('42225', '42224', '42223', '3', '0'),
('42226', '42225', '42223', '4', '0'),
('42218', '42226', '42223', '5', '0'),
('47817', '42218', '42223', '6', '0'),
('47818', '47817', '42223', '7', '0'),
('5857', '0', '5857', '1', '0'),
('11681', '5857', '5857', '2', '0'),
('11682', '11681', '5857', '3', '0'),
('27214', '11682', '5857', '4', '0'),
('47822', '27214', '5857', '5', '0'),
('42208', '0', '42208', '1', '0'),
('42209', '42208', '42208', '2', '0'),
('42210', '42209', '42208', '3', '0'),
('42211', '42210', '42208', '4', '0'),
('42212', '42211', '42208', '5', '0'),
('42213', '42212', '42208', '6', '0'),
('42198', '42213', '42208', '7', '0'),
('42937', '42198', '42208', '8', '0'),
('42938', '42937', '42208', '9', '0'),
('25914', '0', '25914', '1', '0'),
('25913', '25914', '25914', '2', '0'),
('25903', '25913', '25914', '3', '0'),
('27175', '25903', '25914', '4', '0'),
('33074', '27175', '25914', '5', '0'),
('48820', '33074', '25914', '6', '0'),
('48821', '48820', '25914', '7', '0'),
('27813', '0', '27813', '1', '0'),
('27817', '27813', '27813', '2', '0'),
('27818', '27817', '27813', '3', '0'),
[b]('44461', '0', '44461', '1', '0'),
('55361', '44461', '44461', '2', '0'),
('55362', '55361', '44461', '3', '0'),
('61391', '0', '61391', '1', '0'),
('61390', '61391', '61391', '2', '0'),
('61388', '61390', '61391', '3', '0'),
('61387', '61388', '61391', '4', '0'),
('53227', '61387', '61391', '5', '0'),
('49821', '0', '49821', '1', '0'), 
('53022', '49821', '49821', '2', '0'); [/b]

Edit: Judgement of Righteousness does not need AP data

[bidji29]

All gear now has a stat called "spell power"

there is no talent that gives healers more +healing from spellpower or anything like that.

Blizzard has severely increased the coefficients from Healing spells in WotLK.

Currently the reported modifier when spell power gets run through a healing spell is 1.8

[Litaken]

Fix me if im wrong but Priest spell Prayer of Mending seems having bad coefficents also, tooltip(addon, Drdamage) writes 8,8k heal for all the 5 ticks and it heals 800 each tick, so its kinda half. Posted becouse havent seen it in the list.

[nos4r2zod]

The coefficient is right for prayer of mending, but something in the code is wrong... I did some testing and it gave the correct value for the heal (base heal + 0.8068 * sp) when a direct_bonus of 11 was used, but I have no idea why the coefficient isn't working right.

EDIT: Ok, I found the source of this bug: the spell has a spellLevel of 1 in the dbc, so it's receiving a lvl difference penalty. Try .cast 33110 on yourself at level 1 and level 80 and you'll see the difference, even though your spell power doesn't change.

EDIT2: Is it possible to just get rid of the "downranking penalty" calculation altogether? 3.0.2 made it so that all spells are based off on % of base mana, so there's virtually no benefit to downranking anyways.

[Litaken]

Eh. Tricky. Tx for informing. Was glad 2 see it working, its fun 2 shoot everyone with this, but not when it heals 800..

[sso1]

Can Windfury get his coefficients also from this table? I see its hitting with Rank8 and a decent gear for 120 - 600 crit

[nos4r2zod]

('2944', '0', '0.1849', '0', 'Priest - Devouring Plague'),

Something needs to be fixed in Spell::EffectHealthLeech first; the coefficient on this spell and the coefficient on drain life are being applied twice for the healing portions of the spells.

According to the wiki, there should be no bonus from +healing, but there should be benefits from spell effects that directly affect healing, like demon armor.

@sso1 : Windfury works fine for me, and it wouldn't be affected by this table anyway.

[Sephiroth1983]

-- Add coefficient for Shadowflame DoT
DELETE FROM `spell_bonus_data` WHERE `entry` IN ('47960', '61291');
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('47960', '0', '0.0667', '0', 'Warlock - Shadowflame Trigger Rank 1'),
('61291', '0', '0.0667', '0', 'Warlock - Shadowflame Trigger Rank 2');
-- Add coefficient for Shadowflame DD
DELETE FROM `spell_bonus_data` WHERE `entry` = '47897';
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('47897', '0.1064', '0', '0', 'Warlock - Shadowflame');
-- Conflagrate no direct benefit from spell power with Patch 3.1.2, coefficient set to 0, deleting causes high damage because will use default instant coefficient
DELETE FROM `spell_bonus_data` WHERE `entry` = '17962';
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('17962', '0', '0', '0', 'Warlock - Conflagrate');

[bidji29]

ll gear now has a stat called "spell power"

there is no talent that gives healers more +healing from spellpower or anything like that.

Blizzard has severely increased the coefficients from Healing spells in WotLK.

Currently the reported modifier when spell power gets run through a healing spell is 1.8

Currently in Mangos, the healing spell doesn't have this multiplier.

Maybe i'm wrong but

- http://www.wowhead.com/?spell=48782

- http://www.wowhead.com/?spell=48785

- http://www.wowhead.com/?spell=48825

Those spell doesn't heal like Official.

[Sephiroth1983]

ll gear now has a stat called "spell power"

there is no talent that gives healers more +healing from spellpower or anything like that.

Blizzard has severely increased the coefficients from Healing spells in WotLK.

Currently the reported modifier when spell power gets run through a healing spell is 1.8

Currently in Mangos, the healing spell doesn't have this multiplier.

Maybe i'm wrong but

- http://www.wowhead.com/?spell=48782

- http://www.wowhead.com/?spell=48785

- http://www.wowhead.com/?spell=48825

Those spell doesn't heal like Official.

In this topic we already use the right coefficients updated to 3.1.3, you didn't use this fix for tests I see.

[Sephiroth1983]

The ones with "Needs core implementation first" should be added IMHO, the data in tables should be correctly provided, regardless if the spell is fixed or not.

Also, a friend of mine suggests to use '-1' as coefficient for Conflagrate (17962), Vampiric Touch Dispel proc (64085), Seal of Martyr self and enemy procs (53718, 53719), Seal of Blood (31893, 32221) and Swiftmend (18562). This is to avoid them to get ANY bonus damage.

If you need the queries I can provide them after we discuss if is correct.

[nos4r2zod]

Also, a friend of mine suggests to use '-1' as coefficient for Conflagrate (17962), Vampiric Touch Dispel proc (64085), Seal of Martyr self and enemy procs (53718, 53719), Seal of Blood (31893, 32221) and Swiftmend (18562). This is to avoid them to get ANY bonus damage.

A coefficient of zero is the correct way to show no bonus from coefficients, at least for now. Having a negative coefficient will result in the spell's damage decreasing as a result of spell power, or having the spell treated as a miss, or in some cases, having the spell's damage wrap around and causing damage orders of magnitude too high.

[Sephiroth1983]

A coefficient of zero is the correct way to show no bonus from coefficients, at least for now. Having a negative coefficient will result in the spell's damage decreasing as a result of spell power, or having the spell treated as a miss, or in some cases, having the spell's damage wrap around and causing damage orders of magnitude too high.

Probably my friend modified his core to have it not use any benefit when value is negative, not even buffs or other ways than spell power.

[VladimirMangos]

In [8488]. Thank you, to cccyril, nos4r2zod and all helpers

Some data droped from from suggested sql updates as already listed in mangos.sql:

('17962', '0', '0', '0', 'Warlock - Conflagrate'),

('53742', '0', '0.0156', '0.03', 'Paladin - Blood Corruption'),

('31803', '0', '0.0156', '0.03', 'Paladin - Holy Vengeance'),

('31898', '0.18', '0', '0.11', 'Paladin - Judgement of Blood Enemy'),

('32220', '0.0594', '0', '0.0363', 'Paladin - Judgement of Blood Self'),

('20467', '0.25', '0', '0.16', 'Paladin - Judgement of Command'),

('53733', '0', '0', '0', 'Paladin - Judgement of Corruption'),

('53725', '0.0594', '0', '0.0363', 'Paladin - Judgement of the Martyr Self'),

('53726', '0.18', '0', '0.11', 'Paladin - Judgement of the Martyr Enemy'),

('31804', '0', '0', '0', 'Paladin - Judgement of Vengeance'),

('31893', '0', '0', '0', 'Paladin - Seal of Blood Proc Enemy'),

('32221', '0', '0', '0', 'Paladin - Seal of Blood Proc Self'),

('20424', '0', '0', '0', 'Paladin - Seal of Command Proc'),

('53718', '0', '0', '0', 'Paladin - Seal of the Martyr Proc Self'),

('53719', '0', '0', '0', 'Paladin - Seal of the Martyr Proc Enemy'),

[Tassader2]

sorry if im wrong but I think this patch missed the DD spell bonus form Unstable Affliction in this part :confused:

according to http://www.wowwiki.com/Spell_power_coefficient

the DD spell coefficient for unstable affliction is 180%

maybe this should not be covered by default calculation and inserted in the table as

if not, at least someone more experienced could look at the DD spell coeficient of UA

sorry about bad english.

The triggered spell is 31117

EDIT: Strange that I wrote this post in reply to the following one, but it is shown before it :-o

[dogeht]

sorry if im wrong but I think this patch missed the DD spell bonus form Unstable Affliction in this part :confused:

-- ('30108', '0', '0.2', '0', 'Warlock - Unstable Affliction'),

according to http://www.wowwiki.com/Spell_power_coefficient

the DD spell coefficient for unstable affliction is 180%

maybe this should not be covered by default calculation and inserted in the table as

-- ('30108', '1.8', '0.2', '0', 'Warlock - Unstable Affliction'),

if not, at least someone more experienced could look at the DD spell coeficient of UA

sorry about bad english.

[reeshack]

As Tassader2 has already stated, search for entry "31117" .

(31117,1.8,0,0,'Warlock - Unstable Affliction Dispell')

[dogeht]

thanks