[SQL][8488] Spells coefficients

[Serker]

update `spell_bonus_data` set `direct_bonus` = 0.6453 where `entry` = 33763;

Lifebloom has a 0 coefficient for final heal, which is incorrect...

[rechapa79]

Well, I use an older rev than the one in svn, wich doesn't have that part and I thought that was older because of old values ^^

EDIT : same thing for Judgement of Vengeance, in SpellEffect.cpp, delete lines 551 to 554 and replace line 566 by

damage *= stacks * 10 /100;

Also delete lines 568 to 583 (Hammer of Wrath already have an entry in spell_bonus_data table)

if you make this code modifications Judgement of Vengeance deals no damage and hammer of wrath only deals base damage. best to leave them as it is

[rastikzzz]

update `spell_bonus_data` set `direct_bonus` = 0.6453 where `entry` = 33763;

Lifebloom has a 0 coefficient for final heal, which is incorrect...

lifebloom final heal is not working due to this check

uint32 Unit::SpellHealingBonus(Unit *pVictim, SpellEntry const *spellProto, uint32 healamount, DamageEffectType damagetype, uint32 stack)
{
   // No heal amount for this class spells
   if (spellProto->DmgClass == SPELL_DAMAGE_CLASS_NONE)
       return healamount;

so i changed it a bit

   if (spellProto->DmgClass == SPELL_DAMAGE_CLASS_NONE && spellProto->SpellFamilyName == SPELLFAMILY_GENERIC)
       return healamount;

and now is working perfectly

[Sephiroth1983]

The real problem of Lifebloom is the overpower

the stacks are handled wrongly in mangos as was stated by an offy player like Deafboy

and the actual coefficient doesn't help either, its healing a lot for each stack and very fast if stacked to max, it should work that way.

[cccyril]

if you make this code modifications Judgement of Vengeance deals no damage and hammer of wrath only deals base damage. best to leave them as it is

I don't understand why, Hammer of Wrath already have an entry in spell_bonus_data table, and it currently benefit of 2 times 0.15 SP + 0.15 AP, so, if we don't modify that code, we should at least remove the entry in spell_bonus_data.

[rechapa79]

I don't understand why, Hammer of Wrath already have an entry in spell_bonus_data table, and it currently benefit of 2 times 0.15 SP + 0.15 AP, so, if we don't modify that code, we should at least remove the entry in spell_bonus_data.

i dont understand it either. but the fact is hammer of wrath isnt taking twice the coefficients as others spells do. if you remove the db entry, the spell deals base damage. if you remove the code, it deals base damage.

beats me

[Sephiroth1983]

This fix will make it much better for pvp, nerfing Rain of Fire (insane aoe dmg) and Seal of Vengeance as well as Seal of Blood/Martyr

We need to remove those doubts remaining so Devs will review, because the fix otherwise is CORRECT.

Moreover, I am not sure about spells used by Soul Leech, Blessed Recovery and Reflective Shield.

All the spells you used are correct in this case

I will test personally the whole fix.

[NuRRi]

Patch is working like a charm. Makes DPS in raids going down and PVP / PVE is much more playable and balanced now.

Keep it up. Very nice work.

Bye

NuRRi

[raftom]

I have one question about Ice Barrier... it doesnt seem to get 80% bonus from spell power

http://www.wowwiki.com/Spell_power_coefficient

so i thought it might help

DELETE FROM `spell_bonus_data` WHERE `entry` IN ('11426','13031','13032','13033','27134','33405','43038','43039'); 
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES 
('11426', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 1)'), 
('13031', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 2)'), 
('13032', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 3)'), 
('13033', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 4)'), 
('27134', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 5)'), 
('33405', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 6)'), 
('43038', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 7)'), 
('43039', '0.8053', '0', '0', 'Mage - Ice Barrier(Rank 8)'); 

if sth is wrong with entries plz correct it

[Morale]

Well, as I look up on wowwiki, Seal of Command proc does not have bonus spell dmg, only have weapon dmg.

DELETE FROM `spell_bonus_data` WHERE `entry` = '20424'

Source : http://www.wowwiki.com/Seal_of_Command

[Lightguard]

Afaik it recieves bonus from attack power...

[Seizer]

Seal of Command receives 20% coefficient from normal +spell damage stats, and 32% from Attack Power.

patch 3.0.8 (1/20/09): Now gives the Paladin a chance to deal {0.45*Min Weap Damage+0.45*0.23*SpellPower} to {0.45*Max Weap Damage+0.45*0.23*SpellPower} additional Holy damage. (Old - Didn't scale with Spell Power)

[dardennf]

How this spell should work : Gnomish Lightning Generator from this trinket Gnomish Lightning Generator ?

Is there any bonus from spellpower ?

[Morale]

Seal of Command receives 20% coefficient from normal +spell damage stats, and 32% from Attack Power.

patch 3.0.8 (1/20/09): Now gives the Paladin a chance to deal {0.45*Min Weap Damage+0.45*0.23*SpellPower} to {0.45*Max Weap Damage+0.45*0.23*SpellPower} additional Holy damage. (Old - Didn't scale with Spell Power)

Thanks Seizer but as wowwiki state, that formula is old. The Seal of Command proc does not scale with Spell power.

The info from wowhead, thottbot does not show the 20% SP + 32% AP... Only 45% weapon dmg.

Could some1 from Offy check if this ?

Source :

http://www.wowhead.com/?spell=20424

http://thottbot.com/wotlk/ta1481

Please be noted :

http://thottbot.com/ta1481 <- this is before wotlk expansion. ( the version with 0.45*0.23 SP )

Well, in wowhead, how come the effect is 45 % weapon dmg but in the tool tip, it said 70% o_O ?

[The_Game_Master]

How this spell should work : Gnomish Lightning Generator from this trinket Gnomish Lightning Generator ?

Is there any bonus from spellpower ?

It should not be any bonus from spellpower.

This should be the right fix for it.

INSERT INTO spell_bonus_data
 (entry, direct_bonus, dot_bonus, ap_bonus, comments)
VALUES
 (55039, 0, 0, 0, "Engineering - Gnomish Lightning Generator");

[dardennf]

I will test it, thanks in advance.

[The_Game_Master]

It should not be any bonus from spellpower.

This should be the right fix for it.

INSERT INTO spell_bonus_data
 (entry, direct_bonus, dot_bonus, ap_bonus, comments)
VALUES
 (55039, 0, 0, 0, "Engineering - Gnomish Lightning Generator");

Edit: Tested and AP still counts. SP is gone tough.

[Alez]

FIX for 'gouge' (rogue spell)

3.0.2

- Gouge is now only 1 rank and causes damage based on attack power.

http://thottbot.com/s1776 - the coefficient is 0.21 from AP

DELETE FROM `spell_bonus_data` WHERE `entry` IN (1776);
INSERT INTO `spell_bonus_data` VALUES
(1776, 0, 0, .21, 'Rogue - Gouge');

[jorooo]

Edit: Tested and AP still counts. SP is gone tough.

Strange :huh:

Probably AP is hardecoded in core?

[Morale]

Spell coefficient of Mind Flay of Shadow priest is wrong.

In Shadow form, they deal around 2k/s non-crit....

Here come the fix :

DELETE FROM `spell_bonus_data` WHERE `entry` IN ('15407','17311','17312','17313','17314','18807','25387','48155','48156');
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('15407', '0.257', '0', '0', 'Priest - Mind Flay rank 1'),
('17311', '0.257', '0', '0', 'Priest - Mind Flay rank 2'),
('17312', '0.257', '0', '0', 'Priest - Mind Flay rank 3'),
('17313', '0.257', '0', '0', 'Priest - Mind Flay rank 4'),
('17314', '0.257', '0', '0', 'Priest - Mind Flay rank 5'),
('18807', '0.257', '0', '0', 'Priest - Mind Flay rank 6'),
('25387', '0.257', '0', '0', 'Priest - Mind Flay rank 7'),
('48155', '0.257', '0', '0', 'Priest - Mind Flay rank 8'),
('48156', '0.257', '0', '0', 'Priest - Mind Flay rank 9');

Source :

http://www.wowwiki.com/Spell_power_coefficient

[jorooo]

Morale and Alez, better make new topics as I doubt this will be reviewed any time soon

[Morale]

Yeah, too many things = confuse the reviewer

[dardennf]

Edit: Tested and AP still counts. SP is gone tough.

I tested it, and AP isn't take into account.

So it's so fixed

Thank you !

[jorooo]

Judgement of blood and Judgement of Vengeance deal insane dmg with this patch. Pls someone take a look at the code ;]

[dardennf]

I have a question about this spell Rain of fire.

Currently, there is 69.32% from Direct_bonus, but I wonder if it should normally be (or not) 69.32% dot_bonus.

Moreover about "Healing Stream Totem" there is currently no Bonus from spellpower, could we add a 4.50% in the field of "dot_bonus" ?

What do you think about that ?

Thank you, and sorry for my english ^^.

References from Wowwiki : Spell power Coefficient

PS : I'm agree with jorooo, "judgement of Blood/martyr" deal insane dmg, and can do another "Seal of Blood/martyr Enemy" proc ...