[SQL][8488] Spells coefficients

[Auntie Mangos]

• * What bug does the patch fix? What features does the patch add?
  

It fixes the coefficients of spells wich were using wrong coefficients.

• * For which repository revision was the patch created?
  7242+
  * Who has been writing this patch?
  cccyril , with the help of Sephiroth1983 who wrote a part of the fix (http://getmangos.eu/community/viewtopic.php?id=6289)
  

-- Updating coefficients for some spells
DELETE FROM `spell_bonus_data` WHERE `entry` IN ('689', '18790', '172', '42223', '42224', '42225', '42226', '42218', '47817', '47818', '1949', '5857', '11681', '11682', '27214', '47822', '27243', '30108', '17962', '6789', '48181', '29722', '5676', '686', '17877', '30283', '1120', '30294', '44425', '42208', '42209', '42210', '42211', '42212', '42213', '42198', '42937', '42938', '11113', '31661', '120', '19750', '635', '25914', '25913', '25903', '27175', '33074', '48820', '48821', '58597', '31935', '31803', '53742', '31893', '32221', '53719', '53718', '20167', '20424', '31804', '53733', '31898', '32220', '53726', '53725', '20267', '20187', '20467', '53600', '596', '2944', '8092', '27813', '27817', '27818', '33619', '60089');
INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('689', '0', '0.143', '0', 'Warlock - Drain Life'),
('18790', '0', '0', '0','Warlock - Fel Stamina'),
('172', '0', '0.2', '0', 'Warlock - Corruption'),
('42223', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 1'),
('42224', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 2'),
('42225', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 3'),
('42226', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 4'),
('42218', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 5'),
('47817', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 6'),
('47818', '0.6932', '0', '0', 'Warlock - Rain of Fire Triggered Rank 7'),
('1949', '0', '0.0949', '0', 'Warlock - Hellfire'),
('5857', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy Rank 1'),
('11681', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy Rank 2'),
('11682', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy Rank 3'),
('27214', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy Rank 4'),
('47822', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy Rank 5'),
('27243', '0.2129', '0.25', '0', 'Warlock - Seed of Corruption'),
('30108', '0', '0.2', '0', 'Warlock - Unstable Affliction'),
('17962', '0.4293', '0', '0', 'Warlock - Conflagrate'),
('6789', '0.214', '0', '0', 'Warlock - Death Coil'),
('48181', '0.4793', '0', '0', 'Warlock - Haunt'),
('29722', '0.7139', '0', '0', 'Warlock - Incinerate'),
('5676', '0.4293', '0', '0', 'Warlock - Searing Pain'),
('686', '0.8569', '0', '0', 'Warlock - Shadow Bolt'),
('17877', '0.4293', '0', '0', 'Warlock - Shadowburn'),
('30283', '0.1932', '0', '0', 'Warlock - Shadowfury'),
('1120', '0', '0.429', '0', 'Warlock - Drain Soul'),
('30294', '0', '0', '0', 'Warlock - Soul Leech'),
('44425', '0.7143', '0', '0', 'Mage - Arcane Barrage'),
('42208', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 1'),
('42209', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 2'),
('42210', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 3'),
('42211', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 4'),
('42212', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 5'),
('42213', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 6'),
('42198', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 7'),
('42937', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 8'),
('42938', '0.1437', '0', '0', 'Mage - Blizzard Triggered Spell Rank 9'),
('11113', '0.1936', '0', '0', 'Mage - Blast Wave Rank'),
('31661', '0.1936', '0', '0', 'Mage - Dragons Breath'),
('120', '0.214', '0', '0', 'Mage - Cone of Cold'),
('19750', '1', '0', '0', 'Paladin - Flash of Light'),
('635', '1.66', '0', '0', 'Paladin - Holy Light'),
('25914', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 1'),
('25913', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 2'),
('25903', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 3'),
('27175', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 4'),
('33074', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 5'),
('48820', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 6'),
('48821', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal Rank 7'),
('58597', '0.75', '0', '0', 'Paladin - Sacred Shield'),
('31935', '0.07', '0', '0.07', 'Paladin - Avenger Shield'),
('31803', '0', '0.018', '0.03', 'Paladin - Holy Vengeance'),
('53742', '0', '0.018', '0.03', 'Paladin - Blood Corruption'),
('31893', '0', '0', '0', 'Paladin - Seal of Blood Enemy Proc'),
('32221', '0', '0', '0', 'Paladin - Seal of Blood Self Proc'),
('53719', '0', '0', '0', 'Paladin - Seal of The Martyr Enemy Proc'),
('53718', '0', '0', '0', 'Paladin - Seal of The Martyr Self Proc'),
('20167', '0.15', '0', '0.15', 'Paladin - Seal of Light Proc'),
('20424', '0.1035', '0', '0', 'Paladin - Seal of Command Proc'),
('31804', '0.22', '0', '0.14', 'Paladin - Judgement of Vengeance'),
('53733', '0.22', '0', '0.14', 'Paladin - Judgement of Corruption'),
('31898', '0.25', '0', '0.16', 'Paladin - Judgement of Blood Enemy'),
('32220', '0', '0', '0', 'Paladin - Judgement of Blood Self'),
('53726', '0.25', '0', '0.16', 'Paladin - Judgement of the Martyr Enemy'),
('53725', '0', '0', '0', 'Paladin - Judgement of the Martyr Self'),
('20267', '0.1', '0', '0.1', 'Paladin - Judgement of Light Proc'),
('20187', '0.4', '0', '0.25', 'Paladin - Judgement of Righteousness'),
('20467', '0.25', '0', '0.16', 'Paladin - Judgement of Command'),
('53600', '0', '0', '0', 'Paladin - Shield of Righteousness'),
('596', '0.8068', '0', '0', 'Priest - Prayer of Healing'),
('2944', '0', '0.1849', '0', 'Priest - Devouring Plague'),
('8092', '0.428', '0', '0', 'Priest - Mind Blast'),
('27813', '0', '0', '0', 'Priest - Blessed Recovery Rank 1'),
('27817', '0', '0', '0', 'Priest - Blessed Recovery Rank 2'),
('27818', '0', '0', '0', 'Priest - Blessed Recovery Rank 3'),
('33619', '0', '0', '0', 'Priest - Reflective Shield'),
('60089', '0', '0', '0.05', 'Druid - Faerie Fire (Bear Form)');

Nevertheless, I have some doubts about Seal of Command and Seal of Blood / Martyr coefficients.

Moreover, I am not sure about spells used by Soul Leech, Blessed Recovery and Reflective Shield.

Remove old coded Judgement of Righteousness coefficients, thanks to rechapa79

2009-03-08 12:19 diff -rul a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp Page 1


--- a/src/game/SpellEffects.cpp    2009-03-08 12:15:02.000000000 -0200
+++ b/src/game/SpellEffects.cpp    2009-03-08 12:16:27.000000000 -0200
@@ -1559,14 +1559,7 @@

            switch(m_spellInfo->Id)
            {
-                // Judgement of Righteousness (0.2*$AP+0.32*$SPH) holy added in spellDamagBonus
-                case 20187:
-                {
-                    if (!unitTarget)
-                        return;
-                    m_damage+=int32(0.2f*m_caster->GetTotalAttackPowerValue(BASE_ATTACK));
-                    return;
-                }
+                
                case 31789:                                 // Righteous Defense (step 1)
                {
                    // 31989 -> dummy effect (step 1) + dummy effect (step 2) -> 31709 (taunt like spell for each target)

[Auntie Mangos]

In the interests of keeping this topic alive, I updated cccyril's post with stuff on the second page and more.

@The_Game_Master : Your Lightning Generator data works fine for me (no AP/SP bonus). Were you looking online for checking damage? Because the damage has been decreased in 3.1.0, which was released 3 days before your post.

@Alez : Gouge works fine (tested on [7970])

@cccyril : On Holy Vengeance, in my tests, I used 0.88/5 ticks => 0.0176 rather than 0.018. Not that there's any really noticeable difference though.

- Also blanked data for Seal of Command (it has a hardcoded bonus in EffectWeaponDmg) and Judgement of Vengeance/Corruption (Judgement of Vengeance has a hardcoded bonus, so I assume Judgement of Corruption will too) and added data for Judgement of Martyr/Blood backlash (the trigger for the backlash damage is called before spell bonuses are added, so these backlash spells should have 1/3 the coefficients. You can confirm this after applying my fix for these seals ).

- I don't think multiple ranks of a spell should be used in spell_bonus_data where it can be helped because it makes updating like this a bit more tedious. I used spell_chain instead, since there's already some triggered spells in there anyhow. So where I bolded an entire line, it means that I removed some redundancies (only in this patch, not what's already in the table) and added the ranks to spell_chain.

EDIT: see below

[Auntie Mangos]

I ran all the coefficients here through my patch here to see which of the entries were actually necessary. Then, I trimmed down the patch accordingly and removed all the entries that were already in MaNGOS tables.

Here are my results:

spell_chain

DELETE FROM `spell_chain` WHERE `spell_id` IN (27813, 27817, 27818, 61391, 61390, 61388, 61387, 53227, 47960, 61291);

INSERT INTO `spell_chain` (`spell_id`, `prev_spell`, `first_spell`, `rank`, `req_spell`) VALUES
/*Blessed Recovery Proc*/
('27813', '0', '27813', '1', '0'),
('27817', '27813', '27813', '2', '0'),
('27818', '27817', '27813', '3', '0'),
/*Typhoon Triggered*/
('61391', '0', '61391', '1', '0'),
('61390', '61391', '61391', '2', '0'),
('61388', '61390', '61391', '3', '0'),
('61387', '61388', '61391', '4', '0'),
('53227', '61387', '61391', '5', '0'),
/*Shadowflame Triggered DoT*/
('47960','0','47960','1','0'),
('61291','47960','47960','2','0');

spell_bonus_data

DELETE FROM `spell_bonus_data` WHERE `entry` IN
-- Spells that would be better off using default calculations (and should be removed from base MaNGOS tables)
(689, 30108, 6789, 29722, 5676, 686, 17877, 30283, 11113, 31661, 120, 25914, 596, 8092, 15407,
-- Spells that are getting entries below
18790, 42223, 27243, 17962, 30294, 47960, 47897, 44425, 42208, 19750, 635, 20424, 20467, 31803, 53742, 31804, 53733, 31893, 32221, 31898, 32220, 53718, 53719, 53725, 53726, 20167, 20267, 20187, 53600, 25997, 2944, 58381, 27813, 33619, 5570, 61391);

INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES
('18790', '0', '0', '0','Warlock - Fel Stamina'),
('42223', '0.285714', '0', '0', 'Warlock - Rain of Fire Triggered'), -- should be same as default calc (2/7), but this is a triggered spell
('27243', '0.2129', '0.25', '0', 'Warlock - Seed of Corruption'),
('17962', '0', '0', '0', 'Warlock - Conflagrate'),
('30294', '0', '0', '0', 'Warlock - Soul Leech'),
('47960', '0', '0.06666', '0', 'Warlock - Shadowflame DoT'),
('47897', '0.1064', '0', '0', 'Warlock - Shadowflame Direct'),
('44425', '0.714286', '0', '0', 'Mage - Arcane Barrage'), -- treat as 2.5 second cast time (as of 3.0.9)
('42208', '0.1437', '0', '0', 'Mage - Blizzard Triggered'),
('19750', '1', '0', '0', 'Paladin - Flash of Light'),
('635', '1.66', '0', '0', 'Paladin - Holy Light'), -- These two Paladin heals are their default calculations multiplied by 7/3, not sure why that is
('20424', '0', '0', '0', 'Paladin - Seal of Command Proc'),
('20467', '0.25', '0', '0.16', 'Paladin - Judgement of Command'),
('31803', '0', '0.0156', '0.03', 'Paladin - Holy Vengeance'),
('53742', '0', '0.0156', '0.03', 'Paladin - Blood Corruption'),
('31804', '0', '0', '0', 'Paladin - Judgement of Vengeance'),
('53733', '0', '0', '0', 'Paladin - Judgement of Corruption'),
('31893', '0', '0', '0', 'Paladin - Seal of Blood Proc Enemy'),
('32221', '0', '0', '0', 'Paladin - Seal of Blood Proc Self'),
('31898', '0.18', '0', '0.11', 'Paladin - Judgement of Blood Enemy'), 
('32220', '0.0594', '0', '0.0363', 'Paladin - Judgement of Blood Self'),
('53718', '0', '0', '0', 'Paladin - Seal of the Martyr Proc Self'),
('53719', '0', '0', '0', 'Paladin - Seal of the Martyr Proc Enemy'),
('53725', '0.0594', '0', '0.0363', 'Paladin - Judgement of the Martyr Self'),
('53726', '0.18', '0', '0.11', 'Paladin - Judgement of the Martyr Enemy'),
('20167', '0.15', '0', '0.15', 'Paladin - Seal of Light Proc'),
('20267', '0.1', '0', '0.1', 'Paladin - Judgement of Light Proc'),
('20187', '0.32', '0', '0', 'Paladin - Judgement of Righteousness'),
('53600', '0', '0', '0', 'Paladin - Shield of Righteousness'),
('25997', '0', '0', '0', 'Paladin - Eye for an Eye'),
('2944', '0', '0.1849', '0', 'Priest - Devouring Plague'),
('58381', '0.257143', '0', '0', 'Priest - Mind Flay Triggered'), -- Treated as 2.7 sec channel instead of 3?
('27813', '0', '0', '0', 'Priest - Blessed Recovery'),
('33619', '0', '0', '0', 'Priest - Reflective Shield'),
('5570', '0', '0.2', '0', 'Druid - Insect Swarm'),
('61391', '0.193', '0', '0', 'Druid - Typhoon');

and here are the spells I removed from this topic if anyone wants to know why

-- Already in MaNGOS.sql
-- ('1949', '0', '0.0949', '0', 'Warlock - Hellfire'),
-- ('5857', '0.1427', '0', '0', 'Warlock - Hellfire Effect on Enemy'),
-- ('48181', '0.4793', '0', '0', 'Warlock - Haunt'),
-- ('1120', '0', '0.429', '0', 'Warlock - Drain Soul'),
-- ('31935', '0.07', '0', '0.07', 'Paladin - Avenger Shield'),

-- Needs core implementation first
-- ('44457', '0', '0.2', '0', 'Mage - Living Bomb DoT'), this part is already added
-- ('44461', '0.4', '0', '0', 'Mage - Living Bomb Explosion'), NYI
-- ('58597', '0.75', '0', '0', 'Paladin - Sacred Shield'), NYI / might have to be hardcoded like other School Absorb spells
-- ('49821', '0.2861', '0', '0', 'Priest - Mind Sear Trigger'), don't think this should be added until Mind Sear is fixed (shouldn't hit target)
-- ('60089', '0', '0', '0.05', 'Druid - Faerie Fire (Bear Form)'), NYI
-- ('33745', '0', '0', '0.01', 'Druid - Lacerate'), has to be hard coded (and already is)
-- ('55039', '0', '0', '0', 'Trinket - Gnomish Lightning Generator'), should be a more generic way to do this

-- Covered by default calculation
-- ('689', '0', '0.143', '0', 'Warlock - Drain Life'),
-- ('30108', '0', '0.2', '0', 'Warlock - Unstable Affliction'),
-- ('6789', '0.214', '0', '0', 'Warlock - Death Coil'),
-- ('29722', '0.7139', '0', '0', 'Warlock - Incinerate'),
-- ('5676', '0.4293', '0', '0', 'Warlock - Searing Pain'),
-- ('686', '0.8569', '0', '0', 'Warlock - Shadow Bolt'), ranks have different cast time, better to use default calculation
-- ('17877', '0.4293', '0', '0', 'Warlock - Shadowburn'),
-- ('30283', '0.1932', '0', '0', 'Warlock - Shadowfury'), covered by default calculation (with my patch only!)
-- ('11113', '0.1936', '0', '0', 'Mage - Blast Wave Rank'), covered by default calculation (with my patch only!)
-- ('31661', '0.1936', '0', '0', 'Mage - Dragons Breath'), covered by default calculation (with my patch only!)
-- ('120', '0.214', '0', '0', 'Mage - Cone of Cold'), covered by default calculation (with my patch only!)
-- ('25914', '0.81', '0', '0', 'Paladin - Holy Shock Triggered Heal'),
-- ('596', '0.8068', '0', '0', 'Priest - Prayer of Healing'),
-- ('8092', '0.428', '0', '0', 'Priest - Mind Blast'),

[Auntie Mangos]

The coefficient is there somewhere, the real problem with unstable affliction dispel damage is level penalty which it gains...

See :http://getmangos.eu/community/viewtopic.php?id=10268

[Auntie Mangos]

The coefficient is there somewhere, the real problem with unstable affliction dispel damage is level penalty which it gains...

See :http://getmangos.eu/community/viewtopic.php?id=10268

Could you please showme where is the spell coefficient for the DD part of unstable affliction? i cant find it.

[amrok]

thanks nice work

[Seizer]

"Blessed Recovery and Reflective Shield."

i can confirm that these 2 dont have coefficient, reflective shield is tied to enemys dmg and blessed recorvery aswell

[rechapa79]

judgement of the martyr and judgement of blood backlash coefficients seem wrong.

i think they should be:

-----------------------------------------------------------------------------------------

----------------------------------------------------------------------------------------

EDIT:nevermind the backlash base damage seems bugged

[cccyril]

Currently, pushback damage are higher than damage done to the target, so I think pushback damage is calculate after the application of AP and SP to judgement damage.

Just try and see if pushback equal to 33% of damage.

[rechapa79]

seal of command proc should have a spell coefficient of 0.25 instead of 0.1035.

i dont know why earlier versions of the table added a 0.16 contribution from attack power to SoC proc making it extremely OP

[cccyril]

Well, according to the tooltip on thottbot (http://thottbot.com/ta1481) and a comment on wowhead, it benefit of 0.45*0.23*SP (0.45*(Main weapon damage + 0.23 SP)), but like I said, I'm not sure of this.

[rechapa79]

sorry. my mistake. your coefficient (0.1035) is the right one

[Sephiroth1983]

('31661', '0.1936', '0', '0', 'Mage - Dragons Breath'),
('120', '0.214', '0', '0', 'Mage - Cone of Cold'),

Hm 2 cone spells, wonder why so different coefficient, they also share cooldown category.

[Ledeet]

('31661', '0.1936', '0', '0', 'Mage - Dragons Breath'),
('120', '0.214', '0', '0', 'Mage - Cone of Cold'),

Hm 2 cone spells, wonder why so different coefficient, they also share cooldown category.

Weird but that's what wowwiki says

[paytheo]

('31661', '0.1936', '0', '0', 'Mage - Dragons Breath'),
('120', '0.214', '0', '0', 'Mage - Cone of Cold'),

Hm 2 cone spells, wonder why so different coefficient, they also share cooldown category.

probably balance issues since dragons breath incapacitates i think

[Gommes]

bump here! very helpful thing + correct

[Sephiroth1983]

I don't want to make another post, would like to ask if spell 60089 is currently casted when you use 16857 in Dire Bear and Bear Forms

if code is still not doing, we can at least add the 0.05 attack power coefficient as said in the tooltip

Decrease the armor of the target by 175 for 40 sec. While affected, the target cannot stealth or turn invisible. Deals [AP * 0.05 + 1] damage and additional threat when used in Bear Form or Dire Bear Form.

in the case is needed and not managed by c++ code already:

-- has been added to main post

[smyle]

What about priests Renew?

If I correct, the direct bonus is 1.88, instead of 0.376

('139', '0', '1.88', '0', 'Priest - Renew')

[cccyril]

Renew benefit of 1.88 SP overall, it's currently fine.

I edit first post with faerie fire, thank you.

[smyle]

What determine that?

Priest - Devouring Plague is over time spell too, but its overall Spell Power Coefficient presents in the new SQL here.

(old value in mangos is 0.1849, and 0.8149 here, what a big difference)

It is not the same category?

It seems, in the present mangos db, there are the "per tick" coefficients for the over time spells...

[cccyril]

Devouring Plague's value edited.

[rechapa79]

you might need to add this code patch:

2009-03-08 12:19 diff -rul a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp Page 1


--- a/src/game/SpellEffects.cpp    2009-03-08 12:15:02.000000000 -0200
+++ b/src/game/SpellEffects.cpp    2009-03-08 12:16:27.000000000 -0200
@@ -1559,14 +1559,7 @@

            switch(m_spellInfo->Id)
            {
-                // Judgement of Righteousness (0.2*$AP+0.32*$SPH) holy added in spellDamagBonus
-                case 20187:
-                {
-                    if (!unitTarget)
-                        return;
-                    m_damage+=int32(0.2f*m_caster->GetTotalAttackPowerValue(BASE_ATTACK));
-                    return;
-                }
+                
                case 31789:                                 // Righteous Defense (step 1)
                {
                    // 31989 -> dummy effect (step 1) + dummy effect (step 2) -> 31709 (taunt like spell for each target)

because the current code is adding the spell coefficients TWICE making Judgement of Righteousness extreamly overpwered

[cccyril]

It seems that it has already been deleted.

[Graftal]

It seems that it has already been deleted.

Doesn't seem to me..

[cccyril]

Well, I use an older rev than the one in svn, wich doesn't have that part and I thought that was older because of old values ^^

EDIT : same thing for Judgement of Vengeance, in SpellEffect.cpp, delete lines 551 to 554 and replace line 566 by

damage *= stacks * 10 /100;

Also delete lines 568 to 583 (Hammer of Wrath already have an entry in spell_bonus_data table)

(if someone can do a patch, that would be great, I can't right now)

EDIT 2 : Added Avenger's Shield