Warlock pets not regenerating mana

Alright, this should be "all pets regenerate nothing". Hunter pets are no longer regenerating focus and warlock pets do not regenerate mana. I am changing the priority of this ticket to urgent due to this.

Even stranger now! Hunter pets appear to lose all their energy, but keep using their skills despite no energy. On top of that, when a warlock pet loses mana, it can no longer use anything. This is strange!

This is odd. Here is what is going on right now.

[list]
[*]Warlock pets lose all mana, but they can keep casting spells. However, using "Dark Pact" returns no mana, since the pet is really out
[*]Hunter pets eventually lose all focus, but keep right on using skills, so this isn't as bad for them
[*]NPC voidwalker minions have rage instead of mana, and it is maxed out
[/list]

The PetAI script need an overhaul .. that's clear.

Is the current AI in SD2 or core? If it is in SD2 it should be moved to the core since it is a core functionality. I will volunteer to do that once my Linux system is back up.

It's inside the core already. I've worked on it to rewrite how the Imp is working (first one) because for Mangos, all pets are generic pets (which is incorrect) and have the same behavior.

Regarding the mana/health generation, in the past, it was going well but the amount was too low (and I never found the original data). I don't know what has been changed.. that it doesn't work now.

No worries. Warlocks need love in general and this can wait. I know R20 needs to be released and once I get caught up with Le Froid and look into SD2 and the DB stuff, I will be happy to lend a hand here.

has there been any news on this issue? I also seem to have this problem on Two as well.

The pet power regen was killed in Rel20 branch at Aug 2014. Here is the fix of that useful but, say, unlucky commit:
[url]https://github.com/Olion17/ZeroCore/commit/6bfb014cac6badcea2ea71dac696c9c9ac138f97[/url]

I wish it be the last bug with the pets :D but it is far from one. After a brief testing, it seems that now we have to teach the pets to actually use the energy, then correctly calculate spell CDs... but I hope these will be another bugreports.

tested on Dev21 and pets do work so marking this completed