Possible fix - Shadow Dance

Lynx3d · November 16, 2009

If i may try to quote Vladimir in a gramatically more correct form:

Spell has aura SPELL_AURA_MOD_IGNORE_SHAPESHIFT that provides removing form requirement for spells.
So setting form is clearly a horrible hack.

Note the words "horrible hack"...

This is no solution, it's a workaround.

Someone better find out WHY you cannot cast said spells when in Shadow Dance instead of overwriting this form and pretend that everything is cool.

Is it blocked by server or already by client?

It might be a similar problem as Warrior's Charge enabling taltents that need an invisible aura to be sent to client before you can even use the action button...

Cobra101 · November 17, 2009

I agree. I also believe you're correct about the aura. Since it does mimic the same problems, it's most likely being blocked by the client. I'm simply keeping the post up so people can review it and possible get something better going. At least, for the time being; it's better than nothing.

bulek · November 28, 2009

any news/updates?

test this?

this is no my code

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 3a0862d..0d28cb8 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -2637,6 +2637,9 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
        case FORM_SHADOW:
        case FORM_STEALTH:
            break;
+        case FORM_SHADOWDANCE:
+            PowerType = POWER_ENERGY;
+            break;
        case FORM_TREE:
            modelid = 864;
            break;
@@ -2682,7 +2685,8 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
        if(m_target->m_ShapeShiftFormSpellId)
            m_target->RemoveAurasDueToSpell(m_target->m_ShapeShiftFormSpellId, this);

-        m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, form);
+        // For Shadow Dance we must apply Stealth form (30) instead of current (13)
+        m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, (form == FORM_SHADOWDANCE) ? uint8(FORM_STEALTH) : form);

        if(modelid > 0)
            m_target->SetDisplayId(modelid);
@@ -2747,6 +2751,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
                        m_target->SetPower(POWER_RAGE, Rage_val);
                    break;
                }
+                // Shadow Dance - apply stealth mode stand flag
+                case FORM_SHADOWDANCE:
+                    m_target->SetStandFlags(UNIT_STAND_FLAGS_CREEP);
+                    break;
                default:
                    break;
            }
@@ -2779,6 +2787,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
                if(Aura* dummy = m_target->GetDummyAura(37324) )
                    m_target->CastSpell(m_target, 37325, true, NULL, dummy);
                break;
+            // Shadow Dance - remove stealth mode stand flag
+            case FORM_SHADOWDANCE:
+                m_target->RemoveStandFlags(UNIT_STAND_FLAGS_CREEP);
+                break;
            default:
                break;
        }
diff --git a/src/game/Unit.h b/src/game/Unit.h
index faefbef..3f0e578 100644
--- a/src/game/Unit.h
+++ b/src/game/Unit.h
@@ -167,6 +167,7 @@ enum ShapeshiftForm
    FORM_GHOUL              = 0x07,
    FORM_DIREBEAR           = 0x08,
    FORM_CREATUREBEAR       = 0x0E,
+    FORM_SHADOWDANCE        = 0x0D,
    FORM_CREATURECAT        = 0x0F,
    FORM_GHOSTWOLF          = 0x10,
    FORM_BATTLESTANCE       = 0x11,

Raynar · December 2, 2009

anybody has tried the bulek's patch?

DJNefast · December 2, 2009

yes one of my dev had tried it. Works perfectly but not a clear code for mangos structure but a little hack which works.

Raynar · December 16, 2009

works in mangos 9000?

bulek · December 17, 2009

works in mangos 9000?

yes works fine but a little hack code

KAPATEJIb · December 17, 2009

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 993753e..93ba68b 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -2974,6 +2974,7 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
    switch(form)
    {
        case FORM_CAT:
+        case FORM_SHADOW_DANCE:
            PowerType = POWER_ENERGY;
            break;
        case FORM_BEAR:
@@ -3040,7 +3041,8 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
        if(m_target->m_ShapeShiftFormSpellId)
            m_target->RemoveAurasDueToSpell(m_target->m_ShapeShiftFormSpellId, this);

-        m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, form);
+        // For Shadow Dance we must apply Stealth form (30) instead of current (13)
+        m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, (form == FORM_SHADOW_DANCE) ? uint8(FORM_STEALTH) : form);

        if(modelid > 0)
            m_target->SetDisplayId(modelid);
@@ -3105,6 +3107,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
                        m_target->SetPower(POWER_RAGE, Rage_val);
                    break;
                }
+                // Shadow Dance - apply stealth mode stand flag
+                case FORM_SHADOW_DANCE:
+                    m_target->SetStandFlags(UNIT_STAND_FLAGS_CREEP);
+                    break;
                default:
                    break;
            }
@@ -3137,6 +3143,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
                if(Aura* dummy = m_target->GetDummyAura(37324) )
                    m_target->CastSpell(m_target, 37325, true, NULL, dummy);
                break;
+            // Shadow Dance - remove stealth mode stand flag
+            case FORM_SHADOW_DANCE:
+                m_target->RemoveStandFlags(UNIT_STAND_FLAGS_CREEP);
+                break;
            default:
                break;
        }

bulek · December 18, 2009

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 993753e..93ba68b 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -2974,6 +2974,7 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
    switch(form)
    {
        case FORM_CAT:
+        case FORM_SHADOW_DANCE:
            PowerType = POWER_ENERGY;
            break;
        case FORM_BEAR:
@@ -3040,7 +3041,8 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
        if(m_target->m_ShapeShiftFormSpellId)
            m_target->RemoveAurasDueToSpell(m_target->m_ShapeShiftFormSpellId, this);

-        m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, form);
+        // For Shadow Dance we must apply Stealth form (30) instead of current (13)
+        m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, (form == FORM_SHADOW_DANCE) ? uint8(FORM_STEALTH) : form);

        if(modelid > 0)
            m_target->SetDisplayId(modelid);
@@ -3105,6 +3107,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
                        m_target->SetPower(POWER_RAGE, Rage_val);
                    break;
                }
+                // Shadow Dance - apply stealth mode stand flag
+                case FORM_SHADOW_DANCE:
+                    m_target->SetStandFlags(UNIT_STAND_FLAGS_CREEP);
+                    break;
                default:
                    break;
            }
@@ -3137,6 +3143,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
                if(Aura* dummy = m_target->GetDummyAura(37324) )
                    m_target->CastSpell(m_target, 37325, true, NULL, dummy);
                break;
+            // Shadow Dance - remove stealth mode stand flag
+            case FORM_SHADOW_DANCE:
+                m_target->RemoveStandFlags(UNIT_STAND_FLAGS_CREEP);
+                break;
            default:
                break;
        }

thank you works with 9013 mangos:)

ascent · February 15, 2010

4> .. \\ .. \\ src \\ game \\ SpellAuras.cpp (5978): error C2065: 'PowerType': undeclared identifier. what's the problem?

rev 9387

voltas · March 8, 2010

Any news on this project?

maxo_tt · March 9, 2010

any news? patch for latest rev?

presto · March 15, 2010

I added it (manually) and it didnt gave any error.
Try adding it again.

========== Build: 11 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

luck

edit: btw, i tested it, it "works" but not like it should be.

When you enter shadow dance, you are NOT stealthed (which is ok) but you have like... stealth movements, (while walking, etc)

but yeah, it kinda works.

As I will add it manually? Can someone guide me? plz

sorry for English

Shadowhack · March 18, 2010

When a rogue shadow dances, he gets access to his stealth action bar but he does not stealth he can just use moves like Ambush and Cheap Shot. The rogue also moves at normal non stealthed speed.

voltas · March 27, 2010

It will be great, if it can be fix for 3.3.3 blizz trays really hard to bring back the sub rogue like in the old days.

Gamba88 · April 17, 2010

bump! any news about this fix?

goodbadguy · May 25, 2010

This is not working in 3.3.3a branch

voltas · June 12, 2010

Any news on the project, because it is a key talent for the rogue. Without it the whole sub tree is pointless.

Thanks in advance

Viruss · June 18, 2010

When you click Shadow Dance, it applies a feature of stealth (Skill bar), nothing more can come from it. What the form does is apply the aura (Apply Aura: Shapeshift Ignored SpellClass - Wowhead), giving the player access to the skills. You need to add some things to the original Stealth "form" that can make this executable and not just Shadow Dance because Shadow Dance does multiple things so it needs to be applied in the places it affects.

Forusim · June 18, 2010

This patch is a working hack, but the real problem is behind not implemented Apply Aura: Shapeshift Ignored SpellClass

darkstalker · June 18, 2010

aura is implemented in core, but client doesn't allow casting stealth spells in "shadowdance form"

xarly · July 15, 2010

I have been testing in lastest rev, patch posted above works up to a certain point, because for example:

1. You are in Stealth form with Master of Subtlety

2. Use Shadowdance............................................+

------------------------------------------------------------

3. Shadowdance buff replace stealth buff, Master of Subtlety remains

It looks like cannot be at the same time

laise · July 15, 2010

without any patches, Shadowdance doesn't work on latest rev(and i mean latest, not any before)?

xarly · July 16, 2010

Yes that's true. I mean I applied patch from KAPATEJIb on post #33. With the results I posted in #47

darkstalker · July 16, 2010

without any patches, Shadowdance doesn't work on latest rev(and i mean latest, not any before)?

spells are blocked client side, you can't use stealth spells in shadow dance form, and gives you an empty shapeshift bar for that form.

Sign In

Possible fix - Shadow Dance

Recommended Posts

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Recently Browsing 0 members

Contact Us

Repositories

Important Information