Vehicles (Dev)

smirnoffsf · December 29, 2009

Hi, i need some help with vehicule patch

i've made it, patch correctly, compile mangos 9077

i'll try the item http://www.wowhead.com/?item=44086

but i do not understand how it workd to invit people on it, the vehicule bar doesnt appear ...

nothing in menu

Any idea, help please?

Thanks

mihai · December 29, 2009

vehicle patch have an problem. the target is vehicle it self. and when you leave it he despawn but dont respawn at start point.

luffydu22 · December 30, 2009

Hi, i need some help with vehicule patch
i've made it, patch correctly, compile mangos 9077

i'll try the item http://www.wowhead.com/?item=44086

but i do not understand how it workd to invit people on it, the vehicule bar doesnt appear ...

nothing in menu

Any idea, help please?

Thanks

if you need help, this patch have is for the multi mount passenger, but this patch don't work on 3.2.2 and 3.3.0 because maybe blizzard has been changed the opcode or the spellclick.

http://www.trinitycore.org/forum/multi-passenger-mount-test-t6736.html?highlight=Mount

this patch is for trinity core 2, but i ve adapted this patch for my 3.1.2 in mangos

erazare · December 30, 2009

just wanted to remark that after I *did* fix the patch and built my server that Grand Theft Palimino works perfeclty... awesome patch kids... although it crashes the server on Into the Realm of Shadows..... still good work hope to see more in the future!

yeah I think i will continue to keep DKs off limits on my server... while this advances them greatly.. into the realm of shadows crashes the serevr and if I try to set it autocomplete (by setting method 2 to 0) it doesnt autocomplete the quest and the server will still crash if you click on the horse.

still I love seeing the vehicle system work with Grand Theft Palimino I cannot wait to see what else is now working.

I wish I could offer everyone the patch for this git to make it work but i never made one solely for it. I could zip up the spell.cpp and pet.cpp files that I fixed which are corrupted if you try to pull from the Valhalla git.

smirnoffsf · December 30, 2009

if you need help, this patch have is for the multi mount passenger, but this patch don't work on 3.2.2 and 3.3.0 because maybe blizzard has been changed the opcode or the spellclick.
http://www.trinitycore.org/forum/multi-passenger-mount-test-t6736.html?highlight=Mount

this patch is for trinity core 2, but i ve adapted this patch for my 3.1.2 in mangos

Do you wanan say 3.1.3 or 3.2.2 ?

if its for 3.2.2 could you release your job?

Thanks again

satex · December 30, 2009

you are aware that there are DEFINITE errors in the vehicle branch?
when you clone mangos and then pull the vehicle branch it LOOKS like it pulls clean but in actuality it writes a whole bad merge into pet.cpp complete with <<<<<<HEAD statements

after clearing those out you have to remove the section below them that the merge was supposed to be removing then the cpp file is fine except there is another error in spell.cpp where it instructs a push.back but the identifier is tagunitmap and its SUPPOSED to be targetunitmap

I think they should definitely clean up this commit

hi thx

you can make a patch file ??

i can not make a patch file and so i can not clean this patch

can anny gays upload a patch for me thx

sorry for my bad englich

Wojta · December 30, 2009

you are aware that there are DEFINITE errors in the vehicle branch?
when you clone mangos and then pull the vehicle branch it LOOKS like it pulls clean but in actuality it writes a whole bad merge into pet.cpp complete with <<<<<<HEAD statements

¨

Sorry, my bad, its fixed now.

luffydu22 · December 30, 2009

Do you wanan say 3.1.3 or 3.2.2 ?
if its for 3.2.2 could you release your job?

Thanks again

I must clean my patch, and after i share my work in this post

DJNefast · January 2, 2010

i've tried to spawn a vehicle, not a creature where vehicleid > 0 but there's a crash.

There is my 2 tried fixes :

in loadhelper

if(Creature *d = dynamic_cast<Creature*>(obj))
       {
           if(d->GetCreatureAddon()->vehicle_id > 0)
           {
               Vehicle* vh = dynamic_cast<Vehicle*>(obj);
               vh->AddToWorld();
           }
           else
               obj->AddToWorld();
       }
       else
           obj->AddToWorld();

void Creature::AddToWorld()
{
   if(GetCreatureAddon()->vehicle_id > 0)
       Vehicle::AddToWorld();
   else
   {
       ///- Register the creature for guid lookup
       if(!IsInWorld() && GetGUIDHigh()==HIGHGUID_UNIT)
           GetMap()->GetObjectsStore().insert<Creature>(GetGUID(), (Creature*)this);

       Unit::AddToWorld();
   }
}

That crash on GetCreatureAddon, vehicleid bugued, if i get my mouse on it with VS2008 debuguer

Christian Schamara · January 2, 2010

i've tried to spawn a vehicle, not a creature where vehicleid > 0 but there's a crash.
There is my 2 tried fixes :
void Creature::AddToWorld()
{
   if(GetCreatureAddon()->vehicle_id > 0)
       Vehicle::AddToWorld();
   else
   {
       ///- Register the creature for guid lookup
       if(!IsInWorld() && GetGUIDHigh()==HIGHGUID_UNIT)
           GetMap()->GetObjectsStore().insert<Creature>(GetGUID(), (Creature*)this);

       Unit::AddToWorld();
   }
}
That crash on GetCreatureAddon, vehicleid bugued, if i get my mouse on it with VS2008 debuguer

Pls make a diff file Thanks

DJNefast · January 2, 2010

that does'nt works there's a crash when load creatures

it's all the function addtoworld with a little rewriting...

ascent · January 3, 2010

anyone patch file link plz;; i pull 0kb

kaxias · January 3, 2010

Frist whiteSpece Fix

diff --git a/sql/v10_vehicle_test_data.sql b/sql/v10_vehicle_test_data.sql
index e3fee71..45ad1ed 100644
--- a/sql/v10_vehicle_test_data.sql
+++ b/sql/v10_vehicle_test_data.sql
@@ -455,11 +455,9 @@ DELETE FROM creature_template_addon WHERE entry IN (28887,28833);
INSERT INTO creature_template_addon (`entry`, `mount`, `bytes1`, `bytes2`, `emote`, `moveflags`, `vehicle_id`, `passengers`, `auras`) VALUES
(28887, 0, 0, 2049, 0, 0, 68, '', '');
INSERT INTO creature_template_addon (`entry`, `mount`, `bytes1`, `bytes2`, `emote`, `moveflags`, `vehicle_id`, `passengers`, `auras`) VALUES
(28833, 0, 0, 2049, 0, 0, 68, '', '');

-
-
/*Traveler's Tundra Mammoth */
REPLACE INTO npc_spellclick_spells VALUES
(32633, 52196, 0, 0, 0, 0);
-REPLACE INTO creature_template_addon VALUES
(32633, 0, 0, 0, 0, 0, 312, NULL, NULL); 
+REPLACE INTO creature_template_addon VALUES
(32633, 0, 0, 0, 0, 0, 312, NULL, NULL);
REPLACE INTO vehicle_data VALUES
(312, 12, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);

/* Grand Ice Mammoth */
@@ -468,18 +466,18 @@ REPLACE INTO creature_template_addon VALUES
(31857, 0, 0, 0, 0, 0, 312, NULL, NU

/* Salvaged Chopper */
REPLACE INTO npc_spellclick_spells VALUES
(33062, 52196, 0, 0, 0, 0);
-REPLACE INTO creature_template_addon VALUES
(33062, 0, 0, 0, 0, 0, 335, NULL, NULL); 
-REPLACE INTO vehicle_data VALUES
(335, 12, 62974, 62286, 62299, 64660, 0, 0, 0, 0, 0, 0, 0); 
+REPLACE INTO creature_template_addon VALUES
(33062, 0, 0, 0, 0, 0, 335, NULL, NULL);
+REPLACE INTO vehicle_data VALUES
(335, 12, 62974, 62286, 62299, 64660, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(3005, 1);
- 
+
/* Salvaged Demolisher */
REPLACE INTO npc_spellclick_spells VALUES
(33109, 52196, 0, 0, 0, 0);
-REPLACE INTO creature_template_addon VALUES
(33109, 0, 0, 0, 0, 0, 338, NULL, NULL); 
+REPLACE INTO creature_template_addon VALUES
(33109, 0, 0, 0, 0, 0, 338, NULL, NULL);
REPLACE INTO vehicle_data VALUES
(338, 12, 62306, 62490, 62308, 62324, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(3011, 1);
- 
+
/* Salvaged Siege Engine */
-REPLACE INTO npc_spellclick_spells VALUES
(33060, 52196, 0, 0, 0, 0); 
-REPLACE INTO creature_template_addon VALUES
(33060, 0, 0, 0, 0, 0, 336, NULL, NULL); 
+REPLACE INTO npc_spellclick_spells VALUES
(33060, 52196, 0, 0, 0, 0);
+REPLACE INTO creature_template_addon VALUES
(33060, 0, 0, 0, 0, 0, 336, NULL, NULL);
REPLACE INTO vehicle_data VALUES
(336, 12, 62345, 62522, 62346, 0, 0, 0, 0, 0, 0, 0, 0);
REPLACE INTO vehicle_seat_data VALUES
(3006, 1);
\\ No newline at end of file
--

always good to have everything perfect!

Good work like this patch!

kaxias · January 3, 2010

Second WhiteSpece Fix

diff --git a/src/game/Vehicle.cpp b/src/game/Vehicle.cpp
index dbad562..a74e382 100644
--- a/src/game/Vehicle.cpp
+++ b/src/game/Vehicle.cpp
@@ -98,7 +98,7 @@ void Vehicle::RegeneratePower(Powers power)

    float addvalue = 0.0f;

-    // hack: needs more research of power type from the dbc. 
+    // hack: needs more research of power type from the dbc.
    // It must contains some info about vehicles like Salvaged Chopper.
    if(m_vehicleInfo->m_powerType == POWER_TYPE_PYRITE)
        return;
@@ -150,7 +150,7 @@ bool Vehicle::Create(uint32 guidlow, Map *map, uint32 phaseMask, uint32 Entry, u
    {
        ((InstanceMap*)map)->GetInstanceData()->OnCreatureCreate(this);
    }
-    
+
    if(m_vehicleInfo->m_powerType == POWER_TYPE_STEAM)
    {
        setPowerType(POWER_ENERGY);
--

always good to have everything perfect!

Good work like this patch!

kaxias · January 3, 2010

ops! duplicate

piroy1337 · January 3, 2010

what about mechano hog ;P

luffydu22 · January 3, 2010

this the start of my patch for the multimount scripting

http://pastebin.com/f53c9e1cb

DJNefast · January 3, 2010

on which vehicle can this patch beeing usefull ?

Morphau · January 3, 2010

on which vehicle can this patch beeing usefull ?

The mamouth, the moto (mechano) ...

DJNefast · January 3, 2010

thanks a lot

DJNefast · January 3, 2010

this is a trinity patch ? whe don't have vehiclekit in tassadar projet patch thoses patch please.

DJNefast · January 3, 2010

sorry for triple post but edit does'nt work anymore.

Vehiclekit must be up to unit from creature. sorry for inconvenience

Can u give ur createvehiclekit function please ?

Jermayan · January 4, 2010

this is a trinity patch ? whe don't have vehiclekit in tassadar projet patch thoses patch please.

this is a MaNGOS patch, hence it is on the MaNGOS forums. If you want to adapt it to trinity, then feel free to download it and try it yourself, but dont post about it on these forums.

Edder · January 4, 2010

Here's the vehicle patch: http://filebeam.com/6b0a46adde431b255ba2ce8f4cab2de4

to create patch file, use:

git clone git://github.com/mangos/mangos.git
cd mangos
git checkout -b (chose what u want, i took rev. nr)9088 09428ebad23b2d408cbb20d2608aa988cd473b0e 
git checkout -b vehicle
git pull git://github.com/Tasssadar/Valhalla-Project.git vehicle 
git diff -p 9088 vehicle > vehicle.patch

If git://github.com/Tasssadar/Valhalla-Project.git switch to an another revision, you need to modify this in part 3 too, to avoid merge bugs.

erazare · January 4, 2010

May i ask why people prefer to use the .patch system for doing three-way merges rather than something simple like GIT REBASE ?

i.e.

clone repo

checkout -b <new branch>

cd <repo>

pull <another repo>

git rebase master

now repair files as you would in a clone/pull merge except AFTER each fix/commit just: git rebase --skip

this will systematically merge in ever update in all repos against the master repo... when its all done being merged it will let you know its clean.. else just keep using the above method til its clean.. this is the ultimate merge, as git cannot "forget" any merges.

warning... highly suggest you do not go crazy witht he rebase technique else you could spend days (literally) rebasing if you go overboard... I am speaking from experience... I rebased Mangos master repo vs Tasssadar's master repo for two days straight during the TiamaT project.

Sign In

Vehicles (Dev)

Recommended Posts

Link to comment

Share on other sites

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Recently Browsing 0 members

Contact Us

Repositories

Important Information