Mind Control Crashing + Dalaran Broke

[Auntie Mangos]

I've got the same trace after a crash from mindcontrol as Schmoozerd had. Posted it here: http://getmangos.eu/community/viewtopic.php?id=4235&p=119439&viewfull=1#post119439

[yasuno]

Im getting reports from some testers of mine that Mind Control is crashing the server instantly, They have tested this several times.

Also after the updates to vmaps and etc etc, Dalaran is no longer a proper sanctuary, and people can kill each other to there hearts content.

[Lynx3d]

Problem 1: Can't make it crash here, but Mind Control does act strange for me. But i'd say that's more likely related to the camera system, just tested with last commit before new vmaps, same result.

Someone posted about extreme lag spikes possibly related to camera system, if you have freeze detection enabled, this might be your crash, but you didn't gave any useful hints really. like if your last compile already included camera system or a call stack etc...

Problem 2: Enable vmaps, i'd say...

[yasuno]

I am on the latest rev.. I do have custom patches but none of them effect the situations i have described as there more for external use.

VMAPS is fully enabled on my servers, we have found that 81 and below it is still a sanctuary, above 81 it because a normal hostile zone. Which still doesn't make since because the next level bracket will be 85. Before i updated to the new changes to vmaps it was still a sanctuary at any level, normal or custom.

Avenging Wrath was crashing the server but that got fixed, mind control still crashes the server instantly pretty much for me.

EDIT - Mind Control works perfectly fine on any creature, BUT when you use Mind Control on another player, after some time it crashes the server not instantly but while your mind controlling the player. AGAIN only crashes when using it on a player.

[yasuno]

Can anyone else confirm this..

And does anyone know in what file or area i can disable mind control or at least break it so it doesn't work right lol.

[tehavatar]

Do you compile in x64 or 32 bit mode?

[yasuno]

I compile on Debian - Linux

[wside420]

Confirm to Mind control Crashing server. Dalaran/Sanctuary is Fine For me.

[x64][Windows] Newest Build [vmaps]

[yasuno]

Thanks for confirming on this annoying mind control bug at least.

[wside420]

Yes I recommend either spell_disabling It (If you have that) or waiting lol

[yasuno]

spell_disable was a patch wasn't it that someone made? If so no i don't have it, i was hoping someone would know how to just disable it in the core.

[mns]

possible caused by your Anti Cheat

mind control cause report misstiming in Anti Cheat Check .

Disable misstiming check and test again

[Lynx3d]

So sanctuary thing is a problem of players above level 80?

I'm afraid I can't really help there, vmap code doesn't query player level anywhere (it can't even), it just reads the correct area entry instead of using hardcoded ones for a few roughly defined bounds.

Whatever it is, I'm confident that I didn't break it

And honestly, when custom patches and custom level caps are involved, all alarm bells ring anyway...

[wside420]

I Don't Have Anticheat enabled? Level cap 80. Problem with mind control = Crash

[Caskast]

[Confirmed] [Rev 10168] [ x64 Windows ] When mind control runs out server crash's instantly.

[Schmoozerd]

confirmed rev 10168 (no relevant custom stuff)

confirmed Rev 10176 (clean), no SD2, with fresh spawned hogger at GM Island

-- EDIT: version 3, for rev 10176

http://paste2.org/p/910266

Server log:

2010-07-10 17:05:24 Our ticks: 27224923, diff 32, latency 0

2010-07-10 17:05:30 Aura 4 now is remove mode 7

2010-07-10 17:05:30 Aura 2 now is remove mode 7

2010-07-10 17:05:30 Aura 2 now is remove mode 0

2010-07-10 17:05:30 Creature 501565 used AI is EventAI.

2010-07-10 17:05:30 WORLD: Sent SMSG_AI_REACTION, type 2.

2010-07-10 17:05:30 WORLD: Sent SMSG_ATTACKSTART

2010-07-10 17:05:30 CreatureEventAI: DoScriptText: text entry=-5, Sound=0, Type=0, Language=0, Emote=0

2010-07-10 17:05:30 Sending SMSG_SPELL_START id=6268

2010-07-10 17:05:30 Creature (Entry: 448 Guid: 501565) chase to Player Testdudu (Guid: 6)

2010-07-10 17:05:30 Aura 138 now is remove mode 0

2010-07-10 17:05:30 creature 501565 stopped attacking player 6

2010-07-10 17:05:30 WORLD: Send SMSG_THREAT_CLEAR Message

2010-07-10 17:05:30 Creature 501565 used AI is EventAI.

2010-07-10 17:05:30 WORLD: Sent SMSG_AI_REACTION, type 2.

2010-07-10 17:05:30 WORLD: Sent SMSG_ATTACKSTART

2010-07-10 17:05:30 Sending SMSG_SPELL_START id=6268

2010-07-10 17:05:30 Creature (Entry: 448 Guid: 501565) chase to Player Testdudu (Guid: 6)

I think there is a problem: The mob seems to aggro the player two times!

-- EDIT: version one, just one mob including

http://paste2.org/p/910256

Server log:

2010-07-10 16:48:48 Player '6' Added Action '605' (type 0) to Button '4' for spec 0

2010-07-10 16:48:52 Command: gm off [Player: Testdudu (Account: 5) X: 64.627518 Y: -26.629271 Z: -10.173753 Map: 552 Selected: Creature (Entry: 20859 Guid: 501565)]

2010-07-10 16:48:57 creature 501565 stopped attacking player 6

2010-07-10 16:49:03 Send all time packets count: 317 bytes: 32956 avr.count/sec: 1.#INF00 avr.bytes/sec: 1.#INF00 time: 0

2010-07-10 16:49:03 Send last min packets count: 317 bytes: 32956 avr.count/sec: 5.283333 avr.bytes/sec: 549.266667

2010-07-10 16:49:56 creature 501565 stopped attacking player 6

-- version two, with many mobs

http://paste2.org/p/910238

What I did:

learned MindCOntrol (spellid 605)

Used MindControl with Gm.off on a mob1

started attacking mob2 with mob1

mob1 aggroed a few more mobs

I .die ed the other mobs

Aura wore off, mob1 started to attack me (heading my direction)

mob2 didn't move

Crash after a few seconds

My server log actions:

2010-07-10 16:34:15 Command: learn 605 [Player: Testdudu (Account: 5) X: -1.231650 Y: 0.014346 Z: -0.204380 Map: 552 Selected: None (Guid: 0)]

2010-07-10 16:34:20 BUTTON: 4 ACTION: 605 TYPE: 0

2010-07-10 16:34:20 MISC: Added Spell 605 into button 4

2010-07-10 16:34:20 Player '6' Added Action '605' (type 0) to Button '4' for spec 0

2010-07-10 16:34:26 WORLD: CMSG_CREATURE_QUERY 'Protean Nightmare' - Entry: 20864.

2010-07-10 16:34:32 Command: dam 500000 [Player: Testdudu (Account: 5) X: 53.464214 Y: -16.903543 Z: -4.323042 Map: 552 Selected: Creature (Entry: 20859 Guid: 501822)]

2010-07-10 16:34:57 Send all time packets count: 12750 bytes: 647917 avr.count/sec: 0.685447 avr.bytes/sec: 34.832375 time: 18601

2010-07-10 16:34:57 Send last min packets count: 157 bytes: 16044 avr.count/sec: 2.616667 avr.bytes/sec: 267.400000

2010-07-10 16:35:23 WORLD: CMSG_CREATURE_QUERY 'Eredar Soul-Eater' - Entry: 20879.

2010-07-10 16:35:55 Command: gm off [Player: Testdudu (Account: 5) X: 89.160309 Y: 3.210148 Z: -11.028415 Map: 552 Selected: Creature (Entry: 20859 Guid: 501821)]

2010-07-10 16:35:58 Send all time packets count: 12872 bytes: 653239 avr.count/sec: 0.689781 avr.bytes/sec: 35.005573 time: 18661

2010-07-10 16:35:58 Send last min packets count: 123 bytes: 5351 avr.count/sec: 2.016393 avr.bytes/sec: 87.721311

2010-07-10 16:35:58 HandlePetAction.Pet 501821 flag is 7, spellid is 2, target 501861.

2010-07-10 16:36:01 creature 501823 stopped attacking creature 501821

2010-07-10 16:36:01 Command: die [Player: Testdudu (Account: 5) X: 89.160309 Y: 3.210148 Z: -11.028415 Map: 552 Selected: Creature (Entry: 20857 Guid: 501823)]

2010-07-10 16:36:05 creature 501860 stopped attacking creature 501821

2010-07-10 16:36:05 Command: die [Player: Testdudu (Account: 5) X: 89.160309 Y: 3.210148 Z: -11.028415 Map: 552 Selected: Creature (Entry: 20857 Guid: 501860)]

2010-07-10 16:36:31 creature 501821 stopped attacking creature 501861

2010-07-10 16:36:31 creature 501861 stopped attacking creature 501821

2010-07-10 16:36:31 creature 501821 stopped attacking player 6

[zergtmn]

I can confirm crash on rev 10160, but my dump is different: http://paste2.org/p/910267

Such crash happens sometimes after dying in spirit of redemption form while MC'ing a mob.

[yasuno]

Yeah not sure what the anti-cheat guy was talking about i do not have anti-cheat at all lol. And yeah i dont understand the above level 80 thing either Lynx3d i just know it was working fine before the map updates.

And i dont see how your getting crashes on mind control with NPCS it works fine for me on NPCS but it crashes when used on PLAYERS. I cant believe this is still not fixed, or someone has at least told a way to disable it lol this is freaking killing me.

[wside420]

Yasuno. If your sanctuarys Arent working Due To Having > Level 80. Thats Unsupported. Theres Ways to Force Zones to be Sanctuarys by editing the code. The Mind Control bug will get fixed when it gets fixed...They Revamped A lot of stuff be happy. If its such a problem disable the spell.

[yasuno]

Well that was unhelpful... For 1 i know its unsupported but i was also noting the fact that the new level will be 85 and it stops at 81.

For 2, ive been trying to disable the spell for 16 hours, and i cant figure it out and i have yet to have any helpful response on how to disable the spell. I am not bashing any developers or recent commits. Please make sure you actually read my reply before making one.

Edit - Its ok i have just disabled it myself finally lol.. but its still broke and should be looked at.

[goodbadguy]

Could you SHARE with us how you disabled the spell?

[Schmoozerd]

Crash due MindControl Aura (of spell 605) on expire still present in _clean_ M Rev 10185

log

http://paste2.org/p/912485

related function:

   // remove expired auras
   for (SpellAuraHolderMap::iterator iter = m_spellAuraHolders.begin(); iter != m_spellAuraHolders.end()
   {
       SpellAuraHolder *holder = iter->second;
       if (holder)
       {
           if (!(holder->IsPermanent() || holder->IsPassive()) )
           {
               bool removedAura = false;
               for (int32 i = 0; i < MAX_EFFECT_INDEX; ++i)
               {
                   if (Aura *aura = holder->GetAuraByEffectIndex(SpellEffectIndex(i)))
                   {
                       [color="Red"]if (!aura->GetAuraDuration())[/color]
                       {
                           RemoveSingleAuraFromSpellAuraHolder(holder, aura->GetEffIndex(), AURA_REMOVE_BY_EXPIRE);
                           removedAura = true;
                       }
                   }
               }

               if (!removedAura)
                   ++iter;
               else
                   iter = m_spellAuraHolders.begin();
           }
           else
               ++iter;
       }
       else
           ++iter;
   }

that calls
[color=RED]        int32 GetAuraDuration() const { return m_duration; }[/color]

[MrGhost]

Confirmed. Also having a crash on mind control with a CLEAN MaNGOS..

[blackbahamut]

hi friends if you use Mind Control tu a player,you only can play with the player only 10seconds,whten 10secods are finished,server crash really I can play with player 1 minute while you're canalizing

[SilverIce]

Sadly, but i can't reproduсe these crashes

You may apply following patch - it almost disables camera functionality. So, if these crashes will gone - crashs caused by camera's SetView function or one of subsequent functions.

diff --git a/src/game/Camera.cpp b/src/game/Camera.cpp
index 2c37b15..a95be5e 100644
--- a/src/game/Camera.cpp
+++ b/src/game/Camera.cpp
@@ -39,6 +39,9 @@ void Camera::SetView(WorldObject *obj)
{
    ASSERT(obj);

+    m_owner.SetUInt64Value(PLAYER_FARSIGHT, (obj == &m_owner ? 0 : obj->GetGUID()));
+    return;
+
    if (m_source == obj)
        return;