[11723][PATCH]Auction House Bot

[Rog360]

Thanks Vladimir, I didn't notice my config ratio was wrong too. I Still had old config.. )

[firedervil11]

yep @ Pyromaniac, you right.

the problem is the german translation! Why? i don´t know.

Will make some more test wil the locales.

Thanks for help

[Schmoozerd]

http://paste2.org/p/1526564 - still existing crash related to AH (bot?)

If I am not mistaken the way to reproduce is:

- display a few items (ie empty search)

- buyout one item (direct buyout)

- let sort by some criteria

[herrtrigger]

Not nearly as important as the crash reports, but while we're at it:

https://github.com/mangos/mangos/blob/master/src/game/AuctionHouseBot/ahbot.conf.dist.in

# AuctionHouseBot.BuyPrice.Buyer

# Should the Buyer use BuyPrice or SellPrice to determine Bid Prices

# Default 0 (use SellPrice)

AuctionHouseBot.Buyer.Buyprice = 1

[Pyromaniac]

it seems to work with patch 11743

great work vladimir!!

[VladimirMangos]

[11743] expected fix only localization related crash, still exist crash in sorter not related to localization.

[VladimirMangos]

Not nearly as important as the crash reports, but while we're at it:

https://github.com/mangos/mangos/blob/master/src/game/AuctionHouseBot/ahbot.conf.dist.in

# AuctionHouseBot.BuyPrice.Buyer

# Should the Buyer use BuyPrice or SellPrice to determine Bid Prices

# Default 0 (use SellPrice)

AuctionHouseBot.Buyer.Buyprice = 1

In [11746] value set base at comment default value. Thank you.

[Pyromaniac]

[11743] expected fix only localization related crash, still exist crash in sorter not related to localization.

ok, couldn't really test the AH before 11743. i know what you mean now, played a little bit around, but don't have any ideas what could cause the crashes. seems kind of random for me at the moment...

[kreegoth]

Auctionhouse for me has crashes related to if i select it to be sorted by "Useable by character" if i use that filter it crashes. If i do not it does not crash. If i use that filter AND another filter it does not crash.

[VladimirMangos]

I not understood last description. "Useable by character" is filter as you say. So sorting by it impossible. It _can_ used in sort time but sort must be sby some from collumns. I test with/without "Useable by character" by different collumns and not get crash.

[added]Just after hit post button i get crash in auction sorting code. So i found possible source of problem. Not related for me to filters but related to way how we check some sorting cases.

[added2]sort assert fail case must be fixed in [11769]

[Rog360]

Just thought I'd mention, That the AHBOT buyer will buy things that you buy from a vendor for outrageous prices. My Daughters where buying Symbol of Kings and selling them on auction for around 5000 gold per stack. 8)

So, for now I'll disable the Buyer. Any way to stop this without disabling AHBOT Buyer?

One of my girls had over 8 million gold... :lol:

[herrtrigger]

Just thought I'd mention, That the AHBOT buyer will buy things that you buy from a vendor for outrageous prices. My Daughters where buying Symbol of Kings and selling them on auction for around 5000 gold per stack. 8)

So, for now I'll disable the Buyer. Any way to stop this without disabling AHBOT Buyer?

One of my girls had over 8 million gold... :lol:

Maybe a .conf setting for the buyer to ignore vendor items would be a good idea, true.

Also, projectiles, get bought at very high prices by the buyer (maybe because they stack up till 1000?).

[Schmoozerd]

maybe something very simple, like "max gold per day" as config variable

[antiroot]

I think the code for MaxBuyablePrice and other related checks need to be reviewed in this case. I also think if an item doesn't have Buyprice or Sellprice (depending on config) set in db then AHBot should ignore attempting to buy those items.

lets assume itemA is 3000 and we sell 1

BasePrice *= item->GetCount(); // == 3000

MaxBuyablePrice = ( BasePrice * config.BuyerPriceRatio )/100; // 6000 if(config.BuyerPriceRatio==200)

MaxBidablePrice = MaxBuyablePrice - ( MaxBuyablePrice / 30); // 5800

so AHbot should not buyout this item if its more than 6000 (0g60s00c) and should not bid over 5800 (0g58s00c).

I've seen players put low level white items up for thousands and ahbot still buys it so I think these area do require some investigation. This is just an assumption and i haven't looked into it enough to know for sure, but i'll do a little more research when i have time

also if itemA stacks for 20, ahbot should not buy it over 120000 (12g00s00c) or bid over 116000 (11g60s00c) based on the math above which is from the ahbot source

[herrtrigger]

I think the code for MaxBuyablePrice and other related checks need to be reviewed in this case. I also think if an item doesn't have Buyprice or Sellprice (depending on config) set in db then AHBot should ignore attempting to buy those items.

lets assume itemA is 3000 and we sell 1

BasePrice *= item->GetCount(); // == 3000

MaxBuyablePrice = ( BasePrice * config.BuyerPriceRatio )/100; // 6000 if(config.BuyerPriceRatio==200)

MaxBidablePrice = MaxBuyablePrice - ( MaxBuyablePrice / 30); // 5800

so AHbot should not buyout this item if its more than 6000 (0g60s00c) and should not bid over 5800 (0g58s00c).

I've seen players put low level white items up for thousands and ahbot still buys it so I think these area do require some investigation. This is just an assumption and i haven't looked into it enough to know for sure, but i'll do a little more research when i have time

also if itemA stacks for 20, ahbot should not buy it over 120000 (12g00s00c) or bid over 116000 (11g60s00c) based on the math above which is from the ahbot source

That sounds very nice indeed.

[Goolash]

This week-end I'll try to update with this core and do some test, my server is on a VM-box (ubuntu) on a win 7 machine

and the client is on a win 7 machine

I'll give my detail if it works fine

[rhaziel]

hello boys,

do you know maybe if this can be used with lates mangos0 compile??

[TheLuda]

A mangos-zero port is incoming.

[rhaziel]

hey boys, if i have downloaded git for newest mangos how can i apply this to it?

[cyberium]

Happy to see this in the core. Thanks all.

[Famine]

A mangos-zero port is incoming.

Did this ever come to fruition? Looking to start playing around with the zero branch and if it hasn't may be able to help out with that.

[tibbi]

where is it defined, how often does the bot put items to auction ?

[Unkle Nuke]

That is controled by the following two settings in ahbot.conf :

AuctionHouseBot.MinTime

# Minimum time for the new auction

# Default 1 (Hour)

#

# AuctionHouseBot.MaxTime

# Maximum time for the new auction

# Default 72 (Hours)

[tibbi]

I thought it from the description too, but its not that. That just sets the length of the auction (for how long can people bid for your item), not the frequence of putting items to AH.

[Pyromaniac]

the faster the items disappear, the faster the AHBot will put new items into the AH.

if you set Maxtime to 2 hours, alle your items will be "renewed" every 2 hours. so, i would say this should be a "very high frequency"

edit: or maybe you want to know something different i think AHBot trys to fill the AH about every 20 seconds.