[11723][PATCH]Auction House Bot

[EARTHWALKER]

Fantastic Vlad, you're the man.

Been running this since about 2 minutes after the update and all seems to be working very well indeed.

[tyrael]

so what's next great patch playerbot?

[tim]

I want to say Thank you Vladimir for finally implement this to core. And thank you for all guys out there who have worked on this great patch.

[Rog360]

Yes, Thanks to all involved...

[CharlesPs]

Nice to see AHBOT in core

[Pyromaniac]

hm, am i the only one with a crashing mangos when interacting with the auction house?

I try to explain my experience:

my System: Ubuntu 11.04 (32bit)

Mangos: 11733

Patches: SD2

Database: UDB + GMDB

when mangos startet the first time with the activated AHBot everything was ok. but after several minutes (lets say ~10, don't know exactly) it was crashing everytime i've searched anything in the AH. restarting mangos didn't helped, so i truncated the "auction"-field in the characters-database and restartet mangos. from now on it was the same, the first ~10 minutes die AH worked, after that mangos crashed.

the last logfile-line is always:

2011-07-11 18:29:55 WORLD: HandleAuctionListItems

sorry for the developers, i can't tell you more. anyone here with a similar behavior?

edit: i've noticed that after a crash, die alliance and horde auctions houses are "empty" when typing "ahbot status". the neutral AH is not empty.

[Schmoozerd]

indeed - I buyed some item, sorted multiple times, and then got this crash:

http://paste2.org/p/1514638

(not perfectly clean mangos, but no changes in any related area)

[EARTHWALKER]

I was getting a few of the above errors, so I just truncated the Characters\\Tables\\auction table. Now all works fine. Related, or coincidence? You decide

Worth a shot though eh

[hyuga]

Working fine in 11728 for over a day now. Sold and bought at the AH with no issues. It is awesome that this is now part of core. Great work!

Playerbot has my vote (not that my vote would matter) to be included in core!

[herrtrigger]

This might help with ahbot crashing upon browsing items (i guess):

https://github.com/mangos/mangos/commit/d351e203347e1ded48baae304e4ab93affeab915

[Pyromaniac]

nope, unfortunately not, still crashing

[zergtmn]

This might help with ahbot crashing upon browsing items (i guess):

https://github.com/mangos/mangos/commit/d351e203347e1ded48baae304e4ab93affeab915

That's just small speedup and reduction in number of memory allocations.

From Schmoo's crash dump I can see that AuctionSorter predicate is not strict weak ordering. That's the problem.

[herrtrigger]

Ow, ok.

Thx for clearing up.

[Pyromaniac]

[11739] Fixed possible crash after auction loading with wrong houseid field value.

still crashing, and after a restart of mangos all auctions are still in "neutral"-house again

[cedside]

Auction House Bot crash for me too...

[demon]

Just Shutdown MaNGOS server and clean the Characters\\auction table.

[Pyromaniac]

@demon: jep, i did

tested again: worked for about ~10 minutes, searching, sort "current bid"... then i've clicked sort by "rarity" --> crash

[Sky1]

Finally Auction House Bot is accepted. Thank you very much for this....Mangos Admi/Devs.

[VladimirMangos]

and after a restart of mangos all auctions are still in "neutral"-house again

what you meaning? auction moved at loading to wrong auction house?

[demon]

tested again: worked for about ~10 minutes, searching, sort "current bid"... then i've clicked sort by "rarity" --> crash

for me it work, I do not have this problem sorry.

[Pyromaniac]

and after a restart of mangos all auctions are still in "neutral"-house again

what you meaning? auction moved at loading to wrong auction house?

yes, that's what i meant. and it doesn't matter whether its after a crash or after a regular restart per "server restart xx".

what do i have to do to get such error-messages like the one that schmoozerd postet? I think that would be more helpful for you and the other developers...

[Pyromaniac]

maybe I've found something what causes the crashes. I've truncated "locales_item" and "locales_gameobject" in the mangos-db (I'm using the german-translation GMDB) and now it runs since 30 mins. without a crash.

edit: runtime meanwhile more than 21 hour without crash

[Azelen]

Hmm found something interesting in config file. line 77 and down:

# AuctionHouseBot.Alliance.Price.Ratio

# Define the price of selled item here for the Alliance Auction House

# Default 200

#

# AuctionHouseBot.Horde.Price.Ratio

# Define the price of selled item here for the Horde Auction House

# Default 200

#

# AuctionHouseBot.Alliance.Price.Ratio

# Define the price of selled item here for the Neutral Auction House

# Default 200

Should it be like this?

[Rog360]

Should Be..

# AuctionHouseBot.Alliance.Price.Ratio

# Define the price of selled item here for the Alliance Auction House

# Default 100

#

# AuctionHouseBot.Horde.Price.Ratio

# Define the price of selled item here for the Horde Auction House

# Default 100

#

# AuctionHouseBot.Neutral.Price.Ratio

# Define the price of selled item here for the Neutral Auction House

# Default 100

Has it right where it counts...

AuctionHouseBot.Alliance.Price.Ratio = 200

AuctionHouseBot.Horde.Price.Ratio = 200

AuctionHouseBot.Neutral.Price.Ratio = 200

[VladimirMangos]

It don't must be 100. This how high auction price from item default price.

Where you see item prices at auction = default price for vendors.

Hmm found something interesting in config file. line 77 and down:

# AuctionHouseBot.Alliance.Price.Ratio

# Define the price of selled item here for the Neutral Auction House

# Default 200

Should it be like this?

Fixed in [11742]. Thank you.