[not working] Outdoor Pvp

[KAPATEJIb]

http://filebeam.com/995272805b9c15b4fc8280d824da614c

[Thyros]

thanks you

[balrok]

again a filebeam error - for the update i fixed the spelleffects-merge-error (very easy)

then for getmap i had to change in outdoorpvpsi.cpp

Map * map = MapManager::Instance().GetMap(plr->GetMapId(), plr);

to

Map * map = plr->GetMap();

in function: HandleDropFlag

i hope everything else will play well together with the getmap-patch

if you get strange new errors please report

-----

outdoor-0.12 is also updated (again the spelleffect-mergething).. i haven't checked for compile-problems, but since mangos-0.12 is just a subset of master, and the getmap-patch is not in mangos-0.12, i think there should be no problems

[yad02]

Compile fix for 8190+

Maybe new void KilledMonster( CreatureInfo const* cInfo, uint64 guid ); could be used...

--------------------------- src/game/OutdoorPvP.cpp ---------------------------
index c43cf89..51d09ce 100644
@@ -582,7 +582,7 @@ void OutdoorPvPObjective::SendObjectiveComplete(uint32 id,uint64 guid)
        Player * plr = objmgr.GetPlayer(*itr);
        if(plr && plr->GetTeam() == controlling_faction)
        {
-            plr->KilledMonster(id,guid);
+            plr->KilledMonsterCredit(id,guid);
        }
    }
}

-------------------------- src/game/OutdoorPvPNA.cpp --------------------------
index c0456c1..65105c6 100644
@@ -32,7 +32,7 @@ void OutdoorPvPNA::HandleKillImpl(Player *plr, Unit * killed)
{
    if(killed->GetTypeId() == TYPEID_PLAYER && plr->GetTeam() != ((Player*)killed)->GetTeam())
    {
-        plr->KilledMonster(NA_CREDIT_MARKER,0); // 0 guid, btw it isn't even used in killedmonster function 
+        plr->KilledMonsterCredit(NA_CREDIT_MARKER,0); // 0 guid, btw it isn't even used in killedmonster function 
        if(plr->GetTeam() == ALLIANCE)
            plr->CastSpell(plr,NA_KILL_TOKEN_ALLIANCE,true);
        else

-------------------------- src/game/OutdoorPvPSI.cpp --------------------------
index 4c7ae9f..7afb9f7 100644
@@ -150,7 +150,7 @@ bool OutdoorPvPSI::HandleAreaTrigger(Player *plr, uint32 trigger)
                // add 20 cenarion circle repus
                plr->GetReputationMgr().ModifyReputation(sFactionStore.LookupEntry(609), 20);
                // complete quest
-                plr->KilledMonster(SI_TURNIN_QUEST_CM_A,0);
+                plr->KilledMonsterCredit(SI_TURNIN_QUEST_CM_A,0);
            }
            return true;
        case SI_AREATRIGGER_H:
@@ -176,7 +176,7 @@ bool OutdoorPvPSI::HandleAreaTrigger(Player *plr, uint32 trigger)
                plr->GetReputationMgr().ModifyReputation(sFactionStore.LookupEntry(609), 20);

                // complete quest
-                plr->KilledMonster(SI_TURNIN_QUEST_CM_H,0);
+                plr->KilledMonsterCredit(SI_TURNIN_QUEST_CM_H,0);
            }
            return true;
    }

[balrok]

thank you,

i will run a testcompile first and then upload it.. outdoor-0.12 gets fixed in a few minutes too

edit: i'm not sure if this is my problem or mangos-0.12 but for outdoor-0.12 i get

"make[3]: *** No rule to make target `2008_12_22_01_mangos_creature_equip_template.sql', needed by `all-am'. Stop." so i couldn't run a testcompile..

i have currently not much time to investigate, so maybe some can test it for me

edit: thank you fullburned.. and freghar already fixed it

[fullburned]

thank you,

i will run a testcompile first and then upload it.. outdoor-0.12 gets fixed in a few minutes too

edit: i'm not sure if this is my problem or mangos-0.12 but for outdoor-0.12 i get

"make[3]: *** No rule to make target `2008_12_22_01_mangos_creature_equip_template.sql', needed by `all-am'. Stop." so i couldn't run a testcompile..

i have currently not much time to investigate, so maybe some can test it for me

That's mangos-0.12 problem, only on unix again:) You should remove trailing backslashes...

diff --git a/sql/updates/Makefile.am b/sql/updates/Makefile.am
index fd7292a..ae9f46f 100644
--- a/sql/updates/Makefile.am
+++ b/sql/updates/Makefile.am
@@ -91,7 +91,7 @@ pkgdata_DATA = \\
    051_8158_01_mangos_playercreateinfo_action.sql \\
    052_8072_01_characters_characters.sql \\
    052_8072_02_characters_characters.sql \\
-    053_8190_01_mangos_creature_template.sql \\  
+    053_8190_01_mangos_creature_template.sql \\
    README

## Additional files to include when running 'make dist'
@@ -162,5 +162,5 @@ EXTRA_DIST = \\
    051_8158_01_mangos_playercreateinfo_action.sql \\
    052_8072_01_characters_characters.sql \\
    052_8072_02_characters_characters.sql \\
-    053_8190_01_mangos_creature_template.sql \\  
+    053_8190_01_mangos_creature_template.sql \\
    README

outdoor pvp code compiles fine, though.

[andyme]

2009-07-21 08:56:02 Halting process...

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200008

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200009

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200010

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200011

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200012

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200019

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200018

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200017

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200016

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200021

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200020

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200023

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200022

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200002

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200001

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200004

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200003

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200006

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200005

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200007

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200015

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find creature guid: 200030

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find creature guid: 200031

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200013

2009-07-21 08:56:02 ERROR:OutdoorPvPObjective: Can't find gobject guid: 200014

[balrok]

thats not critical i think.. but it needs a rewrite of the spawnfunctions, which i won't do in the next time

[Fell]

Why does this never get into the offical branch? I mean, it is completely blizzlike feature like battlegrounds. So why doesn't Vladimir apply it to the core?

[Thyros]

Officialwriter have leave mangos, and balrok is the new developer, vladimir add nothing custom patches.

[Fell]

Why is OutdoorPvP custom? It's available on all original servers just like with this patch.

[GriffonHeart]

I started work with Wintergrasp, but I have a question. Is Wintergrasp already implemented?

[Thyros]

no is not implemented, and needed Vehicle Support.

[balrok]

griffonheart: i think only the files for it exist.. maybe trinity has already something done for it.. but i'm not sure..

fell: this patch needs to be read at least once, cause it's quite big, and making changes afterwards is more difficult than a change before..

and reviewing must be done, cause if noone understands this patch, it will be hard to implement things in future..

also i see no problem in using this branch.. it's quite up to date all the time

[andriuspel]

someone can edit first this topic post and put working github links?

[redcore]

I have success with this patch on latest mangos build. But one issue I got with triggers which are hostile and decrease player by 1 hp. Does someone know which flags are incorrect for trigger creatures?

[balrok]

try with faction_a and faction_h = 75

(don't know if this is the best solution - but those faction should make this creature friendly to the world)

if you have a (tested+working) sql-query then, you can post here or pm me, so i can add it to the repository

@andriuspel:

i think i wanted to do it since i took over the repository, thanks for reminding me

i hope my text there is understandable..

[lucamors1]

hi,

i want know when this patch will be added to the repository.

thank you.

lucamors

[JordanMckeag]

When is this going to be added to the svn

[Neo2003]

I think proper content of firebomb.sql should be this instead of current. There is missing 11 for event_type and one 0 to remove.

-- Execute on MaNGOS DB

-- Fire bomb script

DELETE FROM `creature_ai_scripts` WHERE `creature_id` = 18225;
INSERT INTO `creature_ai_scripts`(`creature_id`,`event_type`,`event_inverse_phase_mask`,`event_chance`
,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action1_type`,`action1_param1`
,`action1_param2`,`action1_param3`,`action2_type`,`action2_param1`,`action2_param2`,`action2_param3`,
`action3_type`,`action3_param1`,`action3_param2`,`action3_param3`,`comment`) VALUES
(18225,11,0,100,0,0,0,0,0,11,31961,0,4,0,0,0,0,0,0,0,0,'Fire Bomb Target cast Fire Bomb on Spawn'),
(18225,11,0,100,5000,0,5000,0,0,37,0,0,0,0,0,0,0,0,0,0,0,'Fire Bomb Target Despawn');

UPDATE creature_template SET AIName = 'EventAI', ScriptName='' WHERE `entry` = 18225;

[balrok]

hello, thank you very much.. i'm not good with eventai, so i waited until now for someone who can do this ..

i will wait until tomorrow, or the day after it and then add it to repo (until then everybody can complain or correct it ^^)

is this query also for master? - or is the eventai in master the same like in mangos-0.12 ?

also i plan to change the id of this eventai-script to something random, which wouldn't overwrite acid-scripts

----

jordanmckeag:

i also pm'ed you, but maybe other need an answer too..

answer can also be found in the thread somewhere..

the coding style isn't very good, but no-one wants to look at it..

also if you stop your server it will spam some errors about wrong guids.. i guess it's from OutdoorPvP::addobject() but it's just a guess..

[balrok]

sorry for the late response.. but this eventai doesn't work for me.. for me it looks like eventai is still broken there

[ankso]

I´m testing it on my server and the flag in The Overlook at Hellfire can´t be conquested. I´m using MaNGOS rev. 8415

Note: I love this patch, now I´m trying to learn C++ to help, good work guys

Note2: Sorry for my bad english, I´m spanish...

[Macedonien]

Hi Mangos Team!

First of all , I want to thank you all for your great work! Second, i'm working with a GM on the server I play to make Halaa work as it normally should work, we fixed every aspect but there's a pain in the *ss, every time a player aggro's a guard, the guard doesn't return on the place he normally should be. Well it's the first time i went on getmangos, i'm not a programmer, the GM is, and he's desesperate We're still in 2.4.3 debugging it completely and then hop on to 3.0.x

Can someone help us please, (if you do, 4000 players will be happy )

With Kind Regards,

Macedonien

[Quetzacoalt]

every time a player aggro's a guard, the guard doesn't return on the place he normally should be.

If I can add ... he wants to mean the guards never go back to their home position when they leave the combat mode. We tried few corrections, such has add a IA script, modify the summoning function ... without success ...

Thanks for your help.