[not working] Outdoor Pvp

[mrelfire]

Officialwriter have leave mangos, and balrok is the new developer, vladimir add nothing custom patches.

is it true that Vladimir doesn't want to implement this patch (the same for alterac valley ?) ?

[DasBlub]

is it true that Vladimir doesn't want to implement this patch (the same for alterac valley ?) ?

no, that's wrong.

it's simply so, that neither the outdoor-pvp nor the alterac patch are ready to go into the repo. therefore they stay in here and are under further development.

and yes, the original authors have left mangos, so others have first to learn, what the code does exactly, else they can't maintain it later.

so if this code will be ready and a mangos dev (probably balrok?) has learned how to maintain this code (as it contains much changes to mangos), they'll completely review it and commit it.

[therapist]

This is not bad.

They just don't want to go subbmiting every patch people do as people need to test it first otherwise there will be quite a lot of stablilty issues

[yad02]

Can you fix conflicts with it http://github.com/mangos/mangos/commit/a54f2aaed43bf84b7146acbc2c01613164a49cef

please.

[beleko]

Can someone please patch current default type for mangos 0:12

[wormyke]

Any news on this? I saw that Balrok has started to implement some BG functions into the Master branch. It would be good if this will be there as soon as possible...:huh:

[The_Game_Master]

I think it requires some extra functions, but with the current bg2db patch in master this should not be needed anymore.

[cyrex]

So is this working on Master? since you say is not needed anymore

[The_Game_Master]

You missed the part when i said that it required some extra functions for master.

[cyrex]

I did not see that part. Are you sure you put it (The_Game_Master stabs Cyrex in the back..puts the body in a garbage can i keeps on writing)....oh right right, totally right. I did not see it before

[The_Game_Master]

Ok sorry. :lol:

[yad02]

Do you think it's the good way to fix conflicts with 3.2.2 ?

void Player::UpdateZone(uint32 newZone, uint32 newArea)
{
   AreaTableEntry const* zone = GetAreaEntryByAreaID(newZone);
   if(!zone)
       return;

   uint32 oldZoneId  = m_zoneUpdateId;

   if(m_zoneUpdateId != newZone)
   {
       SendInitWorldStates(newZone, newArea);              // only if really enters to new zone, not just area change, works strange...

       if (sWorld.getConfig(CONFIG_WEATHER))
       {
           if(Weather *wth = sWorld.FindWeather(zone->ID))
               wth->SendWeatherUpdateToPlayer(this);
           else if(!sWorld.AddWeather(zone->ID))
           {
               // send fine weather packet to remove old zone's weather
               Weather::SendFineWeatherUpdateToPlayer(this);
           }
       }
   }

   m_zoneUpdateId    = newZone;
   m_zoneUpdateTimer = ZONE_UPDATE_INTERVAL;

   // zone changed, so area changed as well, update it
   UpdateArea(newArea);

   // inform outdoor pvp
   if(oldZoneId != m_zoneUpdateId)
   {
       sOutdoorPvPMgr.HandlePlayerLeaveZone(this, oldZoneId);
       sOutdoorPvPMgr.HandlePlayerEnterZone(this, m_zoneUpdateId);
   }    

   // in PvP, any not controlled zone (except zone->team == 6, default case)
   // in PvE, only opposition team capital
   switch(zone->team)
   {
[...]

[balrok]

my solution was a bit different - i got rid of this oldZoneId variable

so everything got quite short:

 6251     if(m_zoneUpdateId != newZone)
6252     {
6253         // inform outdoor pvp
6254         sOutdoorPvPMgr.HandlePlayerLeaveZone(this, m_zoneUpdateId);
6255         sOutdoorPvPMgr.HandlePlayerEnterZone(this, newZone);
6256 
6257         SendInitWorldStates(newZone, newArea);              // only if really enters to new zone, not just area change, works strange...
6258 
6259         if (sWorld.getConfig(CONFIG_WEATHER))
6260         {

i just did a quick test and hope it still works as expected (:

[NetSky]

balrok are you already working on wintergrasp outdoor pvp? if yes let me join development there

[Sephiroth1983]

balrok are you already working on wintergrasp outdoor pvp? if yes let me join development there

Yeah please work on Wintergrasp as soon as this patch is ready

to testers/users: TEST!

[The_Game_Master]

Anybody got any ideea with what "SendUpdateObjectToAllExcept" was replaced with?

../../../src/game/OutdoorPvPEP.cpp: In member function 'virtual bool OutdoorPvPObjectiveEP_EWT::Update(uint32)':
../../../src/game/OutdoorPvPEP.cpp:109: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp:114: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp: In member function 'virtual bool OutdoorPvPObjectiveEP_NPT::Update(uint32)':
../../../src/game/OutdoorPvPEP.cpp:280: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp:285: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp: In member function 'virtual bool OutdoorPvPObjectiveEP_CGT::Update(uint32)':
../../../src/game/OutdoorPvPEP.cpp:445: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp:450: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp: In member function 'virtual bool OutdoorPvPObjectiveEP_PWT::Update(uint32)':
../../../src/game/OutdoorPvPEP.cpp:611: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp:616: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
make[3]: *** [OutdoorPvPEP.o] Error 1
make[3]: Leaving directory `/root/mangos/

http://github.com/mangos/mangos/commit/3209e0a7dfaf44d6db43c02f985a89a4b99c9437

[mistico911]

Anybody got any ideea with what "SendUpdateObjectToAllExcept" was replaced with?

../../../src/game/OutdoorPvPEP.cpp: In member function 'virtual bool OutdoorPvPObjectiveEP_EWT::Update(uint32)':
../../../src/game/OutdoorPvPEP.cpp:109: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp:114: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp: In member function 'virtual bool OutdoorPvPObjectiveEP_NPT::Update(uint32)':
../../../src/game/OutdoorPvPEP.cpp:280: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp:285: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp: In member function 'virtual bool OutdoorPvPObjectiveEP_CGT::Update(uint32)':
../../../src/game/OutdoorPvPEP.cpp:445: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp:450: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp: In member function 'virtual bool OutdoorPvPObjectiveEP_PWT::Update(uint32)':
../../../src/game/OutdoorPvPEP.cpp:611: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
../../../src/game/OutdoorPvPEP.cpp:616: error: 'class GameObject' has no member named 'SendUpdateObjectToAllExcept'
make[3]: *** [OutdoorPvPEP.o] Error 1
make[3]: Leaving directory `/root/mangos/

http://github.com/mangos/mangos/commit/3209e0a7dfaf44d6db43c02f985a89a4b99c9437

Bump up! i hope someone answers...

[thenecromancer]

If you set a byte value server should update those object for nearby players, and you probably can remove those functions out of the patch.

If this does not work ( eg. GO art is not updated for clients nearby ) then it probably needs other kind of fix.

In other words, those lines are kind of hack that shouldn't be needed.

[Christian Schamara]

[color="Red"]//[/color]SendUpdateObjectToAllExcept

so you can fix these errors

Index: src/game/OutdoorPvPEP.cpp
===================================================================
--- src/game/OutdoorPvPEP.cpp    (revision 1)
+++ src/game/OutdoorPvPEP.cpp    (working copy)
@@ -98,12 +98,12 @@
            if(flag)
            {
                flag->SetGoArtKit(artkit);
[color="Red"]-                flag->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+                //flag->SendUpdateObjectToAllExcept(NULL);[/color]
            }
            if(flag2)
            {
                flag2->SetGoArtKit(artkit);
[color="Red"]-                flag2->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+                //flag2->SendUpdateObjectToAllExcept(NULL);[/color]
            }


@@ -273,12 +273,12 @@
            if(flag)
            {
                flag->SetGoArtKit(artkit);
[color="Red"]-                flag->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+                //flag->SendUpdateObjectToAllExcept(NULL);[/color]
            }
            if(flag2)
            {
                flag2->SetGoArtKit(artkit);
[color="Red"]-                flag2->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+                //flag2->SendUpdateObjectToAllExcept(NULL);[/color]
            }

            UpdateTowerState();
@@ -442,12 +442,12 @@
            if(flag)
            {
                flag->SetGoArtKit(artkit);
[color="Red"]-                flag->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+                //flag->SendUpdateObjectToAllExcept(NULL);[/color]
            }
            if(flag2)
            {
                flag2->SetGoArtKit(artkit);
[color="Red"]-                flag2->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+                //flag2->SendUpdateObjectToAllExcept(NULL);[/color]
            }

            UpdateTowerState();
@@ -612,12 +612,12 @@
            if(flag)
            {
                flag->SetGoArtKit(artkit);
[color="Red"]-                flag->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+                //flag->SendUpdateObjectToAllExcept(NULL);[/color]
            }
            if(flag2)
            {
                flag2->SetGoArtKit(artkit);
[color="Red"]-                flag2->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+                //flag2->SendUpdateObjectToAllExcept(NULL);[/color]
            }

            UpdateTowerState();
Index: src/game/OutdoorPvPHP.cpp
===================================================================
--- src/game/OutdoorPvPHP.cpp    (revision 1)
+++ src/game/OutdoorPvPHP.cpp    (working copy)
@@ -251,12 +251,12 @@
            if(flag)
            {
                flag->SetGoArtKit(artkit);
[color="Red"]-                flag->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+                //flag->SendUpdateObjectToAllExcept(NULL);[/color]
            }
            if(flag2)
            {
                flag2->SetGoArtKit(artkit2);
[color="Red"]-                flag2->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+                //flag2->SendUpdateObjectToAllExcept(NULL);[/color]
            }

            // send world state update
Index: src/game/OutdoorPvPNA.cpp
===================================================================
--- src/game/OutdoorPvPNA.cpp    (revision 1)
+++ src/game/OutdoorPvPNA.cpp    (working copy)
@@ -645,7 +645,7 @@
            if(flag)
            {
                flag->SetGoArtKit(artkit);
[color="Red"]-                flag->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+                //flag->SendUpdateObjectToAllExcept(NULL);[/color]
            }

            UpdateHalaaWorldState();
Index: src/game/OutdoorPvPTF.cpp
===================================================================
--- src/game/OutdoorPvPTF.cpp    (revision 1)
+++ src/game/OutdoorPvPTF.cpp    (working copy)
@@ -344,7 +344,7 @@
            if(flag)
            {
                flag->SetGoArtKit(artkit);
[color="Red"]-                flag->SendUpdateObjectToAllExcept(NULL);[/color]
[color="Lime"]+               //flag->SendUpdateObjectToAllExcept(NULL);[/color]
            }

            UpdateTowerState();

[DasBlub]

salja: commenting out some code is not 'fixing' it

maybe you break the whole code with that... but as i don't know exactly what has been changed with the commit ,which is affecting that function, i don't know what it will cause.

[thenecromancer]

DasBlub: Please read again what did I wrote, thanks.

[The_Game_Master]

I works ok. Allready tested it.

[balrok]

lol realy?

since i still didn't find out for what reason setgoartkit was added (as the name sounds - it can change the model of a gameobject maybe) it would help much to remove wrong / not needed code, which is surrounding this unknown thing.. ^^

so i apply your patch right now.. if other people say it changes things the bad way, they can post here - then we can use a better patch

edit: setgoartkit calls SetByteValue

and setbytevalue calls ObjectAccessor::Instance().AddUpdateObject(this);

which sounds good for me )

realy nice solution then

[Daimon22]

if my memory is correct, goartkit tells the go which graphical state it should display to the world (n/a/h flag state for outdoorpvp as example).

[yad02]

Does someone has idea to fix compile since [8653] Implemented per map guids store. ?