Jump to content

[not working] Outdoor Pvp

Auntie Mangos

By Auntie Mangos
in OldCore modifications

 Share

Recommended Posts

  • Replies 621
  • Created
  • Last Reply

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

XTZGZoReX Advanced Member

XTZGZoReX

Posted
Posted
check also next commit after this linked by balrok. And second thing aren't we supposed to make sure if pointer to map was successfully created by using if (Map* map = ....)?
Inside an OutdoorPvP class, the _map can _never_ be NULL, because, if it is, then there wouldn't be anything that could even call any methods on the OutdoorPvP object.

Because if there is no world map, there are no players on it, and therefore, no one to call opvp events. So map must never be null in the places where ->GetMap() is called. Also, check this: http://bitbucket.org/kane/infinitycore/changeset/4b305e9b9b1e/

Link to comment
Share on other sites
KAPATEJIb Advanced Member

KAPATEJIb

Posted
Posted 

mangos>
..\\..\\src\\game\\OutdoorPvPMgr.cpp:94 in OutdoorPvPMgr::NotifyMapAdded ASSERTION F
AILED:
 !map->Instanceable()
MapInstanced::MapInstanced() c:\\mang\\src\\game\\mapinstanced.cpp: 28 + 0x4b
MapManager::_createBaseMap() c:\\mang\\src\\game\\mapmanager.cpp: 118 + 0x33
MapManager::CreateMap() c:\\mang\\src\\game\\mapmanager.cpp: 135 + 0xf
WorldSession::HandleMoveWorldportAckOpcode() c:\\mang\\src\\game\\movementhandler.cp
p: 68 + 0x2e
WorldSession::HandleMoveWorldportAckOpcode() c:\\mang\\src\\game\\movementhandler.cp
p: 39 + 0x0
WorldSession::Update() c:\\mang\\src\\game\\worldsession.cpp: 224 + 0x0
World::UpdateSessions() c:\\mang\\src\\game\\world.cpp: 2076 + 0x18
World::Update() c:\\mang\\src\\game\\world.cpp: 1617 + 0x0
WorldRunnable::run() c:\\mang\\src\\mangosd\\worldrunnable.cpp: 65 + 0x0
ACE_Based::Thread::ThreadTask() c:\\mang\\src\\shared\\threading.cpp: 186 + 0x0
ACE_OS_Thread_Adapter::invoke()+0x74 [0x0]
endthreadex()+0x44 [0x0]
endthreadex()+0xd8 [0x0]
FlsSetValue()+0x136 [0x0]


..\\..\\src\\game\\OutdoorPvPMgr.cpp:94 in OutdoorPvPMgr::NotifyMapAdded ASSERTION F
AILED:
 !map->Instanceable()
InstanceMap::InstanceMap() c:\\mang\\src\\game\\map.cpp: 2268 + 0x49
MapInstanced::CreateInstance() c:\\mang\\src\\game\\mapinstanced.cpp: 205 + 0x7d
MapInstanced::CreateInstance() c:\\mang\\src\\game\\mapinstanced.cpp: 172 + 0x18
MapManager::CreateMap() c:\\mang\\src\\game\\mapmanager.cpp: 137 + 0x3d
WorldSession::HandleMoveWorldportAckOpcode() c:\\mang\\src\\game\\movementhandler.cp
p: 68 + 0x2e
WorldSession::HandleMoveWorldportAckOpcode() c:\\mang\\src\\game\\movementhandler.cp
p: 39 + 0x0
WorldSession::Update() c:\\mang\\src\\game\\worldsession.cpp: 224 + 0x0
World::UpdateSessions() c:\\mang\\src\\game\\world.cpp: 2076 + 0x18
World::Update() c:\\mang\\src\\game\\world.cpp: 1617 + 0x0
WorldRunnable::run() c:\\mang\\src\\mangosd\\worldrunnable.cpp: 65 + 0x0
ACE_Based::Thread::ThreadTask() c:\\mang\\src\\shared\\threading.cpp: 186 + 0x0
ACE_OS_Thread_Adapter::invoke()+0x74 [0x0]
endthreadex()+0x44 [0x0]
endthreadex()+0xd8 [0x0]
FlsSetValue()+0x136 [0x0]


..\\..\\src\\game\\OutdoorPvPMgr.cpp:117 in OutdoorPvPMgr::NotifyMapDeleted ASSERTIO
N FAILED:
 !map->Instanceable()
InstanceMap::~InstanceMap() c:\\mang\\src\\game\\map.cpp: 2284 + 0xf
InstanceMap::`vector deleting destructor'()+0x50 [0x0]
MapInstanced::DestroyInstance() c:\\mang\\src\\game\\mapinstanced.cpp: 251 + 0x25
MapInstanced::Update() c:\\mang\\src\\game\\mapinstanced.cpp: 60 + 0x0
MapManager::Update() c:\\mang\\src\\game\\mapmanager.cpp: 269 + 0x0
World::Update() c:\\mang\\src\\game\\world.cpp: 1654 + 0x0
WorldRunnable::run() c:\\mang\\src\\mangosd\\worldrunnable.cpp: 65 + 0x0
ACE_Based::Thread::ThreadTask() c:\\mang\\src\\shared\\threading.cpp: 186 + 0x0
ACE_OS_Thread_Adapter::invoke()+0x74 [0x0]
endthreadex()+0x44 [0x0]
endthreadex()+0xd8 [0x0]
FlsSetValue()+0x136 [0x0]


..\\..\\src\\game\\OutdoorPvPMgr.cpp:94 in OutdoorPvPMgr::NotifyMapAdded ASSERTION F
AILED:
 !map->Instanceable()
InstanceMap::InstanceMap() c:\\mang\\src\\game\\map.cpp: 2268 + 0x49
MapInstanced::CreateInstance() c:\\mang\\src\\game\\mapinstanced.cpp: 205 + 0x7d
MapInstanced::CreateInstance() c:\\mang\\src\\game\\mapinstanced.cpp: 172 + 0x18
MapManager::CreateMap() c:\\mang\\src\\game\\mapmanager.cpp: 137 + 0x3d
WorldSession::HandleMoveWorldportAckOpcode() c:\\mang\\src\\game\\movementhandler.cp
p: 68 + 0x2e
WorldSession::HandleMoveWorldportAckOpcode() c:\\mang\\src\\game\\movementhandler.cp
p: 39 + 0x0
WorldSession::Update() c:\\mang\\src\\game\\worldsession.cpp: 224 + 0x0
World::UpdateSessions() c:\\mang\\src\\game\\world.cpp: 2076 + 0x18
World::Update() c:\\mang\\src\\game\\world.cpp: 1617 + 0x0
WorldRunnable::run() c:\\mang\\src\\mangosd\\worldrunnable.cpp: 65 + 0x0
ACE_Based::Thread::ThreadTask() c:\\mang\\src\\shared\\threading.cpp: 186 + 0x0
ACE_OS_Thread_Adapter::invoke()+0x74 [0x0]
endthreadex()+0x44 [0x0]
endthreadex()+0xd8 [0x0]
FlsSetValue()+0x136 [0x0]


..\\..\\src\\game\\OutdoorPvPMgr.cpp:94 in OutdoorPvPMgr::NotifyMapAdded ASSERTION F
AILED:
 !map->Instanceable()
InstanceMap::InstanceMap() c:\\mang\\src\\game\\map.cpp: 2268 + 0x49
MapInstanced::CreateInstance() c:\\mang\\src\\game\\mapinstanced.cpp: 205 + 0x7d
MapInstanced::CreateInstance() c:\\mang\\src\\game\\mapinstanced.cpp: 172 + 0x18
MapManager::CreateMap() c:\\mang\\src\\game\\mapmanager.cpp: 137 + 0x3d
WorldSession::HandleMoveWorldportAckOpcode() c:\\mang\\src\\game\\movementhandler.cp
p: 68 + 0x2e
WorldSession::HandleMoveWorldportAckOpcode() c:\\mang\\src\\game\\movementhandler.cp
p: 39 + 0x0
WorldSession::Update() c:\\mang\\src\\game\\worldsession.cpp: 224 + 0x0
World::UpdateSessions() c:\\mang\\src\\game\\world.cpp: 2076 + 0x18
World::Update() c:\\mang\\src\\game\\world.cpp: 1617 + 0x0
WorldRunnable::run() c:\\mang\\src\\mangosd\\worldrunnable.cpp: 65 + 0x0
ACE_Based::Thread::ThreadTask() c:\\mang\\src\\shared\\threading.cpp: 186 + 0x0
ACE_OS_Thread_Adapter::invoke()+0x74 [0x0]
endthreadex()+0x44 [0x0]
endthreadex()+0xd8 [0x0]
FlsSetValue()+0x136 [0x0]

I just login, enter into Vault of Archavon, leave it, then tele to naxx (.tele naxx), enter and start Kel'Thuzad's encounter

Server doesn't crash anyway.

Link to comment
Share on other sites
The_Game_Master Advanced Member

The_Game_Master

Posted
Posted

I think this script needs to be updated.

Can anybody confirm that this is not working anymore?

-- Fire bomb script

DELETE FROM `creature_ai_scripts` WHERE `creature_id` = 18225;
INSERT INTO `creature_ai_scripts`(`creature_id`,`event_type`,`event_inverse_phase_mask`,`event_chance`
,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action1_type`,`action1_param1`
,`action1_param2`,`action1_param3`,`action2_type`,`action2_param1`,`action2_param2`,`action2_param3`,
`action3_type`,`action3_param1`,`action3_param2`,`action3_param3`,`comment`) VALUES
(18225,11,0,100,0,0,0,0,0,11,31961,0,4,0,0,0,0,0,0,0,0,'Fire Bomb Target cast Fire Bomb on Spawn'),
(18225,0,100,5000,0,5000,0,0,0,37,0,0,0,0,0,0,0,0,0,0,0,'Fire Bomb Target Despawn');

UPDATE creature_template SET AIName = 'EventAI', ScriptName='' WHERE `entry` = 18225;

Link to comment
Share on other sites
KAPATEJIb Advanced Member

KAPATEJIb

Posted
Posted

Any updates? I get a crash when entering to bg with .debug bg

Call stack:
Address   Frame     Function      SourceFile
004A0F9E  00000000  Map::Update+6DE
0080D6DE  00000000  MapInstanced::Update+DE
006040D8  00000000  MapManager::Update+128
005E8940  00000000  World::Update+780
0043060E  00000000  WorldRunnable::run+8E
00899F39  00000000  ACE_Based::Thread::ThreadTask+19
00B914D4  00000000  ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74
78543433  00000000  _endthreadex+44
785434C7  00000000  _endthreadex+D8
7D4DFE21  00000000  FlsSetValue+136

And get easy conflict in map.cpp when use git pull from your repo

Link to comment
Share on other sites
XTZGZoReX Advanced Member

XTZGZoReX

Posted
Posted
Address Frame Function SourceFile

004A0F9E 00000000 Map::Update+6DE

0080D6DE 00000000 MapInstanced::Update+DE

006040D8 00000000 MapManager::Update+128

005E8940 00000000 World::Update+780

0043060E 00000000 WorldRunnable::run+8E

00899F39 00000000 ACE_Based::Thread::ThreadTask+19

00B914D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74

78543433 00000000 _endthreadex+44

785434C7 00000000 _endthreadex+D8

7D4DFE21 00000000 FlsSetValue+136

This is totally useless. I need line numbers and variables.
Link to comment
Share on other sites
KAPATEJIb Advanced Member

KAPATEJIb

Posted
Posted

windows crash dumps doesn't have a BT full :) and i doesn't have a visual studio on test server machine for debugging

last lines in log before crash 

2009-10-23 23:46:12 Loading map ./maps/4893029.map
2009-10-23 23:46:12 VMAP loaded name:Warsong Gulch, id:489, x:30, y:29 (vmap rep.: x:30, y:29)
2009-10-23 23:46:12 Loading map ./maps/4893232.map
2009-10-23 23:46:12 VMAP loaded name:Warsong Gulch, id:489, x:32, y:32 (vmap rep.: x:32, y:32)
2009-10-23 23:46:12 Creating player data for himself 8
2009-10-23 23:46:12 Loading map ./maps/4893028.map
2009-10-23 23:46:12 VMAP loaded name:Warsong Gulch, id:489, x:30, y:28 (vmap rep.: x:30, y:28)
2009-10-23 23:46:12 Loading map ./maps/4892929.map
2009-10-23 23:46:12 VMAP loaded name:Warsong Gulch, id:489, x:29, y:29 (vmap rep.: x:29, y:29)
2009-10-23 23:46:12 BATTLEGROUND: Player Bohaha joined the battle.

Link to comment
Share on other sites
KAPATEJIb Advanced Member

KAPATEJIb

Posted
Posted

From one of my patched sources user

#0  Map::GetCreature (this=0x34310038373931, guid=17379391180115989345)
   at /usr/lib/gcc/x86_64-redhat-linux/4.1.2/../../../../include/c++/4.1.2/ext/hashtable.h:513
No locals.
#1  0x0000000000846c78 in OutdoorPvPObjective::HandlePlayerActivityChanged (this=<value optimized out>,
   plr=0x2aaae3629fd0) at ../../../src/game/OutdoorPvP.cpp:70
       c = <value optimized out>
       map = (class Map *) 0x34310038373931
#2  0x0000000000847353 in OutdoorPvP::HandlePlayerActivityChanged (this=<value optimized out>, plr=0x2aaae3629fd0)
   at ../../../src/game/OutdoorPvP.cpp:467
No locals.
#3  0x00000000007bd847 in Unit::DealDamage (this=0x33b71a20, pVictim=0x2aaae3629fd0, damage=1783,
   cleanDamage=<value optimized out>, damagetype=DIRECT_DAMAGE, damageSchoolMask=SPELL_SCHOOL_MASK_NORMAL,
   spellProto=0x0, durabilityLoss=true) at ../../../src/game/Unit.cpp:637
       player = (class Player *) 0x0
       bRewardIsAllowed = <value optimized out>
       damageFromSpiritOfRedemtionTalent = false
       spiritOfRedemtionTalentReady = (class Aura *) 0x0
       health = <value optimized out>
       duel_hasEnded = false
       __PRETTY_FUNCTION__ = "uint32 Unit::DealDamage(Unit*, uint32, const CleanDamage*, DamageEffectType, SpellSchoolMask, const SpellEntry*, bool)"
#4  0x00000000007bf58a in Unit::DealMeleeDamage (this=0x33b71a20, damageInfo=0x42cafcd0, durabilityLoss=true)
   at ../../../src/game/Unit.cpp:1534
       pVictim = (Unit *) 0x2aaae3629fd0
       cleanDamage = {damage = 785, attackType = BASE_ATTACK, hitOutCome = MELEE_HIT_NORMAL}
#5  0x00000000007c00ae in Unit::AttackerStateUpdate (this=0x33b71a20, pVictim=0x2aaae3629fd0, attType=BASE_ATTACK,
   extra=false) at ../../../src/game/Unit.cpp:2159
       extraAttacks = 0
       damageInfo = {attacker = 0x33b71a20, target = 0x2aaae3629fd0, damageSchoolMask = SPELL_SCHOOL_MASK_NORMAL,
 damage = 1783, absorb = 0, resist = 0, blocked_amount = 0, HitInfo = 2, TargetState = 1, attackType = BASE_ATTACK,
 procAttacker = 4, procVictim = 1048584, procEx = 1, cleanDamage = 785, hitOutCome = MELEE_HIT_NORMAL}
#6  0x00000000008162b6 in CreatureEventAI::DoMeleeAttackIfReady (this=0x33b73ed0)
   at ../../../src/game/CreatureEventAI.cpp:1332
No locals.
#7  0x000000000081b81b in CreatureEventAI::UpdateAI (this=0x33b73ed0, diff=172)
   at ../../../src/game/CreatureEventAI.cpp:1107
       Combat = true
#8  0x00000000005573b5 in Creature::Update (this=0x33b71a20, diff=172) at ../../../src/game/Creature.cpp:443
No locals.
---Type <return> to continue, or q <return> to quit---
#9  0x000000000062aadf in VisitorHelper<MaNGOS::ObjectUpdater, Creature> (v=@0x42cb3030, c=<value optimized out>)
   at ../../../src/game/GridNotifiersImpl.h:47
No locals.
#10 0x000000000062c81d in VisitorHelper<MaNGOS::ObjectUpdater, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > (v=@0x34310038373931, c=@0xf1300032c75ed361)
   at ../../../src/game/../framework/GameSystem/TypeContainerVisitor.h:70
No locals.
#11 0x0000000000627038 in Map::Update (this=0x2aaac153c930, t_diff=@0x2aab16d607e0)
   at ../../../src/game/../framework/GameSystem/TypeContainerVisitor.h:105
       x = 291
       plr = <value optimized out>
       updater = {i_timeDiff = 172}
#12 0x000000000063aa52 in MapUpdateRequest::call (this=0x2aab16d607c0) at ../../../src/game/MapUpdater.cpp:47
No locals.
#13 0x000000000089837c in DelayExecutor::svc (this=0x2aaac0ca8a70) at ../../../src/shared/DelayExecutor.cpp:60
       rq = (class ACE_Method_Request *) 0x2aab16d607c0
#14 0x00002af9a5bc9817 in ACE_Task_Base::svc_run (args=<value optimized out>) at ../../ace/Task.cpp:275
       t = (ACE_Task_Base *) 0x2aaac0ca8a70
       svc_status = <value optimized out>
#15 0x00002af9a5bca795 in ACE_Thread_Adapter::invoke (this=0x2383f700) at ../../ace/Thread_Adapter.cpp:98
       exit_hook_instance = (ACE_Thread_Exit *) 0x237fc9b0
       exit_hook_maybe = {instance_ = 0x0}
       exit_hook_ptr = (ACE_Thread_Exit *) 0x237fc9b0
#16 0x0000003758a06367 in start_thread () from /lib64/libpthread.so.0
No symbol table info available.
#17 0x00000037582d309d in clone () from /lib64/libc.so.6
No symbol table info available.

#0  Map::GetGameObject (this=0x0, guid=17370386817866690413)
   at /usr/lib/gcc/x86_64-redhat-linux/4.1.2/../../../../include/c++/4.1.2/ext/hashtable.h:513
513             for (__first = _M_buckets[__n];
(gdb) bt full
#0  Map::GetGameObject (this=0x0, guid=17370386817866690413)
   at /usr/lib/gcc/x86_64-redhat-linux/4.1.2/../../../../include/c++/4.1.2/ext/hashtable.h:513
No locals.
#1  0x0000000000848557 in OutdoorPvPObjective::HandleCaptureCreaturePlayerMoveInLos (this=0x2aaab40d0810,
   p=0x2aaad68d92d0, c=<value optimized out>) at ../../../src/game/OutdoorPvP.cpp:390
       cp = <value optimized out>
#2  0x0000000000847142 in OutdoorPvP::HandleCaptureCreaturePlayerMoveInLos (this=<value optimized out>,
   p=0x2aaad68d92d0, c=0x2aaab4140150) at ../../../src/game/OutdoorPvP.cpp:537
No locals.
#3  0x00000000006968a2 in OutdoorPvPMgr::HandleCaptureCreaturePlayerMoveInLos (this=<value optimized out>,
   plr=0x2aaad68d92d0, c=0x2aaab4140150) at ../../../src/game/OutdoorPvPMgr.cpp:201
No locals.
#4  0x000000000062fe93 in VisitorHelper<MaNGOS::PlayerRelocationNotifier, Creature> (v=@0x45ac3a80,
   c=<value optimized out>) at ../../../src/game/GridNotifiersImpl.h:77
No locals.
#5  0x000000000062fefd in VisitorHelper<MaNGOS::PlayerRelocationNotifier, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > (v=@0x0, c=@0xf11002c752126f6d)
   at ../../../src/game/../framework/GameSystem/TypeContainerVisitor.h:70
No locals.
#6  0x0000000000620918 in Map::PlayerRelocationNotify (this=0x24f21ef0, player=0x2aaad68d92d0, cell=
       {data = {Part = {grid_x = 16, grid_y = 52, cell_x = 3, cell_y = 43, nocreate = 1, reserved = 34}, All = 1168915728}}, cellpair={x_coord = 1168915648, y_coord = 0})
   at ../../../src/game/../framework/GameSystem/TypeContainerVisitor.h:105
       r_zone = {data = {Part = {grid_x = 37, grid_y = 26, cell_x = 4, cell_y = 2, nocreate = 0, reserved = 0},
   All = 542373}}
       relocationNotifier = {i_player = @0x2aaad68d92d0}
#7  0x0000000000621c42 in Map::PlayerRelocation (this=0x24f21ef0, player=0x2aaad68d92d0, x=<value optimized out>,
   y=<value optimized out>, z=115.028191, orientation=1.59220648) at ../../../src/game/Map.cpp:888
       old_cell = {data = {Part = {grid_x = 37, grid_y = 26, cell_x = 4, cell_y = 1, nocreate = 0, reserved = 0},
   All = 280229}}
       new_cell = {data = {Part = {grid_x = 37, grid_y = 26, cell_x = 4, cell_y = 1, nocreate = 0, reserved = 0},
   All = 280229}}
       newGrid = <value optimized out>
#8  0x0000000000703066 in Player::SetPosition (this=0x2aaad68d92d0, x=2990.62964, y=-3088.72607, z=115.028191,
   orientation=1.59220648, teleport=false) at ../../../src/game/Player.cpp:5676
       m = (class Map *) 0x24f21ef0
       old_x = 2990.78052
       old_y = -3089.50977
       old_z = <value optimized out>
---Type <return> to continue, or q <return> to quit---
       old_r = <value optimized out>
#9  0x0000000000844823 in WorldSession::HandleMovementOpcodes (this=0x2aaaf3ef25c0, recv_data=@0x2aab0f7957a0)
   at ../../../src/game/MovementHandler.cpp:322
       opcode = 218
       mover = (class Unit *) 0x2aaad68d92d0
       plMover = (class Player *) 0x2aaad68d92d0
       guid = <value optimized out>
       movementInfo = {guid = 173599, flags = 1, unk1 = 0, time = 2203458098, x = 2990.62964, y = -3088.72607,
 z = 115.028191, o = 1.59220648, t_guid = 0, t_x = 0, t_y = 0, t_z = 0, t_o = 0, t_time = 0, t_seat = -85 '?',
 s_pitch = 0, fallTime = 306, j_unk = 0, j_sinAngle = 0, j_cosAngle = 0, j_xyspeed = 0, u_unk1 = 0}
       data = {<ByteBuffer> = {static DEFAULT_SIZE = 4096, _rpos = 0, _wpos = 34,
   _storage = {<std::_Vector_base<unsigned char,std::allocator<unsigned char> >> = {
       _M_impl = {<std::allocator<unsigned char>> = {<__gnu_cxx::new_allocator<unsigned char>> = {<No data fields>}, <No data fields>}, _M_start = 0x2aab4447ff10 "\\a\\037?\\002\\001", _M_finish = 0x2aab4447ff32 "??*",
         _M_end_of_storage = 0x2aab4447ff32 "??*"}}, <No data fields>}}, m_opcode = 218}
#10 0x00000000007d9a0a in WorldSession::Update (this=0x2aaaf3ef25c0) at ../../../src/game/WorldSession.cpp:243
       opHandle = (OpcodeHandler &) @0xf1300032c75eba37: <error reading variable>
       packet = (WorldPacket *) 0x2aab0f7957a0
       currTime = <value optimized out>
#11 0x00000000007d1975 in World::UpdateSessions (this=0x19e37070, diff=77) at ../../../src/game/World.cpp:2078
       next = {_M_cur = 0x2aab19b6ae50, _M_ht = 0x19e37140}
       sess = <value optimized out>
#12 0x00000000007d23a3 in World::Update (this=0x19e37070, diff=77) at ../../../src/game/World.cpp:1615
       autobroadcaston = 1
#13 0x00000000005082ad in WorldRunnable::run (this=<value optimized out>) at ../../../src/mangosd/WorldRunnable.cpp:64
       diff = 77
       realCurrTime = 2203458090
       realPrevTime = <value optimized out>
       prevSleepTime = 66
#14 0x000000000089b905 in ACE_Based::Thread::ThreadTask (param=0x0) at ../../../src/shared/Threading.cpp:183
       _task = (class ACE_Based::Runnable *) 0x2aaab445da40
#15 0x0000003758a06367 in start_thread () from /lib64/libpthread.so.0

Link to comment
Share on other sites
balrok Advanced Member

balrok

Posted
Posted

would be interesting whats on:

/usr/lib/gcc/x86_64-redhat-linux/4.1.2/../../../../include/c++/4.1.2/ext/hashtable.h:513

i don't see why a getcreature could crash.. even with a nonexistant guid this shouldn't happen

fix for first crash with bg - is now compiling and will be pushed soon :)

Link to comment
Share on other sites
NetSky Advanced Member

NetSky

Posted
Posted

better revert to original and then start doing this all over

sOutdoorPvPMgr.HandlePlayerLeaveZone(_player,_player->GetZoneId());

this call shoots off legs because it is accessing map object by getzoneid call which is already deleted

try terminating your client in instance infight you get 100% crash

Link to comment
Share on other sites
XTZGZoReX Advanced Member

XTZGZoReX

Posted
Posted
sOutdoorPvPMgr.HandlePlayerLeaveZone(_player,_player->GetZoneId());
I'm not sure why it is like this in balrok's branch - in my repo, it's correct:
// OutdoorPvPMgr sets our new m_OutdoorPvP pointer for us.

sOutdoorPvPMgr.HandlePlayerLeaveZone(this, oldZoneId);

sOutdoorPvPMgr.HandlePlayerEnterZone(this, m_zoneUpdateId);

no good maybe working with trinity but not with mangos that way
You'll have to explain exactly what won't work with MaNGOS 'that way'. Also, my repo is _not_ a Trinity derivative - it's based on MaNGOS sources.
Link to comment
Share on other sites
NetSky Advanced Member

NetSky

Posted
Posted

because this call @logoutplayer will crash for sure : go to instance getinfight -> alt+f4

wont with this patch : http://www.pastebin.org/48066 (sry patchfile broken you got to add manually) but then it will crash later in sendobjectupdates when player is removed from map

maybe related to missing sOutdoorPvPMgr.HandlePlayerEnterZone(this, m_zoneUpdateId); i will test now - are you sure these lines are in WorldSession::LogoutPlayer ? We are talking about different Calls

my patch should alsy fixproblematic getmap() calls in LogoutPlayer which were not save before

Link to comment
Share on other sites
Guest
This topic is now closed to further replies.
 Share
Go to topic listing

Contact Us

To contact us click here
You can also email us at [email protected]

Privacy Policy | Terms & Conditions

Repositories

The Link to the master list
of MaNGOS repositories:
Copyright © getMaNGOS. All rights Reserved.

This website is in no way associated with or endorsed by Blizzard Entertainment®
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use