Auntie Mangos

Hi commits I'm talking about: [11543] Fixed change form to same (powershifting) https://github.com/mangos/mangos/commit/9b4dcbbc01d65dd9f39c35814025a70daba730e6 [s1261] Added function Object::SendForcedObjectUpdate() https://github.com/mangos-one/server/commit/2654c01b1b25cfb6b9294c61f4cab3920a2e937e The commit in master fixes a problem about shapeshifting, more exact powershifting. This is frequently used by Druids in Cat Form for max dps as it gains 40 energy everytime used. The addressed bug was, that shifting too fast from cat form to caster form and back to cat form made you stuck in cat form but unable to use cat spells. This was fixed by the SendForcedObjectUpdate fix in master. When backporting that patch, one line was left out commented not to be needed for pre 3.x. I'm pretty sure by my research now, that this is not the case. With this line (as in master) the above works just fine. You can test this with the following one-line macro: /cast !Cat Form While in cat form, you should only see a small cloud for a very short time and be back in catform nearly instantly when used, giving you 40 energy (if skilled in feral tree). This does only work if the line is commented in. The original bug discussion took place here : http://getmangos.eu/community/topic/15889/fixedbug-powershifting/ I request to correct the backport as follows: diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index dde1c83..9494f3d 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -2606,7 +2606,7 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real) target->RemoveSpellsCausingAura(SPELL_AURA_MOD_SHAPESHIFT, GetHolder()); // need send to client not form active state, or at re-apply form client go crazy - // target->SendForcedObjectUpdate(); -- not need in pre-3.x + target->SendForcedObjectUpdate(); //-- not need in pre-3.x if (modelid > 0) target->SetDisplayId(modelid);

Can you please try the following : diff --git a/dep/recastnavigation/Detour/Source/DetourNode.cpp b/dep/recastnavigation/Detour/Source/DetourNode.cpp index 0d1af83..52e55a7 100644 --- a/dep/recastnavigation/Detour/Source/DetourNode.cpp +++ b/dep/recastnavigation/Detour/Source/DetourNode.cpp @@ -88,14 +88,16 @@ dtNode* dtNodePool::getNode(dtPolyRef id) unsigned int bucket = dtHashRef(id) & (m_hashSize-1); unsigned short i = m_first[bucket]; dtNode* node = 0; - while (i != DT_NULL_IDX) + int counter = 0; + while (i != DT_NULL_IDX && counter < m_maxNodes) { if (m_nodes[i].id == id) return &m_nodes[i]; i = m_next[i]; + counter++; } - if (m_nodeCount >= m_maxNodes) + if (m_nodeCount >= m_maxNodes - 1) return 0; i = (unsigned short)m_nodeCount; Ugly hack, but I want to see it is in the right direction. Since I cannot reproduce it on local. Thanks in advance. PS: how often it happens? since from what I see, you got it only on map 33, shadowfang. Tried it, and it works lovely for me. There's indeed a problem there. I can't get it to crash, but for some reason, while having pet on follow, if will get call location update every cycle, even tho it is at the right position. I will debug it once I get some more time. Thanks for the report. Can you please check if you get same problem in other places in world when using off mesh connections? Anyway to reproduce it? doe's it always happen, or just sometimes? Cheers

First read related topics before posting: http://getmangos.eu/community/viewtopic.php?id=15430

I posted this months ago.. See http://getmangos.eu/community/showthread.php?13344-dev-Reload-item_template-amp-creature_template Also no reason to reload every field like in your patch.. Much more stress on an active database. A simple sObjectMgr.LoadCreatureTemplates(); Does the same thing and I would think a lot faster too.

Try http://getmangos.eu/community/showthread.php?9392-[patch]-creature-spell-cooldown-and-spellmod or http://github.com/pasdVn/mangos/commit/3b653afa9f72fd31eb8798670bdf129d5aea7162 (I updated the patch in my branch but not yet the thread...).

What bug does the patch fix? What features does the patch add? * Added a "canMiss" flag which is set to false when the spell is triggered, but not from a proc. This prevents miss chance from being factored in multiple times when calculating miss for Judgements, Stormstrike, Mutilate, Whirlwind. These should only have one miss roll. * Fixed the miss chance of SPELL_DAMAGE_CLASS_RANGED spells so that spells that don't really use a ranged weapon (meaning they don't have SPELL_ATTR_RANGED) always use max skill. (This includes judgements and blind) * Also made the scripted spell triggered by Chimera Shot count as a triggered spell. For which repository revision was the patch created? 8379 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. Judgement miss chance - http://getmangos.eu/community/viewtopic.php?id=8131 Freezing Arrow - http://getmangos.eu/community/viewtopic.php?id=6923 Who has been writing this patch? Please include either forum user names or email addresses. Myself Patch

Since 3.x, Omen has pulled the data from Threat API afaik. @Seizer: You would not happen to have a Prot Paladin to test with on live would you?

Xfurry: http://getmangos.eu/community/post/134520/#p134520

I think that's exactly the kind of case why qsa worked on this : http://getmangos.eu/community/post/131450/#p131450

http://getmangos.eu/community/showthread.php?13121-World-of-Warcraft-Server-for-Windows-Installation-Guide Part 15 should help you out

luciolis is this clean core? looks like not player type object is trying to access player class function

Hi, Anybody can help me on setting instance reset timer to 7 hours that works fine via codes ? From my research, the timer can be lowered until 1 day only. I've tried modifications from here, http://getmangos.eu/community/showthread.php?11755-Instance-Reset-Time&highlight=instance+reset Seems like, it doesnt work well. It does say 7 hours reset in RAID INFO. But the yellow text when u enter instance will say " Scheduled to expire # days". Even if it does say 7 hours in raid info, the timer ticks while u're in but not when u're out. When u relog back in, the timer reset to its original time = 7 hours Please help, thank you! (moreover, this feature would help & benefit those low population servers)

Yes, that would be the bug I was referring to. I recently made a change to fix the far teleport problem, which now results in the bots being invisible in an instance. The CMSG_AREATRIGGER packet is used for near and far teleports which gets intercepted in PlayerbotMgr.cpp and then resent from the bot. This is similar to how I had a work around set up, except I had a delay in the UpdateAI code with a new botstate. This immediate resend of the packet makes the bot teleport immediately. Since there is no load time for the bot, the bot appears in the instance first. Basically, the master is not getting the packet updates that tell the client that bots are there. The master will always be the slow computer in reference to the forum thread. May be a good way to test it and fix it. I'll work on getting a branch created for the delay work around I did. Now, I'm feeling exceptionally guilty for not contributing as much recently. I'm still here though, just busier with RL.

Read the source code management section. It contains guides for patching, merging, etc. freghar has collected and written quite a few very good ones.

please post this only in the resources thread that contains links to external projects. http://getmangos.eu/community/viewtopic.php?id=84

Im getting the same error as http://getmangos.eu/community/showpost.php?p=86288&postcount=96 when i try to compile. I've read through the forum and tried different approaches, but it ends up in the same way. I tried with MaNGOS rev. 8746 with ScriptDev2 on Ubuntu. Basicly i use these commands to merge AHBot into mangos git clone git://github.com/mangos/mangos.git cd mangos git pull git://github.com/Naicisum/mangos.git ahbot Does anyone have an idea, what im doing wrong - or should i descripe it more in details?

We need someone who wants to take care of the mangos-one core updates. Unfortunately Stfx isn't currently available for this anymore and the core really needs to be updated with the latest changes so it will work with the latest SD2 and TBC-DB. Thanks

Have a look here: http://getmangos.eu/community/viewtopic.php?id=13676 and ofc here http://getmangos.eu/community/viewtopic.php?id=8238 That are latest threads for any AHbot and Playerbot developing, a recent MaNGOS commit broke at least the AHbot I was using, haven't bothered finding out if there's a working version. If there is a working version you should learn how to use patch, git diff and compiling, also you should be able to do some basic mysql stuff. Following a book is a great way, we all did it this way :-) Merging two huge patches is always a bit like gambling, might work, doesn't have to. Have a good time Skirnir

Hummm perhaps you should double check Part 14-15 http://getmangos.eu/community/showthread.php?13121-World-of-Warcraft-Server-for-Windows-Installation-Guide make sur you,ve done everything right

@KAPATEJIb Hmm, i think you're right. http://pastebin.com/ZbRFMzp7 @LordJZ Shouldn't m_target->IsInWorld do that?

Try Mangold: http://getmangos.eu/community/viewtopic.php?id=23371 Or search the DB&C forum: http://getmangos.eu/community/viewforum.php?id=5

That link is invalid. Is this addon still being updated?

24th November 2010 Sometimes a little PM can go a long way. Fixes Do I see doubled stuff? Indeed, that was weird. Doubled report links, among other stuff. All gone for good now. Is there more? Roughly 80 culminated issues fixed from reports our users sent it. You might notice a lot of less weird things going on now. House cleaning Can't we have that little private talks again? Yes, you can as some president would say. Look above all things and see PM craving for your attention. Feedback this way, please.

Awsome colab nanounico Thanks!

@Voltage Can you post or PM the info I request for helping troubleshoot your issues? Ref: http://getmangos.eu/community/showp...07&postcount=2