Auntie Mangos

Bah I give up, merging patches is well beyond my user abilities

Actually that line wasn't changed since the proc patch by DiSlord was applied.

Description of the bug? For which repository revision was the patch created? 8029 Is there a thread in the bug report section or at lighthouse? http://getmangos.eu/community/viewtopic.php?id=6982 Who has been writing this patch? Myself + nos4r2zod Fix: Update the regenerate mechanism so that it is time-based and no longer only "2 seconds based". The rune cooldown was also based on 5 ticks of 2 seconds. moved to a more fine time-based cooldown (in msec). In the normal case, the regenerate is still called every 2sec. However, when a spell requires some power (energy, mana, ...), RegenerateAll is called to have up to date value. Well, almost. To avoid to much regenerate computation, there is a minimum of 400msec between regenerate. Finally, the unit_flag2 UNIT_FLAG2_REGENERATE_POWER is set/unset to notify the client to display correctly the regen in the mana bar. Test OK for Mana (with a priest) and Energy (with a rogue). need a test for DK. latest patch with corrections for [8029] (posted by nos4r2zod) : http://paste2.org/p/268341

Look at this topic for inspiration: http://getmangos.eu/community/viewtopic.php?id=23142

Still not correct, but as Lynx said the liquid fix is low impact. The terrain hole data is probably a bigger deal, but I never wrote code for the core to use it. Of course, both fixes are included in this thread

When the target dies due to the spell the damage shouldn't be done on the player. Someone suggested a fix here http://getmangos.eu/community/topic/16136/mangos-onepatch-fix-shadow-word-death/ and for some reason it works. Altho Vladimir was right that it's the same procflag as in the .dbc file, and you get a console error stating that, seems the fix is actually working. Maybe there's something wrong in the spell's code and doesnt handle the procflag correctly?

Trying to follow the installation guide at http://getmangos.eu/community/showthread.php?7839-[GUIDE]-Ubuntu-Debian-CentOS-RHEL-Install-Guide I am building on Fedora 12 (current updates) - postgresql 8.4.2: $ cat /etc/redhat-release Fedora release 12 (Constantine) $ rpm -qi postgresql-devel Name : postgresql-devel Relocations: (not relocatable) Version : 8.4.2 Vendor: Fedora Project Release : 1.fc12 Build Date: Wed 16 Dec 2009 05:02:18 PM EST Install Date: Fri 12 Mar 2010 03:57:02 PM EST Build Host: localhost Group : Development/Libraries Source RPM: postgresql-8.4.2-1.fc12.src.rpm Size : 5014894 License: MIT Signature : RSA/8, Thu 17 Dec 2009 05:09:21 AM EST, Key ID 9d1cc34857bbccba Packager : Fedora Project URL : [url]http://www.postgresql.org/[/url] Summary : PostgreSQL development header files and libraries Description : The postgresql-devel package contains the header files and libraries needed to compile C or C++ applications which will directly interact with a PostgreSQL database management server and the ecpg Embedded C Postgres preprocessor. You need to install this package if you want to develop applications which will interact with a PostgreSQL server. Received this build failure: CXX QueryResultPostgre.o ../../../../src/shared/Database/QueryResultPostgre.cpp: In member function ‘Field::DataTypes QueryResultPostgre::ConvertNativeType(Oid) const’: ../../../../src/shared/Database/QueryResultPostgre.cpp:84: error: ‘BPCHAROID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:85: error: ‘CIDOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:86: error: ‘CIDROID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:87: error: ‘CIRCLEOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:88: error: ‘INETOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:89: error: ‘NAMEOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:90: error: ‘TEXTOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:91: error: ‘VARCHAROID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:93: error: ‘CASHOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:94: error: ‘FLOAT4OID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:95: error: ‘FLOAT8OID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:96: error: ‘NUMERICOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:98: error: ‘DATEOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:99: error: ‘RELTIMEOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:100: error: ‘TIMEOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:101: error: ‘TIMETZOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:102: error: ‘ABSTIMEOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:103: error: ‘INTERVALOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:104: error: ‘TIMESTAMPOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:105: error: ‘TIMESTAMPTZOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:106: error: ‘INT2OID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:107: error: ‘INT2VECTOROID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:108: error: ‘INT4OID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:109: error: ‘OIDOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:110: error: ‘CHAROID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:111: error: ‘INT8OID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:113: error: ‘BOOLOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:121: error: ‘LSEGOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:122: error: ‘OIDVECTOROID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:123: error: ‘PATHOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:124: error: ‘POINTOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:125: error: ‘POLYGONOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:126: error: ‘REGPROCOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:127: error: ‘TIDOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:128: error: ‘TINTERVALOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:129: error: ‘UNKNOWNOID’ was not declared in this scope ../../../../src/shared/Database/QueryResultPostgre.cpp:130: error: ‘XIDOID’ was not declared in this scope make[5]: *** [QueryResultPostgre.o] Error 1 I know most people use MySQL rather than PostgreSQL, but I prefer to use PostgreSQL and would prefer not to install MySQL as well on my server.

What bug does the patch fix? What features does the patch add? allows SPELL_AURA_MOD_HEALING_PCT to reduce any healing made on target like it should For which repository revision was the patch created? should work on latest Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.php?id=10686 Who has been writing this patch? Please include either forum user names or email addresses. me diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index b6a319c..92a6a0f 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -8941,19 +8941,32 @@ uint32 Unit::SpellCriticalHealingBonus(SpellEntry const *spellProto, uint32 dama uint32 Unit::SpellHealingBonus(Unit *pVictim, SpellEntry const *spellProto, uint32 healamount, DamageEffectType damagetype, uint32 stack) { - // No heal amount for this class spells - if (spellProto->DmgClass == SPELL_DAMAGE_CLASS_NONE) - return healamount; - // For totems get healing bonus from owner (statue isn't totem in fact) if( GetTypeId()==TYPEID_UNIT && ((Creature*)this)->isTotem() && ((Totem*)this)->GetTotemType()!=TOTEM_STATUE) if(Unit* owner = GetOwner()) return owner->SpellHealingBonus(pVictim, spellProto, healamount, damagetype, stack); + float TakenTotalMod = 1.0f; + + // Healing taken percent + float minval = pVictim->GetMaxNegativeAuraModifier(SPELL_AURA_MOD_HEALING_PCT); + if(minval) + TakenTotalMod *= (100.0f + minval) / 100.0f; + + float maxval = pVictim->GetMaxPositiveAuraModifier(SPELL_AURA_MOD_HEALING_PCT); + if(maxval) + TakenTotalMod *= (100.0f + maxval) / 100.0f; + + // No heal amount for this class spells + if (spellProto->DmgClass == SPELL_DAMAGE_CLASS_NONE) + { + healamount = healamount * TakenTotalMod; + return healamount < 0 ? 0 : uint32(healamount); + } + // Healing Done // Taken/Done total percent damage auras float DoneTotalMod = 1.0f; - float TakenTotalMod = 1.0f; int32 DoneTotal = 0; int32 TakenTotal = 0; @@ -9100,15 +9113,6 @@ uint32 Unit::SpellHealingBonus(Unit *pVictim, SpellEntry const *spellProto, uint TakenTotalMod *= ((*itr)->GetModifier()->m_amount+100.0f) / 100.0f; } - // Healing taken percent - float minval = pVictim->GetMaxNegativeAuraModifier(SPELL_AURA_MOD_HEALING_PCT); - if(minval) - TakenTotalMod *= (100.0f + minval) / 100.0f; - - float maxval = pVictim->GetMaxPositiveAuraModifier(SPELL_AURA_MOD_HEALING_PCT); - if(maxval) - TakenTotalMod *= (100.0f + maxval) / 100.0f; - AuraList const& mHealingGet= pVictim->GetAurasByType(SPELL_AURA_MOD_HEALING_RECEIVED); for(AuraList::const_iterator i = mHealingGet.begin(); i != mHealingGet.end(); ++i) if ((*i)->isAffectedOnSpell(spellProto))

http://getmangos.eu/community/showthread.php?p=50346#post50346 more specifically, open your git bash and type:"git mergetool" (with no quotes). It should bring up a GUI that allows you to directly implement what you want into your .conf.in file. I LOVE the tortoise mergetool personally.

I'm getting the same error as creat91. 2011-12-14 02:27:58 MaNGOS/0.17.0-DEV (2011-12-12 22:32:11 Revision 11863 - c9d511abb70744ce10bbea724cf108417299a95f) for Win32 (little-endian) [world-daemon] (bla, bla, bla) 2011-12-14 02:27:58 Using World DB: UDB 0.12.2 (402) for MaNGOS 11792 with SD2 SQL for rev. 2279 2011-12-14 02:27:58 Using creature EventAI: ACID 3.0.9 'Streamlined Perfection' - Full Release for MaNGOS (3.3.5a Client) 2011-12-14 02:27:58 Using DataDir C:/WoW\\data/ 2011-12-14 02:27:58 WORLD: VMap support included. LineOfSight:1, getHeight:1, indoorCheck:1 2011-12-14 02:27:58 WORLD: VMap data directory is: C:/WoW/data/vmaps 2011-12-14 02:27:58 ERROR:Map file 'C:/WoW/data/maps/0004331.map' is non-compatible version (outdated?). Please, create new using ad.exe program. 2011-12-14 02:27:58 ERROR:Correct *.map files not found in path 'C:/WoW/data/maps' or *.vmtree/*.vmtile files in 'C:/WoW/data/vmaps'. Please place *.map and vmap files in appropriate directories or correct the DataDir value in the mangosd.conf file. Running WoW client: 3.3.3 (11685) Could that be my problem? Or is it possible that my UDB is not updated to the highest patch? (because I really don't know how to do that, altrought I followed the guide ) Im also using an script to update the MaNGOS SQL files, so if that one works correctly, it shouldn't be a problem there.

i've get returned this: After using this code: Code get from topic: [GUIDE] Ubuntu/Debian/CentOS/RHEL Install Guide URL: http://getmangos.eu/community/topic/7839/guide-ubuntudebiancentosrhel-install-guide/ My Dedicated server has ubuntu 10.4, is all in order?

Found this other one too: http://getmangos.eu/community/showthread.php?8820-Level-cap-grater-than-100

i started a thread, since im not an expert coder i will maybe find help froms omeone more expert tham me lol http://getmangos.eu/community/showthread.php?12000-Custom-weapons-after-3-3-0

What bug does the patch fix? What features does the patch add? fixes Berserk part that allows Mangle (Bear) to hit additional targets For which repository revision was the patch created? should work on latest Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.php?id=10816 Who has been writing this patch? Please include either forum user names or email addresses. me diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp index 4be1945..e8fef7c 100644 --- a/src/game/Spell.cpp +++ b/src/game/Spell.cpp @@ -2542,6 +2542,13 @@ void Spell::cast(bool skipCheck) AddPrecastSpell(57723); // Exhaustion break; } + case SPELLFAMILY_DRUID: + { + // Berserk (Bear Mangle part) + if (m_spellInfo->Id == 50334) + AddTriggeredSpell(58923); + break; + } default: break; }

What bug does the patch fix? What features does the patch add? There were some areas in the world map which did not give the exploration achievement after being discovered, or you'd have to discover a different area to get the achievement. That was because there are four columns in WorldMapOverlay.dbc which describe the potential area ids used to check the completion of the achievement, but the original code only compared the first one. This generic patch fixes Splitertree Post, The Black Temple, Kirin'var Village, Ruins of the Scarlet Enclave, and (maybe) some of the Northrend areas. Note: Undercity is a different story, so it won't get fixed with this patch. For which repository revision was the patch created? 7517 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.php?id=6761 diff --git a/src/game/AchievementMgr.cpp b/src/game/AchievementMgr.cpp index 59e2c53..18db0ef 100644 --- a/src/game/AchievementMgr.cpp +++ b/src/game/AchievementMgr.cpp @@ -723,14 +723,24 @@ void AchievementMgr::UpdateAchievementCriteria(AchievementCriteriaTypes type, ui if(!worldOverlayEntry) break; - int32 exploreFlag = GetAreaFlagByAreaID(worldOverlayEntry->areatableID); - if(exploreFlag < 0) - break; + bool matchFound = false; + for (int i = 0; i < 3; ++i) + { + int32 exploreFlag = GetAreaFlagByAreaID(worldOverlayEntry->areatableID[i]); + if(exploreFlag < 0) + break; + + uint32 playerIndexOffset = uint32(exploreFlag) / 32; + uint32 mask = 1<< (uint32(exploreFlag) % 32); - uint32 playerIndexOffset = uint32(exploreFlag) / 32; - uint32 mask = 1<< (uint32(exploreFlag) % 32); + if(GetPlayer()->GetUInt32Value(PLAYER_EXPLORED_ZONES_1 + playerIndexOffset) & mask) + { + matchFound = true; + break; + } + } - if(GetPlayer()->GetUInt32Value(PLAYER_EXPLORED_ZONES_1 + playerIndexOffset) & mask) + if(matchFound) SetCriteriaProgress(achievementCriteria, 1); break; } diff --git a/src/shared/Database/DBCStructure.h b/src/shared/Database/DBCStructure.h index 2f1b0b1..9a78202 100644 --- a/src/shared/Database/DBCStructure.h +++ b/src/shared/Database/DBCStructure.h @@ -1609,7 +1609,7 @@ struct WorldSafeLocsEntry struct WorldMapOverlayEntry { uint32 ID; // 0 - uint32 areatableID; // 2 + uint32 areatableID[4]; // 2 }; // GCC have alternative #pragma pack() syntax and old gcc version not support pack(pop), also any gcc version not support it at some platform diff --git a/src/shared/Database/DBCfmt.cpp b/src/shared/Database/DBCfmt.cpp index 5049fcd..c46e861 100644 --- a/src/shared/Database/DBCfmt.cpp +++ b/src/shared/Database/DBCfmt.cpp @@ -96,4 +96,4 @@ const char VehicleEntryfmt[]="niffffiiiiiiiiffffiiiiiifffffffffffssssfifi"; const char VehicleSeatEntryfmt[]="niiffffffffffiiiiiifffffffiiifffiiiiiiiffiiiii"; const char WorldMapAreaEntryfmt[]="xinxffffix"; const char WorldSafeLocsEntryfmt[]="nifffxxxxxxxxxxxxxxxxx"; -const char WorldMapOverlayEntryfmt[]="nxixxxxxxxxxxxxxx"; +const char WorldMapOverlayEntryfmt[]="nxiiiixxxxxxxxxxx"; Edit: A quick (and hacky) fix for Undercity (I know that this is not the proper way, but if someone want to fix this too...) @@ -1645,10 +1645,15 @@ uint16 Map::GetAreaFlag(float x, float y, float z) const // Dalaran case 1593: case 2484: case 2492: if( (x < 6116 && x > 5568) && (y < 982 && y > 282) && z > 563.0f) areaflag = 2153; break; + // Undercity + case 607: // Ruins of Lordaeron + if (((x < 1850) && (y > 6) && (y < 443)) || + ((x < 1877.2f) && (y > 233) && (y < 242)) || + ((x < 1866) && (y > 224) && (y < 252))) areaflag = 685; break; } return areaflag; }

It can be a great idea In my old experience with E\\/erquest, sometime a team of GMs will transform themselves into mobs and attack players in random maps, meanwhile, when players kill these GM mobs, they get some great loots. similar topic is being talked in here: http://getmangos.eu/community/viewtopic.php?id=21324

Water/Slime/Lava detection has been fixed as of vmap3 in mangos master and as of vmap3 backport + this patch in One/Zero. Breath timer refreshing while swimming (not underwater) has been fixed way before that.

Take a look in this thread http://getmangos.eu/community/topic/15791/10870-crash-at-learning-skills/

Well , i've it tested 8-10 times that when players are doing instances & when they pull many mobs it is crashing the server always. In Previous revs it was working fine . my crash dumps

Ok, I have made some progress. Nothing new, mainly the abstraction part I mentioned. Started new thread at http://getmangos.eu/community/showthread.php?13557-mmaps-redux, go there from now on.

your guide is compleetly different!!!!!!!!! I am at PART 11 - EXTRACTING MAPS AND DBC FILES I am not doing everthing.. for example I have done the ad.exe part that I dont have to do again... but many stages are... anyway.. will update if I get a problem.. its just fitting the databace or maybe just everything is done wrong I am trying to do step: PART 5 - CONFIGURING GIT but when it finishes, I do not get the mangosd.exe and realmd.exe!! any1 have that problem ? anyway, its such a good tut u have there thanks for everything

@belfedia You do reset from clean mangos (source code) to commit: 8994, but then it will not be possible to pull vehicle branch, because Tasssadar/Valhalla (branch vehicle) is updated to commit: 9390 edit: For old commits, maybe you should look in the original topic: http://getmangos.eu/community/showthread.php?7952-[Help]-Implementing-Vehicles

Yes there is a limit and yes it was discused before here's the link: -Stats-On-Higher-Levels"]http://getmangos.eu/community/showthread.php?10289-[Help]-Stats-On-Higher-Levels

On load 2009-09-29 23:11:50 Loading Guilds... 2009-09-29 23:11:50 ERROR:Player (GUID: 46567) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 31276) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 31795) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 4380) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 33051) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 43526) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 34059) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 30750) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 46794) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 22740) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 47269) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 51741) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 53894) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 33504) has broken zone-data 2009-09-29 23:11:50 ERROR:Player (GUID: 45085) has broken zone-data These players stay near flight master in Dalaran (it's a bugged duel area - players location shown as Unknown) Program terminated with signal 11, Segmentation fault. #0 0x08492cbd in Guild::LoadBankRightsFromDB (this=0xec71338, guildBankTabRightsResult=0xd799350) at ../../../src/game/../shared/Database/Field.h:54 54 uint32 GetUInt32() const { return mValue ? static_cast<uint32>(a tol(mValue)) : uint32(0); } (gdb) bt #0 0x08492cbd in Guild::LoadBankRightsFromDB (this=0xec71338, guildBankTabRightsResult=0xd799350) at ../../../src/game/../shared/Database/Field.h:54 #1 0x082a6d3f in ObjectMgr::LoadGuilds (this=0x90c0cf8) at ../../../src/game/ObjectMgr.cpp:2910 #2 0x0842f7ca in World::SetInitialWorldSettings (this=0x90bfc38) at ../../../src/game/World.cpp:1398 #3 0x0813394d in Master::Run (this=0x90965d0) at ../../../src/mangosd/Master.cpp:221 #4 0x08133293 in main (argc=1, argv=0xbfb5a204) at ../../../src/mangosd/Main.cpp:172 more info at http://getmangos.eu/community/viewtopic.php?id=10209

Please refer to #20 and #21 in this thread: http://getmangos.eu/community/viewtopic.php?id=8512&p=76555 That solution might get your problem fixed.