Sephiroth1983

The ones with "Needs core implementation first" should be added IMHO, the data in tables should be correctly provided, regardless if the spell is fixed or not. Also, a friend of mine suggests to use '-1' as coefficient for Conflagrate (17962), Vampiric Touch Dispel proc (64085), Seal of Martyr self and enemy procs (53718, 53719), Seal of Blood (31893, 32221) and Swiftmend (18562). This is to avoid them to get ANY bonus damage. If you need the queries I can provide them after we discuss if is correct.

That one happens when arena ends and is just visual for the ones who see it, the player is not even laging, it must be some wrong packet received by client, or a missing one.

Hi Vlad, a friend of mine finds the DBC values wrong, sometimes for example for Twisted Faith - it affects only Mind Blast with DBC data and not Mind Flay he fixed it by overwriting (forcing) table values in spell_affect. This is the data: insert into `spell_affect` (`entry`, `effectId`, `SpellClassMask0`, `SpellClassMask1`, `SpellClassMask2`) values('51167','1','8396800','0','0'); insert into `spell_affect` (`entry`, `effectId`, `SpellClassMask0`, `SpellClassMask1`, `SpellClassMask2`) values('51166','1','8396800','0','0'); insert into `spell_affect` (`entry`, `effectId`, `SpellClassMask0`, `SpellClassMask1`, `SpellClassMask2`) values('47578','1','8396800','0','0'); insert into `spell_affect` (`entry`, `effectId`, `SpellClassMask0`, `SpellClassMask1`, `SpellClassMask2`) values('47573','1','8396800','0','0'); insert into `spell_affect` (`entry`, `effectId`, `SpellClassMask0`, `SpellClassMask1`, `SpellClassMask2`) values('47577','1','8396800','0','0'); What do you think, it is correct?

Tested and works.

No, check again spell_bonus_data, the only exceptions (or missing records in the table) are Frost Ward and Fire Ward.

Can't you add the coefficients using spell_bonus_data table?

Obvious fix is obvious, thanks.

In this topic we already use the right coefficients updated to 3.1.3, you didn't use this fix for tests I see.

If the program tries to allocate 203GB of memory, its a code problem tho.

Ok but now can we focus on testing the latest branch first? Thanks

Looking forward to see this patch tested as deserves.

-- Add coefficient for Shadowflame DoT DELETE FROM `spell_bonus_data` WHERE `entry` IN ('47960', '61291'); INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES ('47960', '0', '0.0667', '0', 'Warlock - Shadowflame Trigger Rank 1'), ('61291', '0', '0.0667', '0', 'Warlock - Shadowflame Trigger Rank 2'); -- Add coefficient for Shadowflame DD DELETE FROM `spell_bonus_data` WHERE `entry` = '47897'; INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES ('47897', '0.1064', '0', '0', 'Warlock - Shadowflame'); -- Conflagrate no direct benefit from spell power with Patch 3.1.2, coefficient set to 0, deleting causes high damage because will use default instant coefficient DELETE FROM `spell_bonus_data` WHERE `entry` = '17962'; INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES ('17962', '0', '0', '0', 'Warlock - Conflagrate');

Nice, except that I don't think spell_chain is needed, in the end is the same quantity of code we have to make if we use the spell_chain or directly the spell_bonus_data entries. Also I would like to discuss the following suggestions and corrections, Living Bomb is just obvious: -- Living bomb correction, before DD and DoT coefficient in one spell, but explosion is separate DELETE FROM `spell_bonus_data` WHERE `entry` IN ('44457', '44461', '55361', '55362'); INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES ('44457', '0', '0.2', '0', 'Mage - Living Bomb DoT'), ('44461', '0.4', '0', '0', 'Mage - Living Bomb Explosion Rank 1'), ('55361', '0.4', '0', '0', 'Mage - Living Bomb Explosion Rank 2'), ('55362', '0.4', '0', '0', 'Mage - Living Bomb Explosion Rank 3'); -- Some coefficients added DELETE FROM `spell_bonus_data` WHERE `entry` IN ('5570', '61391', '33745', '49821', '53022'); INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES ('5570', '0', '0.2', '0', 'Druid - Insect Swarm'), ('61391', '0.193', '0', '0', 'Druid - Typhoon'), ('33745', '0', '0', '0.01', 'Druid - Lacerate'), ('49821', '0.2861', '0', '0', 'Priest - Mind Sear Trigger Rank 1'), ('53022', '0.2861', '0', '0', 'Priest - Mind Sear Trigger Rank 2'); About the druid ones, I'm not sure about Lacerate, it can be it is hardcoded in damage calculation per combo point and needs to be updated there?

Thanks, this fix is needed.

('2944', '0', '0.1849', '0', 'Priest - Devouring Plague'), I would like to receive comments from guys who can actually add something about Gauge, I don't know if we should add the coefficient with this table, maybe the attackpower is added depending on combo points and then its done within code calculation? I never played rogue.

Can't you use Mind Flay trigger spell so you cover all ranks? DELETE FROM `spell_bonus_data` WHERE `entry` = '58381'; INSERT INTO `spell_bonus_data` (`entry`, `direct_bonus`, `dot_bonus`, `ap_bonus`, `comments`) VALUES ('58381', '0.257', '0', '0', 'Priest - Mind Flay - Trigger - all ranks'); I would like this topic to don't be forgotten, post your updates and fixes to the current version.

Is not possible to generically fix this kind of problem by despawning the spell target if quest credit is awarded to prevent using it again?

Bump, Frenzy is procing on normal attacks, this fixes that overpower please review. ps: the bloodsurge query is missing a ` quote

Updated first post with cleanup queries

I can confirm the problem.

Confirmed.

This patch is really interesting and needed, thanks for working on this complex patch.

Tested, works.

And what about this: The spell they should trigger 30452 has Apply Aura: Force Reaction (1059)

Hope will be fixed soon, really annoying to have testers whining.