[patch] Some Game Event Extensions

[jolan]

I just set up a git repo for serverwide event.

first update your local repo :

gut pull

then pull serverwide event :

git pull git://github.com/jolan/mangos.git serverwide

then apply sql patches in sql/updates/serverwide_event/

see sql/updates/serverwide_event/readme.txt for DB structure, there is no content sql included so you start with no serverwide event at all but you can test the demo sql from the first post.

the branch dosn't appear on mangos's network graph, that's strange, does someone know why ? [edit] never-mind, github had to refresh it

note : in struct GameEventData (GameEvent.h L54) new variables are not initialized, this is potentially a problem that need analysis

[Daimon22]

i always get The remote end hung up unexpectedly. does anybody has a solution for this.

thanks in advance

[jolan]

I have no idea ... i'll try to figure that out

[Daimon22]

it is working now. thank you

[jolan]

ok, there was a permission problem on github's side.

[FunkyBit]

Hi guys!

Just discovered this wonderfull thread and gave it to our testers.

They love it

But we found a little bug, that took us some time to realy get track of.

First of all - configuration: MaNGOS 0.12 REV 7066 (additional extensions don't touch the following)

Bug:

Wenn you do ".reload creature_questrelation" all quests that are under "game event control" get lost from thier NPCs.

Quests that get activated by a game event don't realy appear in the "creature_questrelation" table. They get somehow integrated on the fly.

Wenn you do the reload command MaNGOS seams to do a full rebuild of the cache from DB and the "on the fly" added quests by any game event are gone.

You have to restart the deamon or the game event to get them back.

Hope you can trace the bug as described

It's not that disturbing it was just as we didn't know about it

Any way, big thanks for this patch!!!

[Sephiroth1983]

Hi guys!

Just discovered this wonderfull thread and gave it to our testers.

They love it

But we found a little bug, that took us some time to realy get track of.

First of all - configuration: MaNGOS 0.12 REV 7066 (additional extensions don't touch the following)

Bug:

Wenn you do ".reload creature_questrelation" all quests that are under "game event control" get lost from thier NPCs.

Quests that get activated by a game event don't realy appear in the "creature_questrelation" table. They get somehow integrated on the fly.

Wenn you do the reload command MaNGOS seams to do a full rebuild of the cache from DB and the "on the fly" added quests by any game event are gone.

You have to restart the deamon or the game event to get them back.

Hope you can trace the bug as described

It's not that disturbing it was just as we didn't know about it

Any way, big thanks for this patch!!!

So the patch still compiles? If not, post your latest compiled

This patch can be really nice to have accepted, world events like Isle of Quel'danas and Ahn'Qiraj doors opening can have finally attention.

[FunkyBit]

Oh yes, it compiles without any problems!

Not a single line to modify yourself.

[jolan]

Fixed .reload creature_questrelation and .reload gameobject_questrelation

This doesn't make game_event_creature_quest or game_event_gameobject_quest reloadable, but game-events quest relations loaded at startup will be re-added to the list after reload

I didn't test .reload gameobject_questrelation nor serverwide-master , report any issue

there may be other .reload commands problems, I didn't check this yet.

You may have noticed that 'serverwide' branch is no more up-to-date, pull either serverwide-0.12 or serverwide-master

[jorooo]

Shouldn't something similar be written for Phases support? Only it should be player dependant, not realm dependant.

[jolan]

"Phases support" ? "player dependant" ?

I dont understand what you are talking about.

this patch implement server-wide (realm dependant) events such as shattered sun offensive plot line, it's realm dependant, players are supposed to contribute in order to get the realm to switch to the next phase. the whole concept is player independent. are you talking about something else ?

[jorooo]

I meant the phasing introduced in WotLK.

e.g. DK Phases

http://www.wowwiki.com/Phasing

[jolan]

ok, thank you i didn't know this new mechanism. I dont think it can be easily implemented from server-wide events but as i am not using master branch and i didn't investigate this mechanism i cant tell for sure.

some phases listed on wowiki's page are actually serverwide events (The Argent Vanguard etc.)

[FunkyBit]

Yes, we already used serverwide-0.12.

Thanks for fixing!!

I'll report after our next update.

[jorooo]

ok, thank you i didn't know this new mechanism. I dont think it can be easily implemented from server-wide events but as i am not using master branch and i didn't investigate this mechanism i cant tell for sure.

some phases listed on wowiki's page are actually serverwide events (The Argent Vanguard etc.)

This seems promising

Hopefully the devs will have time to commit this patch in git :rolleyes:

[charlie2025]

Not compatible now

[hikikomori18]

Not compatible now

What rev are you? did you get an error log?

[charlie2025]

What rev are you? did you get an error log?

Newest master .. Conflicts in three files, I have updated .

git pull git://github.com/charlie2025/mangos.git serverwide

[jolan]

I have updated

that's a good thing because I dont have much free time. would you like access to my serverwide repo ?

[charlie2025]

that's a good thing because I dont have much free time. would you like access to my serverwide repo ?

Yea, thanks, when I more tray it, if my update is work-able, I would push it to your repo and updated in your repo if you would be away

[Sephiroth1983]

I was also wondering if phasing system makes this patch outdated.

[jolan]

charlie2025 : you are now a "Repository Collaborator" on my mangos branch, tell me if you cant push

Sephiroth1983 : I dont think so. serverwide event units are (de-)spawns triggered by events while phased units are spawned units with phase id, but maybe i'm wrong.

[charlie2025]

charlie2025 : you are now a "Repository Collaborator" on my mangos branch, tell me if you cant push

Yes, it works, I pushed succesfully

[jolan]

ok. I used serverwide-master and serverwide-0.12 for different client revs. you pushed into serverwide, so I think it's for master branch ? I dont think it's a problem.

[amrok]

is it possible that this patch causes a graveyard bug?^^ if i release my spirit nothing happens... game_graveyard_zone table is fine