[Patch] Auction House Bot (Xeross' Branch)

[mrelfire]

Basicaly you are right and you correctly understaind the functionality.

Anyway i didn't develloped this in this way.

I limited the ratio to 10000 (thinking it's enought to make some difference between faction).

if (getConfig(CONFIG_UINT32_AHBOT_ALLIANCE_RATIO)>10000) setConfig(CONFIG_UINT32_AHBOT_ALLIANCE_RATIO,10000);
if (getConfig(CONFIG_UINT32_AHBOT_HORDE_RATIO)>10000) setConfig(CONFIG_UINT32_AHBOT_HORDE_RATIO,10000);
if (getConfig(CONFIG_UINT32_AHBOT_NEUTRAL_RATIO)>10000) setConfig(CONFIG_UINT32_AHBOT_NEUTRAL_RATIO,10000);

So if you whant i can elevate that value...

Anyway you still didn't give me an example of yellow/orange sellable item you whant to see in the AH...

I was more looking at the "multiplication" of little bread

[mnocz]

Hello, i have problem with BIND and BUYOUT prices.

Sometime happend, that the BUYOUT price is lower than BIND price and then is not possible BIND that items (BUYOUT button is disabled).

So I have an idea. Calculate BUYOUT price from BIND as simple BIND * MODIFIER.

Something like AuctionHouseBot.BuyPrice.Buyout = 20 (1-X in percentage)

So in this case BUYOUTprice = BINDprice * 1.20

Thanks for our work:)

[madmax765]

I often code after 18h till 2h.

Yes its redundant but i choose to let original method instead adding additional test. Just because i dont know if this method is called often or not to avoid any performence issue.

Update

On my repo :

1 - Added separate conf file (ahbot.conf)

2 - moved src files into subfolder.

GCC brokken iam working on it.

Update

GCC build restored.

hmm i cant seem to find ahbot.conf file

Can some one please post a patch file for core 10480

[mnocz]

hmm i cant seem to find ahbot.conf file

Can some one please post a patch file for core 10480

hi, here is patch from my yesterday compile (Cyberium - AHBot_new).

It is patched for SD2, so just apply:)

http://www.mediafire.com/?68i8hv4jsq3uzkb

gl.

[FeRkEl]

hmm i cant seem to find ahbot.conf file

Can some one please post a patch file for core 10480

the conf is in the sourcefile directory src/game/auctionhousebot/ahbot.conf

( don't know if it will be copied to any expected destination, i never compiled and run the new ahbot )

[mnocz]

the conf is in the sourcefile directory src/game/auctionhousebot/ahbot.conf

( don't know if it will be copied to any expected destination, i never compiled and run the new ahbot )

It is copied.

${MangosInstallDir}/etc/ahbot.conf.dist

must be renamed/copied as ${MangosInstallDir}/etc/ahbot.conf

And Buyer don't functional now, so is better disable him.

Because sometime buy something, last time buyed item for 1247514 Golds:))

[cyberium]

Hello, i have problem with BIND and BUYOUT prices.

Sometime happend, that the BUYOUT price is lower than BIND price and then is not possible BIND that items (BUYOUT button is disabled).

So I have an idea. Calculate BUYOUT price from BIND as simple BIND * MODIFIER.

Something like AuctionHouseBot.BuyPrice.Buyout = 20 (1-X in percentage)

So in this case BUYOUTprice = BINDprice * 1.20

Thanks for our work:)

I cannot reproduce it.

For compute of the price, iam not satisfied for now.

What do you think about :

Compute the buyout price :

Take de base price ( from DB )

Apply the "price ratio" (in ahbot conf file)

Randomize the value for exemple (-30%, +30%)

Compute de bind price:

Take 50% the buyout price (just computed)

Randomize the value for exemple (-40%, +40%)

Exemple:

price is 23 gold from DB, conf file set to 200 (%)

price = 23*(200/100) = 46

price = random ( 46-(46*(30/100)), 46+(46*(30/100))) = 52 for ex. aviable range (32.2 .. 59.8)

bind = price*(50/100) = 26

bind = random ( bind-(price*(40/100)), bind+(price*(40/100))) = 41 for ex. aviable range ( 5.2 .. 46.8)

I olso think about add settings to specify different ratio on the aviable categories but not sure if it will be usefull.

Greetings

[mrelfire]

I cannot reproduce it.

For compute of the price, iam not satisfied for now.

What do you think about :

Compute the buyout price :

Take de base price ( from DB )

Apply the "price ratio" (in ahbot conf file)

Randomize the value for exemple (-30%, +30%)

Compute de bind price:

Take 50% the buyout price (just computed)

Randomize the value for exemple (-40%, +40%)

Exemple:

price is 23 gold from DB, conf file set to 200 (%)

price = 23*(200/100) = 46

price = random ( 46-(46*(30/100)), 46+(46*(30/100))) = 52 for ex. aviable range (32.2 .. 59.8)

bind = price*(50/100) = 26

bind = random ( bind-(price*(40/100)), bind+(price*(40/100))) = 41 for ex. aviable range ( 5.2 .. 46.8)

I olso think about add settings to specify different ratio on the aviable categories but not sure if it will be usefull.

Greetings

tell us when you put this into the code so we can test these specific options

[cyberium]

Price compute method changed.

I hope i will get more feedback than now.

I confirm ahbuyer don't work as expected iam trying to get it work.

[mrelfire]

I have still some problems, I try to sell items and after 4 hours nobody buy them (I have devided by 2 the price suggested, I continue to wait )

[mnocz]

I have still some problems, I try to sell items and after 4 hours nobody buy them (I have devided by 2 the price suggested, I continue to wait )

Hi, it s mistake.

Cyberium said "I confirm ahbuyer don't work as expected iam trying to get it work.".

So AHBuyer do not work now, and he will try repair it as soon as possible:)

Maybe in next version will AHBuyer functional.

Good luck Cyberium:)

[EARTHWALKER]

Thankfully I haven't updated since rev 10442 as mine works flawlessly..lol

/me runs and hides

[DaemonCantor]

mrelfire, you still working on ahbot?....I thought you'd have it mastered by now....lol

[mrelfire]

mrelfire, you still working on ahbot?....I thought you'd have it mastered by now....lol

you are right

[cyberium]

Update:

- added comment on the code.

- removed some bug on ahbuyer.

Has i said i only will debug ahbuyer for now. No optmising or adding stuff on it.

Can anyone give me feedback on the ahbuyer?

[Skirnir]

git apply ../ahbot.patch 
../ahbot.patch:256: trailing whitespace.
// getRandomArray is used to make aviable the possibility to add any of missed item in place of first one to last one. 
../ahbot.patch:293: trailing whitespace.
// Add new auction to one of the factions. 
../ahbot.patch:318: trailing whitespace.
   while (getRandomArray(config,RandArray, ItemsAdded) && (items>0))

Compiling, will report later.

Yours

Skirnir

PS: It bids! At least on one item. Reduced the price, nevertheless thats a positive thing, servers running for 8 Min.

PPS: Is there a feature to reload ahbot.conf? I wanted to change bid interval to force him to buy an item, I changed the value, but had to restart therefore.

[cyberium]

Is there a feature to reload ahbot.conf?

Not yet, however it's on my todo. ( at least with ingame command )

[Skirnir]

Okay looked again: http://paste2.org/p/995166

It seems that ahbot.buyer bids on items owned by himself. IF thats not wanted I suggest a check if itemowners.guid is a player.guid.

Regards

Skirnir

PS: No one else bid on these items before. Just as information, its not the case that ahbot.buyer tries to initiate a real "auction" by rising the price :-)

PPS: I use new_ahbot branch if there was any doubt.

[cyberium]

It seems that ahbot.buyer bids on items owned by himself.

Yes this bug was resolved by last patch, so you probably not reset your table before testing my last revision?

Normaly this would not happen now.

Thanks for your excellent feedback.

[mnocz]

Update:

- added comment on the code.

- removed some bug on ahbuyer.

Has i said i only will debug ahbuyer for now. No optmising or adding stuff on it.

Can anyone give me feedback on the ahbuyer?

Hello,

Compiled with last MaNGOS revision + SD2, no problem.

Buyer buy only at Aliance/Hrode Auctions. Do not buy at neutral Auction for me.

AuctionHouseBot.Alliance.Buyer.Enabled = 1

AuctionHouseBot.Horde.Buyer.Enabled = 1

AuctionHouseBot.Neutral.Buyer.Enabled = 1

AuctionHouseBot.Buyer.Bid.Interval = 1

AuctionHouseBot.Buyer.BidDigin.Interval = 1

[cyberium]

Buyer buy only at Aliance/Hrode Auctions. Do not buy at neutral Auction for me.

Not confirmed for me. It work no mater faction used.

If you are sure, give me more info about item selled, price etc...

[Skirnir]

I can confirm it, it does not even bid for items. After truncating the auction table another interesting thing happened.

http://paste2.org/p/995680

First part: Items ahbot bids for.

Second part: Items inserted by me.

Third part: Items inserted by ahbot ... somehow thats a quite spendable bot :-)

Regards

Skirnir

PS: ahbot.conf: http://paste2.org/p/995688

[cyberium]

yes regarding tour table we can see auction house number 7 (neutral) items are not yet bided.

Strange because just tried it and on my config i have item buyed and bided normaly.

Anyway thanks i am investigating.

[aternox]

I apologize if I missed it in search.

Is there a 10485 compatible version of ahbot?

[mnocz]

I apologize if I missed it in search.

Is there a 10485 compatible version of ahbot?

I compiled it with MaNGOS r10509 + SD2 1826 with no problem.