[Patch] Auction House Bot (Xeross' Branch)

thcobl · September 26, 2010

is it possible to let the bot not put stack of glyphs on AH

when i put option glyphs on it starts to put full stacks on AH

while it should be better that it put them on AH as 1 in stead of 2-20

madmax765 · September 30, 2010

cyberium i tryed to use your ahbot patch. but i get 3 errors 9 ok when core is done built using mangos 10558was using xeross branck witch allways worked good for me (10484)... tell i updated core to 10558

mnocz · September 30, 2010

cyberium i tryed to use your ahbot patch. but i get 3 errors 9 ok when core is done built using mangos 10558was using xeross branck witch allways worked good for me (10484)... tell i updated core to 10558

Hi,

I tyred now compile lastest Core+SD2+AHBot_new and it is done with no errors:)

I know these AHBot_new bugs:

Neutral AHBot_Buyer do not buy.

Money exploits.

-1. some lootable items have in DB(UDB ) abnormal low sell/buy(copper-silver) prices. This items are lootable and treir content is able sell for many golds. Items like Bag of coins, bag of gems etc... If you change sell/buy(it depends on method you generate seller prices) price so this money exploit is resolved:)

-2. default AHBot properties...(example) is possible buy item from AHBot_seller for 5Golds and sell to AHBot_buyer for 20Golds. But if change properties, so all is ok and this money exploit is resolved:)

cyberium · September 30, 2010

If you are satisfied with your actual ahbot conf can you please share it with us? I will make it new default.

I still working on the new ingame command, i have to implement status and rebuild before i update the patch. I hope i will have time today.

EARTHWALKER · September 30, 2010

Just grabbed the new core, SD2'd it, made the patch which was 996kb. A lot larger than previous one's. Tried to patch and ended in an epic fail.

No matter what (of the hundreds) of variations I use (&^%Y$$ GIT) I get this output.

$ patch -p1 < new_ahbot.patch
patching file `.gitignore'
Reversed (or previously applied) patch detected!  Assume -R? [n]

No matter what I press, I get patch or hunk failed.

I don't understand at all what is going on.

cyberium · September 30, 2010

Update:

- Removed the need of getauctionhouseentrybyfaction method.

- Added ingame commands just type (in level 3 account) .ahbot help for complete list.

- Some comment added and some optimisation.

@ EARTHWALKER, Just updated so please try with latest build.

ps: didnt have time till now to test gcc compilation...

mnocz · September 30, 2010

Update:
- Removed the need of getauctionhouseentrybyfaction method.

- Added ingame commands just type (in level 3 account) .ahbot help for complete list.

- Some comment added and some optimisation.

@ EARTHWALKER, Just updated so please try with latest build.

ps: didnt have time till now to test gcc compilation...

Lastest MaNGOS + SD2 + AHbot_new

Err at compilation:

make[3]: Leaving directory `/home/mangos/mcompile/mworldtest/mangos/objdir/src/realmd'
Making all in game
make[3]: Entering directory `/home/mangos/mcompile/mworldtest/mangos/objdir/src/game'
Making all in AuctionHouseBot
make[4]: Entering directory `/home/mangos/mcompile/mworldtest/mangos/objdir/src/game/AuctionHouseBot'
 CXX    AuctionHouseBot.o
In file included from ../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:1:
../../../../src/game/AuctionHouseBot/AuctionHouseBot.h:421: error: expected â,â or â...â before â||â token
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp: In member function âvoid AuctionHouseBot::addNewAuctionBuyerBotBid(AHBConfig*, WorldSession*)â:
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:326: warning: format â%fâ expects type âdoubleâ, but argument 3 has type âlong doubleâ
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:345: warning: format â%fâ expects type âdoubleâ, but argument 3 has type âlong doubleâ
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp: In member function âvoid AuctionHouseBot::Initialize()â:
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:598: warning: format not a string literal and no format arguments
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:628: warning: format not a string literal and no format arguments
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:779: warning: format â%uâ expects type âunsigned intâ, but argument 4 has type âsize_tâ
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:779: warning: format â%uâ expects type âunsigned intâ, but argument 5 has type âsize_tâ
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:779: warning: format â%uâ expects type âunsigned intâ, but argument 6 has type âsize_tâ
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:779: warning: format â%uâ expects type âunsigned intâ, but argument 7 has type âsize_tâ
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:779: warning: format â%uâ expects type âunsigned intâ, but argument 8 has type âsize_tâ
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:779: warning: format â%uâ expects type âunsigned intâ, but argument 9 has type âsize_tâ
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:779: warning: format â%uâ expects type âunsigned intâ, but argument 10 has type âsize_tâ
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp: At global scope:
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:1086: error: expected â,â or â...â before â||â token
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp: In member function âvoid AuctionHouseBot::SetItemsAmount(uint32, uint32, uint32, uint32, uint32, uint32)â:
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:1093: error: expected primary-expression before â||â token
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:1093: error: expected primary-expression before â)â token
../../../../src/game/AuctionHouseBot/AuctionHouseBot.cpp:1094: error: âyeâ was not declared in this scope
make[4]: *** [AuctionHouseBot.o] Error 1
make[4]: Leaving directory `/home/mangos/mcompile/mworldtest/mangos/objdir/src/game/AuctionHouseBot'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/mangos/mcompile/mworldtest/mangos/objdir/src/game'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/mangos/mcompile/mworldtest/mangos/objdir/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/mangos/mcompile/mworldtest/mangos/objdir'
make: *** [all] Error 2

cyberium · September 30, 2010

Sorry due to stupid naming of variable...

Updated...

mnocz · September 30, 2010

Sorry due to stupid naming of variable...
Updated...

Thanks, compile OK:)

mnocz · September 30, 2010

If you are satisfied with your actual ahbot conf can you please share it with us? I will make it new default.
I still working on the new ingame command, i have to implement status and rebuild before i update the patch. I hope i will have time today.

Ok, I test something yet, and then i post my conf.

I use AHBot on blizzlike server with low population, so my AHBot do not sell puprle and better items, and more limitations. So I configure AHBot on dev server to sell all items and try money exploits form much kind of items as possible.

cyberium · October 1, 2010

I know these AHBot_new bugs:

Neutral AHBot_Buyer do not buy.

In this code you can see on config buyer are working

mysql> SELECT * FROM auction WHERE lastbid!=0;
+--------+---------+----------+---------------+-----------+-------------+------------+------------+---------+----------+---------+
| id     | houseid | itemguid | item_template | itemowner | buyoutprice | time       | buyguid    | lastbid | startbid | deposit |
+--------+---------+----------+---------------+-----------+-------------+------------+------------+---------+----------+---------+
| 116433 |       7 |  1335924 |         41603 |         1 |     1000000 | 1286013666 | 4294967295 |   90900 |    30000 |   30000 |
| 116421 |       7 |  1335904 |         41603 |         1 |       40000 | 1286013399 | 4294967295 |   30001 |    30000 |   30000 |
| 116439 |       7 |  1335923 |         41603 |         1 |      300000 | 1286013689 | 4294967295 |  221100 |    30000 |   30000 |
| 116440 |       7 |  1117718 |         41603 |         1 |     9000000 | 1286013715 | 4294967295 |  239400 |   210000 |  210000 |
+--------+---------+----------+---------------+-----------+-------------+------------+------------+---------+----------+---------+
4 rows in set

So i don't see where the problem are... I will try your conf when you post it.

Anyway i will work on buyer next week (started now to modify algorithm to make it more unpredictable)

If you whant some new stuff (you think it will be important to have) on ah seller part or see any other bug please be free to post it. If no feedback about it i will considere all is fine and do code rebase only for future "under review" section.

Here is my plan for buyer part.

- make a decision about auction entry only 1 time. (mean at next auction scan by buyer it will be ignored)

- the more cheaper are the item the more chance you will have to sell it.

- if there is other item same as your (selled by ahbot or other player) less expensive you will have less chance to sell it.

- if this kind of item is the only one exist on the ah you will have more chance to sell it at expensive price.

- The bid will be computed to be minimal one. (percentage of total price)

- And probably other idea... so stay tuned

Sky1 · October 1, 2010

I use the latest mangos with the lates new_ah patch and it work perfect. I wanted to test it out so I created a Admin account and went to the AH to sell stuff. I put 9 items on the AH for between 20g and 25g. Let my server run and came back 3 hrs later and found in my mail 6 sold out. So 6 x 20g is 120g in 3 hrs.

What I want to know...is that not a bit to much money in 3 hrs? It is fun that AHbot buy stuff but if you get much money in less time it ruin the game a bit. Or is that not so much money in 3 hrs. I hardly play on the blizz server so I don`t know what normal is for the ammount of money.

mnocz · October 1, 2010

I use the latest mangos with the lates new_ah patch and it work perfect. I wanted to test it out so I created a Admin account and went to the AH to sell stuff. I put 9 items on the AH for between 20g and 25g. Let my server run and came back 3 hrs later and found in my mail 6 sold out. So 6 x 20g is 120g in 3 hrs.
What I want to know...is that not a bit to much money in 3 hrs? It is fun that AHbot buy stuff but if you get much money in less time it ruin the game a bit. Or is that not so much money in 3 hrs. I hardly play on the blizz server so I don`t know what normal is for the ammount of money.

Yes, we knows about this money exploit. I am working on new configuration for AHBot now.

mnocz · October 1, 2010

In this code you can see on config buyer are working
mysql> SELECT * FROM auction WHERE lastbid!=0;
+--------+---------+----------+---------------+-----------+-------------+------------+------------+---------+----------+---------+
| id     | houseid | itemguid | item_template | itemowner | buyoutprice | time       | buyguid    | lastbid | startbid | deposit |
+--------+---------+----------+---------------+-----------+-------------+------------+------------+---------+----------+---------+
| 116433 |       7 |  1335924 |         41603 |         1 |     1000000 | 1286013666 | 4294967295 |   90900 |    30000 |   30000 |
| 116421 |       7 |  1335904 |         41603 |         1 |       40000 | 1286013399 | 4294967295 |   30001 |    30000 |   30000 |
| 116439 |       7 |  1335923 |         41603 |         1 |      300000 | 1286013689 | 4294967295 |  221100 |    30000 |   30000 |
| 116440 |       7 |  1117718 |         41603 |         1 |     9000000 | 1286013715 | 4294967295 |  239400 |   210000 |  210000 |
+--------+---------+----------+---------------+-----------+-------------+------------+------------+---------+----------+---------+
4 rows in set
So i don't see where the problem are... I will try your conf when you post it.

Anyway i will work on buyer next week (started now to modify algorithm to make it more unpredictable)

If you whant some new stuff (you think it will be important to have) on ah seller part or see any other bug please be free to post it. If no feedback about it i will considere all is fine and do code rebase only for future "under review" section.

Here is my plan for buyer part.

- make a decision about auction entry only 1 time. (mean at next auction scan by buyer it will be ignored)

- the more cheaper are the item the more chance you will have to sell it.

- if there is other item same as your (selled by ahbot or other player) less expensive you will have less chance to sell it.

- if this kind of item is the only one exist on the ah you will have more chance to sell it at expensive price.

- The bid will be computed to be minimal one. (percentage of total price)

- And probably other idea... so stay tuned

Hello,

In last revision AHbot is Buyer functional in all Auctions:) Tested today, Great:)

With Money Exploits it will be more complicated than I think at first time:/

The problem is in BINDprice and BuyerPrice...I make more tests and write what i found...

EARTHWALKER · October 1, 2010

Can someone post how to make a patch file please.

I know there are a few variations, as I think I've tried them all, so rather than beat the dead horse, I'm asking to see what other people do from start to finish and compare.

Here is what I do. The patch is made, but it does seem a bit odd

Make new folder in C: named corefiles
Right-click and select git bash
Type these into bash window
git clone git://github.com/cyberium/mangos.git new_ahbot
cd new_ahbot
git checkout -b new_ahbot origin/ahbot
git diff 4bbb824c8088d28d9736bea51edcda586c471901 new_ahbot > ../ahbot.patch

Patch now found inside c:\\corefiles
Copy patch to whatever folder your binaries are in.
Right-click the folder and choose git bash
Type:-
patch -p1 < ahbot.patch

I'm sure I have always done it this way and not had a problem...until now, so perhaps I am in error somewhere hidden to me.

cyberium · October 1, 2010

Try this

git clone git://github.com/cyberium/mangos.git new_ahbot
cd new_ahbot
git checkout new_ahbot
git diff master > ../ahbot.patch

go to your repository (of course in bash mode)
git apply ../ahbot.patch

Greetings

caeruleaus · October 1, 2010

120g in 3 hours isnt that much. I used to make ~500g a day (in about 5-8 hours) just questing at level 80. And whenever I got stuff to sell that number could drastically increase. There are people who farm ore and make about 5000g a day on retail

thcobl1 · October 5, 2010

Hi,

does anyone has a working patch for me

when i try to apply patch i get :

generals:/home/svn/master# git apply ../AHBot.patch

../AHBot.patch:2386: trailing whitespace.

auctionbot.SetItemsRatio(&uparam1, &uparam2, &uparam3);

../AHBot.patch:2560: trailing whitespace.

PSendSysMessage("Items Amount : Grey = %u, White = %u, Green = %u, Blue = %u, Purple = %u, Orange = %u, Yellow = %u", auctionbot.getConfig(CONFIG_UINT32_AHBOT_ITEM_GREY_AMOUNT), auctionbot.getConfig(CONFIG_UINT32_AHBOT_ITEM_WHITE_AMOUNT),

warning: 2 lines add whitespace errors.

generals:/home/svn/master#

cyberium · October 5, 2010

Hi,
does anyone has a working patch for me

when i try to apply patch i get :

generals:/home/svn/master# git apply ../AHBot.patch

../AHBot.patch:2386: trailing whitespace.

auctionbot.SetItemsRatio(&uparam1, &uparam2, &uparam3);

../AHBot.patch:2560: trailing whitespace.

PSendSysMessage("Items Amount : Grey = %u, White = %u, Green = %u, Blue = %u, Purple = %u, Orange = %u, Yellow = %u", auctionbot.getConfig(CONFIG_UINT32_AHBOT_ITEM_GREY_AMOUNT), auctionbot.getConfig(CONFIG_UINT32_AHBOT_ITEM_WHITE_AMOUNT),

warning: 2 lines add whitespace errors.

generals:/home/svn/master#

It's a working patch Don't worry about theses trainling space warning... I will resolve it next commit. (but i can't for now too much modification on ahbuyer are comming)

thcobl1 · October 5, 2010

so i can start compile my server again ?

EARTHWALKER · October 5, 2010

Thanks Cyber. Did what you said and it now patches and compiles fine.

I do have another problem though.

I start the server and get this in the console:-

Initialize AuctionHouseBot...

-------------------------------
------- AuctionHouseBot -------
-------------------------------

AHBot> New CORE by Cyberium (Original by Xeross, Naicisum, ChrisK, Paradox)
AHBot> Includes AHBuyer by Kerbe and Paradox (Not tested)
AHBot> Unable to open configuration file(ahbot.conf). AHBOT is Disabled.
WORLD: World initialized
SERVER STARTUP TIME: 1 minutes 22 seconds
mangosd process priority class set to HIGH

I did take all the ahbot configurations and put them into a file ahbot.conf in the same folder as the rest of the conf files and still this comes up.

Any clues?

EDIT: I fixed it

Somehow I didn't have this in my conf file:-

################################################
# MANGOS Auction House Bot Configuration file  #
################################################

[AhbotConf]
ConfVersion=2010090101

Most peculiar

EARTHWALKER · October 5, 2010

Just wondering, with all these changes now, is the auctionhousebot.sql file needed still, or is that now redundant?

cyberium · October 5, 2010

Just wondering, with all these changes now, is the auctionhousebot.sql file needed still, or is that now redundant?

No, there is no auctionhousebot.sql in my "new_ahbot" repo long time ago...

EARTHWALKER · October 6, 2010

Ok dude, thanks.

I'll get that removed from my database as it's still lurking

mrelfire · October 6, 2010

a little question for Cyberium: are we far away from the review "stages " in % ? :rolleyes:

Sign In

[Patch] Auction House Bot (Xeross' Branch)

Recommended Posts

Link to comment

Share on other sites

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Recently Browsing 0 members

Contact Us

Repositories

Important Information