[Crash][9236]CountTheRoll

[Auntie Mangos]

Voldemmort yes I guess still no one can fix that "kaka" without reverting: http://getmangos.eu/community/showthread.php?12213-[Crash][9236]CountTheRoll&p=101812&viewfull=1#post101812

[Auntie Mangos]

Here is it! Let's suffer together my friend!

http://getmangos.eu/community/showthread.php?4235-Linux-crash-dumps&p=103890&viewfull=1#post103890

[wside420]

Not sure if its related but I noticed the Roll Code Changed on January 9th.

Happens every Hour or so.

Registers:
EAX:00011000
EBX:F33A0A90
ECX:F3008F00
EDX:00000080
ESI:00000000
EDI:008A5FA0
CS:EIP:0023:004ABA81
SS:ESP:002B:0D6625C8  EBP:0D6627D0
DS:002B  ES:002B  FS:0053  GS:002B
Flags:00010206

Call stack:
Address   Frame     Function      SourceFile
004ABA81  00000000  Group::CountTheRoll+31
004ABA49  00000000  Group::EndRoll+69
00491C21  00000000  Creature::Update+501
004DCE1F  00000000  MaNGOS::ObjectUpdater::Visit+6F
004DCDA2  00000000  VisitorHelper<MaNGOS::ObjectUpdater,Creature>+12
004DC320  00000000  VisitorHelper<MaNGOS::ObjectUpdater,Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > >+10
004DBDB3  00000000  VisitorHelper<MaNGOS::ObjectUpdater,GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > >+23
004DB690  00000000  VisitorHelper<MaNGOS::ObjectUpdater,TypeList<GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > > >+10
004D6F2F  00000000  Map::Visit<MaNGOS::SingleThreaded<ACE_RW_Thread_Mutex>::Lock,MaNGOS::ObjectUpdater,TypeMapContainer<TypeList<GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > > > >+FF
004D1386  00000000  Cell::Visit<MaNGOS::SingleThreaded<ACE_RW_Thread_Mutex>::Lock,MaNGOS::ObjectUpdater,TypeMapContainer<TypeList<GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > > > >+56
004B899D  00000000  Map::Update+35D
004BEE63  00000000  InstanceMap::Update+13
0083D7FE  00000000  MapInstanced::Update+DE
0067E558  00000000  MapManager::Update+128
0062086E  00000000  World::Update+8BE
0043079E  00000000  WorldRunnable::run+8E
008A5FB9  00000000  ACE_Based::Thread::ThreadTask+19
00B91B84  00000000  __WSAFDIsSet+FFFFFFFFFFFCCB4C
78543433  00000000  _endthreadex+44
785434C7  00000000  _endthreadex+D8
7D4DFE37  00000000  FlsSetValue+13C

Call stack:
Address   Frame     Function      SourceFile
7D61C846  00000000  NtWaitForSingleObject+15
7D4D8C0D  00000000  WaitForSingleObject+12
00B49C04  00000000  __WSAFDIsSet+FFFFFFFFFFF84BCC
00BB64AA  00000000  __WSAFDIsSet+FFFFFFFFFFFF1472
00BB266F  00000000  __WSAFDIsSet+FFFFFFFFFFFED637
0063847A  00000000  WorldSocketMgr::Wait+4A
F35AAC04  FFFFFFFF  0000:00000000 
F35AAC04  FFFFFFFF  0000:00000000 
6C696146  00000000  

[Shadez]

I can confirm this crash on [9245].

[wside420]

bump..............

[Wowka321]

Confirm. Think related http://github.com/mangos/mangos/commit/e8929f3c939dfad55518e316711ed260cdbddca8

I'll try to revert...

[wside420]

Yea I was looking at that.

Let me know how that Works. I'll do the same

[Wojta]

I reverted it and it seems that its "stable" now. Uptime 2 hours and 16 min now(345 ppl), before it was 30-40 min max.

[Wowka321]

Yep, ufter undo this commit stability come back. =)

[Span1sh]

I think i got same crash, but with ACE-mtmaps it looks like that:

#0 Group::EndRoll (this=0x8c7a88500) at stl_list.h:223
#1 0x000000000050c4dc in Creature::Update (this=0x8ce703000, diff=Variable "diff" is not available.
)

at ../../../src/game/Creature.cpp:407

#2 0x00000000005c9eb8 in VisitorHelper<MaNGOS::ObjectUpdater, Creature> (

v=@0x7ffffeff8e90) at GridNotifiersImpl.h:47

#3 0x00000000005dbab2 in Map::Update (this=0x8c9c80000, t_diff=Variable "t_diff" is not available.
)

at TypeContainerVisitor.h:70

#4 0x00000000005dd039 in InstanceMap::Update (this=0x8c9c80000,

t_diff=@0x8c7ca2210) at ../../../src/game/Map.cpp:2503

#5 0x00000000007c5a68 in MapInstanced::Update (this=0x839f90000,

t=@0x8c7ca2210) at ../../../src/game/MapInstanced.cpp:63

#6 0x00000000005ec082 in MapUpdateRequest::call (this=0x8c7ca21f0)

at ../../../src/game/MapUpdater.cpp:47

#7 0x000000000081fefb in DelayExecutor::svc (this=0x813c64e18)

at ../../../src/shared/DelayExecutor.cpp:60

#8 0x0000000800c52117 in ACE_Task_Base::svc_run ()
from /usr/local/lib/libACE-5.7.5.so #9 0x0000000800c52431 in ACE_Thread_Adapter::invoke ()
from /usr/local/lib/libACE-5.7.5.so #10 0x000000080194f4d1 in pthread_getprio () from /lib/libthr.so.3 . 

Mb somebody knows how to fix current code without any revertion?

[henhouse]

I reverted it and it seems that its "stable" now. Uptime 2 hours and 16 min now(345 ppl), before it was 30-40 min max.

Good, so a revert will work fine. Alright, gonna do that until this commit is stable. Cheers

[Synt]

9260 still having this crash

and for some reason i can't revert the commit.

[wside420]

Well I Reverted that specific Commit.

Although The up time has been 12 Hours.

I Received the Exact same Crash log.

004ABA81 00000000 Group::CountTheRoll+31

004ABA49 00000000 Group::EndRoll+69

00491C21 00000000 Creature::Update+501

Blah blah... So Looks like This Isn't a fix for the crash.

[kero99]

9260 still having this crash

and for some reason i can't revert the commit.

You need revert two commit:

first: http://github.com/mangos/mangos/commit/d86ad9e91fd1623be131f3f558dba34ac0040925

second: http://github.com/mangos/mangos/commit/e8929f3c939dfad55518e316711ed260cdbddca8

Best Regards

[KiriX]

Confirm... Crash stay alive at rev.9254...

I get also one other crash with Group, but crash-log was deleted...

[yasuno]

Well as easy as reverting 2 commits is for most of us, why isnt this being looked into by some body, its still on the latest revisions and is hurting uptime horribly. I think this should be fixed instead of the user reverting, its not good to leave bad forgotten code in the core.

[The_Game_Master]

Here is a more accturate backtrace of the problem.

SESSION: received not allowed opcode CMSG_LFD_PLAYER_LOCK_INFO_REQUEST (0x036E)

Program received signal SIGSEGV, Segmentation fault.
[switching to Thread 0x7fe4b3fff950 (LWP 15154)]
0x0000000000584e7b in Group::EndRoll (this=0x7fe476a5ded0)
   at /usr/lib64/gcc/x86_64-slackware-linux/4.3.3/../../../../include/c++/4.3.3/bits/stl_iterator_base_funcs.h:85
85                ++__n;
(gdb)
------------------------------------------------------------------------------------------------------------------------
(gdb) info program
       Using the running image of child Thread 0x7fe4b3fff950 (LWP 15154).
Program stopped at 0x584e7b.
It stopped with signal SIGSEGV, Segmentation fault.
(gdb)
------------------------------------------------------------------------------------------------------------------------
(gdb) bt
#0  0x0000000000584e7b in Group::EndRoll (this=0x7fe476a5ded0)
   at /usr/lib64/gcc/x86_64-slackware-linux/4.3.3/../../../../include/c++/4.3.3/bits/stl_iterator_base_funcs.h:85
#1  0x000000000051bf84 in Creature::Update (this=0x7fe48eddf350, diff=<value optimized out>) at ../../../src/game/Creature.cpp:409
#2  0x00000000005f12f6 in VisitorHelper<MaNGOS::ObjectUpdater, Creature> (v=@0x7fe4b3ffefa0, c=<value optimized out>)
   at ../../../src/game/GridNotifiersImpl.h:47
#3  0x00000000005f0cd2 in Map::Update (this=0xcf3360, t_diff=@0x7fe4b3ffeffc) at ../../../src/game/../framework/GameSystem/TypeContainerVisitor.h:70
#4  0x00000000005fae17 in MapManager::Update (this=0x7fe4b65698d0, diff=<value optimized out>) at ../../../src/game/MapManager.cpp:265
#5  0x000000000076be94 in World::Update (this=0x7fe4c8012670, diff=17) at ../../../src/game/World.cpp:1672
#6  0x00000000004d9420 in WorldRunnable::run (this=<value optimized out>) at ../../../src/mangosd/WorldRunnable.cpp:60
#7  0x00000000008126cc in ACE_Based::Thread::ThreadTask (param=0x7fe476a5ded0) at ../../../src/shared/Threading.cpp:183
#8  0x00007fe4cd9c23a0 in start_thread () from /lib64/libpthread.so.0
#9  0x00007fe4cd293bdd in clone () from /lib64/libc.so.6
------------------------------------------------------------------------------------------------------------------------

(gdb) bt full
#0  0x0000000000584e7b in Group::EndRoll (this=0x7fe476a5ded0)
   at /usr/lib64/gcc/x86_64-slackware-linux/4.3.3/../../../../include/c++/4.3.3/bits/stl_iterator_base_funcs.h:85
No locals.
#1  0x000000000051bf84 in Creature::Update (this=0x7fe48eddf350, diff=<value optimized out>) at ../../../src/game/Creature.cpp:409
       group = (Group *) 0x7fe400000001
#2  0x00000000005f12f6 in VisitorHelper<MaNGOS::ObjectUpdater, Creature> (v=@0x7fe4b3ffefa0, c=<value optimized out>)
   at ../../../src/game/GridNotifiersImpl.h:47
No locals.
#3  0x00000000005f0cd2 in Map::Update (this=0xcf3360, t_diff=@0x7fe4b3ffeffc) at ../../../src/game/../framework/GameSystem/TypeContainerVisitor.h:70
       cell = {data = {Part = {grid_x = 12, grid_y = 34, cell_x = 2, cell_y = 4, nocreate = 1, reserved = 16}, All = 554707084}}
       y = 276
       x = 98
       plr = <value optimized out>
       area = {right_offset = 1, left_offset = 1, upper_offset = 2, lower_offset = 1}
       updater = {i_timeDiff = 100}
       grid_object_update = {i_visitor = @0x7fe4b3ffefa0}
       world_object_update = {i_visitor = @0x7fe4b3ffefa0}
       __PRETTY_FUNCTION__ = "virtual void Map::Update(const uint32&)"
#4  0x00000000005fae17 in MapManager::Update (this=0x7fe4b65698d0, diff=<value optimized out>) at ../../../src/game/MapManager.cpp:265
No locals.
#5  0x000000000076be94 in World::Update (this=0x7fe4c8012670, diff=17) at ../../../src/game/World.cpp:1672
No locals.
#6  0x00000000004d9420 in WorldRunnable::run (this=<value optimized out>) at ../../../src/mangosd/WorldRunnable.cpp:60
       diff = 17
       realCurrTime = 1896911535
       realPrevTime = <value optimized out>
       prevSleepTime = 0
#7  0x00000000008126cc in ACE_Based::Thread::ThreadTask (param=0x7fe476a5ded0) at ../../../src/shared/Threading.cpp:183
       _task = (class ACE_Based::Runnable *) 0xd621f0
#8  0x00007fe4cd9c23a0 in start_thread () from /lib64/libpthread.so.0
No symbol table info available.
#9  0x00007fe4cd293bdd in clone () from /lib64/libc.so.6
No symbol table info available.
(gdb)
------------------------------------------------------------------------------------------------------------------------
(gdb) info threads
 12 Thread 0x7fe4b17fa950 (LWP 15172)  0x00007fe4cd2941a8 in epoll_wait () from /lib64/libc.so.6
 11 Thread 0x7fe4b1ffb950 (LWP 15167)  0x00007fe4cd2941a8 in epoll_wait () from /lib64/libc.so.6
 10 Thread 0x7fe4b27fc950 (LWP 15166)  0x00007fe4cd2941a8 in epoll_wait () from /lib64/libc.so.6
 9 Thread 0x7fe4b2ffd950 (LWP 15158)  0x00007fe4cd9c9691 in nanosleep () from /lib64/libpthread.so.0
 8 Thread 0x7fe4b37fe950 (LWP 15155)  0x00007fe4cd9c9691 in nanosleep () from /lib64/libpthread.so.0
* 7 Thread 0x7fe4b3fff950 (LWP 15154)  0x0000000000584e7b in Group::EndRoll (this=0x7fe476a5ded0)
   at /usr/lib64/gcc/x86_64-slackware-linux/4.3.3/../../../../include/c++/4.3.3/bits/stl_iterator_base_funcs.h:85
 5 Thread 0x7fe4c77fe950 (LWP 14681)  0x00007fe4cd9c9691 in nanosleep () from /lib64/libpthread.so.0
 4 Thread 0x7fe4c7fff950 (LWP 14680)  0x00007fe4cd9c9691 in nanosleep () from /lib64/libpthread.so.0
 3 Thread 0x7fe4cd1ae950 (LWP 14679)  0x00007fe4cd9c9691 in nanosleep () from /lib64/libpthread.so.0
 1 Thread 0x7fe4cfd68700 (LWP 14651)  0x00007fe4cd9c2c05 in pthread_join () from /lib64/libpthread.so.0

[wside420]

I apologize I made the Changes for The Code. However my Exhausted Self Switched the Wrong mangosd.exe to test.

I have switched them now and will report back results tomorrow.

I apologize for confusion

[Rage Hunter]

I was helped by recoil 9233 and 9228! The server already works more than days!

To whom it is necessary in the form of a patch!

[zhenya``]

can someone post a line which cause a crash?

[silverleet]

are you working on that?

[hentai01]

I was helped by recoil 9233 and 9228! The server already works more than days!

To whom it is necessary in the form of a patch!

Hi! im trying to apply this patch but it says "fatal: corrupt patch at line 25"

Probably it's not your fault, i never maked apply a patch and i saw all the guides and faq on this forum...

What i do is take the crash.patch file put on my mangos source "c:/mangos/" not the "c:/mangos/src" then i open the git bash.

Im trying to apply with this commands "git apply crash.patch" and got that error =/

plz some help ? i___i

[Rage Hunter]

I apologise! Not that has laid out, here the correct!

Use git bash!

patch -p1 < crash.patch

[hentai01]

I saw the edit only now

i will check out and post here ^^"

[Voldemmort]

I apologise! Not that has laid out, here the correct!

Use git bash!

patch -p1 < crash.patch

Hello Rage, thanks for the patch, I'll test it now.

P.D: You post the same link of the previous patch. Is it correct?