[Patch] Auction House Bot (Xeross' Branch)

[thyphoon]

I don't see why that is a problem, but maybe a solution for the name would be make some changes in the part of the code that send the name of the seller to the client so if the seller guid = 0 then send player name = AHbot.

of course I'am just thinking here, I haven't even look at the source code, I don't know a thing about C

Also: I have to see what happens when the guid is 0 and the item expires and it is returned or buy-outed. what happens to the email it generates?

[VladimirMangos]

We send only GUID to client, so i don't know how i can assign a name to an unassigned GUID... Someone have idea?

when you send unknown for client player guid, client ask name info proccessed at server side in WorldSession::HandleNameQueryOpcode

so you can overwrited it. I not like by self using fake players, but agree that use fake guid at least better that use fake player object.

Vladimir has requested a NPC ...

I am not 100% sure that this possible and ofc will required modify handlers for this case.

But if possible this will better. Still not find time make tests with some creature use in this way...

[shivajiva]

Any chance of you updating your git repo xeross?

[Whyarp]

I Just merged and compiled using FrenchW's branch, works so far, no merge conflicts usig core 10337 + PlayerBot...

[PaLL3]

Its working with ScriptDev2 aswell?

Earlier i had some compiling problems with ScriptDev2 and ahbot...

[thyphoon]

Vladimir: I think using fake player is going to be easier and cleaner than using a NPC, to fake a player we just need to send fake data to the client, but to use a NPC I think we will need the rewrite of too many code; logically NPC and players are handled differently right?

Pall3: I just compiled 10337 + Scriptdev2 + AHbot so no problem about it.

[cyberium]

I am about to finish the code of auctionner with fake GUID.

Here is what i found.

GUID=0 cannot be used because client not send query to know player name.

All player class can be removed from ahbot class.

I used MaxUInt32 for default Fake GUID.

You will be able to use name of any npc in database. The default is "AHBot" but if you prefer "Commissaire priseur Latarge" it's up to you.

No mail is created when auction is over.

Iam trying to make the minimal hack on mangos core to avoid any bad side effect...

Let me just finish the code and make a minimal test.

[xeross155]

I haven't tested my new build yet so I'm not going to push it just yet, should be done testing in a few days.

[thyphoon]

It is too bad there isnt a second thanks button in the board

[PaLL3]

@typhoon: Strange, i pulled the xeross branch but still couldnt compile the SD2...

Keep getting errors...

*EDIT*

No wonder...

Its still on version 9849... doh..

[cyberium]

Here is my version of the AHBot patch for 10337

Or Git if you prefer, git://github.com/cyberium/mangos.git ahbot

Purpose :

- No more account needed to be created for AHBot

- Cleaned not used code.

- Add some method to avoid some hack to the core.

- Add possibility to assign any npc name as seller by simply add DB entry number on mangosd.conf file.

I have some idea to optimise the add auction process but i need more time to implement and test.

Feedback are welcome.

[thyphoon]

I will compile and test ASAP

[DaViper]

Thank you cyberium, now some questions as to config's...NPC used

1) Does it have to be nuetral with all 3 factions?

2) can you create a custom NPC just for use with ahbot?

3) can you give some extra documentaion on configuring your version?

[Unkle Nuke]

Also, why not include the NPC database entry as part of the patch? This would eliminate the need to choose one and simplify configuration.

[cyberium]

DaViper:

1) The patch take only name of npc you want. So no matter the faction of that npc.

2) Yes, has i say all npc in database can be used. (i think)

3) There is no raison, the patch make more simple the use of AHBOT, Just patch it and enable it. The npc option is only an "option" and a brief description is on conf file.

UnkleNuke

I didn't understaind what you want? Ahbot doesn't need the npc to run, but if you want one (for ex add your npc with some script in one map) you can simply do it with Entry of that NPC.

Get these entry it's not difficult, make .npc info in game or look at the table creature or locale_creature.

Sorry if iam not clear but i need more practice of english

[Unkle Nuke]

I am asking about this:

Add possibility to assign any npc name as seller by simply add DB entry number on mangosd.conf file.

After reviewing the code more, it seems you are saying only the name is needed and you do not use the full NPC as the bot.

You have brought AHBot a giant leap forward with this code! This makes you a hero in my book.

[DaViper]

Here's the next complaint report.....IT WORKS GREAT!...now the complaint....Dev's need to put this in the core yesterday so se can move on to more important mods to complain about!...lol

[DaemonCantor]

This new patch works pretty good congrats for getting this worked out!

[DaemonCantor]

Works Really good, Thanks!

Sorry about the Double post, Firefox Goofed...again...

[DaViper]

Get your computer fixed you do the same thing on our forum....

[VladimirMangos]

I at this moment can only say (not check real sources) that if fake player class usage remove then i have lot less resistance against adding ahbot to core. Ofc, for real comments i need look sources at some moment...

[xeross155]

I would like to see this code, sounds interesting.

[cyberium]

Thank for your support, i think the code still need some cleanning and iam actualy doing some of these.

Iam olso make a reflexion to the first loop of addauction. Retrieving all item in auctionneer to get overal quantity of all defined quality can probably avoided at least in most of the case. Make this once a day is probably enought.

ItemID generation loop olso probably can be lighted but no idea for now.

Git updated. And here is the cleaned patch for 10342.

[Cobra101]

I -think- I understand what Vlad means and I have to say how happy I am he's consider(ed/ing) this. After all, it's a simple matter of a config option if someone wants it on or not.

Being part of the real core although not retail like, which is what we're striving for, would be such a great addition. I really hope we can sort it out.

P.S. thanks for the new patch cyberium, I hate doin this by hand. lol

[Cobra101]

Hate to post under myself, but I didn't want my new post to get lost in text. I have a problem with this. At first I thought it was something I had done, because everytime I would load into the server;

the load bar would fill and I'd get spammed on the console with almost a thousand lines of problems. All pertaining to different parts of the code. Some from collision.cpp sometimes others.

This last time I only had the patch from cyberium and was running of a clean build. Here's a pic of the spamming I'd get. It was the same on all 3 of my last attempts.