[PATCH] AuctionHouse Bot

[mrelfire]

You take his. ALL mine is, is a filebeam upload of the auctionhouse.cpp and auctionhouse.h files. So use his as you normally would then just extract my fixes to the correct folder. If you already have Xeross's Repo just extract mine into the Src/Game/ Folder So it overwrites his files.

Sorry im used to SVN and not git so im not sure how to create a patch atm...

BTW Tested and confirmed working with a fresh compilation of mangos rev 9672

No problems, I have tryed Xeross155's files and it is working. Yours change something else?

[xeross155]

Kreegoth if you fixed it I'm interested in what you changed so I could perhaps add it to my branch.

[deviljohn]

Hello there Kanzaki

SQL: SELECT guid, data,

The data blob was removed from characters.characters. So you will need to update that SQL statement to reflect the new format for that operation.

Just browse the characters field and you will see how its laid out now. Good luck.

[xeross155]

Hello there Kanzaki

SQL: SELECT guid, data,

The data blob was removed from characters.characters. So you will need to update that SQL statement to reflect the new format for that operation.

Just browse the characters field and you will see how its laid out now. Good luck.

My branch doesn't even use a query anymore when creating auctions, appears it isn't needed to get info from the database to create an auction.

[deviljohn]

My branch doesn't even use a query anymore when creating auctions, appears it isn't needed to get info from the database to create an auction.

Excellent work. Thats a step in the right direction.

[xeross155]

Excellent work. Thats a step in the right direction.

Yep, now we just need to make it work for other people, I suspect something is messing their core up that causes certain parts of the branch to not get applied or something

[kreegoth]

I simply re-added a few lines at the beginning of Auctionhouse.cpp For Ahbotseller and such and added the Bools to Auctionhouse.h Xeross.. before doing that i had no items in auctionhouse after doing it i did.. its very easy to check the additions just check above the configs for faction at the start of auctionhouse.cpp and above the initialize parts at the bottom of Auctionhouse.h

Can anyone else who had no items in their Ahbot confirm that using these files fixed the problem?

[xeross155]

I simply re-added a few lines at the beginning of Auctionhouse.cpp For Ahbotseller and such and added the Bools to Auctionhouse.h Xeross.. before doing that i had no items in auctionhouse after doing it i did.. its very easy to check the additions just check above the configs for faction at the start of auctionhouse.cpp and above the initialize parts at the bottom of Auctionhouse.h

Can anyone else who had no items in their Ahbot confirm that using these files fixed the problem?

Those files don't change anything you just added in a few useless variables that aren't even used anymore

[kundawow]

I just grabbed Kreegoth's two files, re-compiled, re-started the server and now my AH has items. I didn't do anything else.

Many thanks Kreegoth. No idea what you did, but hey, it worked

Hopefully xeross155 can figure out the how's and why's of it all.

[kreegoth]

well if that is true why does it work when i add them and not when they aren't there? I may have changed something else LOL but ill have to look it over later to make 100% sure as i did about 20-30 different compiles with different changes.. All i know at the moment with my files it worked.

[xeross155]

well if that is true why does it work when i add them and not when they aren't there? I may have changed something else LOL but ill have to look it over later to make 100% sure as i did about 20-30 different compiles with different changes.. All i know at the moment with my files it worked.

Well these changes can't be it, all you did was create some definitions for variables that I have moved, so I suspect you must've changed something else, weird indeed.

Once again can someone zip and upload their non-working GIT repository so I can check what's going wrong.

[Unkle Nuke]

I don't know if anyone has said this yet but, you have my sincere gratitude for taking up the gauntlet and trying to fix AHBot as well as improve the code base, xeross.

Your work, and the other collaborators working with you, is deeply appreciated.

This long-time AHBot fan thanks you from the bottom of his heart.

[xeross155]

I don't know if anyone has said this yet but, you have my sincere gratitude for taking up the gauntlet and trying to fix AHBot as well as improve the code base, xeross.

Your work, and the other collaborators working with you, is deeply appreciated.

This long-time AHBot fan thanks you from the bottom of his heart.

Thanks , now we just need to get rid of this pesky weird bug.

[tortosi]

I have conflicts with de vehicles of Tasssadar. It's more important 2 patches for my server.

Thanks

[xeross155]

You have to solve that yourself, install a program that supports 3 way merges like beyond compare 3 and set it up to work with git.

Regards, Xeross

[mfour]

Once again can someone zip and upload their non-working GIT repository so I can check what's going wrong.

I'll try and get something for you this evening, or by tomorrow morning (on GMT+2 time).

[tortosi]

I don't speak english, and for search manuals to do it, i have very problems. I dont know visual. me am not able to do that

[mrelfire]

The auction house is broken with the latest mangos core

[kreegoth]

Broken how? and using my files or just xeross's?

[temporary]

It works with "UDB_0.12.0_mangos_9582_SD2_1639.sql" altough with 9600+, it doesn't anymore.... problem finding the character i think....

So they are working on this trying to fix it ....

[kreegoth]

Version i posted that has additions to Xeross's works with 9764 tested and confirmed.

[kundawow]

Mine is 9661 with Kreegoth's two files and works perfectly, so your statement is incorrect temporary.

[xeross155]

If kreegoth's works, mine should work as well. Kreegoth can you create a diff between your branch and my branch ?

[kreegoth]

LOL not really I suck at Git.. just came to mangos from arc some months ago.. Ill have to look into how to do that. Give me a bit and ill see what i can do.

[mfour]

Using Xeross's repo (9652) it works for me only when using Kreegoth's two files. I used Winmerge to find what is different between the two sets, and besides spaces, the only text/code that was in Kreegoth's AuctionHouseBot.h file and not in Xeross's, was the following:

         Kreegoth's                 Xeross's
      bool AHBSeller;            
      bool AHBBuyer;            
      bool BuyMethod;            
      bool SellMethod;            

      bool debug_Out;            bool debug_Out;

      bool Vendor_Items;            
      bool Loot_Items;            
      bool Other_Items;            

      bool No_Bind;            
      bool Bind_When_Picked_Up;            
      bool Bind_When_Equipped;            
      bool Bind_When_Use;            
      bool Bind_Quest_Item;  

That bit is right at the end of the file, which must be the bit making the difference?