[PATCH] AuctionHouse Bot

[mrelfire]

Use git mergetool and resolve your conflicts with the default merge utility or use your favorite, once you configure Git to use it as the default.

I can do it manually but is not fun

and second I still have nothing into the AH, so it is weird

[kich0]

confirm its loads normally on console but ingame theres nothing in AH...

[Unkle Nuke]

Maybe he's holding out for better wages?

"Power to the workers! Managment is teh sux!"

... or something to that effect is keeping AHBot on strike.

[kreegoth]

For those that have nothing in the auctionhouse.. Did you take the two files out of my .rar i loaded and extract them into the source/game folder?

[xeross155]

confirm its loads normally on console but ingame theres nothing in AH...

I am totally clueless to why it is working for me but not for others, I'll try creating an isolated test environment, this is just weird

[mrelfire]

For those that have nothing in the auctionhouse.. Did you take the two files out of my .rar i loaded and extract them into the source/game folder?

Yes I did

and

========AuctionHouseBot========

loaded 9 grey trade goods

loaded 566 white trade goods

loaded 89 green trade goods

loaded 31 blue trade goods

loaded 3 purple trade goods

loaded 1 orange trade goods

loaded 0 yellow trade goods

loaded 1300 grey items

loaded 2891 white items

loaded 5499 green items

loaded 1739 blue items

loaded 788 purple items

loaded 0 orange items

loaded 1 yellow items

AuctionHouseBot> [AHBot-x001] is now loaded

AuctionHouseBot> updated by Xeross (Original by Naicisum, ChrisK, Paradox)

AuctionHouseBot> Includes AHBuyer by Kerbe and Paradox

WORLD: World initialized

SERVER STARTUP TIME: 0 minutes 50 seconds

but nothing inside the auction house.

is it link to a problem link to the insert goods inside the AH ?

[vladex]

yea i've got the same items numbers and no items exsisting in the AH

[mrelfire]

I am totally clueless to why it is working for me but not for others, I'll try creating an isolated test environment, this is just weird

Do you follow these steps:

- use mangos core as the baseline (git.exe clone git://github.com/mangos/mangos.git %local_git_ahbot%)

- patch you redepository above this baseline (git.exe pull git://github.com/xeross/mangos.git ahbot)

[kreegoth]

This is what i have done...

- use mangos core as the baseline (git.exe clone git://github.com/mangos/mangos.git %local_git_ahbot%)

- patch you redepository above this baseline (git.exe pull git://github.com/xeross/mangos.git ahbot)

-Edit Merge issues

as Mrelfire says Then extracted my Auctionhouse.cpp and auctionhouse.h into the game folder and compile..

Items are in my auctionhouse

[mrelfire]

This is what i have done...

- use mangos core as the baseline (git.exe clone git://github.com/mangos/mangos.git %local_git_ahbot%)

- patch you redepository above this baseline (git.exe pull git://github.com/xeross/mangos.git ahbot)

-Edit Merge issues

as Mrelfire says Then extracted my Auctionhouse.cpp and auctionhouse.h into the game folder and compile..

Items are in my auctionhouse

so the only difference left are the sql table (can you extract it please in sql format so we can try to insert it "like yours")

and the config files (can you share yours ?)

when you resolve the conflict : do you add things ? do you just remove the "<<<" ?

is your auction house owner has something specific (level , race,... ?)

P.S.

I have 2 different configs in my auctionhousebot table (I have 2 servers) but I end up in the same loading

of items which is stranged

[xeross155]

Seems there's some kind of weird condition needed for the items to appear in the auction house, though I have no idea what it could be.

[gigelf]

Have also something strange.

In config file I asked for 20000 items. They are loaded in database but nothing at the auctionhouse (in Stormwind).

I then checked database, I saw that the auctioneerguid where the auction items were added is the 23442. I spawned to him (he is in Gadgetzan) and I saw that he has 4000 of them. Still missing 16000 and I don't know why they don't show in Stormwind.

I just checked again in Gadgetzan, now there are only 3192 there and still 20000 in DB.

[mrelfire]

Seems there's some kind of weird condition needed for the items to appear in the auction house, though I have no idea what it could be.

More than that, because the "buyer" dosen't work also

[xeross155]

Weird they both work fine for me, I'll try creating a new transparent testing setup with a fresh install.

[Skirnir]

Read gigelfs comment, searched through the code. Quickly ... ~1 minute:

// Added by AHBot, Unknown use (Commented)
   /*if(sWorld.getConfig(CONFIG_ALLOW_TWO_SIDE_INTERACTION_AUCTION))
       AH->auctioneer = 23442;
   else
       AH->auctioneer = GUID_LOPART(auctioneer);*/

You commented a line you didn't understand. That was (a) a bad idea and (b) causes at least gigelfs trouble, don't know about the others, stopped following this thread. That's why I don't know if uncommenting will solve all your problems. Haven't checked the rest of your branch, as I still use the old Naicisum branch with MinimalLoad modification by chucky.black.

Skirnir

[Unkle Nuke]

It has always been my understanding that those lines were for two-sided Auction House functionality on those servers where two-sided is not allowed, as per the two-sided settings in mangosd.conf, such as Horde characters bidding on Alliance items and then receiving their item by mail from the AHBot.

Without the code segment listed above, the AHBot would not function properly for two-sided interaction since it must be a character of one faction or the other and could not interact with characters of the opposing faction, unless two-side interaction is generally enabled on the server.

Yet another reason why it would be best if AHBot/Buyer could be a neutral NPC instead.

I believe Naicisum eventually intended on fixing that code because two-sided functionality is partially broken in AHBot, which is why the Buyer only works with Neutral Auction Houses.

[mrelfire]

Weird they both work fine for me, I'll try creating a new transparent testing setup with a fresh install.

Please can you provide your full patch file with you sql tables ?

[mrelfire]

Read gigelfs comment, searched through the code. Quickly ... ~1 minute:

// Added by AHBot, Unknown use (Commented)
   /*if(sWorld.getConfig(CONFIG_ALLOW_TWO_SIDE_INTERACTION_AUCTION))
       AH->auctioneer = 23442;
   else
       AH->auctioneer = GUID_LOPART(auctioneer);*/

You commented a line you didn't understand. That was (a) a bad idea and (b) causes at least gigelfs trouble, don't know about the others, stopped following this thread. That's why I don't know if uncommenting will solve all your problems. Haven't checked the rest of your branch, as I still use the old Naicisum branch with MinimalLoad modification by chucky.black.

Skirnir

I do not manage to solve the conflict problems with the old Naicisum branch, can you share your results please ?

[gigelf]

Ok, finally it doesn't work at all.

I copied db from my production server to my test server, that's why I had 20000 items in db and only 4000 then 3000 in game (expired items).

Config file was wrong, i kept old one:

Old:

AuctionHouseBot.EnableSeller = 1

AuctionHouseBot.EnableBuyer = 0

AuctionHouseBot.Account = 5

AuctionHouseBot.GUID = 4511

AuctionHouseBot.VendorItems = 0

AuctionHouseBot.LootItems = 1

AuctionHouseBot.OtherItems = 0

AuctionHouseBot.No_Bind = 1

AuctionHouseBot.Bind_When_Picked_Up = 0

AuctionHouseBot.Bind_When_Equipped = 1

AuctionHouseBot.Bind_When_Use = 1

AuctionHouseBot.Bind_Quest_Item = 0

AuctionHouseBot.ItemsPerCycle = 200

AuctionHouseBot.UseBuyPriceForSeller = 0

AuctionHouseBot.UseBuyPriceForBuyer = 0

New:

AuctionHouseBot.Seller.Enabled = 1

AuctionHouseBot.Buyer.Enabled = 0

AuctionHouseBot.Account = 5

AuctionHouseBot.Character = 4511

AuctionHouseBot.Items.Vendor = 0

AuctionHouseBot.Items.Loot = 1

AuctionHouseBot.Items.Misc = 0

AuctionHouseBot.Bind.No = 1

AuctionHouseBot.Bind.Pickup = 0

AuctionHouseBot.Bind.Equip = 1

AuctionHouseBot.Bind.Use = 1

AuctionHouseBot.Bind.Quest = 0

AuctionHouseBot.ItemsPerCycle = 200

AuctionHouseBot.BuyPrice.Seller = 0

AuctionHouseBot.BuyPrice.Buyer = 0

I activated debug mode with:

AuctionHouseBot.DEBUG = 1

Game loads config from DB but nothing happens. auctionhouse table is empty.

Output log:

09:58:09 Initialize AuctionHouseBot...

minItems = 20000

maxItems = 20000

minTime = 8

maxTime = 24

percentGreyTradeGoods = 0

percentWhiteTradeGoods = 27

percentGreenTradeGoods = 12

percentBlueTradeGoods = 10

percentPurpleTradeGoods = 1

percentOrangeTradeGoods = 0

percentYellowTradeGoods = 0

percentGreyItems = 0

percentWhiteItems = 10

percentGreenItems = 30

percentBlueItems = 8

percentPurpleItems = 2

percentOrangeItems = 0

percentYellowItems = 0

minPriceGrey = 100

maxPriceGrey = 150

minPriceWhite = 150

maxPriceWhite = 250

minPriceGreen = 800

maxPriceGreen = 1400

minPriceBlue = 1250

maxPriceBlue = 1750

minPricePurple = 2250

maxPricePurple = 4550

minPriceOrange = 3250

maxPriceOrange = 5550

minPriceYellow = 5250

maxPriceYellow = 6550

minBidPriceGrey = 70

maxBidPriceGrey = 100

minBidPriceWhite = 70

maxBidPriceWhite = 100

minBidPriceGreen = 80

maxBidPriceGreen = 100

minBidPriceBlue = 75

maxBidPriceBlue = 75

minBidPricePurple = 80

maxBidPricePurple = 100

minBidPriceOrange = 80

maxBidPriceOrange = 100

minBidPriceYellow = 80

maxBidPriceYellow = 100

maxStackGrey = 0

maxStackWhite = 0

maxStackGreen = 3

maxStackBlue = 2

maxStackPurple = 1

maxStackOrange = 1

maxStackYellow = 1

09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 09:58:09 ========AuctionHouseBot========

09:58:09 loaded 5 grey trade goods

09:58:09 loaded 256 white trade goods

09:58:09 loaded 28 green trade goods

09:58:09 loaded 8 blue trade goods

09:58:09 loaded 2 purple trade goods

09:58:09 loaded 0 orange trade goods

09:58:09 loaded 0 yellow trade goods

09:58:09 loaded 1004 grey items

09:58:09 loaded 533 white items

09:58:09 loaded 3047 green items

09:58:09 loaded 907 blue items

09:58:09 loaded 89 purple items

09:58:09 loaded 0 orange items

09:58:09 loaded 0 yellow items

09:58:09 AuctionHouseBot> [AHBot-x001] is now loaded

09:58:09 AuctionHouseBot> updated by Xeross (Original by Naicisum, ChrisK, Paradox)

09:58:09 AuctionHouseBot> Includes AHBuyer by Kerbe and Paradox

09:58:09 WORLD: World initialized

I don't understand why nothing appears

[xeross155]

Unfortunately we don't understand it either, but I hope we can figure it out.

[kreegoth]

MY sql data and Configs are straight from Xeross's post from before that that shouldnt be it. I have interfaction enabled in Configs.. if that makes a difference.. Also i am using a Gadgetzan Auctioneer to test.. ill test Stormwind and Org later.

The line you omitted Xeross can be reimplemented easily by re-adding the Bool to the front of it. The line Gig was talking about.

[jsee]

The

ItemsPerCycle

variable never gets initalized from config.

diff --git a/src/game/AuctionHouseBot.cpp b/src/game/AuctionHouseBot.cpp
index b4a60d2..26ff572 100644
--- a/src/game/AuctionHouseBot.cpp
+++ b/src/game/AuctionHouseBot.cpp
@@ -874,6 +874,8 @@ void AuctionHouseBot::Initialize()
{
    debug_Out = sConfig.GetIntDefault("AuctionHouseBot.DEBUG", 0);

+    ItemsPerCycle = sWorld.getConfig(CONFIG_UINT32_AHBOT_ITEMS_CYCLE);
+
    if (!sWorld.getConfig(CONFIG_BOOL_ALLOW_TWO_SIDE_INTERACTION_AUCTION))
    {
        LoadValues(&AllianceConfig);

[mrelfire]

The variable never gets initalized from config.

Code diff:

diff --git a/src/game/AuctionHouseBot.cpp b/src/game/AuctionHouseBot.cpp

index b4a60d2..26ff572 100644

--- a/src/game/AuctionHouseBot.cpp

+++ b/src/game/AuctionHouseBot.cpp

@@ -874,6 +874,8 @@ void AuctionHouseBot::Initialize()

{

debug_Out = sConfig.GetIntDefault("AuctionHouseBot.DEBUG", 0);

+ ItemsPerCycle = sWorld.getConfig(CONFIG_UINT32_AHBOT_ITEMS_CYCLE);

+

if (!sWorld.getConfig(CONFIG_BOOL_ALLOW_TWO_SIDE_INTERACTION_AUCTION))

{

LoadValues(&AllianceConfig);

This is it !!!! it works ! Thanks !

[Unkle Nuke]

<INSERT EPIC CHEER HERE>

Now that jsee's eagle eye and razor-sharp mind has uncovered and, hopefully, fixed the issue with items appearing in the Auction Houses, can we get a roll-up of all the various fixes scattered over the last few pages for testing? I'm getting a little lost here with which code belongs and what has been discarded or superceded.

[temporary]

Please a "Patch" file

I know you like us to clone a repositry but this mean you need to keep your repository updated with the mangos repository .... i would prefer a patch file that i can add

Thanks