[patch][8735] Intel Memory Allocator

[VladimirMangos]

ObjectMgr::GenerateLowGuid - cleary outdated patch that not support recent move vehicle guid per map generation.

[Stillhard]

ObjectMgr::GenerateLowGuid - cleary outdated patch that not support recent move vehicle guid per map generation.

Yes Vlad, you're correct and some fixes already made in getmangos.ru before they went down but it just need some improvement and little tweak to make it work with the patch you've mentioned.

[Grz3s]

just 2 say thank you.

on win xp ... have no problems at all with compile and u can see that it works!

We are waiting fo' yours next patches

regards

[The_Game_Master]

Can't compile on the latest version. 8754.

1>------ Build started: Project: tbb, Configuration: Release Win32 ------
1>Assembling...
1>'ml.exe' is not recognized as an internal or external command,
1>operable program or batch file.
1>Project : error PRJ0019: A tool returned an error code from "Assembling..."
1>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\tbb__Win32_Release\\BuildLog.htm"
1>tbb - 1 error(s), 0 warning(s)
2>------ Build started: Project: tbbmalloc, Configuration: Release Win32 ------
2>Assembling...
2>'ml.exe' is not recognized as an internal or external command,
2>operable program or batch file.
2>Project : error PRJ0019: A tool returned an error code from "Assembling..."
2>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\tbbmalloc__Win32_Release\\BuildLog.htm"
2>tbbmalloc - 1 error(s), 0 warning(s)
3>------ Build started: Project: shared, Configuration: Release Win32 ------
3>Extract revision
3>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\shared__Win32_Release\\BuildLog.htm"
3>shared - 0 error(s), 0 warning(s)
4>------ Build started: Project: realmd, Configuration: Release Win32 ------
4>Linking...
4>LINK : fatal error LNK1181: cannot open input file '..\\..\\dep\\lib\\win32_release\\tbbmalloc.lib'
4>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\realmd__Win32_Release\\BuildLog.htm"
4>realmd - 1 error(s), 0 warning(s)
5>------ Build started: Project: mangosd, Configuration: Release Win32 ------
5>Linking...
5>LINK : fatal error LNK1181: cannot open input file '..\\..\\dep\\lib\\win32_release\\tbbmalloc.lib'
5>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\mangosd__Win32_Release\\BuildLog.htm"
5>mangosd - 1 error(s), 0 warning(s)
6>------ Build started: Project: script, Configuration: Release Win32 ------
6>Linking...
6>LINK : fatal error LNK1181: cannot open input file 'mangosd.lib'
6>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\script__Win32_Release\\BuildLog.htm"
6>script - 1 error(s), 0 warning(s)
========== Build: 1 succeeded, 5 failed, 7 up-to-date, 0 skipped ==========

Where the heck did i go wrong?

[herrtrigger]

Can't compile on the latest version. 8754.

1>------ Build started: Project: tbb, Configuration: Release Win32 ------
1>Assembling...
1>'ml.exe' is not recognized as an internal or external command,
1>operable program or batch file.
1>Project : error PRJ0019: A tool returned an error code from "Assembling..."
1>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\tbb__Win32_Release\\BuildLog.htm"
1>tbb - 1 error(s), 0 warning(s)
2>------ Build started: Project: tbbmalloc, Configuration: Release Win32 ------
2>Assembling...
2>'ml.exe' is not recognized as an internal or external command,
2>operable program or batch file.
2>Project : error PRJ0019: A tool returned an error code from "Assembling..."
2>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\tbbmalloc__Win32_Release\\BuildLog.htm"
2>tbbmalloc - 1 error(s), 0 warning(s)
3>------ Build started: Project: shared, Configuration: Release Win32 ------
3>Extract revision
3>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\shared__Win32_Release\\BuildLog.htm"
3>shared - 0 error(s), 0 warning(s)
4>------ Build started: Project: realmd, Configuration: Release Win32 ------
4>Linking...
4>LINK : fatal error LNK1181: cannot open input file '..\\..\\dep\\lib\\win32_release\\tbbmalloc.lib'
4>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\realmd__Win32_Release\\BuildLog.htm"
4>realmd - 1 error(s), 0 warning(s)
5>------ Build started: Project: mangosd, Configuration: Release Win32 ------
5>Linking...
5>LINK : fatal error LNK1181: cannot open input file '..\\..\\dep\\lib\\win32_release\\tbbmalloc.lib'
5>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\mangosd__Win32_Release\\BuildLog.htm"
5>mangosd - 1 error(s), 0 warning(s)
6>------ Build started: Project: script, Configuration: Release Win32 ------
6>Linking...
6>LINK : fatal error LNK1181: cannot open input file 'mangosd.lib'
6>Build log was saved at "file://f:\\games\\World_of_Warcraft_LAN\\mangos_origin\\win\\VC90\\script__Win32_Release\\BuildLog.htm"
6>script - 1 error(s), 0 warning(s)
========== Build: 1 succeeded, 5 failed, 7 up-to-date, 0 skipped ==========

Where the heck did i go wrong?

8745 compiled fine here, winxp 32bit, release.

[DasBlub]

@The_Game_Master and every one else who's using visual studio:

for TBB you need to have 'ml.exe' which is part from MASM32. The problem: you can't take the 'normal' masm32, you need to have MASM32 9.0 which is shipped with visual studio 2008 SP1.

everyone who's using the 'express' edition without the SP1 will have to uninstall it and then re-install the new version with SP1 because there's no SP1 patch for the 'express' edition. the SP1 as update exists only for the other versions of VS08 (e.g. professional).

-- DasBlub

[henhouse]

Backport to 0.12 will come soon. Expect *nix TBB support to come first since dealing with Windows vcproj files isn't funny

Awesome! Really looking forward to seeing this in action. Great work!

[Ambal]

Everybody experiencing not-found libraries by mangos executables - check this patch, suggested by ApoC: http://www.pastebin.ca/1645235

[Ambal]

Intel Threading Building Blocks memory allocator is implemented in 0.12 branch

[Khira]

Hi, how can I disable this patch ? Before this patch, my serv reboots in 5 seconds, now, it reboots in 2min.

[DasBlub]

Hi, how can I disable this patch ? Before this patch, my serv reboots in 5 seconds, now, it reboots in 2min.

And yes, if USE_STANDARD_MALLOC is defined, there is no need in them in mangos folder... Atleast for now since we are going to base all threading code on Intel TBB library in nearest future

<10 characters>

[NetSky]

you can add #define USE_STANDARD_MALLOC in memorymanagement

[Khira]

Thanks guys.

[bulek]

Hi, how can I disable this patch ? Before this patch, my serv reboots in 5 seconds, now, it reboots in 2min.

confiiirm

[Ambal]

Hi, how can I disable this patch ? Before this patch, my serv reboots in 5 seconds, now, it reboots in 2min.

What do you mean 'server reboots in 2 mins'? :confused: Your OS type, please.

[Khira]

Hi, it is ubuntu server 9.1 and with this patch, my server is very long to reboot after a crash (it is the same time when i run the server for the first time.)

[Ambal]

Hi, it is ubuntu server 9.1 and with this patch, my server is very long to reboot after a crash (it is the same time when i run the server for the first time.)

Do you mean server startup takes too long now? Also, please, provide your OS info and check if you do not use DEBUG build...

[NetSky]

seems due to new allocator whole mem for data needs to be reallocated instead of just linking already allocated memory

[Ambal]

seems due to new allocator whole mem for data needs to be reallocated instead of just linking already allocated memory

Erm, I don't understand what are your trying to say :huh::confused:

[henhouse]

Compiling with 0.12 I get several errors. I've cleaned the project and tried twice already.

These are the collected errors:

Errors at tbb and tbbmalloc projects:

'ml.exe' is not recognized as an internal or external command,

This is in the framework project:

MemoryManagement.cpp

..\\..\\src\\framework\\Policies\\MemoryManagement.cpp(25) : warning C4290: C++ exception specification ignored except to indicate a function is not __declspec(nothrow)

..\\..\\src\\framework\\Policies\\MemoryManagement.cpp(32) : warning C4290: C++ exception specification ignored except to indicate a function is not __declspec(nothrow)

This errors at both realmd and mangosd project builds:

Compiling resources...

Linking...

LINK : fatal error LNK1181: cannot open input file '..\\..\\dep\\lib\\win32_release\\tbbmalloc.lib'

Errors at end of "script" project compile:

Linking...

LINK : fatal error LNK1181: cannot open input file 'mangosd.lib'

[VladimirMangos]

If you read thread then you find sollution. No see reason repeat it each thread page.

[silviu2009]

I've compiled MaNGOS on WinXP and VS 2008 Pro edition. Everything went fine, tbb.dll and tbbmalloc.dll were both in my bin folder after compiling. I just want to know, why realmd and mangosd works without these dlls (i moved them in another folder, to check if the server starts without them. Looks like i don't get any "tbb.dll" or "tbbmalloc.dll" not found)..? Is it OK? Do i have to do something in order to compile with TBB support? If i move ace.dll for example, or any other dll from my mangos server, i get an error (dll missing). Can someone help me with this "stupid" question afterall:)?

PS: I did NOT add,comment, or uncomment any STANDARD_MALLOC thingies...i've just compiled as always.

[Ambal]

I just want to know, why realmd and mangosd works without these dlls (i moved them in another folder, to check if the server starts without them.

It seems that you already have TBB libraries installed in your system as separate install from Intel. Thats why mangosd and realmd work w/o tbb.dll\\tbbmalloc.dll in your mangos folder. BUT: it is better to have these dlls inside your mangos folder since these are the latest versions of Intel TBB libraries!!!

Check whether you have \\Program Files\\Intel\\TBB\\2.1(or 2.2)\\ directories on your PC

[silviu2009]

I did not have anything related to TBB in Program Files, but somehow i had tbb.dll, tbb_debug.dll, tbbmalloc_proxy.dll and like 4 other dlls regarding TBB in my Windows/System32 folder. I deleted them, and now everything works as expected. Thanks a lot!

[Ambal]

I did not have anything related to TBB in Program Files, but somehow i had tbb.dll, tbb_debug.dll, tbbmalloc_proxy.dll and like 4 other dlls regarding TBB in my Windows/System32 folder. I deleted them, and now everything works as expected. Thanks a lot!

I suggest you to restore these dlls in Windows/System32 folder! We don't know the reason why they were put in there so it is better to have them rather than get malfunctioning software