Vehicles (Dev)

[vladex]

Hmm maybie we should look at void PetAI::UpdateAllies() in PetAI.cpp its explaining what happens when the pet gets in a group.We might as well try with warlock and deathknight classes.

[Numnut]

Tort you are getting the same crash as me and you said you weren't

Last 4 days i have been playing around with a few lines to prevent the server from crashing but so far no luck.

[tortosterone]

i'm not getting those crashes anymore, at least i cant reproduce it. It just happened once after testing tasssadar's latest push. I checked your error log after it happened and noted SpellAuras.cpp:2937. i moved default: break; so they were on the same line and now cant reproduce the crash, though i doubt that really did anything...

[Dernise]

Multi seat mounts don't work ? It's normal ? We need an Update !

[traponinet]

from Wojta's repository:

http://filebeam.com/e7d9c70f745b7e5308e0bbf454f2e6a3 vehicle patch for MaNGOS rev. [10326]

[Unkle Nuke]

ankso, vehicles are treated as pets. That's why you owe your confusion to thinking the crash originated with pets.

Something in the Vehicle code is messing up pets.

[vladex]

There is something related to pets in group in vehicles.cpp Vehicle::BuildVehicleActionBar and Vehicle::RemovePassenger ,i belive that when the master of the pet is invited into a party ,it tryes to build a ActionBar for the Pet vehicle with all party members controlling it ,or probably needs more world packet data.

[marx123]

hmm i get error on (vehicle + multiseat_mounts):

error:Patch failed src/game/level3.cpp:74

error:src/game/level3.cpp patch does not apply

can anyone help me out what i have to change thanks:D

[marx123]

tryd to fix it but changing

HandleReloadReservedNameCommand("");

HandleReloadMangosStringCommand("");

HandleReloadGameTeleCommand("");

in patch to

HandleReloadCommandCommand((char*)"");

HandleReloadReservedNameCommand((char*)"");

HandleReloadMangosStringCommand((char*)"");

HandleReloadGameTeleCommand((char*)"");

this didint do anything

can anyone help me out?

[traponinet]

tryd to fix it but changing ... in patch to ...

can anyone help me out?

Try to make changes directly to the source code.

[ankso]

The problem with groups and pets stills present?

[alexluana]

hey Wojta,

isn't there o posibility to split your patch in more pieces so it can go on the master branch?

with respect,

Axel

[traponinet]

merger Wojta's vehicle_patch and zergtmn's multiseat_mounts

Note:

(multiseat_mounts patch is rewritten by Glaciusane to be compatible with Wojta's vehicle_patch)

vehicle+mount_patch_mangos_10342.zip

http://filebeam.com/cc66d8ea96cfa69fd67edd967dca7acf

Edit:

Fix for unifieddb only! to make the vehicle in Ulduar works:

DELETE FROM creature_addon WHERE guid IN (SELECT guid FROM creature WHERE id IN (33060,33062,33109));

[DaViper]

Thank you traponinet, it compiled great and now I'm testing...It's allways good to see your on top of things with these patches because it allows me not to take soooo many asprins for the headakes...and less denting of my desk!

[ankso]

fixed bug with Salvaged Chopper and now,

if a driver moves to the passenger's seat, he can return to drive again.

and if the driver went down, then the passenger can move to the driver's seat and drive the motorbike.

Traponinet, could you post the changes in code for fix this bugs? I'm using my custom git branch and revert/reapply all the patch it's not very suitable for me ^^

Thx

[traponinet]

Fix for Salvaged Chopper, if you want the player to stand nearby when get out from motorbike.

UPDATE creature_model_info SET bounding_radius = '0.306' WHERE modelid IN (25870,25871);

[Atømic]

Hello Traponinet,

Have you the destructible building (type 33) ?

[traponinet]

sorry @Atømic but I have not this patch, because Rage Hunter stopped developing it

but as I remember Ankso was interested from patch (GO type 33) and You can ask him.

[DaViper]

@Atømic Look in http://github.com/Tasssadar/Valhalla-Project/tree/SotA for it....

[Atømic]

Tank's for reply.

@DaViper : Yes have looking, maybe no testing because DBCStructure change with : http://github.com/mangos/mangos/commit/4351c20a54660c77cc63ff8d91d514b10c438c88.

[marx123]

hehe weird to ask but can anyone update it to latest mangos...thanks

[meniacle]

I am using mangos 10382

Tried to apply the patches given by Wojta, but got this error for the:

multiseats_mounts.patch

$ git apply multiseat_mounts.patch

error: patch failed: src/game/AggressorAI.cpp:103

error: src/game/AggressorAI.cpp: patch does not apply

error: patch failed: src/game/Creature.h:409

error: src/game/Creature.h: patch does not apply

error: patch failed: src/game/DBCStructure.h:1780

error: src/game/DBCStructure.h: patch does not apply

error: patch failed: src/game/MiscHandler.cpp:269

error: src/game/MiscHandler.cpp: patch does not apply

error: patch failed: src/game/MovementHandler.cpp:248

error: src/game/MovementHandler.cpp: patch does not apply

error: patch failed: src/game/Object.cpp:289

error: src/game/Object.cpp: patch does not apply

error: patch failed: src/game/Opcodes.cpp:1169

error: src/game/Opcodes.cpp: patch does not apply

error: patch failed: src/game/Player.cpp:1754

error: src/game/Player.cpp: patch does not apply

error: patch failed: src/game/Spell.cpp:4541

error: src/game/Spell.cpp: patch does not apply

error: patch failed: src/game/SpellAuras.cpp:3413

error: src/game/SpellAuras.cpp: patch does not apply

error: patch failed: src/game/SpellHandler.cpp:577

error: src/game/SpellHandler.cpp: patch does not apply

error: patch failed: src/game/Unit.cpp:245

error: src/game/Unit.cpp: patch does not apply

error: patch failed: src/game/Unit.h:304

error: src/game/Unit.h: patch does not apply

error: patch failed: src/game/Vehicle.cpp:22

error: src/game/Vehicle.cpp: patch does not apply

error: patch failed: src/game/Vehicle.h:26

error: src/game/Vehicle.h: patch does not apply

error: patch failed: src/game/WorldSession.h:429

error: src/game/WorldSession.h: patch does not apply

error: patch failed: src/shared/Database/SQLStorage.cpp:25

error: src/shared/Database/SQLStorage.cpp: patch does not apply

and for the vehicle_mangos_10346.patch I get

$ git apply vehicle_mangos_10346.patch

error: patch failed: src/shared/Database/SQLStorage.cpp:27

error: src/shared/Database/SQLStorage.cpp: patch does not apply

Any help would be greatly appreciated!

[ZPS]

can anyone confirm a few persistent issues with this patch?

1. grouping with a hunter / warlock / class with summoned 'pet' standing on a different map to the rest of the group causes client critical errors

2. server crashes - http://paste2.org/p/937668 (this may have been fixed)

they seem to be the 2 problems that need urgent attention... If someone with the knowledge can step in and show us noobs what to do and organise us towards a goal i may let them have my babies.

Patch against server crash:

----------------------------- src/game/Vehicle.cpp -----------------------------
index 3fc4aef..6e69ce2 100644
@@ -637,6 +637,9 @@ void Vehicle::Dismiss()

void Vehicle::RellocatePassengers(Map *map)
{
+    if (m_Seats.empty())
+        return;
+
    for(SeatMap::iterator itr = m_Seats.begin(); itr != m_Seats.end(); ++itr)
    {
        if(itr->second.flags & SEAT_FULL)

[Mr.Grom]

I am using mangos 10382

Tried to apply the patches given by Wojta, but got this error for the:

multiseats_mounts.patch

and for the vehicle_mangos_10346.patch I get

Any help would be greatly appreciated!

Applied first vehicle_mangos_10346.patch

[ankso]

1. grouping with a hunter / warlock / class with summoned 'pet' standing on a different map to the rest of the group causes client critical errors

Anyone stills having this issue?

P.D.: Thanks for crashfix ZPS