[not working] Outdoor Pvp

[w12x]

<div class='quotetop'>QUOTE (Xlayer @ Jul 31 2008, 10:01 PM) <{POST_SNAPBACK}></div>

Patch conflicting with rev 6405.[/b]

I beg to differ, I just updated my source to 6408 without conflict...

[gideon]

<div class='quotetop'>QUOTE (w12x @ Jul 31 2008, 04:38 PM) <{POST_SNAPBACK}></div>

I beg to differ, I just updated my source to 6408 without conflict...[/b]

agreed, 6408 no conflict.

[Tiretunderl]

IF the patch is ready, add it.

[Xlayer]

<div class='quotetop'>QUOTE </div>

I beg to differ, I just updated my source to 6408 without conflict...[/b]

<div class='quotetop'>QUOTE </div>

agreed, 6408 no conflict.[/b]

Strange, I tried re-downloading both the mangos and the patch source 3 times and still got conflicts. I'll try again with more recent revisions.

[riddick]

Updated version for Rev6419 here.

EDIT: Patch is only for Windows. There is a compile error on Linux which I can't fix.

[riddick]

Needs update. Just merging doesen't help anymore.

[gideon]

Updated:

outdoor_pvp_035-6440.patch

[Slink]

There seems to be a new problem with this patch. The structure of the DEV2 table seems to be different now.

Now if you throw bombs on Halaa the "bomb-creature" which normaly appears and attacks the guard dissappers immideatly.

The console gives you the following error: <div class='quotetop'>QUOTE </div>

SD2: Event 2586712 with InitialMax < InitialMin. Event disabled. Type = 1. CreatureEntry = 18225

SD2: Event 2586712 with InitialMax < InitialMin. Event disabled. Type = 1. CreatureEntry = 18225[/b]

[Mogale]

<div class='quotetop'>QUOTE (Slink @ Aug 9 2008, 09:55 PM) <{POST_SNAPBACK}></div>

There seems to be a new problem with this patch. The structure of the DEV2 table seems to be different now.

Now if you throw bombs on Halaa the "bomb-creature" which normaly appears and attacks the guard dissappers immideatly.

The console gives you the following error:[/b]

Yes there are many changes in rev555 But i think its easy to change

Patchupdate needed

[cejkaz]

<div class='quotetop'>QUOTE (gideon @ Aug 9 2008, 12:43 AM) <{POST_SNAPBACK}></div>

Updated:

outdoor_pvp_035-6440.patch[/b]

Tortoise SVN wrote this error: "An unknown line type was found in line 496 !" What is a problem? Thanks.

[Gandalf23]

this means you got to fix it on your own like iam trying to at the moment ^^

Today i am close to some really statisfying solutions .

[gideon]

outdoor_pvp_035-6452.patch

doesnt address any sql issues you may/may not have.

[Butch3r]

when compiling:

OutdoorPvPZM.cpp
..\\..\\src\\game\\OutdoorPvPZM.cpp(82) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(89) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(98) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(104) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(267) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(275) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(280) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(288) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments

w12x, if u have time plz update patch plz to last rev

or simple say: change GetMangosString to GetMangosStringForDBCLocale is correct way?

[w12x]

<div class='quotetop'>QUOTE (Butch3r @ Aug 12 2008, 11:16 AM) <{POST_SNAPBACK}></div>

when compiling:

OutdoorPvPZM.cpp
..\\..\\src\\game\\OutdoorPvPZM.cpp(82) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(89) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(98) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(104) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(267) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(275) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(280) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments
..\\..\\src\\game\\OutdoorPvPZM.cpp(288) : error C2660: 'ObjectMgr::GetMangosString' : function does not take 1 arguments

w12x, if u have time plz update patch plz to last rev

or simple say: change GetMangosString to GetMangosStringForDBCLocale is correct way?[/b]

iirc GetMangosString with one argument is now a member of WorldSession, so depending on the context, it's either GetSession()->GetMangosString() or player->GetSession()->GetmangosString().

[warrior]

Tha latest link bei Gideon has a 404. Is there an alternative link oder SVN access?

regards warrior

[Butch3r]

<div class='quotetop'>QUOTE (w12x @ Aug 12 2008, 06:59 PM) <{POST_SNAPBACK}></div>

iirc GetMangosString with one argument is now a member of WorldSession, so depending on the context, it's either GetSession()->GetMangosString() or player->GetSession()->GetmangosString().[/b]

ok, i try so, but i think its real reason to update patch

[cejkaz]

<div class='quotetop'>QUOTE (gideon @ Aug 12 2008, 04:05 AM) <{POST_SNAPBACK}></div>

outdoor_pvp_035-6452.patch

doesnt address any sql issues you may/may not have.[/b]

Where is it? The link is broken ...

[fearmasters]

<div class='quotetop'>QUOTE (cejkaz @ Aug 13 2008, 10:23 AM) <{POST_SNAPBACK}></div>

Where is it? The link is broken ...[/b]

Pls update!!

[durbatuluk]

I hope for update as well...

[fearmasters]

<div class='quotetop'>QUOTE (cejkaz @ Aug 13 2008, 09:23 AM) <{POST_SNAPBACK}></div>

Where is it? The link is broken ...[/b]

YEs please we need the update this is some cool stuff!!!

[domingo]

<div class='quotetop'>QUOTE (Butch3r @ Aug 12 2008, 11:16 AM) <{POST_SNAPBACK}></div>

or simple say: change GetMangosString to GetMangosStringForDBCLocale is correct way?[/b]

<div class='quotetop'>QUOTE (w12x @ Aug 12 2008, 01:59 PM) <{POST_SNAPBACK}></div>

iirc GetMangosString with one argument is now a member of WorldSession, so depending on the context, it's either GetSession()->GetMangosString() or player->GetSession()->GetmangosString().[/b]

<div class='quotetop'>QUOTE (Butch3r @ Aug 12 2008, 03:15 PM) <{POST_SNAPBACK}></div>

ok, i try so, but i think its real reason to update patch[/b]

Easy way (just search+replace): use GetMangosStringForDBCLocale() as replacement for GetMangosString(). It uses locale from DBC files on server side. Might cause problems when players use client with locale different from server locale.

Correct way: create replacement for sWorld.SendZoneText(X, GetMangosString(Y)) that would use GetSession()->GetMangosString() for every player separately (they can have different client locales). Use that replacement instead.

[domingo]

What about:

New public method in World.h:

void SendMangosString(uint32 strid, uint32 zone = 0, WorldSession *self = 0, uint32 team = 0);

Code in World.cpp:

/// Send a packet to all players (of selected team if team != 0) in the zone (world if zone == 0), except self (if self != NULL)
void World::SendMangosString(uint32 strid, uint32 zone, WorldSession *self, uint32 team)
{
       std::map<int, WorldPacket> packets;

       for (SessionMap::iterator itr = m_sessions.begin(); itr != m_sessions.end(); itr++)
       {
               if (itr->second &&
                       itr->second->GetPlayer() &&
                       itr->second->GetPlayer()->IsInWorld() &&
                       (zone == 0 || itr->second->GetPlayer()->GetZoneId() == zone) &&
                       itr->second != self &&
                       (team == 0 || itr->second->GetPlayer()->GetTeam() == team) )
               {
                       int locidx = itr->second->GetSessionDbLocaleIndex();
                       std::map<int, WorldPacket>::iterator ipkt = packets.find(locidx);
                       if (ipkt == packets.end())
                       {
                               ipkt = packets.insert(std::Pair<int, WorldPacket>(locidx, WorldPacket())).first;
                               ChatHandler::FillMessageData(&ipkt->second, NULL, CHAT_MSG_SYSTEM, LANG_UNIVERSAL,
                                       NULL, 0, objmgr.GetMangosString(strid, locidx), NULL);
                       }
                       itr->second->SendPacket(&ipkt->second);
               }
       }
}

And then replacing all

sWorld.SendZoneText(X,objmgr.GetMangosString(Y));

with

sWorld.SendMangosString(X, Y);

in OutdoorPvP*.cpp files ...

Will it help ? Compiles OK ... but I didn't checked if it works OK.

Patch link (for 6458): http://filebeam.com/3ec8b85ff189cfc42952ea06be7f04af

[Azureus]

Downloading and testing immediately. Hope it wont give errors when patching or compiling. Thx a lot for your work.

[Azureus]

.

[domingo]

<div class='quotetop'>QUOTE (Azureus @ Aug 14 2008, 03:25 PM) <{POST_SNAPBACK}></div>

Downloading and testing immediately. Hope it wont give errors when patching or compiling. Thx a lot for your work.[/b]

It should not, at least on WIN. What I wonder are crashes ... if you get text message for completing some opvp objective and server still works then it should be ok.