[not working] Outdoor Pvp

[Ramses]

great patch, thank you.

some things we noticed ( some cosmetics ):

- In Terrokar Forrest, after the last tower is taken, the second phase starts, and you can not flag this tower completly for your faction. (move the slide to the end of bar)

- In Nagrand, when a Guard is killed by a bomb (npc) the m_GuardsAlive counter does not decrease.

- In Zangamarsh multiple players can get a flag to return it to the graveyard. not sure about test conditions, but I think it happens when second player opens the menu before first player gets the flag.

about the Nagrand issue, how to differ between a TemporarySummon spawned by SpellEffectSummonWild and a usual unit?

If this is possible the addeption of outdoor pvp code in Unit.cpp (call to HandleKill) is easy, but I miss this simple link to the Summon.

[riddick]

I have some problems compiling the patch with newest rev -

<div class='quotetop'>QUOTE </div>

8>..\\..\\src\\game\\OutdoorPvP.cpp(106) : error C2660: 'Creature::Create' : function does not take 8 arguments

10>LINK : fatal error LNK1181: cannot open input file '.\\game__win32_release\\game.lib'

11>LINK : fatal error LNK1181: cannot open input file 'mangosd.lib'[/b]

[Infamousblob]

<div class='quotetop'>QUOTE (Riddick @ Jul 2 2008, 08:35 PM) <{POST_SNAPBACK}></div>

I have some problems compiling the patch with newest rev -[/b]

With rev 6218 I had the same Problem

Open OutdoorPVP.cpp Goto Line 106

Find if (!pCreature->Create(objmgr.GenerateLowGuid(HIGHGUID_UNIT), map, x, y, z, o, entry, teamval))

(according to the tooltip abotu the function x,y,z,o have been removed)

so change it to

if (!pCreature->Create(objmgr.GenerateLowGuid(HIGHGUID_UNIT), map, entry, teamval))

It compiles then, Though I haven't tested this yet

[w12x]

<div class='quotetop'>QUOTE (kizura @ Jul 1 2008, 02:58 PM) <{POST_SNAPBACK}></div>

yes I saw this, maybe I did not write clearly what I meant:

This part should be included into ScriptDev.[/b]

Well, that simple event_ai was just a quick solution to make the bomb work, it should probably be done in c++ instead in a less hacky way. But that's up to the 3rd party script libraries to decide

<div class='quotetop'>QUOTE </div>

Concerning the entries in mangos_string - this needs some internal talk, since

some of the words might be part of a trademark.[/b]

You're totally right, maybe something like northwest/south/etc tower would do the trick.

Also, thanks for the sql corrections, I include them in next version.

<div class='quotetop'>QUOTE (Ramses)</div>

- In Terrokar Forrest, after the last tower is taken, the second phase starts, and you can not flag this tower completly for your faction. (move the slide to the end of bar)

- In Nagrand, when a Guard is killed by a bomb (npc) the m_GuardsAlive counter does not decrease.

- In Zangamarsh multiple players can get a flag to return it to the graveyard. not sure about test conditions, but I think it happens when second player opens the menu before first player gets the flag.[/b]

Fixed.

First post updated.

changes:

- allow complete taking of the towers in tf

- rewrite halaa guard counting

- only 1 player can take the flag in zanga

- remove mangos. db specs from sql, add a delete query before the added gossip option, thanks to kizura

- a typo in the mangos sql

- for rev 6217

[domingo]

Nontrivial conflicts with 6218 in GameObject.cpp and SpellHandler.cpp ...

[w12x]

Great. Up for 6219.

[Ramses]

small issue:

when you die during a duell in Halaar (e.g. from mage's Ignite) he gets an honor mark.

(yes it's caused by another core bug, but anyway it's a really unwanted behavior)

not tested on the latest version, have to do an update next days

[christyan]

I tested:

mangos r6196 + SD2 r260 + WorldPvP + InstancedBG_arena + Anticheat + 2K tester

Result:

Work fine and no crash. This is great work.

+1 SVN

[w12x]

<div class='quotetop'>QUOTE (Ramses @ Jul 4 2008, 02:03 AM) <{POST_SNAPBACK}></div>

small issue:

when you die during a duel in Halaa (e.g. from mage's Ignite) he gets a honor mark.[/b]

Fixed, first post updated.

[Valdifer]

w12x One patch more? the version MaNGOS 6235 create conflicts

Grettings

PD: Sry my bad english

[charlie2025]

<div class='quotetop'>QUOTE (Valdifer @ Jul 5 2008, 04:33 PM) <{POST_SNAPBACK}></div>

w12x One patch more? the version MaNGOS 6235 create conflicts

Grettings

PD: Sry my bad english[/b]

try this

http://filebeam.com/1a93f79044490b899c9dbd6642606a67

[Finch]

<div class='quotetop'>QUOTE (charlie2025 @ Jul 6 2008, 08:45 PM) <{POST_SNAPBACK}></div>

try this

http://filebeam.com/1a93f79044490b899c9dbd6642606a67[/b]

many "No such file or directory" issues.

[Lord X-Press]

Yeah, course he forgot to implement all new files ^^

[w12x]

Updated for rev 6242. Btw the "conflict" was a no new line at end of file.

[johan71]

No one to share the information when this patch applied together with arena i has this crash between 2 to 4 hours running but not sure is was come from this two patch.

<div class='codetop'>CODE</div><div class='codemain' style='height:200px;white-space:Pre;overflow:auto'>

Revision: 6251

Date 10:7:2008. Time 16:34

//=====================================================

*** Hardware ***

Processor: Intel ® Xeon ® CPU 3060 @ 2.40GHz

Number Of Processors: 2

Physical Memory: 3666888 KB (Available: 2156776 KB)

Commit Charge Limit: 4194303 KB

*** Operation System ***

Microsoft Windows Server 2003 Enterprise Edition (Version 5.2, Build 3790)

//=====================================================

Exception code: C0000005 ACCESS_VIOLATION

Fault address: 004CE36D 01:000CD36D C:\\Mangos\\mangosd.exe

Registers:

EAX:201493A8

EBX:00000010

ECX:102B30E0

EDX:7FFE0304

ESI:222DEB30

EDI:11740EA8

CS:EIP:001B:004CE36D

SS:ESP:0023:03CBFC78 EBP:201493A8

DS:0023 ES:0023 FS:003B GS:0000

Flags:00010216

Call stack:

Address Frame Function SourceFile

004CE36D 00000000 Map::GetPlayersCountExceptGMs+3D

004D30A5 00000000 Map::AddInstanced+145

004C0570 00000000 Player::TeleportTo+460

00602CA3 00000000 BattleGroundMgr::SendToBattleGround+113

005D3C11 00000000 WorldSession::HandleBattleGroundPlayerPortOpcode+6B1

00509B31 00000000 stdext::_Hash<stdext::_Hmap_traits<unsigned short,OpcodeHandler,stdext::hash_compare<unsigned short,std::less<unsigned short> >,std::allocator<std::Pair<unsigned short const ,OpcodeHandler> >,0> >::lower_bound+21

0050FCA6 00000000 WorldSession::Update+E6

004F34E0 00000000 World::UpdateSessions+130

004FE841 00000000 World::Update+361

00429A99 00000000 WorldRunnable::run+59

006C74A5 00000000 ZThread::ThreadImpl::Dispatch+195

006C78A2 00000000 ZThread::`anonymous namespace'::Launcher::run+32

006C8ACB 00000000 ZThread::ThreadOps::_dispatch+B

006F86EB 00000000 _callthreadstartex+1B

006F8790 00000000 _threadstartex+7F

77E4A990 00000000 FlsSetValue+779

========================

Local Variables And Parameters

Call stack:

Address Frame Function SourceFile

004CE36D 00000000 Map::GetPlayersCountExceptGMs+3D

004D30A5 00000000 Map::AddInstanced+145

Local <user defined> 'player'

Local <user defined> 'guard'

004C0570 00000000 Player::TeleportTo+460

punting on symbol mapid

punting on symbol x

punting on symbol y

punting on symbol z

punting on symbol orientation

punting on symbol outofrange

punting on symbol ignore_transport

punting on symbol is_gm_command

Local <user defined> 'mEntry'

Local <user defined> 'data'

punting on symbol final_y

Local <user defined> 'data'

punting on symbol final_o

punting on symbol final_z

punting on symbol final_x

00602CA3 00000000 BattleGroundMgr::SendToBattleGround+113

Local <user defined> 'pl'

punting on symbol instanceId

punting on symbol team

punting on symbol O

punting on symbol z

punting on symbol mapid

punting on symbol x

punting on symbol y

005D3C11 00000000 WorldSession::HandleBattleGroundPlayerPortOpcode+6B1

Local <user defined> 'recv_data'

punting on symbol bgTypeId

punting on symbol instanceId

Local <user defined> 'itrPlayerStatus'

punting on symbol bgQueueTypeId

punting on symbol i

Local <user defined> 'data'

Local <user defined> 'itrPlayerStatus'

punting on symbol israted

punting on symbol queueSlot

punting on symbol team

Local <user defined> 'data'

punting on symbol rating

Local <user defined> 'pitr'

punting on symbol arenatype

punting on symbol israted

00509B31 00000000 stdext::_Hash<stdext::_Hmap_traits<unsigned short,OpcodeHandler,stdext::hash_compare<unsigned short,std::less<unsigned short> >,std::allocator<std::Pair<unsigned short const ,OpcodeHandler> >,0> >::lower_bound+21

Local <user defined> '_Keyval'

Local <user defined> '_Where'

0050FCA6 00000000 WorldSession::Update+E6

punting on symbol __formal

004F34E0 00000000 World::UpdateSessions+130

punting on symbol diff

Local <user defined> 'itr'

Local <user defined> 'next'

004FE841 00000000 World::Update+361

punting on symbol diff

Local <user defined> 'AuctionMap'

punting on symbol i

Local <user defined> 'next'

Local <user defined> 'next'

punting on symbol maxClientsNum

00429A99 00000000 WorldRunnable::run+59

006C74A5 00000000 ZThread::ThreadImpl::Dispatch+195

Local <user defined> 'parent'

Local <user defined> 'impl'

Local <user defined> 'task'

Local <user defined> 'i'

Local <user defined> 'g'

Local <user defined> 'i'

006C78A2 00000000 ZThread::`anonymous namespace'::Launcher::run+32

006C8ACB 00000000 ZThread::ThreadOps::_dispatch+B

punting on symbol arg

006F86EB 00000000 _callthreadstartex+1B

006F8790 00000000 _threadstartex+7F

punting on symbol ptd

77E4A990 00000000 FlsSetValue+779

========================

Global Variables

</div>

[anjoamante]

This patch have any SVN address to download?

The last patch released have conflict with arena and auction house bots when i try to compile.

Any solution? New versions??

Thanks.

[jorooo]

This patch is not made to work with other patches. It's for clean MaNGOS Installation.

[johan71]

<div class='quotetop'>QUOTE </div>

w12x FAQ:

Q: Is it compatible with <insert something here, totally up to your imagination>?

A: I have no idea... err.. sure it is! You might have to make some manual modifications though...[/b]

This should clarified this

<div class='quotetop'>QUOTE </div>

This patch is not made to work with other patches. It's for clean MaNGOS Installation.[/b]

[domingo]

<div class='quotetop'>QUOTE (yiuu @ Jul 14 2008, 03:03 AM) <{POST_SNAPBACK}></div>

<div class='quotetop'>QUOTE

This patch is not made to work with other patches. It's for clean MaNGOS Installation.[/b]

[/b]

While it was made to be alone, it merges and works nicely with several bigger patches (arena, procflag) and numerous small ones ...

OP just meant: if you want to use it with another patch, it's your problem to make it compatible ...

[Lord X-Press]

Tested with Arena and Procflags patch, works fine....20h Uptime.

one question,after flagging a point,should there spawn any NPC's of youre fraction?

[Dark21]

Works just fine , +1 for SVN

[Sephiroth1983]

Yes this patch looks ready for review at this point

[Darkpeninsula]

Tested with 300 clients , works fine ,24+ h Uptime , no crash , no strange error.

I think ready for svn

Thanks for your time w12x

[jorooo]

Kizura was talking about some copyrighted stuff. Is that the reason for not adding this in SVN? If not please, devs, let us know what the reason is.

Regards

[anjoamante]

I think this is reason:

"This patch is not made to work with other patches. It's for clean MaNGOS Installation."

Maybe patch in SVN causes trouble with other patches aplied on MaNGOS SVN.

The patch is very good, i'm waiting for a solution e go to SNV