Vehicles (Dev)

[sart13]

I have diasbled mmaps on bosses with a small modification. Also you can disable mmaps in specific maps.

If the code requires a special exception, then it is not working properly.

[ankso]

The second option does not require code modifications, is in server's config files. Or you can just delete the mmap files of that map.

[ichijinkn]

You guys considered adding this to the 'under review' section to go into the core? I have been viewing the progress on this for a LONG time now. Seems it would be a nice asset to the core. I realize there is still a few things to work out, but once its in the core, more people will probably be involved in the dev for this project. Keep up the good work guys!

[mrelfire]

usually I try to do a kind of merge between "pastebin" source files, michalpolko and przemratajczak redepository

but now I am stuck I do not manage to make running a clean vehicles file, so I requesting some help for a latest patch please ?

[Pyrarrows]

Is there any chance of this being updated in the near future?

It seems to be broken...

[Unkle Nuke]

You have no idea, Pyrarrows.

This implementation of Vehicles has a long, twisted, and messy history. I'm amazed it works as well as it does.

What's needed is a fresh rewrite, using what is now known about opcodes and also fixing missing features in the core that's needed for Vehicles to work correctly.

I do know that, in 4.0.6., some multi-seat vehicles are treated as minions when piloted by an NPC. The same may hold true for 3.3.5a.

[mrelfire]

This implementation of Vehicles has a long, twisted, and messy history. I'm amazed it works as well as it does.

What's needed is a fresh rewrite, using what is now known about opcodes and also fixing missing features in the core that's needed for Vehicles to work correctly.

A lot of people are working on it, isn't it ? unfortunately perhaps alone on his side, perhaps we need a leader ? a "mangos developer" could take the lead ?

[Pyrarrows]

I'd love to see this get updated again... too bad I don't know any C++, or else I probably would take some time to fix it...

[Darkknight900]

scanned your patch and found also GO Type 33, rewritten combopoint access mostly caused by the pet rewrite i think, and also some not needed parts at Spell::CheckTarget and Spell::CheckPetCast.

But with this patch you will surely get the vehicles working.

[ifilgud]

Hi! I've tested the patch with revision 11392 and it doesn't apply. In many files it asks for "Reversed (or previously applied) patch detected! Assume -R? [n]" and many other hunks just fails. I saw some changes in "git log" about static vehicle spawns, but I don't know if it is related to this patch (I think it isn't).

If you want, I can paste the result of a --dry-run patching.

[plumkis]

hello everybody

is that there will have a new patch

for vehicles that will be functional

with the latest version of mangos

and that can spawner

[traponinet]

Here it is fresh from the repository of Rsa, but with small changes (in Pet's part).

(Rsa still developing a vehicles until Zergtmn finish them, I hope soon.)

the rest of the vehicles patch for mangos [11425]:

http://filebeam.com/d83d794c49a8e48f475d75a2b03d580e

(contains some hacks)

[plumkis]

you set contains a hack

what kind of hack

[traponinet]

do not worry, not so dirty hacks, as this: in Vehicle.cpp

m_pBase->setFaction(passenger->getFaction());

[plumkis]

thank you for the information

[plumkis]

is what you would have the vehicle mangos sql file

works with the right id of vehicle

[traponinet]

many of vehicle_id are inaccurate, but you can replace vehicle_id

from a similar creature(vehicle) where seating is properly when you ride it.

[plumkis]

hello there is there a new patch updated

[tyrael]

is anyone working for a patch for repo? cause if u have a patch ready for repo, pls pot it for review!

Respect,

Axel

[Wojta]

Hi, long time no see

Is there any vehicle repo or patch present? And what about some improvements, I can see this thread has grown since I looked last time. I will at least update first post with new informations

[michalpolko]

I think the most developed vehicles implementation is in mangosR2 (link in my signature) but I may be wrong ;P But there is no pure vehicle patch branch afaik...

[Xfurry]

But there is no pure vehicle patch branch afaik...

That is the real problem why this patch isn't progressing. Someone who likes vehicles very much should make a distinct branch only with vehicles implementation and keep it up to date.

[Darkknight900]

currently working on one on http://www.github.com/Darkknight900/mangos/tree/vehicle

got first apply of cleaned trapionet patch, currently first diff scratching between original mangos and mangosr2 already saw that there is now a Spell-seat-system and also a better way handling the faction (just a short thing) so i need to do it another time since i ignored related changes to some files

I would appreciate any help so if anyone can pm me the changes (commits) to the vehicle system and related since mangosr2 was created if someone got an overview on this it would be great this would help me a lot getting the latest changes exactly...

btw. branch is not compilable at all since its just a diffing here, got no compiler on my vacation netbook

[plumkis]

Hello I tried to compile your core

but it makes me full of errors

[Darkknight900]

btw. branch is not compilable at all since its just a diffing here, got no compiler on my vacation netbook

yeah already told you that you couldn't compile it at all