Jump to content

[patch] Distract & Stealth


Auntie Mangos

Recommended Posts

What bug does the patch fix? What features does the patch add?

Fixes the poblem that distract removes stealth from distracted and stealthed targets (rogues, druids).

Fixes the poblem that Mass Dispel removes stealth from stealthed targets (rogues, druids).

For which SubVersion revision was the patch created?

146ab472b6ae20e84c03f3782969f43156d5857b

Is there a thread in the bug report section? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=3358&highlight=distract

patch: http://paste2.org/p/105085

Link to comment
Share on other sites

  • 38 years later...
I dont'thik so. Earthbind totem applies debuff as well and should NOT remove stealth

Earthbind totem DOESN'T apply the debuff on stealthed targets, And it's not _one_ debuff that remove sealth, Piercing howl does remove stealth to, Physical scream (fear effect) and it's a debuff that removes stealth.

Edit : Forget about distract, Stuff mixed up with me, it came to my mind the Distract "Effects" (Blind-like) Which if applied to a stealthed target it will certainly get him out of it.

Link to comment
Share on other sites

Earthbind totem DOESN'T apply the debuff on stealthed targets, And it's not _one_ debuff that remove sealth, Piercing howl does remove stealth to, Physical scream (fear effect) and it's a debuff that removes stealth.

Edit : Forget about distract, Stuff mixed up with me, it came to my mind the Distract "Effects" (Blind-like) Which if applied to a stealthed target it will certainly get him out of it.

earthbind totem does apply it to stealthed players, if you read the patchnotes carefully you will see a change where it says that the totem still applies its effect but will not break stealth anymore!

Link to comment
Share on other sites

not realy sure about mass displee

From 2.2.0 release notes:

Mass Dispel: The portion of this spell that removes immunity effects (Blessing of Protection, Ice Block, etc.), now has a chance to be resisted, and will display correctly to the combat log. It will no longer cause Rogues and Druids in Cat Form to lose stealth.
Link to comment
Share on other sites

Anyway, this is a really unique case. I don't reallly see any other way to check this than using spell ids what is 'hacky' as i was told. There would be another way, using AddUnitState(UNIT_STAT_DISTRACTED) but when i ask for HasUnitState(UNIT_STAT_DISTRACTED) it returns false, what's really strange again :)

Link to comment
Share on other sites

Anyway, this is a really unique case. I don't reallly see any other way to check this than using spell ids what is 'hacky' as i was told. There would be another way, using AddUnitState(UNIT_STAT_DISTRACTED) but when i ask for HasUnitState(UNIT_STAT_DISTRACTED) it returns false, what's really strange again :)

Most likely an array of spell ids will do, I think they use the same system because the changelog notes are specific. Same is for Earthbind totem pulses.

Link to comment
Share on other sites

  • 2 weeks later...

Patch 1.2 (12/18/04): 15 second cooldown added to the ability.

Patch 2.2.0 (9/25/07): Earthbind Totem no longer breaks stealth.

Patch 2.3 (11/13/07): Earthbind Totem now breaks stealth on all pulses, not just the first one.

so yeah it should break stealth.

Link to comment
Share on other sites

In 2.3.0

Shaman
-  Chain Heal: The tooltips on ranks 1-3 have been adjusted.
-  Chain Lightning cast time reduced to 2.0 (from 2.5), mana costs 
  reduced, benefit from spell damage reduced appropriately. 
-  Cure Poison and Cure Disease range increased to 40 yards.
-  Earth Shield: This spell will now always be removed correctly if 
  multiple Shaman overwrite each other's Earth Shield.
-  Earth Shield: This ability will no longer be overwritten when the new
  Earth Shield would do less healing.
-  Earth Shock: Interrupting a channeled spell with this spell will now
  always properly prevent casting spells from the same spell school 
  for 2 sec.
-  Elemental Focus (Elemental) now reduces the mana cost of the next 2 
  damage spells by 40%. 
-  Elemental Mastery: It is no longer possible to get two consecutive 
  guaranteed critical strikes from using this ability.
-  Eye of the Storm: This talent can now trigger while the Shaman is 
  sitting.
-  Frost Shock is no longer subject to diminishing returns. 
-  Grounding Totem: This totem is now destroyed upon redirecting any 
  spell to itself. 
-  Lightning Bolt cast time reduced to 2.5 (from 3.0 where applicable),
  mana costs reduced, benefit from spell damage reduced appropriately. 
-  Lightning Mastery (Elemental) cast time reduction reduced to 
  .1/.2/.3/.4/.5 seconds. 
-  Lightning Overload (Elemental) now has a 4/8/12/16/20% chance to 
  occur and the additional spell causes half damage and no additional 
  threat. 
-  Mana Spring Totem effect increased. 
-  Mental Quickness (Enhancement) now also increases spell damage and
  healing equal to 10/20/30% of your attack power.
-  Two-Handed Axes and Two-Handed Maces are now trainable by all Shaman 
  at the appropriate weapon masters. The Enhancement talent has been 
  replaced by Shamanistic Focus. 
-  Shamanistic Focus (New Enhancement Talent): After landing a melee 
  critical strike, you enter a Focused state. The Focused state reduces
  the mana cost of your next Shock spell by 60%. 
-  Shamanistic Rage (Enhancement) now also reduces all damage taken by 
  30% for the duration. 
-  Spirit Weapons (Enhancement) threat reduction increased to 30% from 
  15%.
-  Rockbiter Weapon: For ranks 4, 5, 6, 7, and 8 the increased damage 
  resulting from this enchantment has been reduced slightly to match 
  the intended numbers given in the tooltip. Ranks 1, 2, 3, and 9 are 
  unchanged. 
-  Water Shield: This spell no longer costs any mana to cast and its 
  duration has been shortened. At the end of its duration, it now 
  grants mana for any remaining globes. In addition, the mana granted 
  per globe has been substantially increased. 
-  Windfury Weapon: This enchantment can no longer be triggered while 
  you are disarmed.

and nothing about Earthbind Totem.

Link to comment
Share on other sites

  • 2 weeks later...
  • 4 weeks later...
  • 1 month later...

Well, long forgotten, my first patch :)

Probably this solution will be better. It should solve both earthbind totem and distract problems without sideeffects.

Patch was created for revision 7475

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index 712f976..908a6ed 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -1100,7 +1100,8 @@ void Spell::DoSpellHitOnUnit(Unit *unit, const uint32 effectMask)
                return;
            }

-            unit->RemoveSpellsCausingAura(SPELL_AURA_MOD_STEALTH);
+            if(m_spellInfo->Effect[0] != SPELL_EFFECT_DISTRACT && m_spellInfo->SpellIconID != 686)
+                unit->RemoveSpellsCausingAura(SPELL_AURA_MOD_STEALTH);

            if( !(m_spellInfo->AttributesEx & SPELL_ATTR_EX_NO_INITIAL_AGGRO) )
            { 

Patchfile

Link to comment
Share on other sites

  • 3 weeks later...
  • 3 months later...

Well, while searching for a solution for the Hand of Salvation problem i found the general solution fot this spell...

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index b8c0f80..e9b4218 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -1190,7 +1190,8 @@ void Spell::DoSpellHitOnUnit(Unit *unit, const uint32 effectMask)
                return;
            }

-            unit->RemoveSpellsCausingAura(SPELL_AURA_MOD_STEALTH);
+            if(!isSpellBreakStealth(m_spellinfo))
+                unit->RemoveSpellsCausingAura(SPELL_AURA_MOD_STEALTH);

            if (!(m_spellInfo->AttributesEx & SPELL_ATTR_EX_NO_INITIAL_AGGRO))
            {

Patchfile

Link to comment
Share on other sites

Well, while searching for a solution for the Hand of Salvation problem i found the general solution fot this spell...

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index b8c0f80..e9b4218 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -1190,7 +1190,8 @@ void Spell::DoSpellHitOnUnit(Unit *unit, const uint32 effectMask)
                return;
            }

-            unit->RemoveSpellsCausingAura(SPELL_AURA_MOD_STEALTH);
+            if(!isSpellBreakStealth(m_spellinfo))
+                unit->RemoveSpellsCausingAura(SPELL_AURA_MOD_STEALTH);

            if (!(m_spellInfo->AttributesEx & SPELL_ATTR_EX_NO_INITIAL_AGGRO))
            {

Patchfile

Oo thx, working perfectly^_^ devs pls add :)

Link to comment
Share on other sites

It is working how it is but, but only because of another bug... so nvm...

Confirmed, in http://github.com/mangos/mangos/commit/10e1fc9fe4b3ab4b5236edee2a94a01cba248819 this was fixed.

HOWEVER, Mass Dispell is still breaking stealth. Could you modify your patch and submit a patch for that? The devs might over look this thread since one of the problems has been resolved. Thanks.

Link to comment
Share on other sites

  • 3 weeks later...
HOWEVER, Mass Dispell is still breaking stealth. Could you modify your patch and submit a patch for that? The devs might over look this thread since one of the problems has been resolved. Thanks.

Indeed, so does Earthbind Totem which is just like Mass Dispell not supposed to remove stealth anymore since patch 2.2.0

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use